From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4516CC761A6 for ; Tue, 4 Apr 2023 17:44:21 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 8D88A37107 for ; Tue, 4 Apr 2023 17:44:20 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 844C09865B3 for ; Tue, 4 Apr 2023 17:44:20 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 79994986583; Tue, 4 Apr 2023 17:44:20 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 69AD898658F for ; Tue, 4 Apr 2023 17:44:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: kqtwmqIAOxK3uaCA8VVPoA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680630252; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E3uM9p2xm7VYz2MAT8WoBk0TG8BbNy80LCEN/cIoegc=; b=BLklkpaNbbtTZFimmSednR3B5ox57w0llcy8Vksli2PkAkyuWUvetvhSypyCBbwnus 0d6d9Nng9onAxcfoMLAMmkesvMCJfeUqCaGDhy6ZvKZqZ73G/9u6euxGA3JWJpGAFlaU NzEZ28+GvuZN37MFwbLwvGBX/7UiZOgl3kNmtjWP0WsMrHTVyxpiP1EsyPwL09E4t8Q2 00qHuIHDXvUFg9nm/Lzq3MuN7cHmiMmG6udBiw377QN9DPD6ZIREjdTYPpImOSPdDXFn q/PtBRPDnRsltsBlV6yW0B+uPibf7CtIx5I+eG9Z1hLIt60/Ft3Z2pLmDYiCv9yWSp5K 6ZQA== X-Gm-Message-State: AAQBX9fWAR2Z9ytOM96DhvzC/rWImc3x4EBa5KM880KSW802tbfv9y81 v/AUDUWKGg91HKUrhMtT7Y0CgPjUkm9Gan2atoFInmJIXIw1ZZNQeSiAZTne3lSpYCP18uXjkhV UwEtzNsrFdXqq6uHC5p/KdVt8fNdAFOJ5ng== X-Received: by 2002:a17:906:95c1:b0:8f6:dc49:337f with SMTP id n1-20020a17090695c100b008f6dc49337fmr316682ejy.43.1680630252212; Tue, 04 Apr 2023 10:44:12 -0700 (PDT) X-Google-Smtp-Source: AKy350aec3RiJATfXW3tZ2++sgLAWk8SF0PLNW2BfL64w9KuKfzfger5blsXbDo1LFvGVb49gtMzaA== X-Received: by 2002:a17:906:95c1:b0:8f6:dc49:337f with SMTP id n1-20020a17090695c100b008f6dc49337fmr316659ejy.43.1680630251893; Tue, 04 Apr 2023 10:44:11 -0700 (PDT) Date: Tue, 4 Apr 2023 13:44:07 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Halil Pasic , Heng Qi , "virtio-dev@lists.oasis-open.org" , "virtio-comment@lists.oasis-open.org" , Cornelia Huck , Alvaro Karsz , David Edmondson , Jason Wang , Xuan Zhuo Message-ID: <20230404134141-mutt-send-email-mst@kernel.org> References: <20230323152422.113103-1-hengqi@linux.alibaba.com> <20230404182925.349d402e.pasic@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-comment] Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation On Tue, Apr 04, 2023 at 04:32:07PM +0000, Parav Pandit wrote: > > > From: Halil Pasic > > Sent: Tuesday, April 4, 2023 12:29 PM > > > > On Thu, 23 Mar 2023 23:24:22 +0800 > > Heng Qi wrote: > > > > > +struct virtio_net_ctrl_coal_vq { > > > + le16 vqn; > > > + le16 reserved; > > > + struct virtio_net_ctrl_coal coal; }; > > > + > > > #define VIRTIO_NET_CTRL_NOTF_COAL 6 > > > #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0 > > > #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1 > > > + #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2 #define > > > + VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3 > > > \end{lstlisting} > > > > > > Coalescing parameters: > > > \begin{itemize} > > > +\item \field{vqn}: The virtqueue number of an enabled transmit or receive > > virtqueue. > > > > Just to be on the safe side: VIRTIO_F_NOTIF_CONFIG_DATA has been > > negotiated, and queue_select != queue_notify_data, is vqn supposed to contain > > queue_notify_data or the number/index that is used for queue_select (I'm > > talking about the PCI transport case)? > Vqn has zero relation to notification config data feature and featue bit. > It is the real vqn enabled via queue_select. > > Once the vqn is renamed to vq_notify_id, we won't have this confusion anymore. vqn here is the index. queue_select is also the index. Inside notifications-le.c we have: le32 { vqn : 16; next_off : 15; next_wrap : 1; }; vqn here is queue_notify_data. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D897C761A6 for ; Tue, 4 Apr 2023 17:44:16 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 89DAC2ACAD for ; Tue, 4 Apr 2023 17:44:15 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 6BC70986593 for ; Tue, 4 Apr 2023 17:44:15 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 56C40986524; Tue, 4 Apr 2023 17:44:15 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 43886986583 for ; Tue, 4 Apr 2023 17:44:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: aTthMBVhOICnTuNrkyLbBA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680630252; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E3uM9p2xm7VYz2MAT8WoBk0TG8BbNy80LCEN/cIoegc=; b=VOIQZOy0QWVsY7gY3YlUbjBCNeFCk0wGc8D7BVklzYhIs+IJ5wj9Jhq65KaLF8wNn6 mWviqfIhHtkAv602D6D3tuMFDZCe2UfEqt3u3+0omXx22AYX4GE1iVfARt8Aolg+a29S rBZm4jmDsRsZiWQ/NOgkOs1eepz1wMzzx3pW9Cbw23H9wk/ijmiEeGEw7HLPLnhrv/rL FG3Cx6J27fKHeJG7drhVU/viIuAoeGAkuV5WYOlEHajc8o954KO1hoV/QX5sQgxDeMxj d7KIo4UHZC22uZ6aWnoiTlRLapqFSHlXG/Id1ljAFKJAlKwQbxEBe2PtTHc5Lwq96oEn RZfA== X-Gm-Message-State: AAQBX9d962fbyWQvYgkIMHda7sgoq2oqlucEqL76GGE6bkLyEA675SM5 AHp+AnOI8xvmL/Q0+DqFQ3ASbIPmHUhuw84NlmUY7WF5pBt8qip1NcDczjLYjGRgRO5aEBNboPv 8OwGj1syJz7/AlxKBAF8ls+vOsQGl X-Received: by 2002:a17:906:95c1:b0:8f6:dc49:337f with SMTP id n1-20020a17090695c100b008f6dc49337fmr316676ejy.43.1680630252210; Tue, 04 Apr 2023 10:44:12 -0700 (PDT) X-Google-Smtp-Source: AKy350aec3RiJATfXW3tZ2++sgLAWk8SF0PLNW2BfL64w9KuKfzfger5blsXbDo1LFvGVb49gtMzaA== X-Received: by 2002:a17:906:95c1:b0:8f6:dc49:337f with SMTP id n1-20020a17090695c100b008f6dc49337fmr316659ejy.43.1680630251893; Tue, 04 Apr 2023 10:44:11 -0700 (PDT) Date: Tue, 4 Apr 2023 13:44:07 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Halil Pasic , Heng Qi , "virtio-dev@lists.oasis-open.org" , "virtio-comment@lists.oasis-open.org" , Cornelia Huck , Alvaro Karsz , David Edmondson , Jason Wang , Xuan Zhuo Message-ID: <20230404134141-mutt-send-email-mst@kernel.org> References: <20230323152422.113103-1-hengqi@linux.alibaba.com> <20230404182925.349d402e.pasic@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation On Tue, Apr 04, 2023 at 04:32:07PM +0000, Parav Pandit wrote: > > > From: Halil Pasic > > Sent: Tuesday, April 4, 2023 12:29 PM > > > > On Thu, 23 Mar 2023 23:24:22 +0800 > > Heng Qi wrote: > > > > > +struct virtio_net_ctrl_coal_vq { > > > + le16 vqn; > > > + le16 reserved; > > > + struct virtio_net_ctrl_coal coal; }; > > > + > > > #define VIRTIO_NET_CTRL_NOTF_COAL 6 > > > #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0 > > > #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1 > > > + #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2 #define > > > + VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3 > > > \end{lstlisting} > > > > > > Coalescing parameters: > > > \begin{itemize} > > > +\item \field{vqn}: The virtqueue number of an enabled transmit or receive > > virtqueue. > > > > Just to be on the safe side: VIRTIO_F_NOTIF_CONFIG_DATA has been > > negotiated, and queue_select != queue_notify_data, is vqn supposed to contain > > queue_notify_data or the number/index that is used for queue_select (I'm > > talking about the PCI transport case)? > Vqn has zero relation to notification config data feature and featue bit. > It is the real vqn enabled via queue_select. > > Once the vqn is renamed to vq_notify_id, we won't have this confusion anymore. vqn here is the index. queue_select is also the index. Inside notifications-le.c we have: le32 { vqn : 16; next_off : 15; next_wrap : 1; }; vqn here is queue_notify_data. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org