Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks

From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Eddie Hung <eddie.hung@mediatek.com>,
	Tianping Fang <tianping.fang@mediatek.com>
Subject: Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks
Date: Tue, 4 Apr 2023 08:43:50 -0500	[thread overview]
Message-ID: <20230404134350.GA3782583-robh@kernel.org> (raw)
In-Reply-To: <20230403025230.25035-6-chunfeng.yun@mediatek.com>

On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> Add optional clock 'xhci_ck' and 'frmcnt_ck';
> Add optional property "assigned-clock" and "assigned-clock-parents";
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  .../devicetree/bindings/usb/mediatek,mtu3.yaml       | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index d2655173e108..50c15f2ce14d 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -66,6 +66,8 @@ properties:
>        - description: Reference clock used by low power mode etc
>        - description: Mcu bus clock for register access
>        - description: DMA bus clock for data transfer
> +      - description: DRD controller clock
> +      - description: Frame count clock
>  
>    clock-names:
>      minItems: 1
> @@ -74,6 +76,16 @@ properties:
>        - const: ref_ck
>        - const: mcu_ck
>        - const: dma_ck
> +      - const: xhci_ck
> +      - const: frmcnt_ck
> +
> +  assigned-clocks:
> +    minItems: 1
> +    maxItems: 6
> +
> +  assigned-clock-parents:
> +    minItems: 1
> +    maxItems: 6

You don't need to include assigned-clocks properties. They are 
implicitly allowed (when clocks is present).

Rob