From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Peng Fan <peng.fan@nxp.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] dt-bindings: input: pwm-beeper: convert to dt schema
Date: Tue, 4 Apr 2023 08:51:21 -0500 [thread overview]
Message-ID: <20230404135121.GA3787069-robh@kernel.org> (raw)
In-Reply-To: <9422ab57-8512-0177-76fa-76347626f941@linaro.org>
On Tue, Apr 04, 2023 at 10:17:45AM +0200, Krzysztof Kozlowski wrote:
> On 04/04/2023 08:44, Peng Fan wrote:
>
>
> >>
> >>> +
> >>> + beeper-hz:
> >>> + description: bell frequency in Hz
> >>> + minimum: 1
> >>> + maximum: 4
> >>
> >> default is 1000, so how constraints can be lower than default? Also - missing
> >> default.
> > [Peng Fan]
> > I am not sure what maximum value should be set. Previously I set 256, Rob
> > questioned it.
>
> Yep, because 256 is power of 2, so really does not look correct. It is
> still lower than default, right?
It's Hertz and an audible (to humans) range! At most that's 60 -
10000Hz. I imagine any beeper h/w is capable of much narrower range than
that, but don't know what's typical.
Rob
prev parent reply other threads:[~2023-04-04 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 9:06 [PATCH V2] dt-bindings: input: pwm-beeper: convert to dt schema Peng Fan (OSS)
2023-04-03 13:10 ` Rob Herring
2023-04-04 5:59 ` Krzysztof Kozlowski
2023-04-04 6:44 ` Peng Fan
2023-04-04 8:17 ` Krzysztof Kozlowski
2023-04-04 13:51 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404135121.GA3787069-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.