From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: edward.cree@amd.com, linux-net-drivers@amd.com,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, habetsm.xilinx@gmail.com,
sudheer.mogilappagari@intel.com
Subject: Re: [RFC PATCH net-next 5/6] net: ethtool: add a mutex protecting RSS contexts
Date: Tue, 4 Apr 2023 16:46:08 -0700 [thread overview]
Message-ID: <20230404164608.5489fb1b@kernel.org> (raw)
In-Reply-To: <9536914b-0254-23e4-de6d-a936a50129b0@gmail.com>
On Tue, 4 Apr 2023 13:32:04 +0100 Edward Cree wrote:
> > Argh, the mutex doubles the size of the state, and most drivers don't
> > implement this feature. My thinking was to add a "ethtool state">
> > pointer to net_device which will be allocated by ethtool on demand
> > and can hold all ethtool related state.
>
> Would any other existing net_device fields go in this struct, or is
> it just the RSS stuff so far?
Only wol_enabled possibly, nothing else looks relevant.
But wol_enabled is one bit so up to you if you want to move it.
next prev parent reply other threads:[~2023-04-04 23:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 16:32 [RFC PATCH net-next 0/6] ethtool: track custom RSS contexts in the core edward.cree
2023-04-03 16:32 ` [RFC PATCH net-next 1/6] net: ethtool: attach an IDR of custom RSS contexts to a netdevice edward.cree
2023-04-03 21:43 ` Jakub Kicinski
2023-04-04 11:30 ` Edward Cree
2023-04-04 23:36 ` Jakub Kicinski
2023-04-03 16:32 ` [RFC PATCH net-next 2/6] net: ethtool: record custom RSS contexts in the IDR edward.cree
2023-04-03 21:48 ` Jakub Kicinski
2023-04-04 11:49 ` Edward Cree
2023-04-04 23:40 ` Jakub Kicinski
2023-04-05 9:34 ` Edward Cree
2023-04-06 9:07 ` Dan Carpenter
2023-04-06 15:45 ` Edward Cree
2023-04-03 16:33 ` [RFC PATCH net-next 3/6] net: ethtool: let the core choose RSS context IDs edward.cree
2023-04-03 21:54 ` Jakub Kicinski
2023-04-04 12:14 ` Edward Cree
2023-04-04 23:42 ` Jakub Kicinski
2023-04-03 16:33 ` [RFC PATCH net-next 4/6] net: ethtool: pass ctx_priv and create into .set_rxfh_context edward.cree
2023-04-11 19:45 ` kernel test robot
2023-04-03 16:33 ` [RFC PATCH net-next 5/6] net: ethtool: add a mutex protecting RSS contexts edward.cree
2023-04-03 22:03 ` Jakub Kicinski
2023-04-04 12:32 ` Edward Cree
2023-04-04 23:46 ` Jakub Kicinski [this message]
2023-04-03 16:33 ` [RFC PATCH net-next 6/6] sfc: use new .set_rxfh_context API edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404164608.5489fb1b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.