All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: jgg@nvidia.com, zyjzyj2000@gmail.com, leon@kernel.org,
	jhack@hpe.com, linux-rdma@vger.kernel.org
Cc: Bob Pearson <rpearsonhpe@gmail.com>
Subject: [PATCH for-next 0/5] RDMA/rxe: Protect QP state with qp->state_lock
Date: Tue,  4 Apr 2023 23:24:21 -0500	[thread overview]
Message-ID: <20230405042425.6429-1-rpearsonhpe@gmail.com> (raw)

This patch series makes qp state chages atomic between the various
applicationa and IO threads. The rxe driver currently is very unsafe
as qp state changes made by application threads e.g. ib_modify_qp()
which changes the qp state are not protected against stale reads by
IO threads. This patch series cleans up qp state by reducing the
redundant state variables (qp->req.state, etc.) and then locking
code fragments that access or change the remaining qp state variables.

Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>

Bob Pearson (5):
  RDMA/rxe: Remove qp->resp.state
  RDMA/rxe: Remove qp->comp.state
  RDMA/rxe: Remove qp->req.state
  RDMA/rxe: Move code to check if drained to subroutine
  RDMA/rxe: Protect QP state with qp->state_lock

 drivers/infiniband/sw/rxe/rxe_comp.c  |  94 +++++-----
 drivers/infiniband/sw/rxe/rxe_net.c   |   7 +-
 drivers/infiniband/sw/rxe/rxe_qp.c    | 188 +++++++++-----------
 drivers/infiniband/sw/rxe/rxe_recv.c  |  15 +-
 drivers/infiniband/sw/rxe/rxe_req.c   |  94 ++++++----
 drivers/infiniband/sw/rxe/rxe_resp.c  |  18 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c | 242 +++++++++++++++-----------
 drivers/infiniband/sw/rxe/rxe_verbs.h |  12 --
 8 files changed, 367 insertions(+), 303 deletions(-)


base-commit: b6ba68555d75fd99f7daa9c5a5e476f8635cb155
prerequisite-patch-id: a6993e699da3603cc1d98d704434d467ab3f68f5
-- 
2.37.2


                 reply	other threads:[~2023-04-05  4:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405042425.6429-1-rpearsonhpe@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=jhack@hpe.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.