From: Benjamin Bara <bbara93@gmail.com>
To: mazziesaccount@gmail.com
Cc: DLG-Adam.Thomson.Opensource@dm.renesas.com, bbara93@gmail.com,
benjamin.bara@skidata.com, broonie@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
lee@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
stwiss.opensource@diasemi.com, support.opensource@diasemi.com
Subject: Re: [PATCH v2 1/3] regulator: da9063: add voltage monitoring registers
Date: Wed, 5 Apr 2023 10:04:22 +0200 [thread overview]
Message-ID: <20230405080422.560239-1-bbara93@gmail.com> (raw)
In-Reply-To: <2652d7df-b208-b88a-026e-5821d3d745ef@gmail.com>
Thank you for the feedback!
On Wed, 5 Apr 2023 at 09:29, Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> Just a very minor thing - wouldn't this check be better as:
> if (regl->info->vmon.mask) ?
> We may have device(s) where 0 is a valid reg. However, mask 0 is
> probably not making sense - unless I misunderstand something?
This config is specific to the da9063. On this IC, register 0 is used for
PAGE_CON (control register). The registers relevant for voltage monitoring are
on 0x115-0x117. So IMHO this should be fine.
next prev parent reply other threads:[~2023-04-05 8:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 5:29 [PATCH v2 0/3] regulator: da9063: disable unused voltage monitors Benjamin Bara
2023-04-05 5:29 ` [PATCH v2 1/3] regulator: da9063: add voltage monitoring registers Benjamin Bara
2023-04-05 7:29 ` Matti Vaittinen
2023-04-05 8:04 ` Benjamin Bara [this message]
2023-04-05 5:29 ` [PATCH v2 2/3] regulator: da9063: implement basic XVP setter Benjamin Bara
2023-04-05 7:42 ` Matti Vaittinen
2023-04-05 10:52 ` Mark Brown
2023-04-05 14:08 ` Benjamin Bara
2023-04-05 5:29 ` [PATCH v2 3/3] dt-bindings: mfd: dlg,da9063: document XVP Benjamin Bara
2023-04-05 5:33 ` Krzysztof Kozlowski
2023-04-05 7:43 ` Matti Vaittinen
2023-04-05 15:30 ` [PATCH v2 0/3] regulator: da9063: disable unused voltage monitors Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405080422.560239-1-bbara93@gmail.com \
--to=bbara93@gmail.com \
--cc=DLG-Adam.Thomson.Opensource@dm.renesas.com \
--cc=benjamin.bara@skidata.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.