From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Sahin, Okan" <Okan.Sahin@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Cosmin Tanislav <demonsingur@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
ChiYuan Huang <cy_huang@richtek.com>,
"Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
William Breathitt Gray <william.gray@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
Haibo Chen <haibo.chen@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support
Date: Wed, 5 Apr 2023 14:39:38 +0100 [thread overview]
Message-ID: <20230405133938.GD8371@google.com> (raw)
In-Reply-To: <ZC0zA1bVsrg0XEld@smile.fi.intel.com>
On Wed, 05 Apr 2023, Andy Shevchenko wrote:
> On Mon, Apr 03, 2023 at 03:09:50PM +0100, Lee Jones wrote:
> > On Mon, 03 Apr 2023, Sahin, Okan wrote:
>
> ...
>
>
> > > In fact, one of the maintainers suggested assigning chip_info to data
> > > instead of enumeration. Then I added chip_info and put devices into
> > > sub-structure above. I will replace chip_info with id structure in max77541
> > > device structure, right? I will use enumeration for data as I will assign
> > > it to id, and distinguish different devices.
> >
> > Yes, that's correct. Please remove chip_info altogether.
>
> Then it will provoke casting in the OF ID table which I believe is not what
> we want. I would agree on your first suggestion to have a plain number in I²C
> ID table, but I'm against it in OF and/or ACPI ID table.
And I'm against passing MFD information through the OF/ACPI APIs.
You can put through raw platform data or a device descriptor.
Ref: git grep -A5 "struct of_device_id.*{" -- drivers/mfd
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-05 13:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:28 [PATCH v6 0/5] Add MAX77541/MAX77540 PMIC Support Okan Sahin
2023-03-07 11:28 ` [PATCH v6 1/5] dt-bindings: regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Okan Sahin
2023-03-07 11:28 ` [PATCH v6 2/5] regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Support Okan Sahin
2023-03-07 12:19 ` Andy Shevchenko
2023-04-04 14:05 ` Sahin, Okan
2023-03-07 11:28 ` [PATCH v6 3/5] iio: adc: max77541: Add ADI MAX77541 ADC Support Okan Sahin
2023-03-07 11:28 ` [PATCH v6 4/5] dt-bindings: mfd: max77541: Add ADI MAX77541/MAX77540 Okan Sahin
2023-03-07 11:28 ` [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support Okan Sahin
2023-03-15 17:52 ` Lee Jones
2023-03-15 17:52 ` Lee Jones
2023-03-28 8:26 ` Sahin, Okan
2023-03-28 12:51 ` Andy Shevchenko
2023-03-28 13:26 ` Nuno Sá
2023-03-28 13:46 ` Mark Brown
2023-03-28 14:18 ` Nuno Sá
2023-03-28 14:35 ` Andy Shevchenko
2023-03-28 14:44 ` Lars-Peter Clausen
2023-03-28 14:51 ` Nuno Sá
2023-03-28 15:47 ` Andy Shevchenko
2023-03-28 16:01 ` Sahin, Okan
2023-03-29 14:08 ` Andy Shevchenko
2023-03-29 14:11 ` Andy Shevchenko
2023-03-30 7:43 ` Nuno Sá
2023-03-29 7:01 ` Nuno Sá
2023-03-29 14:06 ` Andy Shevchenko
2023-03-28 15:24 ` Mark Brown
2023-03-29 14:36 ` Lee Jones
2023-03-29 14:43 ` Andy Shevchenko
2023-03-29 14:56 ` Lee Jones
2023-03-29 15:06 ` Lee Jones
2023-03-30 8:04 ` Krzysztof Kozlowski
2023-03-30 8:07 ` Krzysztof Kozlowski
2023-04-03 11:40 ` Sahin, Okan
2023-04-03 14:09 ` Lee Jones
2023-04-05 8:36 ` Andy Shevchenko
2023-04-05 13:39 ` Lee Jones [this message]
2023-04-09 16:48 ` Sahin, Okan
2023-04-12 10:04 ` Lee Jones
2023-04-12 10:44 ` Sahin, Okan
2023-03-30 8:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405133938.GD8371@google.com \
--to=lee@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=Okan.Sahin@analog.com \
--cc=Ramona.Bolboaca@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.