From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [RFC PATCH net-next] net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub
Date: Wed, 5 Apr 2023 19:08:37 -0700 [thread overview]
Message-ID: <20230405190837.3cbbc449@kernel.org> (raw)
In-Reply-To: <20230405165115.3744445-1-vladimir.oltean@nxp.com>
On Wed, 5 Apr 2023 19:51:15 +0300 Vladimir Oltean wrote:
> There have been objections from Jakub Kicinski that using notifiers in
> general when they are not absolutely necessary creates complications to
> the control flow and difficulties to maintainers who look at the code.
> So there is a desire to not use notifiers.
LGTM, thank you!
next prev parent reply other threads:[~2023-04-06 2:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 16:51 [RFC PATCH net-next] net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub Vladimir Oltean
2023-04-05 16:56 ` Vladimir Oltean
2023-04-05 20:05 ` Simon Horman
2023-04-05 20:07 ` Vladimir Oltean
2023-04-05 20:08 ` Vladimir Oltean
2023-04-06 7:07 ` Simon Horman
2023-04-06 11:45 ` Vladimir Oltean
2023-04-05 20:31 ` Vladimir Oltean
2023-04-06 7:12 ` Simon Horman
2023-04-06 2:08 ` Jakub Kicinski [this message]
2023-04-06 2:27 ` kernel test robot
2023-04-06 2:58 ` kernel test robot
2023-04-06 4:30 ` kernel test robot
2023-04-06 5:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405190837.3cbbc449@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.