From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Thu, 6 Apr 2023 08:14:54 +1000 Subject: [Cluster-devel] [PATCH v2 19/23] xfs: disable direct read path for fs-verity sealed files In-Reply-To: References: <20230404145319.2057051-1-aalbersh@redhat.com> <20230404145319.2057051-20-aalbersh@redhat.com> <20230404161047.GA109974@frogsfrogsfrogs> <20230405150142.3jmxzo5i27bbc4c4@aalbersh.remote.csb> <20230405150927.GD303486@frogsfrogsfrogs> Message-ID: <20230405221454.GQ3223426@dread.disaster.area> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Apr 05, 2023 at 06:02:47PM +0000, Eric Biggers wrote: > And I really hope that you don't want to do DIO to the *Merkle tree*, as that Not for XFS - the merkle tree is not held as file data. That said, the merkle tree in XFS is not page cache or block aligned metadata either, so we really want the same memory buffer based interface for the merkle tree reading so that the merkle tree code can read directly from the xfs-buf rather than requiring us to copy it out of the xfsbuf into temporary pages... Cheers, Dave. -- Dave Chinner david at fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39317C950 for ; Wed, 5 Apr 2023 22:14:59 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id z10so22674363pgr.8 for ; Wed, 05 Apr 2023 15:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; t=1680732898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=m04BZY35RD6EaPYELcRel51CNq6xM8X8aXbJWM0zpFJg5R9ZEfx3ALXHe27ZQTx/ML RjdLwwAr7+4sz13cFeM+4MFXL0NDeO0sDJVA9EpyReHBMnIHkm92ebNusykZudTLT4kb ZJt9w2GuxyrtFAj7oogjC2Nr0HL+r4kpZ6lzOt6rcmOuXKj15Zw+5iQ9+bIRQa16RXYd mqYE+wyM7waca64HeD0ztnx4PCy2qkyJsPtmJxS4X1sOHozTDe94atNRk2yRkagS/8TC Xykh3m9EUSbsut3dD/LJF9fvakINcF2XcNSqQnSe8WA/qL2Bzj/UsimauCtRgN2YOZNg vv0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680732898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=2FjDsjrNzsavgG7DMCtbilzV/jwhGV0kcFjP0HCxX3hCEcIHCvC83quMtNgyjqcnGc bL0gBgZLxiHXe422R0p9shL/evcwXXIymmPQytubVmmRYbeae9VPy/k2l/xlQvnuAvIW W32G8GBP7aS/sJwDmZ51TsNkAJ9Sg+7CBk34dc5qCq/VseLOPS75zqHJr5DlCODsUZDZ AaewGtKd6R8Kj239qX6qk7J7Z7NiKxsUOCFrZpuZbyn8BVvXLq90GuX/6vnu/pecYCYr y9vdwdGW0LOhQSPRAOpwbw3d9l1t/SnKSmXmIXkZ22PjnmeLxK7leuH39+nY3naU+Q5j 6Z2g== X-Gm-Message-State: AAQBX9cppVZ2SwaP49IzOp/UzMLq9PKOl2MXT2YoYCamfH2PLrGyGMwP TiI4BCvlIr4AxWlhI63zY3lHvQ== X-Google-Smtp-Source: AKy350buwNZtgpjQjNrpY+dRBomVST4nFtdRBnQ6Mea8vZue8EC+2ZTK97MNMJLE5y0NZdZDQ14O+g== X-Received: by 2002:aa7:9a44:0:b0:626:1c2a:2805 with SMTP id x4-20020aa79a44000000b006261c2a2805mr5960988pfj.25.1680732898541; Wed, 05 Apr 2023 15:14:58 -0700 (PDT) Received: from dread.disaster.area (pa49-181-91-157.pa.nsw.optusnet.com.au. [49.181.91.157]) by smtp.gmail.com with ESMTPSA id t17-20020a62ea11000000b005a9ea5d43ddsm11542560pfh.174.2023.04.05.15.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 15:14:58 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pkBP4-00HUS4-Uz; Thu, 06 Apr 2023 08:14:54 +1000 Date: Thu, 6 Apr 2023 08:14:54 +1000 From: Dave Chinner To: Eric Biggers Cc: Christoph Hellwig , "Darrick J. Wong" , Andrey Albershteyn , dchinner@redhat.com, linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, rpeterso@redhat.com, agruenba@redhat.com, xiang@kernel.org, chao@kernel.org, damien.lemoal@opensource.wdc.com, jth@kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com Subject: Re: [PATCH v2 19/23] xfs: disable direct read path for fs-verity sealed files Message-ID: <20230405221454.GQ3223426@dread.disaster.area> References: <20230404145319.2057051-1-aalbersh@redhat.com> <20230404145319.2057051-20-aalbersh@redhat.com> <20230404161047.GA109974@frogsfrogsfrogs> <20230405150142.3jmxzo5i27bbc4c4@aalbersh.remote.csb> <20230405150927.GD303486@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 05, 2023 at 06:02:47PM +0000, Eric Biggers wrote: > And I really hope that you don't want to do DIO to the *Merkle tree*, as that Not for XFS - the merkle tree is not held as file data. That said, the merkle tree in XFS is not page cache or block aligned metadata either, so we really want the same memory buffer based interface for the merkle tree reading so that the merkle tree code can read directly from the xfs-buf rather than requiring us to copy it out of the xfsbuf into temporary pages... Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9D2FC77B6C for ; Wed, 5 Apr 2023 22:15:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PsJpf5VL8z3f8X for ; Thu, 6 Apr 2023 08:15:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ozlabs.org; s=201707; t=1680732906; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Z0VdLMGazIZcoBLu6tN/fl/JM/1H2Ohilz+GBgey2zxbeQjKT9UDtof74vvC1bpdC kSM069JRYQL0pMryS2Qmuanf/3xQXcUOTn70o6OEUVO9tFfjAWNNkHI4ZR40c9WA+v Yi5JuomjGa9k9agm6im1OlNyrDTUpMzRu6fu1wvVA8XcddqyknT4nCNEPlfLc7MuMc c6lUC3P84nBdSvI1UAhvMu1qPK43uXlEUXbFQ+qVREWPFD/oqDMEgJABEUajI50MQk h3BNG5tCZ5+s0BenrnY5esEtXn0KXHgzaAvv2uwO0pInqm9aE70N/4i3WWzHAxPfqW /Bx1Vu5rujq0g== Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=fromorbit.com (client-ip=2607:f8b0:4864:20::42d; helo=mail-pf1-x42d.google.com; envelope-from=david@fromorbit.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=fromorbit-com.20210112.gappssmtp.com header.i=@fromorbit-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=m04BZY35; dkim-atps=neutral Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PsJpY5rrBz3c41 for ; Thu, 6 Apr 2023 08:15:01 +1000 (AEST) Received: by mail-pf1-x42d.google.com with SMTP id z11so24658319pfh.4 for ; Wed, 05 Apr 2023 15:15:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680732898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=WksQNj5XF4Ke0q5Q0K9tmRCsAAuZfPtrhGGD/RHe3Ms7wP08w0Phd4IwRtkJAwmgNC HOPdCYeaLA8tFE/0F6ZHDrvuWgk9buLmxZqSUDRQUFtLXUmzUvUJOwZ2wJiHj9qHuVAD VSSXQiTmujIazEoGLeqRy7ezgRJcikDyc7GEmPEUdTej9FIdfwDApnQXMPwvLqUPjAOV 8arXzrcLpbU4UGeiRtIo04TKprp/UVYZfjf45m5lZN2RWXubhkgNZ+ahfgo2Sr4WSkva BAMHrwOgYB1dAwsDEEfDshAVo3ZzREfSQPCsJfZAb2aPze7UaDOwkNwTZro29MBb0ORA +nlg== X-Gm-Message-State: AAQBX9dqE/c4eiFlXsw31NTwm01ypOFok9RkScwQqAFNkYKR+rDtOKzc 0ZgdXKLHo91AYGVeHpvBNUuljw== X-Google-Smtp-Source: AKy350buwNZtgpjQjNrpY+dRBomVST4nFtdRBnQ6Mea8vZue8EC+2ZTK97MNMJLE5y0NZdZDQ14O+g== X-Received: by 2002:aa7:9a44:0:b0:626:1c2a:2805 with SMTP id x4-20020aa79a44000000b006261c2a2805mr5960988pfj.25.1680732898541; Wed, 05 Apr 2023 15:14:58 -0700 (PDT) Received: from dread.disaster.area (pa49-181-91-157.pa.nsw.optusnet.com.au. [49.181.91.157]) by smtp.gmail.com with ESMTPSA id t17-20020a62ea11000000b005a9ea5d43ddsm11542560pfh.174.2023.04.05.15.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 15:14:58 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pkBP4-00HUS4-Uz; Thu, 06 Apr 2023 08:14:54 +1000 Date: Thu, 6 Apr 2023 08:14:54 +1000 To: Eric Biggers Subject: Re: [PATCH v2 19/23] xfs: disable direct read path for fs-verity sealed files Message-ID: <20230405221454.GQ3223426@dread.disaster.area> References: <20230404145319.2057051-1-aalbersh@redhat.com> <20230404145319.2057051-20-aalbersh@redhat.com> <20230404161047.GA109974@frogsfrogsfrogs> <20230405150142.3jmxzo5i27bbc4c4@aalbersh.remote.csb> <20230405150927.GD303486@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Dave Chinner via Linux-erofs Reply-To: Dave Chinner Cc: fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, agruenba@redhat.com, "Darrick J. Wong" , Andrey Albershteyn , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , cluster-devel@redhat.com, dchinner@redhat.com, rpeterso@redhat.com, jth@kernel.org, linux-erofs@lists.ozlabs.org, damien.lemoal@opensource.wdc.com, linux-btrfs@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Wed, Apr 05, 2023 at 06:02:47PM +0000, Eric Biggers wrote: > And I really hope that you don't want to do DIO to the *Merkle tree*, as that Not for XFS - the merkle tree is not held as file data. That said, the merkle tree in XFS is not page cache or block aligned metadata either, so we really want the same memory buffer based interface for the merkle tree reading so that the merkle tree code can read directly from the xfs-buf rather than requiring us to copy it out of the xfsbuf into temporary pages... Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 036BDC7619A for ; Wed, 5 Apr 2023 22:38:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pkBld-0004xP-9N; Wed, 05 Apr 2023 22:38:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pkBlc-0004x1-KS for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Apr 2023 22:38:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=Fp0FRqo3jMEozJaqVrIipCqM2T 9jsLk+GsXpK08d+Lq/z8kx4bOGg7l4agUISBiYnZJvfO2+hAkwWcrOm9rgGf7/duNvqTOWt9RGfCm BXhUj8hQiTIPvqPTpAnjnJjwfxjQEEYz0w7RGdEyRMM2cAeq0n8cmlotZb0GJqD4rthQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=YzkpbAxo1sdnmV4kgVwKf+0Isi IB/ZYYgL7CcztUKiUOXaq60FUlq0gwv8SPld7RSN1Ii4SBEcb0IfGb2vp07mGrkfgXujiYgowroBU QpgFeierSFnC97OXVNlaKBLKz8bqXX94Np0hsPxxZc/KyWrqKY+7iFSc0pS/swFjFwW4=; Received: from mail-yw1-f171.google.com ([209.85.128.171]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pkBlb-00GLK8-Rv for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Apr 2023 22:38:13 +0000 Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-54bfa5e698eso39459447b3.13 for ; Wed, 05 Apr 2023 15:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; t=1680734286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=A2ebZYUzCzt2QZN45XHO9sH3qZv8FJBym2XAniJvc2/xCjW5iPAi7qBvSOsMAUqYT/ 2Ib1XCWB0Ct5COj6bB1GLihqs0OjLEiM8q8v3vFk0n+A4RPqzuexTbIuVG9r0s3foB3X 8BR9T5Nch7rgF+ni2YlWfSekUzi+kpJ8dmPTL0wRettkr01PTzDzoNyuUf+RdnD8mka0 KDxUoF6C2YbylYaIre58+KiPMzhQg9X/cZqA1ZuBFYmuL8Xst5NTK8pP2FI8yNLlqh3s xug0xDIGUwOQoRITANY4rrUftRl0bxFCXFfsLdnAFcGcN1SwlrE+3ufV2N9v7SIYjVpg FpHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680734286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sr4CJdOOx/6apQcfPjVNK8msYC2J6U4ttJpvFiO5hDA=; b=hqUXm3cJ2VLKgA2cgg//3buwpWsIGQ3MSGC6+cGwfwP9KzxUuqaJaGPDbBUfxW6POa 61a0Wl/bbkgEWF8ql1DOwILyHIMcy4JjzWYf0gxe2zfRiuCU6Dq1L/il7IXcywMBKolo TtxlSq1IAUKiicj7s42E8t4K3npi/bMDSkq41O6Dzz1zqI/YhQMKyY0DsAx2Zz8gAnZF t2ruXNU8u1VgGaj8qZbKCAVATSbLSzlLw5GGLUSh0vZ+oPuzCsbyeU+tz3NWztPt7ykO G8Ay4I2UBRi60DzGkZYwzoaAP51vPXLpl2gikWPm0TzljuIKKfT1H5ZHxkx14u9uqDN3 oAcA== X-Gm-Message-State: AAQBX9dE8vgKsqNZQnLu9XwbHoJUWx3Yc/6NaCCydo0z5iTnkjDBmo2c rUJf3wEhC2edN5QeIUYt0iuEuf9/u1NDkjRCabM= X-Google-Smtp-Source: AKy350buwNZtgpjQjNrpY+dRBomVST4nFtdRBnQ6Mea8vZue8EC+2ZTK97MNMJLE5y0NZdZDQ14O+g== X-Received: by 2002:aa7:9a44:0:b0:626:1c2a:2805 with SMTP id x4-20020aa79a44000000b006261c2a2805mr5960988pfj.25.1680732898541; Wed, 05 Apr 2023 15:14:58 -0700 (PDT) Received: from dread.disaster.area (pa49-181-91-157.pa.nsw.optusnet.com.au. [49.181.91.157]) by smtp.gmail.com with ESMTPSA id t17-20020a62ea11000000b005a9ea5d43ddsm11542560pfh.174.2023.04.05.15.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 15:14:58 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pkBP4-00HUS4-Uz; Thu, 06 Apr 2023 08:14:54 +1000 Date: Thu, 6 Apr 2023 08:14:54 +1000 To: Eric Biggers Message-ID: <20230405221454.GQ3223426@dread.disaster.area> References: <20230404145319.2057051-1-aalbersh@redhat.com> <20230404145319.2057051-20-aalbersh@redhat.com> <20230404161047.GA109974@frogsfrogsfrogs> <20230405150142.3jmxzo5i27bbc4c4@aalbersh.remote.csb> <20230405150927.GD303486@frogsfrogsfrogs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1pkBlb-00GLK8-Rv Subject: Re: [f2fs-dev] [PATCH v2 19/23] xfs: disable direct read path for fs-verity sealed files X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Dave Chinner via Linux-f2fs-devel Reply-To: Dave Chinner Cc: fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, agruenba@redhat.com, "Darrick J. Wong" , Andrey Albershteyn , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , cluster-devel@redhat.com, dchinner@redhat.com, rpeterso@redhat.com, xiang@kernel.org, jth@kernel.org, linux-erofs@lists.ozlabs.org, damien.lemoal@opensource.wdc.com, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Apr 05, 2023 at 06:02:47PM +0000, Eric Biggers wrote: > And I really hope that you don't want to do DIO to the *Merkle tree*, as that Not for XFS - the merkle tree is not held as file data. That said, the merkle tree in XFS is not page cache or block aligned metadata either, so we really want the same memory buffer based interface for the merkle tree reading so that the merkle tree code can read directly from the xfs-buf rather than requiring us to copy it out of the xfsbuf into temporary pages... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel