All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Filipe Laíns" <lains@riseup.net>,
	"Nestor Lopez Casado" <nlopezcasad@logitech.com>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: [PATCH v2] USB: core: Fix docs warning caused by wireless_status feature
Date: Wed, 5 Apr 2023 20:06:48 +0200	[thread overview]
Message-ID: <2023040541-decipher-chowtime-42a3@gregkh> (raw)
In-Reply-To: <8ee84f3383fb074f031b88c4f030757667635d96.camel@hadess.net>

On Wed, Apr 05, 2023 at 08:03:16PM +0200, Bastien Nocera wrote:
> On Wed, 2023-04-05 at 19:13 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Apr 05, 2023 at 11:27:54AM +0200, Bastien Nocera wrote:
> > > Fix wrongly named 'dev' parameter in doc block, should have been
> > > iface:
> > > drivers/usb/core/message.c:1939: warning: Function parameter or
> > > member 'iface' not described in 'usb_set_wireless_status'
> > > drivers/usb/core/message.c:1939: warning: Excess function parameter
> > > 'dev' description in 'usb_set_wireless_status'
> > > 
> > > And fix missing struct member doc in kernel API, and reorder to
> > > match struct:
> > > include/linux/usb.h:270: warning: Function parameter or member
> > > 'wireless_status_work' not described in 'usb_interface'
> > > 
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Link:
> > > https://lore.kernel.org/linux-next/20230405114807.5a57bf46@canb.auug.org.au/T/#t
> > > Fixes: 0a4db185f078 ("USB: core: Add API to change the
> > > wireless_status")
> > 
> > I do not see that git commit id anywhere, where is it from?  What
> > tree?
> > 
> > Ah, input tree, not much I can do there...
> 
> Yes, it's from the hid tree.
> 
> Benjamin is waiting on either Alan or yourself ack'ing the changes
> before pushing it through the hid tree, to avoid stepping on somebody
> else's toes.
> 
> The patch seems to fix the warnings in my local tests, let me know if
> you have any comments about the wording.

Nope:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  reply	other threads:[~2023-04-05 18:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05  9:27 [PATCH v2] USB: core: Fix docs warning caused by wireless_status feature Bastien Nocera
2023-04-05 17:13 ` Greg Kroah-Hartman
2023-04-05 18:03   ` Bastien Nocera
2023-04-05 18:06     ` Greg Kroah-Hartman [this message]
2023-04-06 15:17       ` Benjamin Tissoires
2023-04-06 15:15 ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023040541-decipher-chowtime-42a3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hadess@hadess.net \
    --cc=lains@riseup.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nlopezcasad@logitech.com \
    --cc=sfr@canb.auug.org.au \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.