From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH net-next 2/3] ksz884x: remove unused #defines
Date: Thu, 6 Apr 2023 09:00:17 -0700 [thread overview]
Message-ID: <20230406090017.0fc0ae34@kernel.org> (raw)
In-Reply-To: <454a61709e442f717fbde4b0ebb8b4c3fdfb515e.camel@redhat.com>
On Thu, 06 Apr 2023 15:37:36 +0200 Paolo Abeni wrote:
> On Wed, 2023-04-05 at 10:39 +0200, Simon Horman wrote:
> > Remove unused #defines from ksz884x driver.
> >
> > These #defines may have some value in documenting the hardware.
> > But that information may be accessed via scm history.
>
> I personally have a slight preference for keeping these definitions in
> the sources (for doc purposes), but it's not a big deal.
>
> Any 3rd opinion more then welcome!
I had the same reaction, FWIW.
Cleaning up unused "code" macros, pure software stuff makes perfect
sense. But I feel a bit ambivalent about removing definitions of HW
registers and bits.
next prev parent reply other threads:[~2023-04-06 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 8:39 [PATCH net-next 0/3] ksz884x: remove unused functions and #defines Simon Horman
2023-04-05 8:39 ` [PATCH net-next 1/3] ksz884x: remove commented-out #defines Simon Horman
2023-04-05 8:39 ` [PATCH net-next 2/3] ksz884x: remove unused #defines Simon Horman
2023-04-06 13:37 ` Paolo Abeni
2023-04-06 16:00 ` Jakub Kicinski [this message]
2023-04-06 16:12 ` Simon Horman
2023-04-06 17:44 ` Jakub Kicinski
2023-04-06 20:06 ` Paolo Abeni
2023-04-05 8:39 ` [PATCH net-next 3/3] ksz884x: remove unused functions Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406090017.0fc0ae34@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.