Re: [RFC PATCH net-next] net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub

[kernel test robot <lkp@intel.com>]

Hi Vladimir,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Vladimir-Oltean/net-dsa-replace-NETDEV_PRE_CHANGE_HWTSTAMP-notifier-with-a-stub/20230406-005302
patch link:    https://lore.kernel.org/r/20230405165115.3744445-1-vladimir.oltean%40nxp.com
patch subject: [RFC PATCH net-next] net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20230406/202304061324.mnmSnwNK-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/4788a6c004ab7f7210b1d27777e733eab85db17e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vladimir-Oltean/net-dsa-replace-NETDEV_PRE_CHANGE_HWTSTAMP-notifier-with-a-stub/20230406-005302
        git checkout 4788a6c004ab7f7210b1d27777e733eab85db17e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs// net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304061324.mnmSnwNK-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/core/dev_ioctl.c: In function 'dev_set_hwtstamp':
>> net/core/dev_ioctl.c:276:15: error: too many arguments to function 'dsa_master_hwtstamp_validate'
     276 |         err = dsa_master_hwtstamp_validate(dev, &kernel_cfg, &extack);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from net/core/dev_ioctl.c:10:
   include/net/dsa_stubs.h:43:19: note: declared here
      43 | static inline int dsa_master_hwtstamp_validate(struct net_device *dev,
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/dsa_master_hwtstamp_validate +276 net/core/dev_ioctl.c

   259	
   260	static int dev_set_hwtstamp(struct net_device *dev, struct ifreq *ifr)
   261	{
   262		struct kernel_hwtstamp_config kernel_cfg;
   263		struct netlink_ext_ack extack = {};
   264		struct hwtstamp_config cfg;
   265		int err;
   266	
   267		if (copy_from_user(&cfg, ifr->ifr_data, sizeof(cfg)))
   268			return -EFAULT;
   269	
   270		hwtstamp_config_to_kernel(&kernel_cfg, &cfg);
   271	
   272		err = net_hwtstamp_validate(&kernel_cfg);
   273		if (err)
   274			return err;
   275	
 > 276		err = dsa_master_hwtstamp_validate(dev, &kernel_cfg, &extack);
   277		if (err) {
   278			if (extack._msg)
   279				netdev_err(dev, "%s\n", extack._msg);
   280			return err;
   281		}
   282	
   283		return dev_eth_ioctl(dev, ifr, SIOCSHWTSTAMP);
   284	}
   285	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests