From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 157168BE0 for ; Thu, 6 Apr 2023 15:18:27 +0000 (UTC) Received: by mail-oi1-f180.google.com with SMTP id bj20so29309905oib.3 for ; Thu, 06 Apr 2023 08:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680794307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tMVZO08lvHqEqzOhCjWBkw6cuH10x2lvDXMm8yPnUHA=; b=AZZUFBYUdZ9JETredLSXJnhnmpEz2a3aWo1+B0c0KKqG0mY11MWbQNN2p2lQZUOT60 XJlpfbGPonJ9aQ05xZNB8EurymMvlnFLhH5L71CdxPO+VsS68hN7owrb0FKI0kC/hdGi ryu61UyXkL8dtmwiXajlPVACEji/45k6s1nIFABLAp5Y8wSuq6Ut7N+d5uyLwUa5+jd2 /nypgPipvI41uNYzVPj9J6jppXKFKslkCK2SGjl3zNp/jo/lXS4Ue7hTyHQTCVb5JvRz f2k5iKwOD1CjS9JMmI+8gwYBo+Rkz/0UftvzjBy7gy7H0Ot6+n0MEgepTNLumg6tdL6C rS2Q== X-Gm-Message-State: AAQBX9faW+RUSZQEC4r6jkhfFITPGpGLmBlUd+OVcJMt69q9BS+D0K5U 7pw5eJIF2dwRTBz9XrNuaA== X-Google-Smtp-Source: AKy350bdKh87MJnB+T/f5MC1AljIe85YEewpcZpqURUk+MxBLINdqR5LYyGaTKMJtGlA2H+WoQ6W0g== X-Received: by 2002:a05:6808:289:b0:389:50f2:4ab0 with SMTP id z9-20020a056808028900b0038950f24ab0mr3866508oic.10.1680794306969; Thu, 06 Apr 2023 08:18:26 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e4-20020a4a5504000000b0054156478f2esm639755oob.44.2023.04.06.08.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 08:18:26 -0700 (PDT) Received: (nullmailer pid 3117135 invoked by uid 1000); Thu, 06 Apr 2023 15:18:25 -0000 Date: Thu, 6 Apr 2023 10:18:25 -0500 From: Rob Herring To: Pin-yen Lin Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck , Xin Ji , Marek Vasut , Hsin-Yi Wang , Thomas Zimmermann , AngeloGioacchino Del Regno , Lyude Paul , devicetree@vger.kernel.org, Stephen Boyd , dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, chrome-platform@lists.linux.dev, =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Chen-Yu Tsai Subject: Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support Message-ID: <20230406151825.GB3098002-robh@kernel.org> References: <20230331091145.737305-1-treapking@chromium.org> <20230331091145.737305-5-treapking@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331091145.737305-5-treapking@chromium.org> On Fri, Mar 31, 2023 at 05:11:39PM +0800, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Chen-Yu Tsai > Tested-by: Chen-Yu Tsai > Reviewed-by: AngeloGioacchino Del Regno > > --- > > (no changes since v12) > > Changes in v12: > - Removed the 4-lane binding in analogix,anx7625.yaml > - Reworded the description for the mode-switch property > > Changes in v11: > - Updated the description of the endpoints > - Referenced video-interfaces.yaml instead for the endpoints > > Changes in v10: > - Collected Reviewed-by and Tested-by tags > > Changes in v9: > - Collected Reviewed-by tag > > Changes in v8: > - Updated anx7625 bindings for data-lane property > - Fixed the subject prefix > > Changes in v7: > - Fixed issues reported by dt_binding_check > - Updated the schema and the example dts for data-lanes. > - Changed to generic naming for the example dts node. > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. > > .../display/bridge/analogix,anx7625.yaml | 88 ++++++++++++++++++- > 1 file changed, 85 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index b42553ac505c..604c7391d74f 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -12,7 +12,8 @@ maintainers: > > description: | > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > - designed for portable devices. > + designed for portable devices. Product brief is available at > + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf > > properties: > compatible: > @@ -112,9 +113,40 @@ properties: > data-lanes: true > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > description: > - Video port for panel or connector. > + Video port for panel or connector. Each endpoint connects to a video > + output downstream, and the "data-lanes" property is used to describe > + the pin connections. 0, 1, 2, 3 in "data-lanes" maps to SSRX1, SSTX1, > + SSRX2, SSTX2, respectively. > + > + patternProperties: > + "^endpoint@[01]$": > + $ref: /schemas/media/video-interfaces.yaml# unevaluatedProperties: false > + properties: > + reg: true > + > + remote-endpoint: true Don't need to list these 2. > + > + data-lanes: > + oneOf: > + - items: > + - enum: [0, 1, 2, 3] > + > + - items: > + - const: 0 > + - const: 1 > + > + - items: > + - const: 2 > + - const: 3 > + > + mode-switch: > + type: boolean > + description: Serves as Type-C mode switch if present. > + > + required: > + - remote-endpoint Don't need required. > > required: > - port@0 > @@ -186,3 +218,53 @@ examples: > }; > }; > }; > + - | > + i2c3 { i2c-3 But better yet, just expand the existing example rather than a whole new one. > + #address-cells = <1>; > + #size-cells = <0>; > + > + encoder@58 { > + compatible = "analogix,anx7625"; > + reg = <0x58>; > + pinctrl-names = "default"; > + pinctrl-0 = <&anx7625_dp_pins>; > + enable-gpios = <&pio 176 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio 177 GPIO_ACTIVE_HIGH>; > + vdd10-supply = <&pp1100_dpbrdg>; > + vdd18-supply = <&pp1800_dpbrdg_dx>; > + vdd33-supply = <&pp3300_dpbrdg_dx>; > + analogix,audio-enable; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + anx7625_dp_in: endpoint { > + bus-type = <7>; > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + anx_typec0: endpoint@0 { > + reg = <0>; > + mode-switch; > + data-lanes = <0 1>; > + remote-endpoint = <&typec_port0>; > + }; > + anx_typec1: endpoint@1 { > + reg = <1>; > + mode-switch; > + data-lanes = <2 3>; > + remote-endpoint = <&typec_port1>; > + }; > + }; > + }; > + }; > + }; > -- > 2.40.0.348.gf938b09366-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91E0BC761A6 for ; Thu, 6 Apr 2023 15:18:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4CE010EC11; Thu, 6 Apr 2023 15:18:29 +0000 (UTC) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE61E10EC11 for ; Thu, 6 Apr 2023 15:18:27 +0000 (UTC) Received: by mail-oi1-f181.google.com with SMTP id r14so23624243oiw.12 for ; Thu, 06 Apr 2023 08:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680794307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tMVZO08lvHqEqzOhCjWBkw6cuH10x2lvDXMm8yPnUHA=; b=QSM+3Ccn8EYf6aTg1nZ9NbR4znh1q5638M41OW9sz0aWNaMal4u9AIDulShLLKN2Wa qNJB8sZo9RejI79Hy/ijHZ762LQDAoGkPbACOk+UB61sWOw+E/S6tvC4T54QvCn3QTeR r0FIL+WQrZx6HX2HiwHgOi40XqxNAUbv92ZlD4hrznppTgxAFNBMQgmANeNG2XiY9D8Q yTJ1MmWhywyeZxt25CcMCGYLetfHy5t8+djFlBdREw5lBojHr6Cof/6NtVyc5xmdSTmZ Dv+fye2YEGUh/a6pWKQX01duKM0CofjLGSmlijOZlWWfxk0TdZeTF/tpmfL+cAFxpAd1 jfhA== X-Gm-Message-State: AAQBX9cr06EQn/kMGlmhqNkaqwn6rjE0K6i5+CJu7RaYj1Ily/K3ca7z iiANCR3s/V39egsxIRWAEQ== X-Google-Smtp-Source: AKy350bdKh87MJnB+T/f5MC1AljIe85YEewpcZpqURUk+MxBLINdqR5LYyGaTKMJtGlA2H+WoQ6W0g== X-Received: by 2002:a05:6808:289:b0:389:50f2:4ab0 with SMTP id z9-20020a056808028900b0038950f24ab0mr3866508oic.10.1680794306969; Thu, 06 Apr 2023 08:18:26 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e4-20020a4a5504000000b0054156478f2esm639755oob.44.2023.04.06.08.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 08:18:26 -0700 (PDT) Received: (nullmailer pid 3117135 invoked by uid 1000); Thu, 06 Apr 2023 15:18:25 -0000 Date: Thu, 6 Apr 2023 10:18:25 -0500 From: Rob Herring To: Pin-yen Lin Subject: Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support Message-ID: <20230406151825.GB3098002-robh@kernel.org> References: <20230331091145.737305-1-treapking@chromium.org> <20230331091145.737305-5-treapking@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331091145.737305-5-treapking@chromium.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Andrzej Hajda , "Rafael J . Wysocki" , dri-devel@lists.freedesktop.org, Laurent Pinchart , Krzysztof Kozlowski , Guenter Roeck , Marek Vasut , chrome-platform@lists.linux.dev, Robert Foss , Javier Martinez Canillas , Jernej Skrabec , linux-acpi@vger.kernel.org, Chen-Yu Tsai , devicetree@vger.kernel.org, Sakari Ailus , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Jonas Karlman , Stephen Boyd , Hsin-Yi Wang , Andy Shevchenko , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Daniel Scally , Krzysztof Kozlowski , Prashant Malani Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 31, 2023 at 05:11:39PM +0800, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Chen-Yu Tsai > Tested-by: Chen-Yu Tsai > Reviewed-by: AngeloGioacchino Del Regno > > --- > > (no changes since v12) > > Changes in v12: > - Removed the 4-lane binding in analogix,anx7625.yaml > - Reworded the description for the mode-switch property > > Changes in v11: > - Updated the description of the endpoints > - Referenced video-interfaces.yaml instead for the endpoints > > Changes in v10: > - Collected Reviewed-by and Tested-by tags > > Changes in v9: > - Collected Reviewed-by tag > > Changes in v8: > - Updated anx7625 bindings for data-lane property > - Fixed the subject prefix > > Changes in v7: > - Fixed issues reported by dt_binding_check > - Updated the schema and the example dts for data-lanes. > - Changed to generic naming for the example dts node. > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. > > .../display/bridge/analogix,anx7625.yaml | 88 ++++++++++++++++++- > 1 file changed, 85 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index b42553ac505c..604c7391d74f 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -12,7 +12,8 @@ maintainers: > > description: | > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > - designed for portable devices. > + designed for portable devices. Product brief is available at > + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf > > properties: > compatible: > @@ -112,9 +113,40 @@ properties: > data-lanes: true > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > description: > - Video port for panel or connector. > + Video port for panel or connector. Each endpoint connects to a video > + output downstream, and the "data-lanes" property is used to describe > + the pin connections. 0, 1, 2, 3 in "data-lanes" maps to SSRX1, SSTX1, > + SSRX2, SSTX2, respectively. > + > + patternProperties: > + "^endpoint@[01]$": > + $ref: /schemas/media/video-interfaces.yaml# unevaluatedProperties: false > + properties: > + reg: true > + > + remote-endpoint: true Don't need to list these 2. > + > + data-lanes: > + oneOf: > + - items: > + - enum: [0, 1, 2, 3] > + > + - items: > + - const: 0 > + - const: 1 > + > + - items: > + - const: 2 > + - const: 3 > + > + mode-switch: > + type: boolean > + description: Serves as Type-C mode switch if present. > + > + required: > + - remote-endpoint Don't need required. > > required: > - port@0 > @@ -186,3 +218,53 @@ examples: > }; > }; > }; > + - | > + i2c3 { i2c-3 But better yet, just expand the existing example rather than a whole new one. > + #address-cells = <1>; > + #size-cells = <0>; > + > + encoder@58 { > + compatible = "analogix,anx7625"; > + reg = <0x58>; > + pinctrl-names = "default"; > + pinctrl-0 = <&anx7625_dp_pins>; > + enable-gpios = <&pio 176 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio 177 GPIO_ACTIVE_HIGH>; > + vdd10-supply = <&pp1100_dpbrdg>; > + vdd18-supply = <&pp1800_dpbrdg_dx>; > + vdd33-supply = <&pp3300_dpbrdg_dx>; > + analogix,audio-enable; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + anx7625_dp_in: endpoint { > + bus-type = <7>; > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + anx_typec0: endpoint@0 { > + reg = <0>; > + mode-switch; > + data-lanes = <0 1>; > + remote-endpoint = <&typec_port0>; > + }; > + anx_typec1: endpoint@1 { > + reg = <1>; > + mode-switch; > + data-lanes = <2 3>; > + remote-endpoint = <&typec_port1>; > + }; > + }; > + }; > + }; > + }; > -- > 2.40.0.348.gf938b09366-goog >