From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7972F8BE0 for ; Thu, 6 Apr 2023 15:29:02 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id q102so37548323pjq.3 for ; Thu, 06 Apr 2023 08:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680794942; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=619nQ0lsEgEINdCEqk6IT2CyO/5/oumKn1+zUtFno4k=; b=YnP4GgynlL7t7+IONZVDilf5FdPhppgHVhPH7qFsWwOeDXZPJ2gMBDgEa+TSEZ4gwJ VWgtTUa10TteY5POfC+h22Cb7gC+x6aGBpGPxo+8MTx5r+PYZc5ZNynUn4s3nZK4Is2b 5q3K52/jo9yTZxmj50Qzdb4cU/KUjYQLjyT34WedNl2n7iTbqOhLvkITZMWvIlvXdCu0 pR+CUptJ23IMUPtc0sDT/8y1TycaLyruUkEqOB0SMkNrRYUD2iaIGLzYM0o49eUs8sMD UpJus3VnJ2AR1GbAhWT3EmCmJIBTwQ2EKpdy+Zx5IpOuTMKOZUpVS1VU4Zu8zdK7Mlt3 nKjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680794942; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=619nQ0lsEgEINdCEqk6IT2CyO/5/oumKn1+zUtFno4k=; b=fK6J06ddxEhVsHJU28FMSgOR3qL8JkRk/UeZhKurwxv317M04Y3f9QMxLFFiQfjlcD X4gOXjjviUZz/t22WIORq+LubYgkxoY4lvpbgD7iBdeCm+R3YI/5XuAP7e/aMKOP3Qfq ZzFvJQYNUJAI29NItnw8rMO2zWdZl9yEr6V7xzjJAFCw2yCWoMiXedBKkclg5lVkziMG mlxIQ/I0Kry01/2ONfkTyDkatwW4B5KBnWIqHY1LT/0/FZqOfNgpp4el6UrfXwMoNz4e f3kqCYi5XvnAgLFm+YWMFSaXmdao30beASuF0PtueAGT6nD5FOKTVangmCo692vfnX84 O6aQ== X-Gm-Message-State: AAQBX9fxOsEKx8LPX7zAvE0vl4I7woyyBwGf0R9NK3zcu9ElGwm7HCVk QvY3nyWQcF7kte8/uLAL+RI= X-Google-Smtp-Source: AKy350aL0d6vsdrWRXnaqUJo+aSZdHYPn8zOrCf5LeepDfVwSJ8pPtckKKR1Ack72MDaBZxWxYO5Ow== X-Received: by 2002:a17:902:fb90:b0:1a2:9183:a499 with SMTP id lg16-20020a170902fb9000b001a29183a499mr9395030plb.34.1680794941673; Thu, 06 Apr 2023 08:29:01 -0700 (PDT) Received: from sumitra.com ([59.95.156.146]) by smtp.gmail.com with ESMTPSA id i2-20020a1709026ac200b001a4fecf79e4sm1318249plt.49.2023.04.06.08.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 08:29:01 -0700 (PDT) Date: Thu, 6 Apr 2023 08:28:55 -0700 From: Sumitra Sharma To: Greg Kroah-Hartman Cc: Simon Horman , Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: qlge: Remove macro FILL_SEG Message-ID: <20230406152855.GC231658@sumitra.com> References: <20230405150627.GA227254@sumitra.com> <20230406144644.GB231658@sumitra.com> <2023040648-zeppelin-escapist-86d1@gregkh> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023040648-zeppelin-escapist-86d1@gregkh> On Thu, Apr 06, 2023 at 04:57:44PM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 06, 2023 at 07:46:44AM -0700, Sumitra Sharma wrote: > > On Wed, Apr 05, 2023 at 06:21:57PM +0200, Simon Horman wrote: > > > On Wed, Apr 05, 2023 at 08:06:27AM -0700, Sumitra Sharma wrote: > > > > Remove macro FILL_SEG to fix the checkpatch warning: > > > > > > > > WARNING: Macros with flow control statements should be avoided > > > > > > > > Macros with flow control statements must be avoided as they > > > > break the flow of the calling function and make it harder to > > > > test the code. > > > > > > > > Replace all FILL_SEG() macro calls with: > > > > > > > > err = err || qlge_fill_seg_(...); > > > > > > Perhaps I'm missing the point here. > > > But won't this lead to err always either being true or false (1 or 0). > > > Rather than the current arrangement where err can be > > > either 0 or a negative error value, such as -EINVAL. > > > > > > > Hi Simon > > > > > > Thank you for the point you mentioned which I missed while working on this > > patch. > > > > However, after thinking on it, I am still not able to get any fix to this > > except that we can possibly implement the Ira's solution here which is: > > > > https://lore.kernel.org/outreachy/64154d438f0c8_28ae5229421@iweiny-mobl.notmuch/ > > > > Although we have to then deal with 40 lines of ifs. > > Which implies that the current solution is the best one, so I would > recommend just leaving it as-is. > Hi greg Before leaving it I would like to know your opinion on the solution Dan is offering. Regards Sumitra > Remember, checkpatch.pl is a tool to provide hints, it does not have > much context, if any, to determine if it's hints actually make sense. > > thanks, > > greg k-h