From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A917C77B6C for ; Thu, 6 Apr 2023 10:08:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235749AbjDFKIz (ORCPT ); Thu, 6 Apr 2023 06:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbjDFKIy (ORCPT ); Thu, 6 Apr 2023 06:08:54 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FA7D98; Thu, 6 Apr 2023 03:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680775732; x=1712311732; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Vj2yYDdaNBKxmJWDjwzQ/CvQHf+cpCsKosmbQ6GR4k8=; b=e9EHZP3VM7tnS2ovnD/qgwOeN7ipicrpmDoiWGOpzIPIszbqWNm3Kvxz L/iilKMCEBgB8IaMSC/MVs2TtbByipFWLMyiMTSZWbfWepn/7nnA7th6l tZue6OLsToNMR6ZE9JiYiDzMB2cDI54KAX7TM+a5oe9MmyPpLaQaTTOhk d2qFqSz2wmhzFKG7nzIByDZZm3ugbgOhJCH/hzp9r+c6bECF9WCLXObN+ 3WF2VopBNKZKhfERmM+trvO/Q0RLSFxKB3dbGcp/gHq27kUG70hHELoUi CjTHvu8ESnOSNogKRbkJlpTzqU2cYLbjELmsPG+WrhTpzKyO+FKoCdOZN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345297262" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="345297262" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 03:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="637220429" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="637220429" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 06 Apr 2023 03:08:47 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pkMXv-000RHy-0m; Thu, 06 Apr 2023 10:08:47 +0000 Date: Thu, 6 Apr 2023 18:08:08 +0800 From: kernel test robot To: Badhri Jagan Sridharan , gregkh@linuxfoundation.org, stern@rowland.harvard.edu, colin.i.king@gmail.com, xuetao09@huawei.com, quic_eserrao@quicinc.com, water.zhangjiantao@huawei.com, peter.chen@freescale.com, balbi@ti.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Badhri Jagan Sridharan Subject: Re: [PATCH v2 1/2] usb: gadget: udc: core: Invoke usb_gadget_connect only when started Message-ID: <202304061713.mqRzNBGz-lkp@intel.com> References: <20230406062549.2461917-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230406062549.2461917-1-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Badhri, kernel test robot noticed the following build warnings: [auto build test WARNING on d629c0e221cd99198b843d8351a0a9bfec6c0423] url: https://github.com/intel-lab-lkp/linux/commits/Badhri-Jagan-Sridharan/usb-gadget-udc-core-Prevent-redundant-calls-to-pullup/20230406-142708 base: d629c0e221cd99198b843d8351a0a9bfec6c0423 patch link: https://lore.kernel.org/r/20230406062549.2461917-1-badhri%40google.com patch subject: [PATCH v2 1/2] usb: gadget: udc: core: Invoke usb_gadget_connect only when started config: hexagon-randconfig-r041-20230403 (https://download.01.org/0day-ci/archive/20230406/202304061713.mqRzNBGz-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2f12e8b0c9bf3d25df88c73b614c3e8d84bd7338 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Badhri-Jagan-Sridharan/usb-gadget-udc-core-Prevent-redundant-calls-to-pullup/20230406-142708 git checkout 2f12e8b0c9bf3d25df88c73b614c3e8d84bd7338 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/usb/gadget/udc/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304061713.mqRzNBGz-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/usb/gadget/udc/core.c:17: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __raw_readb(PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from drivers/usb/gadget/udc/core.c:17: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from drivers/usb/gadget/udc/core.c:17: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writeb(value, PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ >> drivers/usb/gadget/udc/core.c:696:5: warning: no previous prototype for function 'usb_gadget_connect_locked' [-Wmissing-prototypes] int usb_gadget_connect_locked(struct usb_gadget *gadget) ^ drivers/usb/gadget/udc/core.c:696:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int usb_gadget_connect_locked(struct usb_gadget *gadget) ^ static >> drivers/usb/gadget/udc/core.c:749:5: warning: no previous prototype for function 'usb_gadget_disconnect_locked' [-Wmissing-prototypes] int usb_gadget_disconnect_locked(struct usb_gadget *gadget) ^ drivers/usb/gadget/udc/core.c:749:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int usb_gadget_disconnect_locked(struct usb_gadget *gadget) ^ static 8 warnings generated. vim +/usb_gadget_connect_locked +696 drivers/usb/gadget/udc/core.c 694 695 /* Internal version of usb_gadget_connect needs to be called with udc_connect_control_lock held. */ > 696 int usb_gadget_connect_locked(struct usb_gadget *gadget) 697 { 698 int ret = 0; 699 700 if (!gadget->ops->pullup) { 701 ret = -EOPNOTSUPP; 702 goto out; 703 } 704 705 if (gadget->deactivated || !gadget->udc->started) { 706 /* 707 * If gadget is deactivated we only save new state. 708 * Gadget will be connected automatically after activation. 709 * 710 * udc first needs to be started before gadget can be pulled up. 711 */ 712 gadget->connected = true; 713 goto out; 714 } 715 716 ret = gadget->ops->pullup(gadget, 1); 717 if (!ret) 718 gadget->connected = 1; 719 720 out: 721 trace_usb_gadget_connect(gadget, ret); 722 723 return ret; 724 } 725 726 /** 727 * usb_gadget_connect - software-controlled connect to USB host 728 * @gadget:the peripheral being connected 729 * 730 * Enables the D+ (or potentially D-) pullup. The host will start 731 * enumerating this gadget when the pullup is active and a VBUS session 732 * is active (the link is powered). 733 * 734 * Returns zero on success, else negative errno. 735 */ 736 int usb_gadget_connect(struct usb_gadget *gadget) 737 { 738 int ret; 739 740 mutex_lock(&gadget->udc->connect_lock); 741 ret = usb_gadget_connect_locked(gadget); 742 mutex_unlock(&gadget->udc->connect_lock); 743 744 return ret; 745 } 746 EXPORT_SYMBOL_GPL(usb_gadget_connect); 747 748 /* Internal version of usb_gadget_disconnect needs to be called with udc->connect_lock held. */ > 749 int usb_gadget_disconnect_locked(struct usb_gadget *gadget) 750 { 751 int ret = 0; 752 753 if (!gadget->ops->pullup) { 754 ret = -EOPNOTSUPP; 755 goto out; 756 } 757 758 if (!gadget->connected) 759 goto out; 760 761 if (gadget->deactivated || !gadget->udc->started) { 762 /* 763 * If gadget is deactivated we only save new state. 764 * Gadget will stay disconnected after activation. 765 * 766 * udc should have been started before gadget being pulled down. 767 */ 768 gadget->connected = false; 769 goto out; 770 } 771 772 ret = gadget->ops->pullup(gadget, 0); 773 if (!ret) 774 gadget->connected = 0; 775 776 mutex_lock(&udc_lock); 777 if (gadget->udc->driver) 778 gadget->udc->driver->disconnect(gadget); 779 mutex_unlock(&udc_lock); 780 781 out: 782 trace_usb_gadget_disconnect(gadget, ret); 783 784 return ret; 785 } 786 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests