From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-parport@lists.infradead.org
Subject: Re: [PATCH] parport_pc: don't allow driver for SPARC32
Date: Thu, 6 Apr 2023 21:28:19 +0200 [thread overview]
Message-ID: <20230406192819.GA1527307@ravnborg.org> (raw)
In-Reply-To: <20230406160548.25721-1-rdunlap@infradead.org>
On Thu, Apr 06, 2023 at 09:05:48AM -0700, Randy Dunlap wrote:
> arch/sparc/kernel/ebus.o is only built for SPARC64.
> ns87303_lock is only built for SPARC64.
> arch/sparc/include/asm/parport.h says that it is for sparc64.
> Various documentation on the internet says that ebus is for UltraSPARC
> systems (64-bit).
>
> Therefore don't allow PARPORT_PC to be built for SPARC32.
>
> Fixes these build errors on SPARC32:
>
> ERROR: modpost: "ebus_dma_irq_enable" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ebus_dma_unregister" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ebus_dma_register" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ns87303_lock" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ebus_dma_enable" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ebus_dma_prepare" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ebus_dma_request" [drivers/parport/parport_pc.ko] undefined!
> ERROR: modpost: "ebus_dma_residue" [drivers/parport/parport_pc.ko] undefined!
>
> Fixes: 66bcd06099bb ("parport_pc: Also enable driver for PCI systems")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Cc: Maciej W. Rozycki <macro@orcam.me.uk>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: linux-parport@lists.infradead.org
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/parport/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> --- a/drivers/parport/Kconfig
> +++ b/drivers/parport/Kconfig
> @@ -42,7 +42,7 @@ if PARPORT
>
> config PARPORT_PC
> tristate "PC-style hardware"
> - depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390)
> + depends on ARCH_MIGHT_HAVE_PC_PARPORT || (PCI && !S390 && !SPARC32)
> help
> You should say Y here if you have a PC-style parallel port. All
> IBM PC compatible computers and some Alphas have PC-style
next prev parent reply other threads:[~2023-04-06 19:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 16:05 [PATCH] parport_pc: don't allow driver for SPARC32 Randy Dunlap
2023-04-06 19:28 ` Sam Ravnborg [this message]
2023-04-06 19:49 ` Maciej W. Rozycki
2023-04-06 19:51 ` Randy Dunlap
2023-04-06 20:32 ` Sam Ravnborg
2023-04-06 21:01 ` Maciej W. Rozycki
2023-04-06 21:31 ` Randy Dunlap
2023-04-07 20:03 ` Sam Ravnborg
2023-04-07 21:01 ` Maciej W. Rozycki
2023-04-07 21:10 ` Randy Dunlap
2023-06-18 23:42 ` Maciej W. Rozycki
2023-06-19 0:23 ` Randy Dunlap
2023-06-19 1:29 ` Maciej W. Rozycki
2023-06-19 2:35 ` Randy Dunlap
2023-06-23 15:33 ` David Miller
2023-06-23 17:22 ` Sam Ravnborg
2023-06-23 19:20 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406192819.GA1527307@ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=macro@orcam.me.uk \
--cc=rdunlap@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.