From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42F2CC6FD1D for ; Fri, 7 Apr 2023 11:32:48 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id A02D141A17 for ; Fri, 7 Apr 2023 11:32:47 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 958979865F7 for ; Fri, 7 Apr 2023 11:32:47 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 8E2CF983F7B; Fri, 7 Apr 2023 11:32:47 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 7F1F29865D8 for ; Fri, 7 Apr 2023 11:32:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: wk80wm8YO4--b-0G-u8Hvg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680867160; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4CaufME2mCrPd6rGoC7bssgbcqUZZLFly/vo+i5ftUQ=; b=2GE8bEmCT+LVxL1S//dmxfP7gIbQ39aWQ0gu7ql8hFf7lK+59oXHH3bwQWcbJWMIyI Vzou0xrlHkngyUJVKepq4ruC6gLLxVigzyjfJs37r7KofjmcnU1RoIYaHSEhd3g9zpb0 sQRtczBwv/36Ti4iQM6IkL8Fycx7TKkY1BXRAXIy2Cshm1mst0p5uIAdlr/cMZy3TlYW AlTFCIeKFRsnU48ktttHgxJfM4+eMXoPMgp04BX6fRF0rUHzANYmtxl8M9b5ciiAl3at rmyr53WK++odl3qAlhR/AezXF5ENANGoEmYa0oDNXz+O53qoxUIEDrDqFi3BEsqONbIh n5IQ== X-Gm-Message-State: AAQBX9f3X68WqclnP9HGKvMBs9rUIUeX2O6TvfY+xpqjQXeCx80ctVZ2 ZRASXIVbXfszVpp900cl1+X2ho0WvpVL4KfCLtUDoEVdRiLnunhM9cnZM/AypWZ9/IVrGsV4IR2 BhMMy4b/zG+CcUed/PjosytXMVKbUI3oOsg== X-Received: by 2002:a05:600c:2943:b0:3ed:b4e8:630f with SMTP id n3-20020a05600c294300b003edb4e8630fmr1089016wmd.10.1680867159868; Fri, 07 Apr 2023 04:32:39 -0700 (PDT) X-Google-Smtp-Source: AKy350ZHcIuLc7Gwhne2myaNQ/5rib+535JHfabvrXi4KYaX1yZoDpHNY0tOJQWqN46Mxn5HlvyahA== X-Received: by 2002:a05:600c:2943:b0:3ed:b4e8:630f with SMTP id n3-20020a05600c294300b003edb4e8630fmr1089003wmd.10.1680867159585; Fri, 07 Apr 2023 04:32:39 -0700 (PDT) Date: Fri, 7 Apr 2023 07:32:36 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "pasic@linux.ibm.com" , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler Message-ID: <20230407073027-mutt-send-email-mst@kernel.org> References: <20230405010657.612529-1-parav@nvidia.com> <20230405010657.612529-11-parav@nvidia.com> <20230405051637-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-comment] RE: [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id On Wed, Apr 05, 2023 at 01:02:24PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 5, 2023 5:18 AM > > > following format for \field{command-specific-data}: > > > \begin{lstlisting} > > > +struct rss_rq_id { > > > + le16 vqn_1_16: 15; /* Bits 1 to 16 of the vq index */ > > > > Do you want to then call this vq_index_1_16 ? > Yes. will change. > > > And in the comment I would just write virtqueue index. > > > Why do you prefer longer to name here instead of abbreviation? Eschew abbreviation is standard advice for writers. Full names reduce the cognitive load - reader has less terms to remember to be able to understand the spec. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E104C6FD1D for ; Fri, 7 Apr 2023 11:32:43 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id DB4E22B142 for ; Fri, 7 Apr 2023 11:32:42 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C60C19865D9 for ; Fri, 7 Apr 2023 11:32:42 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id B47EF983F7B; Fri, 7 Apr 2023 11:32:42 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id A41E39865D7 for ; Fri, 7 Apr 2023 11:32:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: MblvIQCnMAuny2Aoq7FWCg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680867160; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4CaufME2mCrPd6rGoC7bssgbcqUZZLFly/vo+i5ftUQ=; b=rkGHv4E7pUXFLD0qdIFEsztgzOQ1LDVgVrb/dfxoHYJbLkj/HXyJfcWnFcTL538pJl Mipb8LTXwYIkwVfBRu2iaweNughR5IfZBQ1juNkBy8ZPYpTeiGWNiNi9jDFv7OSR9F+J GRf7It+imcfQHPSuLp6C3GynBQ/4YJ0Dxh5XuClDvp9Sr8PZExqUCphG17p+ZuY+z3S/ gVOLD8Lze+Yom2pOeYEC/oW+JdJyLa442V7D3uvqEk06wtqkr5sAFb0tRpck8g8iN797 mTOIyD0dPgL7YbeYQq8qq95bMpz4K5ti3HWBuLXfFdrbQpTRbuDofGkm3A9MvyPTfpau 30kQ== X-Gm-Message-State: AAQBX9dJ0z1XwsdgpxVHgkt22M/V6j/zH2XM5kPW5m+utGKHhjcZONLX 5fdgj+PIxhwkZtkEI+lfiXC8ckPCIbIOgh4lx3dBLhArErikaB+42hpZaYihrlW/bBy1jI2StIE DewDJcCy8shWvgAww/bqFTAQ2Bbqb X-Received: by 2002:a05:600c:2943:b0:3ed:b4e8:630f with SMTP id n3-20020a05600c294300b003edb4e8630fmr1089017wmd.10.1680867159868; Fri, 07 Apr 2023 04:32:39 -0700 (PDT) X-Google-Smtp-Source: AKy350ZHcIuLc7Gwhne2myaNQ/5rib+535JHfabvrXi4KYaX1yZoDpHNY0tOJQWqN46Mxn5HlvyahA== X-Received: by 2002:a05:600c:2943:b0:3ed:b4e8:630f with SMTP id n3-20020a05600c294300b003edb4e8630fmr1089003wmd.10.1680867159585; Fri, 07 Apr 2023 04:32:39 -0700 (PDT) Date: Fri, 7 Apr 2023 07:32:36 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , "sgarzare@redhat.com" , "pasic@linux.ibm.com" , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler Message-ID: <20230407073027-mutt-send-email-mst@kernel.org> References: <20230405010657.612529-1-parav@nvidia.com> <20230405010657.612529-11-parav@nvidia.com> <20230405051637-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] RE: [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id On Wed, Apr 05, 2023 at 01:02:24PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 5, 2023 5:18 AM > > > following format for \field{command-specific-data}: > > > \begin{lstlisting} > > > +struct rss_rq_id { > > > + le16 vqn_1_16: 15; /* Bits 1 to 16 of the vq index */ > > > > Do you want to then call this vq_index_1_16 ? > Yes. will change. > > > And in the comment I would just write virtqueue index. > > > Why do you prefer longer to name here instead of abbreviation? Eschew abbreviation is standard advice for writers. Full names reduce the cognitive load - reader has less terms to remember to be able to understand the spec. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org