From: Anatolij Gustschin <agust@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>
Subject: Re: [PATCH] sandbox: video: Fix building without SDL
Date: Fri, 7 Apr 2023 21:58:26 +0200 [thread overview]
Message-ID: <20230407215826.65e6807b@crub> (raw)
In-Reply-To: <20230217224547.1647994-1-sjg@chromium.org>
On Fri, 17 Feb 2023 15:45:47 -0700
Simon Glass sjg@chromium.org wrote:
> This is currently broken. If SDL is not installed, SANDBOX_SDL becomes
> false and build errors are generated, e.g.:
>
> test/dm/video.c:424: undefined reference to `sandbox_sdl_set_bpp'
>
> Fix it by making the function return an error in this case.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> arch/sandbox/include/asm/test.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied to u-boot-video/master, thanks!
--
Anatolij
prev parent reply other threads:[~2023-04-07 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 22:45 [PATCH] sandbox: video: Fix building without SDL Simon Glass
2023-04-07 19:58 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407215826.65e6807b@crub \
--to=agust@denx.de \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.