From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: "eperezma@redhat.com" <eperezma@redhat.com>,
"viktor@daynix.com" <viktor@daynix.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio-vdpa: add VIRTIO_F_NOTIFICATION_DATA feature support
Date: Sat, 8 Apr 2023 04:57:12 -0400 [thread overview]
Message-ID: <20230408045648-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <AM0PR04MB4723451039675B61F723B1C6D4979@AM0PR04MB4723.eurprd04.prod.outlook.com>
On Sat, Apr 08, 2023 at 07:32:52AM +0000, Alvaro Karsz wrote:
> > Hmm so I conclude that drivers without kick_vq_with_data
> > should not accept VIRTIO_F_NOTIFICATION_DATA then?
>
> Yes, vDPA drivers without kick_vq_with_data should not offer VIRTIO_F_NOTIFICATION_DATA in the first place.
>
> We can be more forgiving in such cases and clear the feature bit + print a warning.
> It may be easier to debug when creating a new vDPA driver.
No need to warn I think, it might not be mandatory.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2023-04-08 8:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 8:10 [PATCH] virtio-vdpa: add VIRTIO_F_NOTIFICATION_DATA feature support Alvaro Karsz
2023-04-04 5:09 ` Jason Wang
2023-04-04 7:20 ` Alvaro Karsz
2023-04-04 8:05 ` Jason Wang
2023-04-04 8:16 ` Alvaro Karsz
2023-04-08 6:37 ` Michael S. Tsirkin
2023-04-08 7:32 ` Alvaro Karsz
2023-04-08 8:57 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408045648-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=eperezma@redhat.com \
--cc=viktor@daynix.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.