From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, senozhatsky@chromium.org,
minchan@kernel.org, axboe@kernel.dk, hch@lst.de
Subject: Re: + zram-fix-synchronous-reads-fix.patch added to mm-unstable branch
Date: Sat, 8 Apr 2023 17:15:56 +0900 [thread overview]
Message-ID: <20230408081556.GB12892@google.com> (raw)
In-Reply-To: <20230407221754.E8045C433D2@smtp.kernel.org>
On (23/04/07 15:17), Andrew Morton wrote:
>
> turns out this doesn't even compile for PAGE_SIZE > 4096.
>
> Below is the fix, which also removes the #if and instead relies
> on compiler dead code elimination. I wonder if zram should (maybe
> optionally) also offer a 512 byte block size, so that we could
> also test the smaller than page size I/O path even on x86.
>
> Link: https://lkml.kernel.org/r/20230407072224.GA8982@lst.de
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2023-04-08 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 22:17 + zram-fix-synchronous-reads-fix.patch added to mm-unstable branch Andrew Morton
2023-04-08 8:15 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408081556.GB12892@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.