From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Ahmed Zaki <ahmed.zaki@intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net v2 1/2] iavf: refactor VLAN filter states
Date: Sun, 9 Apr 2023 13:40:46 +0300 [thread overview]
Message-ID: <20230409104046.GO14869@unreal> (raw)
In-Reply-To: <20230407210730.3046149-2-anthony.l.nguyen@intel.com>
On Fri, Apr 07, 2023 at 02:07:29PM -0700, Tony Nguyen wrote:
> From: Ahmed Zaki <ahmed.zaki@intel.com>
>
> The VLAN filter states are currently being saved as individual bits.
> This is error prone as multiple bits might be mistakenly set.
>
> Fix by replacing the bits with a single state enum. Also, add an
> "ACTIVE" state for filters that are accepted by the PF.
>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf.h | 15 +++++----
> drivers/net/ethernet/intel/iavf/iavf_main.c | 8 ++---
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 31 +++++++++----------
> 3 files changed, 28 insertions(+), 26 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-04-09 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 21:07 [PATCH net v2 0/2][pull request] iavf: fix racing in VLANs Tony Nguyen
2023-04-07 21:07 ` [PATCH net v2 1/2] iavf: refactor VLAN filter states Tony Nguyen
2023-04-09 10:40 ` Leon Romanovsky [this message]
2023-04-07 21:07 ` [PATCH net v2 2/2] iavf: remove active_cvlans and active_svlans bitmaps Tony Nguyen
2023-04-09 10:40 ` Leon Romanovsky
2023-04-12 4:40 ` [PATCH net v2 0/2][pull request] iavf: fix racing in VLANs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230409104046.GO14869@unreal \
--to=leon@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.