All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Cai Huoqing" <cai.huoqing@linux.dev>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Rob Herring" <robh@kernel.org>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
	"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
	linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v3 02/10] PCI: dwc: Fix inbound iATU entries out-of-bounds warning message
Date: Tue, 11 Apr 2023 16:35:07 +0530	[thread overview]
Message-ID: <20230411110507.GD5333@thinkpad> (raw)
In-Reply-To: <20230411033928.30397-3-Sergey.Semin@baikalelectronics.ru>

On Tue, Apr 11, 2023 at 06:39:20AM +0300, Serge Semin wrote:
> The message is printed if the number of requested inbound iATU windows
> exceed the device capability. In that case the message should either refer
> to the "dma-ranges" DT property or to the DMA-ranges mapping. We suggest
> to use the later version as a counterpart to the just CPU-ranges mapping.
> In any case the current "Dma-ranges" phrase seems incorrect.
> 
> Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>  drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 9952057c8819..5718b4bb67f0 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -723,7 +723,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
>  	}
>  
>  	if (pci->num_ib_windows <= i)
> -		dev_warn(pci->dev, "Dma-ranges exceed inbound iATU size (%u)\n",
> +		dev_warn(pci->dev, "DMA-ranges exceed inbound iATU size (%u)\n",
>  			 pci->num_ib_windows);
>  
>  	return 0;
> -- 
> 2.40.0
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

  reply	other threads:[~2023-04-11 11:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  3:39 [PATCH RESEND v3 00/10] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
2023-04-11  3:39 ` [PATCH RESEND v3 01/10] PCI: dwc: Fix erroneous version type test helper Serge Semin
2023-04-11 11:04   ` Manivannan Sadhasivam
2023-04-11  3:39 ` [PATCH RESEND v3 02/10] PCI: dwc: Fix inbound iATU entries out-of-bounds warning message Serge Semin
2023-04-11 11:05   ` Manivannan Sadhasivam [this message]
2023-04-11  3:39 ` [PATCH RESEND v3 03/10] PCI: bt1: Enable async probe type Serge Semin
2023-04-11 11:05   ` Manivannan Sadhasivam
2023-04-11  3:39 ` [PATCH RESEND v3 04/10] PCI: bt1: Fix printing false error message Serge Semin
2023-04-11 11:06   ` Manivannan Sadhasivam
2023-04-11  3:39 ` [PATCH RESEND v3 05/10] PCI: dwc: Drop duplicated fast-link-mode flag unsetting Serge Semin
2023-04-11 11:09   ` Manivannan Sadhasivam
2023-04-11  3:39 ` [PATCH RESEND v3 06/10] PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() Serge Semin
2023-04-11 11:09   ` Manivannan Sadhasivam
2023-04-11  3:39 ` [PATCH RESEND v3 07/10] PCI: visconti: Convert to using generic resources getter Serge Semin
2023-04-11  3:39   ` Serge Semin
2023-04-11 11:19   ` Manivannan Sadhasivam
2023-04-11 11:19     ` Manivannan Sadhasivam
2023-04-11 17:10     ` Serge Semin
2023-04-11 17:10       ` Serge Semin
2023-04-11  3:39 ` [PATCH RESEND v3 08/10] MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas Serge Semin
2023-04-11 11:20   ` Manivannan Sadhasivam
2023-04-11  3:39 ` [PATCH RESEND v3 09/10] MAINTAINERS: Add myself as the DW PCIe core reviewer Serge Semin
2023-04-11 11:24   ` Manivannan Sadhasivam
2023-04-11 17:16     ` Serge Semin
2023-04-11  3:39 ` [PATCH RESEND v3 10/10] MAINTAINERS: Add myself as the DW eDMA driver reviewer Serge Semin
2023-04-11 11:25   ` Manivannan Sadhasivam
2023-04-11 11:02 ` [PATCH RESEND v3 00/10] PCI: dwc: Relatively simple fixes and cleanups Manivannan Sadhasivam
2023-04-11 16:59   ` Serge Semin
2023-04-12 16:58     ` Vinod Koul
2023-04-13 13:34       ` Serge Semin
2023-04-13 14:00         ` Manivannan Sadhasivam
2023-04-14  0:25           ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411110507.GD5333@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=bhelgaas@google.com \
    --cc=cai.huoqing@linux.dev \
    --cc=dmaengine@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.