All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [tzungbi-chrome-platform:for-next 4/4] drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Tue, 11 Apr 2023 13:14:49 +0800	[thread overview]
Message-ID: <202304111306.f3AWxKuA-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git for-next
head:   4696f24c5655dafc277c778bc7c20812bd72d44b
commit: 4696f24c5655dafc277c778bc7c20812bd72d44b [4/4] platform/chrome: cros_ec: Separate logic for getting panic info
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230411/202304111306.f3AWxKuA-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git/commit/?id=4696f24c5655dafc277c778bc7c20812bd72d44b
        git remote add tzungbi-chrome-platform https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git
        git fetch --no-tags tzungbi-chrome-platform for-next
        git checkout 4696f24c5655dafc277c778bc7c20812bd72d44b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/platform/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304111306.f3AWxKuA-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Returns the size of the panicinfo data fetched from the EC


vim +404 drivers/platform/chrome/cros_ec_debugfs.c

   402	
   403	/**
 > 404	 * Returns the size of the panicinfo data fetched from the EC
   405	 */
   406	static int cros_ec_get_panicinfo(struct cros_ec_device *ec_dev, uint8_t *data,
   407					 int data_size)
   408	{
   409		int ret;
   410		struct cros_ec_command *msg;
   411	
   412		if (!data || data_size <= 0 || data_size > ec_dev->max_response)
   413			return -EINVAL;
   414	
   415		msg = kzalloc(sizeof(*msg) + data_size, GFP_KERNEL);
   416		if (!msg)
   417			return -ENOMEM;
   418	
   419		msg->command = EC_CMD_GET_PANIC_INFO;
   420		msg->insize = data_size;
   421	
   422		ret = cros_ec_cmd_xfer_status(ec_dev, msg);
   423		if (ret < 0)
   424			goto free;
   425	
   426		memcpy(data, msg->data, data_size);
   427	
   428	free:
   429		kfree(msg);
   430		return ret;
   431	}
   432	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

             reply	other threads:[~2023-04-11  5:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  5:14 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-11  6:26 [tzungbi-chrome-platform:for-next 4/4] drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202304111306.f3AWxKuA-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.