From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
bhelgaas@google.com, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lpieralisi@kernel.org
Subject: Re: [PATCH] Revert "dt-bindings: PCI: qcom: Add iommu-map properties"
Date: Wed, 12 Apr 2023 00:12:31 +0530 [thread overview]
Message-ID: <20230411184231.GA59982@thinkpad> (raw)
In-Reply-To: <20230411174742.GA3428751-robh@kernel.org>
On Tue, Apr 11, 2023 at 12:47:42PM -0500, Rob Herring wrote:
> On Tue, Apr 11, 2023 at 05:45:33PM +0530, Manivannan Sadhasivam wrote:
> > This reverts commit 6ebfa40b63ae65eac20834ef4f45355fc5ef6899.
> >
> > "iommu-map" property is already documented in commit
>
> Need the commit hash here.
>
> > ("dt-bindings: PCI: qcom: Add SM8550 compatible") along with the "iommus"
> > property.
>
> Shouldn't there be a patch removing "iommus" as discussed?
>
Yeah, that was my intention after the dts patches were merged. And since the
dts patches are in linux-next now, I could finally send the patch.
- Mani
> >
> > So let's revert the commit that just added "iommu-map" to avoid
> > duplication.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index 5d236bac99b6..a1318a4ecadf 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -78,8 +78,6 @@ properties:
> >
> > dma-coherent: true
> >
> > - iommu-map: true
> > -
> > interconnects:
> > maxItems: 2
> >
> > --
> > 2.25.1
> >
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-04-11 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 12:15 [PATCH] Revert "dt-bindings: PCI: qcom: Add iommu-map properties" Manivannan Sadhasivam
2023-04-11 16:36 ` Lorenzo Pieralisi
2023-04-11 17:47 ` Rob Herring
2023-04-11 18:42 ` Manivannan Sadhasivam [this message]
2023-04-12 8:15 ` Lorenzo Pieralisi
2023-04-12 10:11 ` Manivannan Sadhasivam
2023-04-12 10:46 ` Lorenzo Pieralisi
2023-04-12 11:29 ` Manivannan Sadhasivam
2023-04-12 13:27 ` Lorenzo Pieralisi
2023-04-12 14:23 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411184231.GA59982@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.