From: Chris Leech <cleech@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Lee Duncan <leeman.duncan@gmail.com>,
linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
netdev@vger.kernel.org, Lee Duncan <lduncan@suse.com>
Subject: Re: [RFC PATCH 2/9] iscsi: associate endpoints with a host
Date: Tue, 11 Apr 2023 19:31:25 -0700 [thread overview]
Message-ID: <20230412023125.GA1777710@localhost> (raw)
In-Reply-To: <a9f8cc4f-5d60-be5e-d294-c4a9baa16ec4@suse.de>
On Tue, Mar 14, 2023 at 05:23:26PM +0100, Hannes Reinecke wrote:
> On 2/8/23 18:40, Lee Duncan wrote:
> > From: Lee Duncan <lduncan@suse.com>
> > @@ -230,6 +230,7 @@ iscsi_create_endpoint(int dd_size)
> > ep->id = id;
> > ep->dev.class = &iscsi_endpoint_class;
> > + ep->dev.parent = &shost->shost_gendev;
> > dev_set_name(&ep->dev, "ep-%d", id);
> > err = device_register(&ep->dev);
> > if (err)
>
> Umm... doesn't this change the sysfs layout?
> IE won't the endpoint node be moved under the Scsi_Host directory?
>
> But even if it does: do we care?
It does, but it shouldn't matter. The Open-iSCSI tools look under the
subsystem, not the device path. Being a child of the host makes more
sense then being a floating virtual device.
I just re-tested with bnx2i to make sure moving an endpoint devpath in
sysfs didn't break anything.
- Chris
next prev parent reply other threads:[~2023-04-12 2:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:40 [RFC 0/9] Make iscsid-kernel communications namespace-aware Lee Duncan
2023-02-08 17:40 ` [RFC PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets Lee Duncan
2023-03-14 16:21 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 2/9] iscsi: associate endpoints with a host Lee Duncan
2023-03-14 16:23 ` Hannes Reinecke
2023-03-17 21:42 ` Lee Duncan
2023-04-12 2:31 ` Chris Leech [this message]
2023-04-20 16:42 ` Chris Leech
2023-04-21 5:05 ` Chris Leech
2023-04-21 5:05 ` [PATCH] iscsi iser: fix iser, allow virtual endpoints again Chris Leech
2023-04-21 5:05 ` [PATCH] iscsi iser: direct network namespace support for endpoints Chris Leech
2023-04-21 5:05 ` [PATCH] iscsi iser: enable network namespace awareness in iser Chris Leech
2023-02-08 17:40 ` [RFC PATCH 3/9] iscsi: sysfs filtering by network namespace Lee Duncan
2023-03-14 16:24 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware Lee Duncan
2023-03-14 16:27 ` Hannes Reinecke
2023-04-10 19:10 ` Chris Leech
2023-04-11 6:22 ` Hannes Reinecke
2023-04-10 19:10 ` [PATCH 10/11] iscsi: make session and connection lists per-net Chris Leech
2023-04-11 6:17 ` Hannes Reinecke
2023-04-10 19:10 ` [PATCH 11/11] iscsi: force destroy sesions when a network namespace exits Chris Leech
2023-04-11 6:21 ` Hannes Reinecke
2023-04-11 18:19 ` Chris Leech
2023-04-12 6:02 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 5/9] iscsi: set netns for iscsi_tcp hosts Lee Duncan
2023-03-14 16:29 ` Hannes Reinecke
2023-04-11 0:21 ` Chris Leech
2023-04-11 6:58 ` Hannes Reinecke
2023-04-11 18:03 ` Chris Leech
2023-02-08 17:40 ` [RFC PATCH 6/9] iscsi: check net namespace for all iscsi lookup Lee Duncan
2023-03-14 17:44 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 7/9] iscsi: convert flashnode devices from bus to class Lee Duncan
2023-03-14 17:45 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_* Lee Duncan
2023-03-14 17:46 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 9/9] iscsi: filter flashnode sysfs by net namespace Lee Duncan
2023-03-14 17:47 ` Hannes Reinecke
2023-02-08 19:23 ` [RFC 0/9] Make iscsid-kernel communications namespace-aware (resent) Lee Duncan
2023-03-14 16:20 ` [RFC 0/9] Make iscsid-kernel communications namespace-aware Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412023125.GA1777710@localhost \
--to=cleech@redhat.com \
--cc=hare@suse.de \
--cc=lduncan@suse.com \
--cc=leeman.duncan@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.