From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Yosry Ahmed <yosryahmed@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] seq_buf: add seq_buf_do_printk() helper
Date: Wed, 12 Apr 2023 12:07:59 +0900 [thread overview]
Message-ID: <20230412030759.GD25053@google.com> (raw)
In-Reply-To: <20230411224652.576dd18c@gandalf.local.home>
On (23/04/11 22:46), Steven Rostedt wrote:
> > Sometimes we use seq_buf to format a string buffer, which
> > we then pass to printk(). However, in certain situations
> > the seq_buf string buffer can get too big, exceeding the
> > PRINTKRB_RECORD_MAX bytes limit, and causing printk() to
> > truncate the string.
> >
> > Add a new seq_buf helper. This helper prints the seq_buf
> > string buffer line by line, using \n as a delimiter,
> > rather than passing the whole string buffer to printk()
> > at once.
> >
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
>
> Looks good to me. Want me to pull this in my tree, or do you have
> patches dependent on this?
Thanks, would be great if you can pull this in your tree. The MM
patches that Yosry is working on will be posted after the merge
window.
next prev parent reply other threads:[~2023-04-12 3:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 14:38 [PATCHv2] seq_buf: add seq_buf_do_printk() helper Sergey Senozhatsky
2023-04-12 2:46 ` Steven Rostedt
2023-04-12 3:07 ` Sergey Senozhatsky [this message]
2023-04-12 3:14 ` Yosry Ahmed
2023-04-14 9:00 ` Petr Mladek
2023-04-15 7:04 ` Sergey Senozhatsky
2023-04-15 7:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412030759.GD25053@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.