From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B49C77B72 for ; Wed, 12 Apr 2023 07:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbjDLHjy (ORCPT ); Wed, 12 Apr 2023 03:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjDLHjc (ORCPT ); Wed, 12 Apr 2023 03:39:32 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E26DD2 for ; Wed, 12 Apr 2023 00:39:30 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C7053100018; Wed, 12 Apr 2023 07:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17BPQPrbGfoG/9Y+BnpABrCjBoUgqhojyRjXMZSD+8c=; b=PfRltgJ1Ic+5NX5hMrhg2PjLHxVBR8qIDRKeEQUmT9+oRHTMJXbAourYqKl0z5uG6K6TuD DcbxHoMVNnY3Jaol01OwcUCkcakHD+Glp6SQ22R2TPCE/9hINgQfScuE3msXJb6Oh7Xp4P owEbhQEurMr67d639FR00rh9BlpPievAzMuoB08vtA3/wG/Fzy4Cs3uW1hTpo0kSe5Jyw7 s5zTNYiRtFxhVC9GlMqR0idX7pLB09VCPy9d06roQ5swBkAHoUb2jJARoVWH4n8elGKeFh WT7MW9yG9I2DFhK9bjqwgwms9dnr1Zx+Y1XIcGWbqYGXb+jR7fC+eIl9mO/n6g== Date: Wed, 12 Apr 2023 09:39:25 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Message-ID: <20230412093925.4718ac6f@xps-13> In-Reply-To: <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:57 +0300: > With this chip, buffer length is limited by hardware, so check it before > command execution to avoid length trim. What is "this chip"? Are you talking about the controller itself? Is there any specific SoC version targeted? >=20 > Signed-off-by: Arseniy Krasnov > --- > drivers/mtd/nand/raw/meson_nand.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index 45b53d420aed..f84a10238e4d 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -543,6 +543,9 @@ static int meson_nfc_read_buf(struct nand_chip *nand,= u8 *buf, int len) > u32 cmd; > u8 *info; > =20 > + if (len > NFC_CMD_RAW_LEN) > + return -EINVAL; > + > info =3D kzalloc(PER_INFO_BYTE, GFP_KERNEL); > if (!info) > return -ENOMEM; > @@ -571,6 +574,9 @@ static int meson_nfc_write_buf(struct nand_chip *nand= , u8 *buf, int len) > int ret =3D 0; > u32 cmd; > =20 > + if (len > NFC_CMD_RAW_LEN) > + return -EINVAL; > + > ret =3D meson_nfc_dma_buffer_setup(nand, buf, len, NULL, > 0, DMA_TO_DEVICE); > if (ret) > @@ -1269,6 +1275,7 @@ static int meson_nand_attach_chip(struct nand_chip = *nand) > struct meson_nfc_nand_chip *meson_chip =3D to_meson_nand(nand); > struct mtd_info *mtd =3D nand_to_mtd(nand); > int nsectors =3D mtd->writesize / 1024; > + int raw_writesize; > int ret; > =20 > if (!mtd->name) { > @@ -1280,6 +1287,13 @@ static int meson_nand_attach_chip(struct nand_chip= *nand) > return -ENOMEM; > } > =20 > + raw_writesize =3D mtd->writesize + mtd->oobsize; > + if (raw_writesize > NFC_CMD_RAW_LEN) { > + dev_err(nfc->dev, "too big write size in raw mode: %d > %ld\n", > + raw_writesize, NFC_CMD_RAW_LEN); > + return -EINVAL; > + } > + > if (nand->bbt_options & NAND_BBT_USE_FLASH) > nand->bbt_options |=3D NAND_BBT_NO_OOB; > =20 Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F2EBC77B6E for ; Wed, 12 Apr 2023 07:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w/xiQSeGOJMUa5piSgIgqlIC7IIA4x1YZz2MXBm4iz4=; b=pkgXF7OzTZigBn ARJ6qyXi3A2bxlMnbTtTNAbVckw5n2TfNT0OUB0vUFcIAmGS2cuu4OV5J/7Wo4tEkD3uqfZjwoavu i1kvH3mOnBgD44CAzhx7XUiiFoTPX1KJ5q80f+wMmkWOFP5uphZvUC7DSROPm4Wiya9BhPEuPvO96 TbK4FiUF6qlV3bB5QR60xZV+xMoTp3g0buTDLMy/17HsVUJFSS6Jj4g8tZBsm4BXOOKinBrb3R5XH pgBXj1vETqIri/KhtnZ9myttV4XHtqZD+IftVXS/NGYeBT1/H5jyJNT9oc+8VUN7yPIrcM+ZDHg4D ZUuIT2tLXJ7x7enrmCUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmV4x-0027Hw-25; Wed, 12 Apr 2023 07:39:43 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmV4u-0027FL-1e; Wed, 12 Apr 2023 07:39:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C7053100018; Wed, 12 Apr 2023 07:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17BPQPrbGfoG/9Y+BnpABrCjBoUgqhojyRjXMZSD+8c=; b=PfRltgJ1Ic+5NX5hMrhg2PjLHxVBR8qIDRKeEQUmT9+oRHTMJXbAourYqKl0z5uG6K6TuD DcbxHoMVNnY3Jaol01OwcUCkcakHD+Glp6SQ22R2TPCE/9hINgQfScuE3msXJb6Oh7Xp4P owEbhQEurMr67d639FR00rh9BlpPievAzMuoB08vtA3/wG/Fzy4Cs3uW1hTpo0kSe5Jyw7 s5zTNYiRtFxhVC9GlMqR0idX7pLB09VCPy9d06roQ5swBkAHoUb2jJARoVWH4n8elGKeFh WT7MW9yG9I2DFhK9bjqwgwms9dnr1Zx+Y1XIcGWbqYGXb+jR7fC+eIl9mO/n6g== Date: Wed, 12 Apr 2023 09:39:25 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Message-ID: <20230412093925.4718ac6f@xps-13> In-Reply-To: <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_003940_831232_B5999EA7 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDA5OjE2OjU3ICswMzAwOgoKPiBXaXRoIHRoaXMgY2hpcCwgYnVmZmVyIGxlbmd0aCBp cyBsaW1pdGVkIGJ5IGhhcmR3YXJlLCBzbyBjaGVjayBpdCBiZWZvcmUKPiBjb21tYW5kIGV4ZWN1 dGlvbiB0byBhdm9pZCBsZW5ndGggdHJpbS4KCldoYXQgaXMgInRoaXMgY2hpcCI/IEFyZSB5b3Ug dGFsa2luZyBhYm91dCB0aGUgY29udHJvbGxlciBpdHNlbGY/IElzCnRoZXJlIGFueSBzcGVjaWZp YyBTb0MgdmVyc2lvbiB0YXJnZXRlZD8KCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJzZW5peSBLcmFz bm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYyB8IDE0ICsrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IDQ1 YjUzZDQyMGFlZC4uZjg0YTEwMjM4ZTRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+IEBAIC01NDMsNiArNTQzLDkgQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9idWYoc3Ry dWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1ZiwgaW50IGxlbikKPiAgCXUzMiBjbWQ7Cj4gIAl1 OCAqaW5mbzsKPiAgCj4gKwlpZiAobGVuID4gTkZDX0NNRF9SQVdfTEVOKQo+ICsJCXJldHVybiAt RUlOVkFMOwo+ICsKPiAgCWluZm8gPSBremFsbG9jKFBFUl9JTkZPX0JZVEUsIEdGUF9LRVJORUwp Owo+ICAJaWYgKCFpbmZvKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+IEBAIC01NzEsNiArNTc0LDkg QEAgc3RhdGljIGludCBtZXNvbl9uZmNfd3JpdGVfYnVmKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQs IHU4ICpidWYsIGludCBsZW4pCj4gIAlpbnQgcmV0ID0gMDsKPiAgCXUzMiBjbWQ7Cj4gIAo+ICsJ aWYgKGxlbiA+IE5GQ19DTURfUkFXX0xFTikKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gIAly ZXQgPSBtZXNvbl9uZmNfZG1hX2J1ZmZlcl9zZXR1cChuYW5kLCBidWYsIGxlbiwgTlVMTCwKPiAg CQkJCQkgMCwgRE1BX1RPX0RFVklDRSk7Cj4gIAlpZiAocmV0KQo+IEBAIC0xMjY5LDYgKzEyNzUs NyBAQCBzdGF0aWMgaW50IG1lc29uX25hbmRfYXR0YWNoX2NoaXAoc3RydWN0IG5hbmRfY2hpcCAq bmFuZCkKPiAgCXN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwICptZXNvbl9jaGlwID0gdG9fbWVz b25fbmFuZChuYW5kKTsKPiAgCXN0cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFu ZCk7Cj4gIAlpbnQgbnNlY3RvcnMgPSBtdGQtPndyaXRlc2l6ZSAvIDEwMjQ7Cj4gKwlpbnQgcmF3 X3dyaXRlc2l6ZTsKPiAgCWludCByZXQ7Cj4gIAo+ICAJaWYgKCFtdGQtPm5hbWUpIHsKPiBAQCAt MTI4MCw2ICsxMjg3LDEzIEBAIHN0YXRpYyBpbnQgbWVzb25fbmFuZF9hdHRhY2hfY2hpcChzdHJ1 Y3QgbmFuZF9jaGlwICpuYW5kKQo+ICAJCQlyZXR1cm4gLUVOT01FTTsKPiAgCX0KPiAgCj4gKwly YXdfd3JpdGVzaXplID0gbXRkLT53cml0ZXNpemUgKyBtdGQtPm9vYnNpemU7Cj4gKwlpZiAocmF3 X3dyaXRlc2l6ZSA+IE5GQ19DTURfUkFXX0xFTikgewo+ICsJCWRldl9lcnIobmZjLT5kZXYsICJ0 b28gYmlnIHdyaXRlIHNpemUgaW4gcmF3IG1vZGU6ICVkID4gJWxkXG4iLAo+ICsJCQlyYXdfd3Jp dGVzaXplLCBORkNfQ01EX1JBV19MRU4pOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsK PiAgCWlmIChuYW5kLT5iYnRfb3B0aW9ucyAmIE5BTkRfQkJUX1VTRV9GTEFTSCkKPiAgCQluYW5k LT5iYnRfb3B0aW9ucyB8PSBOQU5EX0JCVF9OT19PT0I7Cj4gIAoKClRoYW5rcywKTWlxdcOobAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1s b2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 405B3C7619A for ; Wed, 12 Apr 2023 07:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6PelKavs9DRD1vAp1zS4bQIYUOD/weXM+OlYW14wyMA=; b=DyYCrv4/gpCK5S m3VYzFrFd3gbjcpu4JZ55jdf218TWS1dECix8hiUKlnAevggxUmMdAlw4f2IlHaAuAH6GLW1U9u6v uZeOlfMVJhEcmr3rED/cwGdjWuinebg5cLlbwW7kcT7l2CteJYZYFSh+UaMqHcXWHhLNkWd0Ajoul ZXQ+bFm95RwXwl2NuQ+ez03qBobBuxx+bCAgkwEDd1hzibOgi0qk8qEbSwplaLFSGJQFr+7t14e94 Li/cb6PrbF0mvmJmg9JY31B/iAxxD1oGfGAawW/ek9Shu4eRPGNQGg8JIvnYyB7STMIPpILYPx1SE XptHlqFz5ApGUsvh90uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmV4z-0027Ia-0E; Wed, 12 Apr 2023 07:39:45 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmV4u-0027FL-1e; Wed, 12 Apr 2023 07:39:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C7053100018; Wed, 12 Apr 2023 07:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17BPQPrbGfoG/9Y+BnpABrCjBoUgqhojyRjXMZSD+8c=; b=PfRltgJ1Ic+5NX5hMrhg2PjLHxVBR8qIDRKeEQUmT9+oRHTMJXbAourYqKl0z5uG6K6TuD DcbxHoMVNnY3Jaol01OwcUCkcakHD+Glp6SQ22R2TPCE/9hINgQfScuE3msXJb6Oh7Xp4P owEbhQEurMr67d639FR00rh9BlpPievAzMuoB08vtA3/wG/Fzy4Cs3uW1hTpo0kSe5Jyw7 s5zTNYiRtFxhVC9GlMqR0idX7pLB09VCPy9d06roQ5swBkAHoUb2jJARoVWH4n8elGKeFh WT7MW9yG9I2DFhK9bjqwgwms9dnr1Zx+Y1XIcGWbqYGXb+jR7fC+eIl9mO/n6g== Date: Wed, 12 Apr 2023 09:39:25 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Message-ID: <20230412093925.4718ac6f@xps-13> In-Reply-To: <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_003940_831232_B5999EA7 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDA5OjE2OjU3ICswMzAwOgoKPiBXaXRoIHRoaXMgY2hpcCwgYnVmZmVyIGxlbmd0aCBp cyBsaW1pdGVkIGJ5IGhhcmR3YXJlLCBzbyBjaGVjayBpdCBiZWZvcmUKPiBjb21tYW5kIGV4ZWN1 dGlvbiB0byBhdm9pZCBsZW5ndGggdHJpbS4KCldoYXQgaXMgInRoaXMgY2hpcCI/IEFyZSB5b3Ug dGFsa2luZyBhYm91dCB0aGUgY29udHJvbGxlciBpdHNlbGY/IElzCnRoZXJlIGFueSBzcGVjaWZp YyBTb0MgdmVyc2lvbiB0YXJnZXRlZD8KCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJzZW5peSBLcmFz bm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYyB8IDE0ICsrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IDQ1 YjUzZDQyMGFlZC4uZjg0YTEwMjM4ZTRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+IEBAIC01NDMsNiArNTQzLDkgQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9idWYoc3Ry dWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1ZiwgaW50IGxlbikKPiAgCXUzMiBjbWQ7Cj4gIAl1 OCAqaW5mbzsKPiAgCj4gKwlpZiAobGVuID4gTkZDX0NNRF9SQVdfTEVOKQo+ICsJCXJldHVybiAt RUlOVkFMOwo+ICsKPiAgCWluZm8gPSBremFsbG9jKFBFUl9JTkZPX0JZVEUsIEdGUF9LRVJORUwp Owo+ICAJaWYgKCFpbmZvKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+IEBAIC01NzEsNiArNTc0LDkg QEAgc3RhdGljIGludCBtZXNvbl9uZmNfd3JpdGVfYnVmKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQs IHU4ICpidWYsIGludCBsZW4pCj4gIAlpbnQgcmV0ID0gMDsKPiAgCXUzMiBjbWQ7Cj4gIAo+ICsJ aWYgKGxlbiA+IE5GQ19DTURfUkFXX0xFTikKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gIAly ZXQgPSBtZXNvbl9uZmNfZG1hX2J1ZmZlcl9zZXR1cChuYW5kLCBidWYsIGxlbiwgTlVMTCwKPiAg CQkJCQkgMCwgRE1BX1RPX0RFVklDRSk7Cj4gIAlpZiAocmV0KQo+IEBAIC0xMjY5LDYgKzEyNzUs NyBAQCBzdGF0aWMgaW50IG1lc29uX25hbmRfYXR0YWNoX2NoaXAoc3RydWN0IG5hbmRfY2hpcCAq bmFuZCkKPiAgCXN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwICptZXNvbl9jaGlwID0gdG9fbWVz b25fbmFuZChuYW5kKTsKPiAgCXN0cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFu ZCk7Cj4gIAlpbnQgbnNlY3RvcnMgPSBtdGQtPndyaXRlc2l6ZSAvIDEwMjQ7Cj4gKwlpbnQgcmF3 X3dyaXRlc2l6ZTsKPiAgCWludCByZXQ7Cj4gIAo+ICAJaWYgKCFtdGQtPm5hbWUpIHsKPiBAQCAt MTI4MCw2ICsxMjg3LDEzIEBAIHN0YXRpYyBpbnQgbWVzb25fbmFuZF9hdHRhY2hfY2hpcChzdHJ1 Y3QgbmFuZF9jaGlwICpuYW5kKQo+ICAJCQlyZXR1cm4gLUVOT01FTTsKPiAgCX0KPiAgCj4gKwly YXdfd3JpdGVzaXplID0gbXRkLT53cml0ZXNpemUgKyBtdGQtPm9vYnNpemU7Cj4gKwlpZiAocmF3 X3dyaXRlc2l6ZSA+IE5GQ19DTURfUkFXX0xFTikgewo+ICsJCWRldl9lcnIobmZjLT5kZXYsICJ0 b28gYmlnIHdyaXRlIHNpemUgaW4gcmF3IG1vZGU6ICVkID4gJWxkXG4iLAo+ICsJCQlyYXdfd3Jp dGVzaXplLCBORkNfQ01EX1JBV19MRU4pOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsK PiAgCWlmIChuYW5kLT5iYnRfb3B0aW9ucyAmIE5BTkRfQkJUX1VTRV9GTEFTSCkKPiAgCQluYW5k LT5iYnRfb3B0aW9ucyB8PSBOQU5EX0JCVF9OT19PT0I7Cj4gIAoKClRoYW5rcywKTWlxdcOobAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA07C77B6E for ; Wed, 12 Apr 2023 07:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=03Xjrq8Ezc3h0d/Gehy47v92mUF080BESkddMrP9yZE=; b=kNbezkS2YGmmOb R3dQVg3YUQHZTmK1w6GC81yzKpEa+beaGUnk4Z5FCJiy6rrV0Ak4lQdyMHs/oBsBTXEXGLr7wvu4P enVRiTinivD/DLZmhsSD+9FiQHlaXYSdnthKWbhscpDTTMDbI5cTWBRJ03VTHp7a8gfyS148t2pEB wpz0djyEpfeBSPBLhKP3GHNQzaurBmXXZXi6WuTZ39+kbQ/zXsfRW+GJvJTso3j2njg13EODJ+HW5 s+oPsmw3pVK5QqehUpb+DIgpJYL4o0jSCWPeYvqLlBgksFi7yjYy1CnsjUli4RAQmR5QU88fukzpH deDpFdpfXGlI/X6HDJZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmV4y-0027I6-0F; Wed, 12 Apr 2023 07:39:44 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmV4u-0027FL-1e; Wed, 12 Apr 2023 07:39:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C7053100018; Wed, 12 Apr 2023 07:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17BPQPrbGfoG/9Y+BnpABrCjBoUgqhojyRjXMZSD+8c=; b=PfRltgJ1Ic+5NX5hMrhg2PjLHxVBR8qIDRKeEQUmT9+oRHTMJXbAourYqKl0z5uG6K6TuD DcbxHoMVNnY3Jaol01OwcUCkcakHD+Glp6SQ22R2TPCE/9hINgQfScuE3msXJb6Oh7Xp4P owEbhQEurMr67d639FR00rh9BlpPievAzMuoB08vtA3/wG/Fzy4Cs3uW1hTpo0kSe5Jyw7 s5zTNYiRtFxhVC9GlMqR0idX7pLB09VCPy9d06roQ5swBkAHoUb2jJARoVWH4n8elGKeFh WT7MW9yG9I2DFhK9bjqwgwms9dnr1Zx+Y1XIcGWbqYGXb+jR7fC+eIl9mO/n6g== Date: Wed, 12 Apr 2023 09:39:25 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Message-ID: <20230412093925.4718ac6f@xps-13> In-Reply-To: <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-4-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_003940_831232_B5999EA7 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDA5OjE2OjU3ICswMzAwOgoKPiBXaXRoIHRoaXMgY2hpcCwgYnVmZmVyIGxlbmd0aCBp cyBsaW1pdGVkIGJ5IGhhcmR3YXJlLCBzbyBjaGVjayBpdCBiZWZvcmUKPiBjb21tYW5kIGV4ZWN1 dGlvbiB0byBhdm9pZCBsZW5ndGggdHJpbS4KCldoYXQgaXMgInRoaXMgY2hpcCI/IEFyZSB5b3Ug dGFsa2luZyBhYm91dCB0aGUgY29udHJvbGxlciBpdHNlbGY/IElzCnRoZXJlIGFueSBzcGVjaWZp YyBTb0MgdmVyc2lvbiB0YXJnZXRlZD8KCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJzZW5peSBLcmFz bm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYyB8IDE0ICsrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IDQ1 YjUzZDQyMGFlZC4uZjg0YTEwMjM4ZTRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+IEBAIC01NDMsNiArNTQzLDkgQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9idWYoc3Ry dWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1ZiwgaW50IGxlbikKPiAgCXUzMiBjbWQ7Cj4gIAl1 OCAqaW5mbzsKPiAgCj4gKwlpZiAobGVuID4gTkZDX0NNRF9SQVdfTEVOKQo+ICsJCXJldHVybiAt RUlOVkFMOwo+ICsKPiAgCWluZm8gPSBremFsbG9jKFBFUl9JTkZPX0JZVEUsIEdGUF9LRVJORUwp Owo+ICAJaWYgKCFpbmZvKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+IEBAIC01NzEsNiArNTc0LDkg QEAgc3RhdGljIGludCBtZXNvbl9uZmNfd3JpdGVfYnVmKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQs IHU4ICpidWYsIGludCBsZW4pCj4gIAlpbnQgcmV0ID0gMDsKPiAgCXUzMiBjbWQ7Cj4gIAo+ICsJ aWYgKGxlbiA+IE5GQ19DTURfUkFXX0xFTikKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gIAly ZXQgPSBtZXNvbl9uZmNfZG1hX2J1ZmZlcl9zZXR1cChuYW5kLCBidWYsIGxlbiwgTlVMTCwKPiAg CQkJCQkgMCwgRE1BX1RPX0RFVklDRSk7Cj4gIAlpZiAocmV0KQo+IEBAIC0xMjY5LDYgKzEyNzUs NyBAQCBzdGF0aWMgaW50IG1lc29uX25hbmRfYXR0YWNoX2NoaXAoc3RydWN0IG5hbmRfY2hpcCAq bmFuZCkKPiAgCXN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwICptZXNvbl9jaGlwID0gdG9fbWVz b25fbmFuZChuYW5kKTsKPiAgCXN0cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFu ZCk7Cj4gIAlpbnQgbnNlY3RvcnMgPSBtdGQtPndyaXRlc2l6ZSAvIDEwMjQ7Cj4gKwlpbnQgcmF3 X3dyaXRlc2l6ZTsKPiAgCWludCByZXQ7Cj4gIAo+ICAJaWYgKCFtdGQtPm5hbWUpIHsKPiBAQCAt MTI4MCw2ICsxMjg3LDEzIEBAIHN0YXRpYyBpbnQgbWVzb25fbmFuZF9hdHRhY2hfY2hpcChzdHJ1 Y3QgbmFuZF9jaGlwICpuYW5kKQo+ICAJCQlyZXR1cm4gLUVOT01FTTsKPiAgCX0KPiAgCj4gKwly YXdfd3JpdGVzaXplID0gbXRkLT53cml0ZXNpemUgKyBtdGQtPm9vYnNpemU7Cj4gKwlpZiAocmF3 X3dyaXRlc2l6ZSA+IE5GQ19DTURfUkFXX0xFTikgewo+ICsJCWRldl9lcnIobmZjLT5kZXYsICJ0 b28gYmlnIHdyaXRlIHNpemUgaW4gcmF3IG1vZGU6ICVkID4gJWxkXG4iLAo+ICsJCQlyYXdfd3Jp dGVzaXplLCBORkNfQ01EX1JBV19MRU4pOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsK PiAgCWlmIChuYW5kLT5iYnRfb3B0aW9ucyAmIE5BTkRfQkJUX1VTRV9GTEFTSCkKPiAgCQluYW5k LT5iYnRfb3B0aW9ucyB8PSBOQU5EX0JCVF9OT19PT0I7Cj4gIAoKClRoYW5rcywKTWlxdcOobAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=