From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E22CC7619A for ; Wed, 12 Apr 2023 07:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wa+AjF5SuHqKJQ8BG3X0DLljkUv92Cnm+AXDEr2CLkc=; b=V5XqQnxu1ZWUwI B8GSQ4biqMxSZj1mr4/81dFwZaGc5+pZLR0dsovycN3hcW0kpzNWTZypJfJVC1aGfHzYlN0kB9K/9 8EdTIpjJHncm3JRtr07qHoh9pgsPt0wnvLtGpAP9CShGUfgf6Yi6+rH8SeEHkPjZpa2exN+/dMMtK wTjYWst9PcXDuceZRfpRFcHzicDjeFdszAAC1euhw9IXmUGvsWVRGXv2oHfQYClUsPy2AC62UKd01 S3vIiHVlEGu62hqQwAWKEVQbcZASeyPqxjNDp0uOTp8jIF+RJQhqrRRRVLwJYlltdRoAEE8Uv32q9 ADrHXCK8fGd2Y2VYjlSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmV9G-0028HE-0f; Wed, 12 Apr 2023 07:44:10 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmV9D-0028GH-1i; Wed, 12 Apr 2023 07:44:08 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DF8E310000A; Wed, 12 Apr 2023 07:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ttYY5/+4QqV7NXlfKfRlva9VOIYN8wHJIRXRSp4/nsU=; b=VOWhGv9pQZHkbQZKW1Fo1DPNbnsXCPKJvakyqc1sFhk61XWz+3f33Y8+rOGAsmKHl3Omg1 oyDuNClMrZTwqvJqIFZJ+ZO4J1teqUkK/k2NHKa8oTEvOfvXpBcgKAy9Mbl9UqlUspUVOk 6D944OrPB6zlH8MAxqUON02U8X8Vc1SgY8ak5Qo7LZXNg2CH4oXZdDrEdqVnlbjViA5y39 vctZlBWs1SE/PAf/qlu1KWTu1lWJQfbMkjS0+ulmf/VMSQxqsu1kYP0034hnJ2R4EMWNdX aLk8ETAVrNdfgvWpzBhNrPhYB1a24wCXYaXrXzWrCUfEG7TVfJlYHPgXBr/VZw== Date: Wed, 12 Apr 2023 09:44:00 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094400.3c82f631@xps-13> In-Reply-To: <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_004407_701253_B988B8B5 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDA5OjE2OjU4ICswMzAwOgoKPiBUaGlzIE5BTkQgcmVhZHMgb25seSBmZXcgdXNlcidz IGJ5dGVzIGluIEVDQyBtb2RlIChub3QgZnVsbCBPT0IpLCBzbwoKIlRoaXMgTkFORCByZWFkcyIg ZG9lcyBub3QgbG9vayByaWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8Kbm90IHJl dHJpZXZlIGFsbCB0aGUgT09CIGJ5dGVzLCI/Cgo+IGZpbGwgT09CIGJ1ZmZlciB3aXRoIHplcm9l cyB0byBub3QgcmV0dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFkcwo+IHRvIHVzZXIuCj4g T3RoZXJ3aXNlICduYW5kZHVtcCcgdXRpbGl0eSBwcmludHMgc29tZXRoaW5nIGxpa2UgdGhpcyBm b3IganVzdCBlcmFzZWQKPiBwYWdlOgo+IAo+IC4uLgo+IDB4MDAwMDA3ZjA6IGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gICBPT0IgRGF0YTogZmYgZmYg ZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiAgIE9PQiBEYXRhOiA2 MyAyNyBhZSAwNiAxNiAwYSAyZiBlYiBiYiBkZCA0NiA3NCA0MSA4ZSA4OCA2ZQo+ICAgT09CIERh dGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1IDdlIDI1IGViIDM0IDdjIGZmCj4gICBP T0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIgNDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUK PiAKPiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNl cy5ydT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgNSArKysr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYwo+IGluZGV4IGY4NGExMDIzOGU0ZC4uZjJmMjQ3MmNiNTExIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRk L25hbmQvcmF3L21lc29uX25hbmQuYwo+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQg bWVzb25fbmZjX3JlYWRfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgc3RhdGlj IGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX3JhdyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAq YnVmLAo+ICAJCQkJICAgaW50IG9vYl9yZXF1aXJlZCwgaW50IHBhZ2UpCj4gIHsKPiArCXN0cnVj dCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFuZCk7Cj4gIAl1OCAqb29iX2J1ZiA9IG5h bmQtPm9vYl9wb2k7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQt Pm9vYnNpemUpOwoKSSdtIHN1cnByaXNlZCByYXcgcmVhZHMgZG8gbm90IHJlYWQgdGhlIGVudGly ZSBPT0I/Cgo+ICsKPiAgCXJldCA9IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2Us IDEpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+IEBAIC04ODEsNiArODg0LDggQEAg c3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX2h3ZWNjKHN0cnVjdCBuYW5kX2NoaXAgKm5h bmQsIHU4ICpidWYsCj4gIAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9wb2k7Cj4gIAlpbnQgcmV0 LCBpOwo+ICAKPiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ICsKPiAgCXJl dCA9IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2UsIDApOwo+ICAJaWYgKHJldCkK PiAgCQlyZXR1cm4gcmV0OwoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGlu dXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FE2CC7619A for ; Wed, 12 Apr 2023 07:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pwGVvchMnhfyb85b71jrBBgjCWk0NWuX9TdI816v9xo=; b=PqIlGuS3tPQNeG r3nUMumTOraokszmCN0ewlM0AZOrVSwvzLT3P5D8THuI8d27s71UzT0wvAq+hy2rfmkrzFPViXl9R U280m1GcVMALkFpXYn0bZRCB85SPfFYq1Wi3G30W5g43l3Is7UPBi4HKOIMZ7q9ywP5DAixY0+8Ys adrwQPyfoeJStkkM3uXVy7wAO718aeFChp9lhPO2dcRgRKEl5tBpQnWsxtD7+iZjmDLRgNJ+o/WrT yPyuMly6vQFmqvRKqf9e1WFWCDGab3+lILOS4bTaBmt49iCnSUk/HRhSxaHfUUo+jTSD4jLM13cKR +33Ehk3ek2uB6kPoh0Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmV9I-0028Hm-2l; Wed, 12 Apr 2023 07:44:12 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmV9D-0028GH-1i; Wed, 12 Apr 2023 07:44:08 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DF8E310000A; Wed, 12 Apr 2023 07:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ttYY5/+4QqV7NXlfKfRlva9VOIYN8wHJIRXRSp4/nsU=; b=VOWhGv9pQZHkbQZKW1Fo1DPNbnsXCPKJvakyqc1sFhk61XWz+3f33Y8+rOGAsmKHl3Omg1 oyDuNClMrZTwqvJqIFZJ+ZO4J1teqUkK/k2NHKa8oTEvOfvXpBcgKAy9Mbl9UqlUspUVOk 6D944OrPB6zlH8MAxqUON02U8X8Vc1SgY8ak5Qo7LZXNg2CH4oXZdDrEdqVnlbjViA5y39 vctZlBWs1SE/PAf/qlu1KWTu1lWJQfbMkjS0+ulmf/VMSQxqsu1kYP0034hnJ2R4EMWNdX aLk8ETAVrNdfgvWpzBhNrPhYB1a24wCXYaXrXzWrCUfEG7TVfJlYHPgXBr/VZw== Date: Wed, 12 Apr 2023 09:44:00 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094400.3c82f631@xps-13> In-Reply-To: <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_004407_701253_B988B8B5 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDA5OjE2OjU4ICswMzAwOgoKPiBUaGlzIE5BTkQgcmVhZHMgb25seSBmZXcgdXNlcidz IGJ5dGVzIGluIEVDQyBtb2RlIChub3QgZnVsbCBPT0IpLCBzbwoKIlRoaXMgTkFORCByZWFkcyIg ZG9lcyBub3QgbG9vayByaWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8Kbm90IHJl dHJpZXZlIGFsbCB0aGUgT09CIGJ5dGVzLCI/Cgo+IGZpbGwgT09CIGJ1ZmZlciB3aXRoIHplcm9l cyB0byBub3QgcmV0dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFkcwo+IHRvIHVzZXIuCj4g T3RoZXJ3aXNlICduYW5kZHVtcCcgdXRpbGl0eSBwcmludHMgc29tZXRoaW5nIGxpa2UgdGhpcyBm b3IganVzdCBlcmFzZWQKPiBwYWdlOgo+IAo+IC4uLgo+IDB4MDAwMDA3ZjA6IGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gICBPT0IgRGF0YTogZmYgZmYg ZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiAgIE9PQiBEYXRhOiA2 MyAyNyBhZSAwNiAxNiAwYSAyZiBlYiBiYiBkZCA0NiA3NCA0MSA4ZSA4OCA2ZQo+ICAgT09CIERh dGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1IDdlIDI1IGViIDM0IDdjIGZmCj4gICBP T0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIgNDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUK PiAKPiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNl cy5ydT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgNSArKysr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYwo+IGluZGV4IGY4NGExMDIzOGU0ZC4uZjJmMjQ3MmNiNTExIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRk L25hbmQvcmF3L21lc29uX25hbmQuYwo+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQg bWVzb25fbmZjX3JlYWRfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgc3RhdGlj IGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX3JhdyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAq YnVmLAo+ICAJCQkJICAgaW50IG9vYl9yZXF1aXJlZCwgaW50IHBhZ2UpCj4gIHsKPiArCXN0cnVj dCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFuZCk7Cj4gIAl1OCAqb29iX2J1ZiA9IG5h bmQtPm9vYl9wb2k7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQt Pm9vYnNpemUpOwoKSSdtIHN1cnByaXNlZCByYXcgcmVhZHMgZG8gbm90IHJlYWQgdGhlIGVudGly ZSBPT0I/Cgo+ICsKPiAgCXJldCA9IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2Us IDEpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+IEBAIC04ODEsNiArODg0LDggQEAg c3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX2h3ZWNjKHN0cnVjdCBuYW5kX2NoaXAgKm5h bmQsIHU4ICpidWYsCj4gIAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9wb2k7Cj4gIAlpbnQgcmV0 LCBpOwo+ICAKPiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ICsKPiAgCXJl dCA9IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2UsIDApOwo+ICAJaWYgKHJldCkK PiAgCQlyZXR1cm4gcmV0OwoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1h aWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CC58C77B6E for ; Wed, 12 Apr 2023 07:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d7PcivVZMVSHYPqpnE/Oww3+KLjKP0J7Bg/iW5r/Db4=; b=CabPnURgIhi6Fs ovi9alHwyR7Enk2t3IJZtuekPrLZAbpgRH3LXG3181/gbA0F7dSXpsaky5XLbP11ywHe3KrzukURH SpoUGa1Foy60J7GJCNVJ2SI89XqF7bwKZ4YyVZg9mfYcGjPklOti1vR+ShUMiMtkR9luPqB5br/+s mPBsDfXz4GJVoOzkjkHf+ZH1SFZZSOkPRa/cvEY78m7/mfHSQTnywEVCCLFDAaR0lP3iKC/AVahwB PO47VwGfcGpipOX9bR8k0BtsTNosMnFuO5qq+edkhh+oF83C+Ggx1FZnEaHEqYThhOdJxNReqrg43 JRZc8xH+4n0ZhHh59VRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmV9G-0028HK-26; Wed, 12 Apr 2023 07:44:10 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmV9D-0028GH-1i; Wed, 12 Apr 2023 07:44:08 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DF8E310000A; Wed, 12 Apr 2023 07:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ttYY5/+4QqV7NXlfKfRlva9VOIYN8wHJIRXRSp4/nsU=; b=VOWhGv9pQZHkbQZKW1Fo1DPNbnsXCPKJvakyqc1sFhk61XWz+3f33Y8+rOGAsmKHl3Omg1 oyDuNClMrZTwqvJqIFZJ+ZO4J1teqUkK/k2NHKa8oTEvOfvXpBcgKAy9Mbl9UqlUspUVOk 6D944OrPB6zlH8MAxqUON02U8X8Vc1SgY8ak5Qo7LZXNg2CH4oXZdDrEdqVnlbjViA5y39 vctZlBWs1SE/PAf/qlu1KWTu1lWJQfbMkjS0+ulmf/VMSQxqsu1kYP0034hnJ2R4EMWNdX aLk8ETAVrNdfgvWpzBhNrPhYB1a24wCXYaXrXzWrCUfEG7TVfJlYHPgXBr/VZw== Date: Wed, 12 Apr 2023 09:44:00 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094400.3c82f631@xps-13> In-Reply-To: <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_004407_701253_B988B8B5 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDA5OjE2OjU4ICswMzAwOgoKPiBUaGlzIE5BTkQgcmVhZHMgb25seSBmZXcgdXNlcidz IGJ5dGVzIGluIEVDQyBtb2RlIChub3QgZnVsbCBPT0IpLCBzbwoKIlRoaXMgTkFORCByZWFkcyIg ZG9lcyBub3QgbG9vayByaWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8Kbm90IHJl dHJpZXZlIGFsbCB0aGUgT09CIGJ5dGVzLCI/Cgo+IGZpbGwgT09CIGJ1ZmZlciB3aXRoIHplcm9l cyB0byBub3QgcmV0dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFkcwo+IHRvIHVzZXIuCj4g T3RoZXJ3aXNlICduYW5kZHVtcCcgdXRpbGl0eSBwcmludHMgc29tZXRoaW5nIGxpa2UgdGhpcyBm b3IganVzdCBlcmFzZWQKPiBwYWdlOgo+IAo+IC4uLgo+IDB4MDAwMDA3ZjA6IGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gICBPT0IgRGF0YTogZmYgZmYg ZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiAgIE9PQiBEYXRhOiA2 MyAyNyBhZSAwNiAxNiAwYSAyZiBlYiBiYiBkZCA0NiA3NCA0MSA4ZSA4OCA2ZQo+ICAgT09CIERh dGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1IDdlIDI1IGViIDM0IDdjIGZmCj4gICBP T0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIgNDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUK PiAKPiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNl cy5ydT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgNSArKysr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYwo+IGluZGV4IGY4NGExMDIzOGU0ZC4uZjJmMjQ3MmNiNTExIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRk L25hbmQvcmF3L21lc29uX25hbmQuYwo+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQg bWVzb25fbmZjX3JlYWRfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgc3RhdGlj IGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX3JhdyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAq YnVmLAo+ICAJCQkJICAgaW50IG9vYl9yZXF1aXJlZCwgaW50IHBhZ2UpCj4gIHsKPiArCXN0cnVj dCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFuZCk7Cj4gIAl1OCAqb29iX2J1ZiA9IG5h bmQtPm9vYl9wb2k7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQt Pm9vYnNpemUpOwoKSSdtIHN1cnByaXNlZCByYXcgcmVhZHMgZG8gbm90IHJlYWQgdGhlIGVudGly ZSBPT0I/Cgo+ICsKPiAgCXJldCA9IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2Us IDEpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+IEBAIC04ODEsNiArODg0LDggQEAg c3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX2h3ZWNjKHN0cnVjdCBuYW5kX2NoaXAgKm5h bmQsIHU4ICpidWYsCj4gIAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9wb2k7Cj4gIAlpbnQgcmV0 LCBpOwo+ICAKPiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ICsKPiAgCXJl dCA9IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2UsIDApOwo+ICAJaWYgKHJldCkK PiAgCQlyZXR1cm4gcmV0OwoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF39C7619A for ; Wed, 12 Apr 2023 07:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbjDLHoJ (ORCPT ); Wed, 12 Apr 2023 03:44:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjDLHoI (ORCPT ); Wed, 12 Apr 2023 03:44:08 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A9171BC0 for ; Wed, 12 Apr 2023 00:44:06 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DF8E310000A; Wed, 12 Apr 2023 07:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ttYY5/+4QqV7NXlfKfRlva9VOIYN8wHJIRXRSp4/nsU=; b=VOWhGv9pQZHkbQZKW1Fo1DPNbnsXCPKJvakyqc1sFhk61XWz+3f33Y8+rOGAsmKHl3Omg1 oyDuNClMrZTwqvJqIFZJ+ZO4J1teqUkK/k2NHKa8oTEvOfvXpBcgKAy9Mbl9UqlUspUVOk 6D944OrPB6zlH8MAxqUON02U8X8Vc1SgY8ak5Qo7LZXNg2CH4oXZdDrEdqVnlbjViA5y39 vctZlBWs1SE/PAf/qlu1KWTu1lWJQfbMkjS0+ulmf/VMSQxqsu1kYP0034hnJ2R4EMWNdX aLk8ETAVrNdfgvWpzBhNrPhYB1a24wCXYaXrXzWrCUfEG7TVfJlYHPgXBr/VZw== Date: Wed, 12 Apr 2023 09:44:00 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094400.3c82f631@xps-13> In-Reply-To: <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:58 +0300: > This NAND reads only few user's bytes in ECC mode (not full OOB), so "This NAND reads" does not look right, do you mean "Subpage reads do not retrieve all the OOB bytes,"? > fill OOB buffer with zeroes to not return garbage from previous reads > to user. > Otherwise 'nanddump' utility prints something like this for just erased > page: >=20 > ... > 0x000007f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > OOB Data: ff ff ff ff 00 00 ff ff 80 cf 22 99 cb ad d3 be > OOB Data: 63 27 ae 06 16 0a 2f eb bb dd 46 74 41 8e 88 6e > OOB Data: 38 a1 2d e6 77 d4 05 06 f2 a5 7e 25 eb 34 7c ff > OOB Data: 38 ea de 14 10 de 9b 40 33 16 6a cc 9d aa 2f 5e >=20 > Signed-off-by: Arseniy Krasnov > --- > drivers/mtd/nand/raw/meson_nand.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index f84a10238e4d..f2f2472cb511 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -858,9 +858,12 @@ static int meson_nfc_read_page_sub(struct nand_chip = *nand, > static int meson_nfc_read_page_raw(struct nand_chip *nand, u8 *buf, > int oob_required, int page) > { > + struct mtd_info *mtd =3D nand_to_mtd(nand); > u8 *oob_buf =3D nand->oob_poi; > int ret; > =20 > + memset(oob_buf, 0, mtd->oobsize); I'm surprised raw reads do not read the entire OOB? > + > ret =3D meson_nfc_read_page_sub(nand, page, 1); > if (ret) > return ret; > @@ -881,6 +884,8 @@ static int meson_nfc_read_page_hwecc(struct nand_chip= *nand, u8 *buf, > u8 *oob_buf =3D nand->oob_poi; > int ret, i; > =20 > + memset(oob_buf, 0, mtd->oobsize); > + > ret =3D meson_nfc_read_page_sub(nand, page, 0); > if (ret) > return ret; Thanks, Miqu=C3=A8l