From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 389EBC7619A for ; Wed, 12 Apr 2023 07:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q/WHk4uidgBHl0KZUs9BETotdGOZq9lXF3J1szeesQM=; b=Lo1C7ATlb6kZB9 smGBT5WJkddcRUSJlKe25Qfn0v7QR/GJ7kiGSQW/0nF2MVERR8NYW/gZ/wgQaCzu9KTauGCyH+Ruq IT3s+RJjPv1YeDQr1AFlYulehijfSz3/VSgSreRRp0gCbZjlrtQ4CWV0FKmcfw6h54325FTKiu1fj JetKZeP4KoZIvpmNRm0Se6EsA7JG7TOpPxeP5nCi1YCow+ynEB2uGJjUuq/5cqYSusdV2cU0V3uDY TAZS74sLcoZjHEDuHQqe64OB15FAfB3aHrk7HXMVWZUH2PCfiLukM1obXiMIP7Hz6/fVPHaOqQ3nX ae2CflRlO/ud/+gwGlng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmVCJ-00290v-2N; Wed, 12 Apr 2023 07:47:19 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmVCF-0028yM-13; Wed, 12 Apr 2023 07:47:17 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D6624000D; Wed, 12 Apr 2023 07:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tl8qiw+0w9MXIDlH7WD7qEaE1rT27aC7+yddYMTRrAw=; b=lJFRUAVhi7QhjUM8KhE+bGlOqqK83Y/4D+qAyp5DwQQOZZI5l1bx4mxWQp8wABN4tq5s+E QBNuVdRF4QssaRpZ28GzbgW/xfL3D243aKGL9REjBJIuoogtrxz6VSWsWkBIBVqwa1U4Ng fqGRSjomysmXiRzUrMD67xfDO5il0YYbmpYM9Rtp+okcjoXkDgJvsX0r7lh7esFYhqgy4g Ra/urhTpfr3E/UGeLNwoJJqdxV+8QrjKnDEBNRAc1kHq7rRdAGYDLzpx2vR9Ucqz2Pnwav gZDnLUv7NEJWL4amjDFonyAXW3j9iH/i/h+mxmyS8+dVUlA2xcoripRiMxbT6A== Date: Wed, 12 Apr 2023 09:47:02 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094651.39f4dbf6@xps-13> In-Reply-To: <20230412094400.3c82f631@xps-13> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_004715_666761_22D2B78F X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgYWdhaW4sCgptaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tIHdyb3RlIG9uIFdlZCwgMTIgQXBy IDIwMjMgMDk6NDQ6MDAgKzAyMDA6Cgo+IEhpIEFyc2VuaXksCj4gCj4gQVZLcmFzbm92QHNiZXJk ZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMDk6MTY6NTggKzAzMDA6Cj4gCj4g PiBUaGlzIE5BTkQgcmVhZHMgb25seSBmZXcgdXNlcidzIGJ5dGVzIGluIEVDQyBtb2RlIChub3Qg ZnVsbCBPT0IpLCBzbyAgCj4gCj4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9vayByaWdo dCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiBub3QgcmV0cmlldmUgYWxsIHRoZSBP T0IgYnl0ZXMsIj8KPiAKPiA+IGZpbGwgT09CIGJ1ZmZlciB3aXRoIHplcm9lcyB0byBub3QgcmV0 dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFkcwo+ID4gdG8gdXNlci4KPiA+IE90aGVyd2lz ZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRoaXMgZm9yIGp1c3Qg ZXJhc2VkCj4gPiBwYWdlOgo+ID4gCj4gPiAuLi4KPiA+IDB4MDAwMDA3ZjA6IGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gPiAgIE9PQiBEYXRhOiBmZiBm ZiBmZiBmZiAwMCAwMCBmZiBmZiA4MCBjZiAyMiA5OSBjYiBhZCBkMyBiZQo+ID4gICBPT0IgRGF0 YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODggNmUKPiA+ICAg T09CIERhdGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1IDdlIDI1IGViIDM0IDdjIGZm Cj4gPiAgIE9PQiBEYXRhOiAzOCBlYSBkZSAxNCAxMCBkZSA5YiA0MCAzMyAxNiA2YSBjYyA5ZCBh YSAyZiA1ZQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25v dkBzYmVyZGV2aWNlcy5ydT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29u X25hbmQuYyB8IDUgKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9k cml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+IGluZGV4IGY4NGExMDIzOGU0ZC4u ZjJmMjQ3MmNiNTExIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25f bmFuZC5jCj4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+IEBA IC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRfcGFnZV9zdWIoc3Ry dWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+ICBzdGF0aWMgaW50IG1lc29uX25mY19yZWFkX3BhZ2Vf cmF3KHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpidWYsCj4gPiAgCQkJCSAgIGludCBvb2Jf cmVxdWlyZWQsIGludCBwYWdlKQo+ID4gIHsKPiA+ICsJc3RydWN0IG10ZF9pbmZvICptdGQgPSBu YW5kX3RvX210ZChuYW5kKTsKPiA+ICAJdTggKm9vYl9idWYgPSBuYW5kLT5vb2JfcG9pOwo+ID4g IAlpbnQgcmV0Owo+ID4gIAo+ID4gKwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsg IAoKU2hvdWxkIHVzZSAweGZmIGluc3RlYWQgb2YgMHgwMCwgdGhhdCdzIHRoZSBkZWZhdWx0IHN0 YXRlIG9mIGEgTkFORApjZWxsLgoKQW5kIGFsc28gdGhpcyBtZW1zZXQgc2hvdWxkIGJlIGNvbmRp dGlvbmVkIHRvICdvb2JfcmVxdWlyZWQnIEkKZ3Vlc3M/Cgo+IAo+IEknbSBzdXJwcmlzZWQgcmF3 IHJlYWRzIGRvIG5vdCByZWFkIHRoZSBlbnRpcmUgT09CPwo+IAo+ID4gKwo+ID4gIAlyZXQgPSBt ZXNvbl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAxKTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7Cj4gPiBAQCAtODgxLDYgKzg4NCw4IEBAIHN0YXRpYyBpbnQgbWVzb25f bmZjX3JlYWRfcGFnZV9od2VjYyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAqYnVmLAo+ID4g IAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9wb2k7Cj4gPiAgCWludCByZXQsIGk7Cj4gPiAgCj4g PiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ID4gKwo+ID4gIAlyZXQgPSBt ZXNvbl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAwKTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7ICAKPiAKPiAKPiBUaGFua3MsCj4gTWlxdcOobAoKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dp Ywo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87AF1C77B6E for ; Wed, 12 Apr 2023 07:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D4d2oRD6GlNi3WA0ZhxvGM6yFukm8+1U5Pm5jG2dDCg=; b=JsURjxuj9s05xk 65QDIqHWMCUx5P4yaXXegfunyTkwF2nYOHgFiSahGzOxkwSBwG1RiadfC5ThYENE4s2IhX7lptx96 8NcdufKyV8mrlVT6SVJo8vfC+aac18VLgcbfjRzIqbWv2QiTsnN8/2wo3A0iKElRdD6CV4Q4VuX1Q tFQSLSBSD5jcGyuFhMZIoKpn2oRlK3Zni/7RGyWUkZB8gqssFSkbjSTwrwwQc76f/BBZrKDLrrJZI J+3I9IMwFo0NYo9VS8/7acX2RrpLiO+Ax+b3J+Ib1NpZmJiyOsdMfRxICtWvxz+LwpRAQJccG2ifG KB36GHnaTkgMzPGSvEiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmVCL-00291h-0P; Wed, 12 Apr 2023 07:47:21 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmVCF-0028yM-13; Wed, 12 Apr 2023 07:47:17 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D6624000D; Wed, 12 Apr 2023 07:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tl8qiw+0w9MXIDlH7WD7qEaE1rT27aC7+yddYMTRrAw=; b=lJFRUAVhi7QhjUM8KhE+bGlOqqK83Y/4D+qAyp5DwQQOZZI5l1bx4mxWQp8wABN4tq5s+E QBNuVdRF4QssaRpZ28GzbgW/xfL3D243aKGL9REjBJIuoogtrxz6VSWsWkBIBVqwa1U4Ng fqGRSjomysmXiRzUrMD67xfDO5il0YYbmpYM9Rtp+okcjoXkDgJvsX0r7lh7esFYhqgy4g Ra/urhTpfr3E/UGeLNwoJJqdxV+8QrjKnDEBNRAc1kHq7rRdAGYDLzpx2vR9Ucqz2Pnwav gZDnLUv7NEJWL4amjDFonyAXW3j9iH/i/h+mxmyS8+dVUlA2xcoripRiMxbT6A== Date: Wed, 12 Apr 2023 09:47:02 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094651.39f4dbf6@xps-13> In-Reply-To: <20230412094400.3c82f631@xps-13> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_004715_666761_22D2B78F X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgYWdhaW4sCgptaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tIHdyb3RlIG9uIFdlZCwgMTIgQXBy IDIwMjMgMDk6NDQ6MDAgKzAyMDA6Cgo+IEhpIEFyc2VuaXksCj4gCj4gQVZLcmFzbm92QHNiZXJk ZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMDk6MTY6NTggKzAzMDA6Cj4gCj4g PiBUaGlzIE5BTkQgcmVhZHMgb25seSBmZXcgdXNlcidzIGJ5dGVzIGluIEVDQyBtb2RlIChub3Qg ZnVsbCBPT0IpLCBzbyAgCj4gCj4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9vayByaWdo dCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiBub3QgcmV0cmlldmUgYWxsIHRoZSBP T0IgYnl0ZXMsIj8KPiAKPiA+IGZpbGwgT09CIGJ1ZmZlciB3aXRoIHplcm9lcyB0byBub3QgcmV0 dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFkcwo+ID4gdG8gdXNlci4KPiA+IE90aGVyd2lz ZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRoaXMgZm9yIGp1c3Qg ZXJhc2VkCj4gPiBwYWdlOgo+ID4gCj4gPiAuLi4KPiA+IDB4MDAwMDA3ZjA6IGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gPiAgIE9PQiBEYXRhOiBmZiBm ZiBmZiBmZiAwMCAwMCBmZiBmZiA4MCBjZiAyMiA5OSBjYiBhZCBkMyBiZQo+ID4gICBPT0IgRGF0 YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODggNmUKPiA+ICAg T09CIERhdGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1IDdlIDI1IGViIDM0IDdjIGZm Cj4gPiAgIE9PQiBEYXRhOiAzOCBlYSBkZSAxNCAxMCBkZSA5YiA0MCAzMyAxNiA2YSBjYyA5ZCBh YSAyZiA1ZQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25v dkBzYmVyZGV2aWNlcy5ydT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29u X25hbmQuYyB8IDUgKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9k cml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+IGluZGV4IGY4NGExMDIzOGU0ZC4u ZjJmMjQ3MmNiNTExIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25f bmFuZC5jCj4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+IEBA IC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRfcGFnZV9zdWIoc3Ry dWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+ICBzdGF0aWMgaW50IG1lc29uX25mY19yZWFkX3BhZ2Vf cmF3KHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpidWYsCj4gPiAgCQkJCSAgIGludCBvb2Jf cmVxdWlyZWQsIGludCBwYWdlKQo+ID4gIHsKPiA+ICsJc3RydWN0IG10ZF9pbmZvICptdGQgPSBu YW5kX3RvX210ZChuYW5kKTsKPiA+ICAJdTggKm9vYl9idWYgPSBuYW5kLT5vb2JfcG9pOwo+ID4g IAlpbnQgcmV0Owo+ID4gIAo+ID4gKwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsg IAoKU2hvdWxkIHVzZSAweGZmIGluc3RlYWQgb2YgMHgwMCwgdGhhdCdzIHRoZSBkZWZhdWx0IHN0 YXRlIG9mIGEgTkFORApjZWxsLgoKQW5kIGFsc28gdGhpcyBtZW1zZXQgc2hvdWxkIGJlIGNvbmRp dGlvbmVkIHRvICdvb2JfcmVxdWlyZWQnIEkKZ3Vlc3M/Cgo+IAo+IEknbSBzdXJwcmlzZWQgcmF3 IHJlYWRzIGRvIG5vdCByZWFkIHRoZSBlbnRpcmUgT09CPwo+IAo+ID4gKwo+ID4gIAlyZXQgPSBt ZXNvbl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAxKTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7Cj4gPiBAQCAtODgxLDYgKzg4NCw4IEBAIHN0YXRpYyBpbnQgbWVzb25f bmZjX3JlYWRfcGFnZV9od2VjYyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAqYnVmLAo+ID4g IAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9wb2k7Cj4gPiAgCWludCByZXQsIGk7Cj4gPiAgCj4g PiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ID4gKwo+ID4gIAlyZXQgPSBt ZXNvbl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAwKTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7ICAKPiAKPiAKPiBUaGFua3MsCj4gTWlxdcOobAoKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18183C77B6E for ; Wed, 12 Apr 2023 07:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JobSlG6hbiUAklYfGb60YB8+sZX3GTZyV4K6WQ0pAwU=; b=b5NsNq6BmzHlBk p+tDO9nEm219uGgMYpDmGWbPSyCojvtaAsLwS1rjV3ayADQ5i6wSe587F4S6Asiq229mll54gDUAj DJr8WCrwbfGZJ66z6bgEkmAtDOJpkbslPL2lP86R/lEJepJxF+ltQf+JL4XLCFRszg5HGE8LmtQiX dzgvid0bCKyOmqImvZZKpcjqq1tUyX8hWEi7Rhsowq92Q8d9CpdkHz5nrzCUEY8k4qHttqXwK2mZQ qs1SE+H6vpkKn9Djzf8UgRUOgtnfbGQKBZj1mrsUS7gGoMwankFORYNbcWUDXsOVOdKG4e+03JQ4C LqVtiu7ST/YMpaak2Png==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmVCK-002919-0c; Wed, 12 Apr 2023 07:47:20 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmVCF-0028yM-13; Wed, 12 Apr 2023 07:47:17 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D6624000D; Wed, 12 Apr 2023 07:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tl8qiw+0w9MXIDlH7WD7qEaE1rT27aC7+yddYMTRrAw=; b=lJFRUAVhi7QhjUM8KhE+bGlOqqK83Y/4D+qAyp5DwQQOZZI5l1bx4mxWQp8wABN4tq5s+E QBNuVdRF4QssaRpZ28GzbgW/xfL3D243aKGL9REjBJIuoogtrxz6VSWsWkBIBVqwa1U4Ng fqGRSjomysmXiRzUrMD67xfDO5il0YYbmpYM9Rtp+okcjoXkDgJvsX0r7lh7esFYhqgy4g Ra/urhTpfr3E/UGeLNwoJJqdxV+8QrjKnDEBNRAc1kHq7rRdAGYDLzpx2vR9Ucqz2Pnwav gZDnLUv7NEJWL4amjDFonyAXW3j9iH/i/h+mxmyS8+dVUlA2xcoripRiMxbT6A== Date: Wed, 12 Apr 2023 09:47:02 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094651.39f4dbf6@xps-13> In-Reply-To: <20230412094400.3c82f631@xps-13> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_004715_666761_22D2B78F X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgYWdhaW4sCgptaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tIHdyb3RlIG9uIFdlZCwgMTIgQXBy IDIwMjMgMDk6NDQ6MDAgKzAyMDA6Cgo+IEhpIEFyc2VuaXksCj4gCj4gQVZLcmFzbm92QHNiZXJk ZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMDk6MTY6NTggKzAzMDA6Cj4gCj4g PiBUaGlzIE5BTkQgcmVhZHMgb25seSBmZXcgdXNlcidzIGJ5dGVzIGluIEVDQyBtb2RlIChub3Qg ZnVsbCBPT0IpLCBzbyAgCj4gCj4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9vayByaWdo dCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiBub3QgcmV0cmlldmUgYWxsIHRoZSBP T0IgYnl0ZXMsIj8KPiAKPiA+IGZpbGwgT09CIGJ1ZmZlciB3aXRoIHplcm9lcyB0byBub3QgcmV0 dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFkcwo+ID4gdG8gdXNlci4KPiA+IE90aGVyd2lz ZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRoaXMgZm9yIGp1c3Qg ZXJhc2VkCj4gPiBwYWdlOgo+ID4gCj4gPiAuLi4KPiA+IDB4MDAwMDA3ZjA6IGZmIGZmIGZmIGZm IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gPiAgIE9PQiBEYXRhOiBmZiBm ZiBmZiBmZiAwMCAwMCBmZiBmZiA4MCBjZiAyMiA5OSBjYiBhZCBkMyBiZQo+ID4gICBPT0IgRGF0 YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODggNmUKPiA+ICAg T09CIERhdGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1IDdlIDI1IGViIDM0IDdjIGZm Cj4gPiAgIE9PQiBEYXRhOiAzOCBlYSBkZSAxNCAxMCBkZSA5YiA0MCAzMyAxNiA2YSBjYyA5ZCBh YSAyZiA1ZQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25v dkBzYmVyZGV2aWNlcy5ydT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29u X25hbmQuYyB8IDUgKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9k cml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+IGluZGV4IGY4NGExMDIzOGU0ZC4u ZjJmMjQ3MmNiNTExIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25f bmFuZC5jCj4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+IEBA IC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRfcGFnZV9zdWIoc3Ry dWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+ICBzdGF0aWMgaW50IG1lc29uX25mY19yZWFkX3BhZ2Vf cmF3KHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpidWYsCj4gPiAgCQkJCSAgIGludCBvb2Jf cmVxdWlyZWQsIGludCBwYWdlKQo+ID4gIHsKPiA+ICsJc3RydWN0IG10ZF9pbmZvICptdGQgPSBu YW5kX3RvX210ZChuYW5kKTsKPiA+ICAJdTggKm9vYl9idWYgPSBuYW5kLT5vb2JfcG9pOwo+ID4g IAlpbnQgcmV0Owo+ID4gIAo+ID4gKwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsg IAoKU2hvdWxkIHVzZSAweGZmIGluc3RlYWQgb2YgMHgwMCwgdGhhdCdzIHRoZSBkZWZhdWx0IHN0 YXRlIG9mIGEgTkFORApjZWxsLgoKQW5kIGFsc28gdGhpcyBtZW1zZXQgc2hvdWxkIGJlIGNvbmRp dGlvbmVkIHRvICdvb2JfcmVxdWlyZWQnIEkKZ3Vlc3M/Cgo+IAo+IEknbSBzdXJwcmlzZWQgcmF3 IHJlYWRzIGRvIG5vdCByZWFkIHRoZSBlbnRpcmUgT09CPwo+IAo+ID4gKwo+ID4gIAlyZXQgPSBt ZXNvbl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAxKTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7Cj4gPiBAQCAtODgxLDYgKzg4NCw4IEBAIHN0YXRpYyBpbnQgbWVzb25f bmZjX3JlYWRfcGFnZV9od2VjYyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAqYnVmLAo+ID4g IAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9wb2k7Cj4gPiAgCWludCByZXQsIGk7Cj4gPiAgCj4g PiArCW1lbXNldChvb2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ID4gKwo+ID4gIAlyZXQgPSBt ZXNvbl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAwKTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7ICAKPiAKPiAKPiBUaGFua3MsCj4gTWlxdcOobAoKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9AAC77B6E for ; Wed, 12 Apr 2023 07:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjDLHrM (ORCPT ); Wed, 12 Apr 2023 03:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjDLHrI (ORCPT ); Wed, 12 Apr 2023 03:47:08 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B80F41705 for ; Wed, 12 Apr 2023 00:47:06 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D6624000D; Wed, 12 Apr 2023 07:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681285625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tl8qiw+0w9MXIDlH7WD7qEaE1rT27aC7+yddYMTRrAw=; b=lJFRUAVhi7QhjUM8KhE+bGlOqqK83Y/4D+qAyp5DwQQOZZI5l1bx4mxWQp8wABN4tq5s+E QBNuVdRF4QssaRpZ28GzbgW/xfL3D243aKGL9REjBJIuoogtrxz6VSWsWkBIBVqwa1U4Ng fqGRSjomysmXiRzUrMD67xfDO5il0YYbmpYM9Rtp+okcjoXkDgJvsX0r7lh7esFYhqgy4g Ra/urhTpfr3E/UGeLNwoJJqdxV+8QrjKnDEBNRAc1kHq7rRdAGYDLzpx2vR9Ucqz2Pnwav gZDnLUv7NEJWL4amjDFonyAXW3j9iH/i/h+mxmyS8+dVUlA2xcoripRiMxbT6A== Date: Wed, 12 Apr 2023 09:47:02 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412094651.39f4dbf6@xps-13> In-Reply-To: <20230412094400.3c82f631@xps-13> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi again, miquel.raynal@bootlin.com wrote on Wed, 12 Apr 2023 09:44:00 +0200: > Hi Arseniy, >=20 > AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:58 +0300: >=20 > > This NAND reads only few user's bytes in ECC mode (not full OOB), so =20 >=20 > "This NAND reads" does not look right, do you mean "Subpage reads do > not retrieve all the OOB bytes,"? >=20 > > fill OOB buffer with zeroes to not return garbage from previous reads > > to user. > > Otherwise 'nanddump' utility prints something like this for just erased > > page: > >=20 > > ... > > 0x000007f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > > OOB Data: ff ff ff ff 00 00 ff ff 80 cf 22 99 cb ad d3 be > > OOB Data: 63 27 ae 06 16 0a 2f eb bb dd 46 74 41 8e 88 6e > > OOB Data: 38 a1 2d e6 77 d4 05 06 f2 a5 7e 25 eb 34 7c ff > > OOB Data: 38 ea de 14 10 de 9b 40 33 16 6a cc 9d aa 2f 5e > >=20 > > Signed-off-by: Arseniy Krasnov > > --- > > drivers/mtd/nand/raw/meson_nand.c | 5 +++++ > > 1 file changed, 5 insertions(+) > >=20 > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/m= eson_nand.c > > index f84a10238e4d..f2f2472cb511 100644 > > --- a/drivers/mtd/nand/raw/meson_nand.c > > +++ b/drivers/mtd/nand/raw/meson_nand.c > > @@ -858,9 +858,12 @@ static int meson_nfc_read_page_sub(struct nand_chi= p *nand, > > static int meson_nfc_read_page_raw(struct nand_chip *nand, u8 *buf, > > int oob_required, int page) > > { > > + struct mtd_info *mtd =3D nand_to_mtd(nand); > > u8 *oob_buf =3D nand->oob_poi; > > int ret; > > =20 > > + memset(oob_buf, 0, mtd->oobsize); =20 Should use 0xff instead of 0x00, that's the default state of a NAND cell. And also this memset should be conditioned to 'oob_required' I guess? >=20 > I'm surprised raw reads do not read the entire OOB? >=20 > > + > > ret =3D meson_nfc_read_page_sub(nand, page, 1); > > if (ret) > > return ret; > > @@ -881,6 +884,8 @@ static int meson_nfc_read_page_hwecc(struct nand_ch= ip *nand, u8 *buf, > > u8 *oob_buf =3D nand->oob_poi; > > int ret, i; > > =20 > > + memset(oob_buf, 0, mtd->oobsize); > > + > > ret =3D meson_nfc_read_page_sub(nand, page, 0); > > if (ret) > > return ret; =20 >=20 >=20 > Thanks, > Miqu=C3=A8l Thanks, Miqu=C3=A8l