From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98E69C7619A for ; Wed, 12 Apr 2023 09:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xHIspYkyMDMO7zb+e71d9RGKpSEytfeqE7YhqPLgTqM=; b=iGDwiznuI1QChl wyn2wTgyhd2wwTz4/RJJ1+za8bwxZY6ttbpqt4wnp/xj96ZKU7B/4qfY84QAZYhke5weRYEoFX5B8 ZzV0MSUPoK/H2AOCfmu07+uB/JqQtGUeI2V74QRi+bXum8oC65XadkkDXF+BTraP2MSipIQ6vhx6A alHh/MCjIJaaPDmsm41ouhwOKpV+6nxlJs9j5mu6zeYpuHi5GuR/nykp6cFOgAms4nksM1QLA7G8p B+jGxYu2SPMC9SuepMHW6+PitxhAMVYqzNVpvcyAXWuTXQ0Kj1TWOebV8Ru+W7VPSMMlZJLnv37IB InMyfz5DKoUUXUGFXiJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmWuZ-002Pss-1e; Wed, 12 Apr 2023 09:37:07 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmWuW-002PpT-0U; Wed, 12 Apr 2023 09:37:06 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 55AE11C0016; Wed, 12 Apr 2023 09:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681292217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjAW3sbnqjC4RD0jM6Lfr+B+vyxCfa8273h/4IpoFAI=; b=W+a/1wnc3Yf9nMGLvyToyer/4s32mDzQcVuiqsEQAORqqeroXYGnnmyqM1luAsPxHGAxY8 y9wIBoK2H4KBIKbJZAvv10MwQSQssxV8h875/K2cH/NqFtputacVb8EguSdhS5IF/rLYup fwa2pexXTUf+TjnIuKLgcARBVScdt8JJWz28ARJ/o+5TsMjwcQBnhzef/pIejEEngIboz7 kmzxLM9F46nQcW0N/+l1HjLkxoWbBnDkc9qSCs68r+ADXYP3aOBUq65np/DRP49kRSf/1A s0HkjTC6qa40BJeB1iI9HRGs1RvQSFjZhEtRYSIZBY0a23YKzl/DiKQ78rXjMw== Date: Wed, 12 Apr 2023 11:36:54 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412113654.183350d0@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_023704_649963_2D551ED3 X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDEyOjIwOjU1ICswMzAwOgoKPiBPbiAxMi4wNC4yMDIzIDEwOjQ0LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gQVZLcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMDk6MTY6NTggKzAzMDA6Cj4gPiAgIAo+ID4+ IFRoaXMgTkFORCByZWFkcyBvbmx5IGZldyB1c2VyJ3MgYnl0ZXMgaW4gRUNDIG1vZGUgKG5vdCBm dWxsIE9PQiksIHNvICAKPiA+IAo+ID4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9vayBy aWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiA+IG5vdCByZXRyaWV2ZSBhbGwg dGhlIE9PQiBieXRlcywiPwo+ID4gICAKPiA+PiBmaWxsIE9PQiBidWZmZXIgd2l0aCB6ZXJvZXMg dG8gbm90IHJldHVybiBnYXJiYWdlIGZyb20gcHJldmlvdXMgcmVhZHMKPiA+PiB0byB1c2VyLgo+ ID4+IE90aGVyd2lzZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRo aXMgZm9yIGp1c3QgZXJhc2VkCj4gPj4gcGFnZToKPiA+Pgo+ID4+IC4uLgo+ID4+IDB4MDAwMDA3 ZjA6IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gPj4g ICBPT0IgRGF0YTogZmYgZmYgZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMg YmUKPiA+PiAgIE9PQiBEYXRhOiA2MyAyNyBhZSAwNiAxNiAwYSAyZiBlYiBiYiBkZCA0NiA3NCA0 MSA4ZSA4OCA2ZQo+ID4+ICAgT09CIERhdGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1 IDdlIDI1IGViIDM0IDdjIGZmCj4gPj4gICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIg NDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFyc2Vu aXkgS3Jhc25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ID4+IC0tLQo+ID4+ICBkcml2 ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCA1ICsrKysrCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMK PiA+PiBpbmRleCBmODRhMTAyMzhlNGQuLmYyZjI0NzJjYjUxMSAxMDA2NDQKPiA+PiAtLS0gYS9k cml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiArKysgYi9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiBAQCAtODU4LDkgKzg1OCwxMiBAQCBzdGF0aWMgaW50 IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gPj4gIHN0 YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwg dTggKmJ1ZiwKPiA+PiAgCQkJCSAgIGludCBvb2JfcmVxdWlyZWQsIGludCBwYWdlKQo+ID4+ICB7 Cj4gPj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+ICAJ dTggKm9vYl9idWYgPSBuYW5kLT5vb2JfcG9pOwo+ID4+ICAJaW50IHJldDsKPiA+PiAgCj4gPj4g KwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsgIAo+ID4gCj4gPiBJJ20gc3VycHJp c2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0aGUgZW50aXJlIE9PQj8gIAo+IAo+IFllcyEgU2Vl bXMgaW4gY2FzZSBvZiByYXcgYWNjZXNzICh3aGF0IGkgc2VlIGluIHRoaXMgZHJpdmVyKSBudW1i ZXIgb2YgT09CIGJ5dGVzIHJlYWQKPiBzdGlsbCBkZXBlbmRzIG9uIEVDQyBwYXJhbWV0ZXJzOiBm b3IgZWFjaCBwb3J0aW9uIG9mIGRhdGEgY292ZXJlZCB3aXRoIEVDQyBjb2RlIHdlIGNhbgo+IHJl YWQgaXQncyBFQ0MgY29kZSBhbmQgInVzZXIgYnl0ZXMiIGZyb20gT09CIC0gaXQgaXMgd2hhdCBp IHNlZSBieSBkdW1waW5nIERNQSBidWZmZXIgYnkKPiBwcmludGsoKS4gRm9yIGV4YW1wbGUgSSdt IHdvcmtpbmcgd2l0aCAySyBOQU5EIHBhZ2VzLCBlYWNoIHBhZ2UgaGFzIDIgeCAxSyBFQ0MgYmxv Y2tzLgo+IEZvciBlYWNoIEVDQyBibG9jayBJIGhhdmUgMTYgT09CIGJ5dGVzIHdoaWNoIEkgY2Fu IGFjY2VzcyBieSByZWFkL3dyaXRlLiBFYWNoIDE2IGJ5dGVzCj4gY29udGFpbnMgMiBieXRlcyBv ZiB1c2VyJ3MgZGF0YSBhbmQgMTQgYnl0ZXMgRUNDIGNvZGVzLiBTbyB3aGVuIEkgcmVhZCBwYWdl IGluIHJhdyBtb2RlCj4gY29udHJvbGxlciByZXR1cm5zIDMyIGJ5dGVzICgyIHggKDIgKyAxNCkp IG9mIE9PQi4gV2hpbGUgT09CIGlzIHJlcG9ydGVkIGFzIDY0IGJ5dGVzLgoKSW4gYWxsIG1vZGVz LCB3aGVuIHlvdSByZWFkIE9PQiwgeW91IHNob3VsZCBnZXQgdGhlIGZ1bGwgT09CLiBUaGUgZmFj dAp0aGF0IEVDQyBjb3JyZWN0aW9uIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQgZG9lcyBub3QgbWF0 dGVyLiBJZiB0aGUgTkFORApmZWF0dXJlcyBPT0Igc2VjdGlvbnMgb2YgNjQgYnl0ZXMsIHlvdSBz aG91bGQgZ2V0IHRoZSA2NCBieXRlcy4KCldoYXQgaGFwcGVucyBzb21ldGltZXMsIGlzIHRoYXQg c29tZSBvZiB0aGUgYnl0ZXMgYXJlIG5vdCBwcm90ZWN0ZWQKYWdhaW5zdCBiaXRmbGlwcywgYnV0 IHRoZSBwb2xpY3kgaXMgdG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4KCj4gCj4gVGhhbmtzLCBB cnNlbml5Cj4gCj4gPiAgIAo+ID4+ICsKPiA+PiAgCXJldCA9IG1lc29uX25mY19yZWFkX3BhZ2Vf c3ViKG5hbmQsIHBhZ2UsIDEpOwo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlyZXR1cm4gcmV0Owo+ ID4+IEBAIC04ODEsNiArODg0LDggQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX2h3 ZWNjKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpidWYsCj4gPj4gIAl1OCAqb29iX2J1ZiA9 IG5hbmQtPm9vYl9wb2k7Cj4gPj4gIAlpbnQgcmV0LCBpOwo+ID4+ICAKPiA+PiArCW1lbXNldChv b2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ID4+ICsKPiA+PiAgCXJldCA9IG1lc29uX25mY19y ZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2UsIDApOwo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlyZXR1 cm4gcmV0OyAgCj4gPiAKPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobCAgCgoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxv Z2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 955DCC77B6E for ; Wed, 12 Apr 2023 09:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5GeZaunfXnKPpmtk54qWBsN2hAxpPmO1KjNr3NQk5I4=; b=Kg2o+rvEa7iX8c Lj2L1o3Yn30eEv9SYmvvdbL1sgT8pWU+M+SwRXLDcxRUzQtuwJtlpQnqOPgucGYfxULMQmJNZHHAl lZdadWIVUYpfUh33NZBBaBgF/XSyXIZSHi6sWYDOhfjHAxkEmpJ+I5W5LRGEiRhISoKf1jhL4bucx H1x5YpCFphcXpH8Xh34HiL+rtvhwqvsOlyWaTh4ofPycfyfxKIFXrfCRbYIRSNJrEDGVPiCbRYkjl 2d/eq3wJ91yNhmAD4ZP+coTKHQU5sUKEXoE4gctf7Ubf/t0021za/KHDpSMs9SQ0ZlKFD5rmFCoxz MNig3cJRxUkYKhto9fzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmWub-002PtN-0C; Wed, 12 Apr 2023 09:37:09 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmWuW-002PpT-0U; Wed, 12 Apr 2023 09:37:06 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 55AE11C0016; Wed, 12 Apr 2023 09:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681292217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjAW3sbnqjC4RD0jM6Lfr+B+vyxCfa8273h/4IpoFAI=; b=W+a/1wnc3Yf9nMGLvyToyer/4s32mDzQcVuiqsEQAORqqeroXYGnnmyqM1luAsPxHGAxY8 y9wIBoK2H4KBIKbJZAvv10MwQSQssxV8h875/K2cH/NqFtputacVb8EguSdhS5IF/rLYup fwa2pexXTUf+TjnIuKLgcARBVScdt8JJWz28ARJ/o+5TsMjwcQBnhzef/pIejEEngIboz7 kmzxLM9F46nQcW0N/+l1HjLkxoWbBnDkc9qSCs68r+ADXYP3aOBUq65np/DRP49kRSf/1A s0HkjTC6qa40BJeB1iI9HRGs1RvQSFjZhEtRYSIZBY0a23YKzl/DiKQ78rXjMw== Date: Wed, 12 Apr 2023 11:36:54 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412113654.183350d0@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_023704_649963_2D551ED3 X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDEyOjIwOjU1ICswMzAwOgoKPiBPbiAxMi4wNC4yMDIzIDEwOjQ0LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gQVZLcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMDk6MTY6NTggKzAzMDA6Cj4gPiAgIAo+ID4+ IFRoaXMgTkFORCByZWFkcyBvbmx5IGZldyB1c2VyJ3MgYnl0ZXMgaW4gRUNDIG1vZGUgKG5vdCBm dWxsIE9PQiksIHNvICAKPiA+IAo+ID4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9vayBy aWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiA+IG5vdCByZXRyaWV2ZSBhbGwg dGhlIE9PQiBieXRlcywiPwo+ID4gICAKPiA+PiBmaWxsIE9PQiBidWZmZXIgd2l0aCB6ZXJvZXMg dG8gbm90IHJldHVybiBnYXJiYWdlIGZyb20gcHJldmlvdXMgcmVhZHMKPiA+PiB0byB1c2VyLgo+ ID4+IE90aGVyd2lzZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRo aXMgZm9yIGp1c3QgZXJhc2VkCj4gPj4gcGFnZToKPiA+Pgo+ID4+IC4uLgo+ID4+IDB4MDAwMDA3 ZjA6IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gPj4g ICBPT0IgRGF0YTogZmYgZmYgZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMg YmUKPiA+PiAgIE9PQiBEYXRhOiA2MyAyNyBhZSAwNiAxNiAwYSAyZiBlYiBiYiBkZCA0NiA3NCA0 MSA4ZSA4OCA2ZQo+ID4+ICAgT09CIERhdGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1 IDdlIDI1IGViIDM0IDdjIGZmCj4gPj4gICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIg NDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFyc2Vu aXkgS3Jhc25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ID4+IC0tLQo+ID4+ICBkcml2 ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCA1ICsrKysrCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMK PiA+PiBpbmRleCBmODRhMTAyMzhlNGQuLmYyZjI0NzJjYjUxMSAxMDA2NDQKPiA+PiAtLS0gYS9k cml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiArKysgYi9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiBAQCAtODU4LDkgKzg1OCwxMiBAQCBzdGF0aWMgaW50 IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gPj4gIHN0 YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwg dTggKmJ1ZiwKPiA+PiAgCQkJCSAgIGludCBvb2JfcmVxdWlyZWQsIGludCBwYWdlKQo+ID4+ICB7 Cj4gPj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+ICAJ dTggKm9vYl9idWYgPSBuYW5kLT5vb2JfcG9pOwo+ID4+ICAJaW50IHJldDsKPiA+PiAgCj4gPj4g KwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsgIAo+ID4gCj4gPiBJJ20gc3VycHJp c2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0aGUgZW50aXJlIE9PQj8gIAo+IAo+IFllcyEgU2Vl bXMgaW4gY2FzZSBvZiByYXcgYWNjZXNzICh3aGF0IGkgc2VlIGluIHRoaXMgZHJpdmVyKSBudW1i ZXIgb2YgT09CIGJ5dGVzIHJlYWQKPiBzdGlsbCBkZXBlbmRzIG9uIEVDQyBwYXJhbWV0ZXJzOiBm b3IgZWFjaCBwb3J0aW9uIG9mIGRhdGEgY292ZXJlZCB3aXRoIEVDQyBjb2RlIHdlIGNhbgo+IHJl YWQgaXQncyBFQ0MgY29kZSBhbmQgInVzZXIgYnl0ZXMiIGZyb20gT09CIC0gaXQgaXMgd2hhdCBp IHNlZSBieSBkdW1waW5nIERNQSBidWZmZXIgYnkKPiBwcmludGsoKS4gRm9yIGV4YW1wbGUgSSdt IHdvcmtpbmcgd2l0aCAySyBOQU5EIHBhZ2VzLCBlYWNoIHBhZ2UgaGFzIDIgeCAxSyBFQ0MgYmxv Y2tzLgo+IEZvciBlYWNoIEVDQyBibG9jayBJIGhhdmUgMTYgT09CIGJ5dGVzIHdoaWNoIEkgY2Fu IGFjY2VzcyBieSByZWFkL3dyaXRlLiBFYWNoIDE2IGJ5dGVzCj4gY29udGFpbnMgMiBieXRlcyBv ZiB1c2VyJ3MgZGF0YSBhbmQgMTQgYnl0ZXMgRUNDIGNvZGVzLiBTbyB3aGVuIEkgcmVhZCBwYWdl IGluIHJhdyBtb2RlCj4gY29udHJvbGxlciByZXR1cm5zIDMyIGJ5dGVzICgyIHggKDIgKyAxNCkp IG9mIE9PQi4gV2hpbGUgT09CIGlzIHJlcG9ydGVkIGFzIDY0IGJ5dGVzLgoKSW4gYWxsIG1vZGVz LCB3aGVuIHlvdSByZWFkIE9PQiwgeW91IHNob3VsZCBnZXQgdGhlIGZ1bGwgT09CLiBUaGUgZmFj dAp0aGF0IEVDQyBjb3JyZWN0aW9uIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQgZG9lcyBub3QgbWF0 dGVyLiBJZiB0aGUgTkFORApmZWF0dXJlcyBPT0Igc2VjdGlvbnMgb2YgNjQgYnl0ZXMsIHlvdSBz aG91bGQgZ2V0IHRoZSA2NCBieXRlcy4KCldoYXQgaGFwcGVucyBzb21ldGltZXMsIGlzIHRoYXQg c29tZSBvZiB0aGUgYnl0ZXMgYXJlIG5vdCBwcm90ZWN0ZWQKYWdhaW5zdCBiaXRmbGlwcywgYnV0 IHRoZSBwb2xpY3kgaXMgdG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4KCj4gCj4gVGhhbmtzLCBB cnNlbml5Cj4gCj4gPiAgIAo+ID4+ICsKPiA+PiAgCXJldCA9IG1lc29uX25mY19yZWFkX3BhZ2Vf c3ViKG5hbmQsIHBhZ2UsIDEpOwo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlyZXR1cm4gcmV0Owo+ ID4+IEBAIC04ODEsNiArODg0LDggQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX2h3 ZWNjKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpidWYsCj4gPj4gIAl1OCAqb29iX2J1ZiA9 IG5hbmQtPm9vYl9wb2k7Cj4gPj4gIAlpbnQgcmV0LCBpOwo+ID4+ICAKPiA+PiArCW1lbXNldChv b2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ID4+ICsKPiA+PiAgCXJldCA9IG1lc29uX25mY19y ZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2UsIDApOwo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlyZXR1 cm4gcmV0OyAgCj4gPiAKPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobCAgCgoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B19A3C77B6E for ; Wed, 12 Apr 2023 09:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nOoCENZJWrtULDQt9bzUsKHzEHaogjymLGrT1pj9mR8=; b=bQdF+4k5vuLUB6 3YVTeFI1gWb/8JyLTyewMwynb7e9bfwfXfoMk0HRfyv3DAK1Lk/I+GScmfYazooJxeTFGYk3Jhnnt C/wdqnsgziLHhWC/6SyJuD8KePB3/FWVPhlHz0wSU16leM9GQRBmXjkXoI7PfjP8fxAIeJL9IOWIV ByupalEqdN2I1XPRo1XK/U9rjJXIjCQijCT/mvAvBldXUQaf9M2cxoX9WzkJ6KnfORg7rMCM71z97 xNzdAUpgnkKFTcbNBqy+g5eVpctvLTjqU+AN5t41DOBKlYw6FcXOZ8f1W1o1nw2h+IdiI8qt/pSAV Isy88nfAh8ys5EL56avg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmWua-002Psz-04; Wed, 12 Apr 2023 09:37:08 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmWuW-002PpT-0U; Wed, 12 Apr 2023 09:37:06 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 55AE11C0016; Wed, 12 Apr 2023 09:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681292217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjAW3sbnqjC4RD0jM6Lfr+B+vyxCfa8273h/4IpoFAI=; b=W+a/1wnc3Yf9nMGLvyToyer/4s32mDzQcVuiqsEQAORqqeroXYGnnmyqM1luAsPxHGAxY8 y9wIBoK2H4KBIKbJZAvv10MwQSQssxV8h875/K2cH/NqFtputacVb8EguSdhS5IF/rLYup fwa2pexXTUf+TjnIuKLgcARBVScdt8JJWz28ARJ/o+5TsMjwcQBnhzef/pIejEEngIboz7 kmzxLM9F46nQcW0N/+l1HjLkxoWbBnDkc9qSCs68r+ADXYP3aOBUq65np/DRP49kRSf/1A s0HkjTC6qa40BJeB1iI9HRGs1RvQSFjZhEtRYSIZBY0a23YKzl/DiKQ78rXjMw== Date: Wed, 12 Apr 2023 11:36:54 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412113654.183350d0@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_023704_649963_2D551ED3 X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDEyOjIwOjU1ICswMzAwOgoKPiBPbiAxMi4wNC4yMDIzIDEwOjQ0LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gQVZLcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMDk6MTY6NTggKzAzMDA6Cj4gPiAgIAo+ID4+ IFRoaXMgTkFORCByZWFkcyBvbmx5IGZldyB1c2VyJ3MgYnl0ZXMgaW4gRUNDIG1vZGUgKG5vdCBm dWxsIE9PQiksIHNvICAKPiA+IAo+ID4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9vayBy aWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiA+IG5vdCByZXRyaWV2ZSBhbGwg dGhlIE9PQiBieXRlcywiPwo+ID4gICAKPiA+PiBmaWxsIE9PQiBidWZmZXIgd2l0aCB6ZXJvZXMg dG8gbm90IHJldHVybiBnYXJiYWdlIGZyb20gcHJldmlvdXMgcmVhZHMKPiA+PiB0byB1c2VyLgo+ ID4+IE90aGVyd2lzZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRo aXMgZm9yIGp1c3QgZXJhc2VkCj4gPj4gcGFnZToKPiA+Pgo+ID4+IC4uLgo+ID4+IDB4MDAwMDA3 ZjA6IGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmIGZmCj4gPj4g ICBPT0IgRGF0YTogZmYgZmYgZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMg YmUKPiA+PiAgIE9PQiBEYXRhOiA2MyAyNyBhZSAwNiAxNiAwYSAyZiBlYiBiYiBkZCA0NiA3NCA0 MSA4ZSA4OCA2ZQo+ID4+ICAgT09CIERhdGE6IDM4IGExIDJkIGU2IDc3IGQ0IDA1IDA2IGYyIGE1 IDdlIDI1IGViIDM0IDdjIGZmCj4gPj4gICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIg NDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFyc2Vu aXkgS3Jhc25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ID4+IC0tLQo+ID4+ICBkcml2 ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCA1ICsrKysrCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMK PiA+PiBpbmRleCBmODRhMTAyMzhlNGQuLmYyZjI0NzJjYjUxMSAxMDA2NDQKPiA+PiAtLS0gYS9k cml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiArKysgYi9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiBAQCAtODU4LDkgKzg1OCwxMiBAQCBzdGF0aWMgaW50 IG1lc29uX25mY19yZWFkX3BhZ2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gPj4gIHN0 YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwg dTggKmJ1ZiwKPiA+PiAgCQkJCSAgIGludCBvb2JfcmVxdWlyZWQsIGludCBwYWdlKQo+ID4+ICB7 Cj4gPj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+ICAJ dTggKm9vYl9idWYgPSBuYW5kLT5vb2JfcG9pOwo+ID4+ICAJaW50IHJldDsKPiA+PiAgCj4gPj4g KwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsgIAo+ID4gCj4gPiBJJ20gc3VycHJp c2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0aGUgZW50aXJlIE9PQj8gIAo+IAo+IFllcyEgU2Vl bXMgaW4gY2FzZSBvZiByYXcgYWNjZXNzICh3aGF0IGkgc2VlIGluIHRoaXMgZHJpdmVyKSBudW1i ZXIgb2YgT09CIGJ5dGVzIHJlYWQKPiBzdGlsbCBkZXBlbmRzIG9uIEVDQyBwYXJhbWV0ZXJzOiBm b3IgZWFjaCBwb3J0aW9uIG9mIGRhdGEgY292ZXJlZCB3aXRoIEVDQyBjb2RlIHdlIGNhbgo+IHJl YWQgaXQncyBFQ0MgY29kZSBhbmQgInVzZXIgYnl0ZXMiIGZyb20gT09CIC0gaXQgaXMgd2hhdCBp IHNlZSBieSBkdW1waW5nIERNQSBidWZmZXIgYnkKPiBwcmludGsoKS4gRm9yIGV4YW1wbGUgSSdt IHdvcmtpbmcgd2l0aCAySyBOQU5EIHBhZ2VzLCBlYWNoIHBhZ2UgaGFzIDIgeCAxSyBFQ0MgYmxv Y2tzLgo+IEZvciBlYWNoIEVDQyBibG9jayBJIGhhdmUgMTYgT09CIGJ5dGVzIHdoaWNoIEkgY2Fu IGFjY2VzcyBieSByZWFkL3dyaXRlLiBFYWNoIDE2IGJ5dGVzCj4gY29udGFpbnMgMiBieXRlcyBv ZiB1c2VyJ3MgZGF0YSBhbmQgMTQgYnl0ZXMgRUNDIGNvZGVzLiBTbyB3aGVuIEkgcmVhZCBwYWdl IGluIHJhdyBtb2RlCj4gY29udHJvbGxlciByZXR1cm5zIDMyIGJ5dGVzICgyIHggKDIgKyAxNCkp IG9mIE9PQi4gV2hpbGUgT09CIGlzIHJlcG9ydGVkIGFzIDY0IGJ5dGVzLgoKSW4gYWxsIG1vZGVz LCB3aGVuIHlvdSByZWFkIE9PQiwgeW91IHNob3VsZCBnZXQgdGhlIGZ1bGwgT09CLiBUaGUgZmFj dAp0aGF0IEVDQyBjb3JyZWN0aW9uIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQgZG9lcyBub3QgbWF0 dGVyLiBJZiB0aGUgTkFORApmZWF0dXJlcyBPT0Igc2VjdGlvbnMgb2YgNjQgYnl0ZXMsIHlvdSBz aG91bGQgZ2V0IHRoZSA2NCBieXRlcy4KCldoYXQgaGFwcGVucyBzb21ldGltZXMsIGlzIHRoYXQg c29tZSBvZiB0aGUgYnl0ZXMgYXJlIG5vdCBwcm90ZWN0ZWQKYWdhaW5zdCBiaXRmbGlwcywgYnV0 IHRoZSBwb2xpY3kgaXMgdG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4KCj4gCj4gVGhhbmtzLCBB cnNlbml5Cj4gCj4gPiAgIAo+ID4+ICsKPiA+PiAgCXJldCA9IG1lc29uX25mY19yZWFkX3BhZ2Vf c3ViKG5hbmQsIHBhZ2UsIDEpOwo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlyZXR1cm4gcmV0Owo+ ID4+IEBAIC04ODEsNiArODg0LDggQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcmVhZF9wYWdlX2h3 ZWNjKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpidWYsCj4gPj4gIAl1OCAqb29iX2J1ZiA9 IG5hbmQtPm9vYl9wb2k7Cj4gPj4gIAlpbnQgcmV0LCBpOwo+ID4+ICAKPiA+PiArCW1lbXNldChv b2JfYnVmLCAwLCBtdGQtPm9vYnNpemUpOwo+ID4+ICsKPiA+PiAgCXJldCA9IG1lc29uX25mY19y ZWFkX3BhZ2Vfc3ViKG5hbmQsIHBhZ2UsIDApOwo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlyZXR1 cm4gcmV0OyAgCj4gPiAKPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobCAgCgoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A197C77B71 for ; Wed, 12 Apr 2023 09:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231515AbjDLJhD (ORCPT ); Wed, 12 Apr 2023 05:37:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbjDLJhB (ORCPT ); Wed, 12 Apr 2023 05:37:01 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5D5C139 for ; Wed, 12 Apr 2023 02:36:58 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 55AE11C0016; Wed, 12 Apr 2023 09:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681292217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjAW3sbnqjC4RD0jM6Lfr+B+vyxCfa8273h/4IpoFAI=; b=W+a/1wnc3Yf9nMGLvyToyer/4s32mDzQcVuiqsEQAORqqeroXYGnnmyqM1luAsPxHGAxY8 y9wIBoK2H4KBIKbJZAvv10MwQSQssxV8h875/K2cH/NqFtputacVb8EguSdhS5IF/rLYup fwa2pexXTUf+TjnIuKLgcARBVScdt8JJWz28ARJ/o+5TsMjwcQBnhzef/pIejEEngIboz7 kmzxLM9F46nQcW0N/+l1HjLkxoWbBnDkc9qSCs68r+ADXYP3aOBUq65np/DRP49kRSf/1A s0HkjTC6qa40BJeB1iI9HRGs1RvQSFjZhEtRYSIZBY0a23YKzl/DiKQ78rXjMw== Date: Wed, 12 Apr 2023 11:36:54 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412113654.183350d0@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 12:20:55 +0300: > On 12.04.2023 10:44, Miquel Raynal wrote: > > Hi Arseniy, > >=20 > > AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:58 +0300: > > =20 > >> This NAND reads only few user's bytes in ECC mode (not full OOB), so = =20 > >=20 > > "This NAND reads" does not look right, do you mean "Subpage reads do > > not retrieve all the OOB bytes,"? > > =20 > >> fill OOB buffer with zeroes to not return garbage from previous reads > >> to user. > >> Otherwise 'nanddump' utility prints something like this for just erased > >> page: > >> > >> ... > >> 0x000007f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > >> OOB Data: ff ff ff ff 00 00 ff ff 80 cf 22 99 cb ad d3 be > >> OOB Data: 63 27 ae 06 16 0a 2f eb bb dd 46 74 41 8e 88 6e > >> OOB Data: 38 a1 2d e6 77 d4 05 06 f2 a5 7e 25 eb 34 7c ff > >> OOB Data: 38 ea de 14 10 de 9b 40 33 16 6a cc 9d aa 2f 5e > >> > >> Signed-off-by: Arseniy Krasnov > >> --- > >> drivers/mtd/nand/raw/meson_nand.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/= meson_nand.c > >> index f84a10238e4d..f2f2472cb511 100644 > >> --- a/drivers/mtd/nand/raw/meson_nand.c > >> +++ b/drivers/mtd/nand/raw/meson_nand.c > >> @@ -858,9 +858,12 @@ static int meson_nfc_read_page_sub(struct nand_ch= ip *nand, > >> static int meson_nfc_read_page_raw(struct nand_chip *nand, u8 *buf, > >> int oob_required, int page) > >> { > >> + struct mtd_info *mtd =3D nand_to_mtd(nand); > >> u8 *oob_buf =3D nand->oob_poi; > >> int ret; > >> =20 > >> + memset(oob_buf, 0, mtd->oobsize); =20 > >=20 > > I'm surprised raw reads do not read the entire OOB? =20 >=20 > Yes! Seems in case of raw access (what i see in this driver) number of OO= B bytes read > still depends on ECC parameters: for each portion of data covered with EC= C code we can > read it's ECC code and "user bytes" from OOB - it is what i see by dumpin= g DMA buffer by > printk(). For example I'm working with 2K NAND pages, each page has 2 x 1= K ECC blocks. > For each ECC block I have 16 OOB bytes which I can access by read/write. = Each 16 bytes > contains 2 bytes of user's data and 14 bytes ECC codes. So when I read pa= ge in raw mode > controller returns 32 bytes (2 x (2 + 14)) of OOB. While OOB is reported = as 64 bytes. In all modes, when you read OOB, you should get the full OOB. The fact that ECC correction is enabled or disabled does not matter. If the NAND features OOB sections of 64 bytes, you should get the 64 bytes. What happens sometimes, is that some of the bytes are not protected against bitflips, but the policy is to return the full buffer. >=20 > Thanks, Arseniy >=20 > > =20 > >> + > >> ret =3D meson_nfc_read_page_sub(nand, page, 1); > >> if (ret) > >> return ret; > >> @@ -881,6 +884,8 @@ static int meson_nfc_read_page_hwecc(struct nand_c= hip *nand, u8 *buf, > >> u8 *oob_buf =3D nand->oob_poi; > >> int ret, i; > >> =20 > >> + memset(oob_buf, 0, mtd->oobsize); > >> + > >> ret =3D meson_nfc_read_page_sub(nand, page, 0); > >> if (ret) > >> return ret; =20 > >=20 > >=20 > > Thanks, > > Miqu=C3=A8l =20 Thanks, Miqu=C3=A8l