From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C29E2C77B6E for ; Wed, 12 Apr 2023 12:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06xMxRSyCwXs2rstnDhpLEBP4B4Z/hr2R6lLYX/f07o=; b=ZiSkCljTwYXFoM 75mlXLsgMHujsIvKN13kXWt3a50Sm1w+pXOynCNNf5OcDxOnQijTyf7SJx11mUnTzUHIt4l8EsORA LqjYUZT0c5ffUS5S+B3UIRE567FLSX6jMi2LN0mIocykhFLwh3ipbUdwgHN6uv3dgiZIrW6+B3Kft vadf2NchBou2wYuxi20112hgRnNievbUQy0DEGL62082qkXbZHn6s9Z2EnS5kXO9UQjzM33A62K0N 5J+oqBTHehDiD1zEipgf4WaviDKhg3Y+uxPdckGVAMIy8rNwrUwLUpMmxEGPWYK1KLLtja73phNtm MqH+OIlLzHkMDvG+FXjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pma2Q-003Ed8-0h; Wed, 12 Apr 2023 12:57:26 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pma2M-003Ebm-0T; Wed, 12 Apr 2023 12:57:24 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1BB20100012; Wed, 12 Apr 2023 12:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681304237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9OeBGkyxviQ45xtIDss2eS2Kn0s5eylHaRXiAWIfUL8=; b=LPNpkMyOIdzbu40qsrGXMQRoMuPs3jK4MPjKM92k4BSt0OjZd0zs4W7S6nD/aEiCQzH8oA lD4LH/NrXixYJbYm+UdF2AzM55S7EMBD7bagbTRgvH2Sk4yR3Aox+H2ifeQez9TxulI8/0 rsIkaHSemafO6lsxbq2OHcLleZgCEoxAArFUllu8VrC5DeJJ0Ze+R4AynFqp+CpgXJgE0U DHv/aTXOmP4pDgncoSwrEQDIRqpAg96rzGuDFcczdfp1EXKYUuHvJELkiDD9+dspXetoaP dogNUwz6kUOfsyKorNp4ofcI2Xg4jb94Dl8BPRy+84qyhpxOVMf/PdL9vXwfZQ== Date: Wed, 12 Apr 2023 14:57:15 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412145715.58c2be4a@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_055722_660496_DA2241C0 X-CRM114-Status: GOOD ( 29.39 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDE1OjIyOjI2ICswMzAwOgoKPiBPbiAxMi4wNC4yMDIzIDE1OjE4LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gYXZrcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMTM6MTQ6NTIgKzAzMDA6Cj4gPiAgIAo+ID4+ IE9uIDEyLjA0LjIwMjMgMTI6MzYsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAKPiA+Pj4gSGkgQXJz ZW5peSwKPiA+Pj4KPiA+Pj4gYXZrcmFzbm92QHNiZXJkZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwg MTIgQXByIDIwMjMgMTI6MjA6NTUgKzAzMDA6Cj4gPj4+ICAgICAKPiA+Pj4+IE9uIDEyLjA0LjIw MjMgMTA6NDQsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAgIAo+ID4+Pj4+IEhpIEFyc2VuaXksCj4g Pj4+Pj4KPiA+Pj4+PiBBVktyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBB cHIgMjAyMyAwOToxNjo1OCArMDMwMDoKPiA+Pj4+PiAgICAgICAKPiA+Pj4+Pj4gVGhpcyBOQU5E IHJlYWRzIG9ubHkgZmV3IHVzZXIncyBieXRlcyBpbiBFQ0MgbW9kZSAobm90IGZ1bGwgT09CKSwg c28gICAgICAKPiA+Pj4+Pgo+ID4+Pj4+ICJUaGlzIE5BTkQgcmVhZHMiIGRvZXMgbm90IGxvb2sg cmlnaHQsIGRvIHlvdSBtZWFuICJTdWJwYWdlIHJlYWRzIGRvCj4gPj4+Pj4gbm90IHJldHJpZXZl IGFsbCB0aGUgT09CIGJ5dGVzLCI/Cj4gPj4+Pj4gICAgICAgCj4gPj4+Pj4+IGZpbGwgT09CIGJ1 ZmZlciB3aXRoIHplcm9lcyB0byBub3QgcmV0dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFk cwo+ID4+Pj4+PiB0byB1c2VyLgo+ID4+Pj4+PiBPdGhlcndpc2UgJ25hbmRkdW1wJyB1dGlsaXR5 IHByaW50cyBzb21ldGhpbmcgbGlrZSB0aGlzIGZvciBqdXN0IGVyYXNlZAo+ID4+Pj4+PiBwYWdl Ogo+ID4+Pj4+Pgo+ID4+Pj4+PiAuLi4KPiA+Pj4+Pj4gMHgwMDAwMDdmMDogZmYgZmYgZmYgZmYg ZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYKPiA+Pj4+Pj4gICBPT0IgRGF0YTog ZmYgZmYgZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiA+Pj4+Pj4g ICBPT0IgRGF0YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODgg NmUKPiA+Pj4+Pj4gICBPT0IgRGF0YTogMzggYTEgMmQgZTYgNzcgZDQgMDUgMDYgZjIgYTUgN2Ug MjUgZWIgMzQgN2MgZmYKPiA+Pj4+Pj4gICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIg NDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pj4+Pj4KPiA+Pj4+Pj4gU2lnbmVkLW9mZi1i eTogQXJzZW5peSBLcmFzbm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+Cj4gPj4+Pj4+IC0t LQo+ID4+Pj4+PiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgNSArKysrKwo+ ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pgo+ID4+Pj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIGIvZHJpdmVy cy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gPj4+Pj4+IGluZGV4IGY4NGExMDIzOGU0ZC4u ZjJmMjQ3MmNiNTExIDEwMDY0NAo+ID4+Pj4+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9t ZXNvbl9uYW5kLmMKPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFu ZC5jCj4gPj4+Pj4+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3Jl YWRfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+Pj4+Pj4gIHN0YXRpYyBpbnQg bWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1ZiwK PiA+Pj4+Pj4gIAkJCQkgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+Pj4+Pj4gIHsK PiA+Pj4+Pj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+ Pj4+PiAgCXU4ICpvb2JfYnVmID0gbmFuZC0+b29iX3BvaTsKPiA+Pj4+Pj4gIAlpbnQgcmV0Owo+ ID4+Pj4+PiAgCj4gPj4+Pj4+ICsJbWVtc2V0KG9vYl9idWYsIDAsIG10ZC0+b29ic2l6ZSk7ICAg ICAgCj4gPj4+Pj4KPiA+Pj4+PiBJJ20gc3VycHJpc2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0 aGUgZW50aXJlIE9PQj8gICAgICAKPiA+Pj4+Cj4gPj4+PiBZZXMhIFNlZW1zIGluIGNhc2Ugb2Yg cmF3IGFjY2VzcyAod2hhdCBpIHNlZSBpbiB0aGlzIGRyaXZlcikgbnVtYmVyIG9mIE9PQiBieXRl cyByZWFkCj4gPj4+PiBzdGlsbCBkZXBlbmRzIG9uIEVDQyBwYXJhbWV0ZXJzOiBmb3IgZWFjaCBw b3J0aW9uIG9mIGRhdGEgY292ZXJlZCB3aXRoIEVDQyBjb2RlIHdlIGNhbgo+ID4+Pj4gcmVhZCBp dCdzIEVDQyBjb2RlIGFuZCAidXNlciBieXRlcyIgZnJvbSBPT0IgLSBpdCBpcyB3aGF0IGkgc2Vl IGJ5IGR1bXBpbmcgRE1BIGJ1ZmZlciBieQo+ID4+Pj4gcHJpbnRrKCkuIEZvciBleGFtcGxlIEkn bSB3b3JraW5nIHdpdGggMksgTkFORCBwYWdlcywgZWFjaCBwYWdlIGhhcyAyIHggMUsgRUNDIGJs b2Nrcy4KPiA+Pj4+IEZvciBlYWNoIEVDQyBibG9jayBJIGhhdmUgMTYgT09CIGJ5dGVzIHdoaWNo IEkgY2FuIGFjY2VzcyBieSByZWFkL3dyaXRlLiBFYWNoIDE2IGJ5dGVzCj4gPj4+PiBjb250YWlu cyAyIGJ5dGVzIG9mIHVzZXIncyBkYXRhIGFuZCAxNCBieXRlcyBFQ0MgY29kZXMuIFNvIHdoZW4g SSByZWFkIHBhZ2UgaW4gcmF3IG1vZGUKPiA+Pj4+IGNvbnRyb2xsZXIgcmV0dXJucyAzMiBieXRl cyAoMiB4ICgyICsgMTQpKSBvZiBPT0IuIFdoaWxlIE9PQiBpcyByZXBvcnRlZCBhcyA2NCBieXRl cy4gICAgCj4gPj4+Cj4gPj4+IEluIGFsbCBtb2Rlcywgd2hlbiB5b3UgcmVhZCBPT0IsIHlvdSBz aG91bGQgZ2V0IHRoZSBmdWxsIE9PQi4gVGhlIGZhY3QKPiA+Pj4gdGhhdCBFQ0MgY29ycmVjdGlv biBpcyBlbmFibGVkIG9yIGRpc2FibGVkIGRvZXMgbm90IG1hdHRlci4gSWYgdGhlIE5BTkQKPiA+ Pj4gZmVhdHVyZXMgT09CIHNlY3Rpb25zIG9mIDY0IGJ5dGVzLCB5b3Ugc2hvdWxkIGdldCB0aGUg NjQgYnl0ZXMuCj4gPj4+Cj4gPj4+IFdoYXQgaGFwcGVucyBzb21ldGltZXMsIGlzIHRoYXQgc29t ZSBvZiB0aGUgYnl0ZXMgYXJlIG5vdCBwcm90ZWN0ZWQKPiA+Pj4gYWdhaW5zdCBiaXRmbGlwcywg YnV0IHRoZSBwb2xpY3kgaXMgdG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4gICAgCj4gPj4KPiA+ PiBPaywgc28gdG8gY2xhcmlmeSBjYXNlIGZvciB0aGlzIE5BTkQgY29udHJvbGxlcjoKPiA+PiAx KSBJbiBib3RoIEVDQyBhbmQgcmF3IG1vZGVzIGkgbmVlZCB0byByZXR1cm4gdGhlIHNhbWUgcmF3 IE9PQiBkYXRhIChlLmcuIHVzZXIgYnl0ZXMKPiA+PiAgICArIEVDQyBjb2Rlcyk/ICAKPiA+IAo+ ID4gV2VsbCwgeW91IG5lZWQgdG8gY292ZXIgdGhlIHNhbWUgYW1vdW50IG9mIGRhdGEsIHllcy4g QnV0IGluIHRoZSBFQ0MKPiA+IGNhc2UgdGhlIGRhdGEgd29uJ3QgYmUgcmF3IChhdCBsZWFzdCBu b3QgYWxsIG9mIGl0KS4gIAo+IAo+IFNvICJzYW1lIGFtb3VudCBvZiBkYXRhIiwgaW4gRUNDIG1v ZGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiByZXR1cm5zIG9ubHkgdXNlciBPT0IgYnl0ZXMgKGUu Zy4KPiBPT0IgZGF0YSBleGNsdWRpbmcgRUNDIGNvZGVzKSwgaW4gcmF3IGl0IHJldHVybnMgdXNl ciBieXRlcyArIEVDQyBjb2Rlcy4gSUlVQyBjb3JyZWN0Cj4gYmVoYXZpb3VyIGlzIHRvIGFsd2F5 cyByZXR1cm4gdXNlciBieXRlcyArIEVDQyBjb2RlcyBhcyBPT0IgZGF0YSBldmVuIGluIEVDQyBt b2RlID8KCklmIHRoZSBwYWdlIGFyZSAyays2NEIgeW91IHNob3VsZCByZWFkIDJrKzY0QiB3aGVu IE9PQiBhcmUgcmVxdWVzdGVkLgoKSWYgdGhlIGNvbnRyb2xsZXIgb25seSByZXR1cm5zIDJrKzMy QiwgdGhlbiBwZXJmb3JtIGEgcmFuZG9tIHJlYWQgdG8KanVzdCBtb3ZlIHRoZSByZWFkIHBvaW50 ZXIgdG8gbXRkLT5zaXplICsgbXRkLT5vb2JzaXplIC0gMzIgYW5kCnJldHJpZXZlIHRoZSBtaXNz aW5nIDMyIGJ5dGVzPwoKVGhpcyBhcHBsaWVzIHRvIHRoZSB0d28gbW9kZXMsIHRoZSBvbmx5IGRp ZmZlcmVuY2UgaXM6Ci0gd2l0aCBjb3JyZWN0aW9uIChjb21tb25seSBuYW1lZCAiRUNDIG1vZGUi KTogdGhlIHVzZXIgYnl0ZXMgYW5kIEVDQwogIGJ5dGVzIHNob3VsZCBiZSBmaXhlZCBpZiB0aGVy ZSBhcmUgYW55IGJpdGZsaXBzCi0gd2l0aG91dCBjb3JyZWN0aW9uIChjb21tb25seSByZWZlcnJl ZCBhcyAicmF3IG1vZGUiKTogbm8gY29ycmVjdGlvbgogIGFwcGxpZXMsIGlmIHRoZXJlIGFyZSBi aXRmbGlwcywgZ2l2ZSB0aGVtCgpQbGVhc2UgbWluZCB0aGUgcmF3IG1vZGUgY2FuIGJlIHNsb3cs IGl0J3MgbWVhbnQgZm9yIGRlYnVnZ2luZyBhbmQKdGVzdGluZywgbWFpbmx5LiBQYWdlIHJlYWRz IGhvd2V2ZXIgc2hvdWxkIGJlIGZhc3QsIHNvIGlmIGp1c3QgbW92aW5nCnRoZSBjb2x1bW4gcG9p bnRlciB3b3JrcywgdGhlbiBkbyBpdCwgb3RoZXJ3aXNlIHdlJ2xsIGNvbnNpZGVyCnJldHVybmlu ZyBGRnMuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 147E4C7619A for ; Wed, 12 Apr 2023 12:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D817a9AQ5ggvTMwGXGwQTHRAe+EEHOTnepAkp7NmuVo=; b=Mu0pEiZbo0REh/ NO/kgmB2k8zbcfObUg3aOYRt5OHZlCwIUFVPQQ9YAZyqvbVB3i4j4+yepbhBxSN8weA4h9bLmyGbV PSRwFanmPelwuuoUy04sEgpB321w2j11I46b+sG6DYWGXu9n7NwHkXjjIaF8D6At85FZx++t3qLpK 1gx8LCqazO8rF9MJNMPzPLtmErC3xXXvMJ1lzzPuvTQiB5KdwGgeBcXgU1g9acoizplLRpOSuvby5 EuoTgTpVZ24yHo2zqqLgcWHgQwJKzzgCBrIrxua2iuBCgudUP4o4TDU1vn9epjBiVna1L9O9UZ6n1 A1CGHGDtxsLOqAZCZGsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pma2R-003EdS-25; Wed, 12 Apr 2023 12:57:27 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pma2M-003Ebm-0T; Wed, 12 Apr 2023 12:57:24 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1BB20100012; Wed, 12 Apr 2023 12:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681304237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9OeBGkyxviQ45xtIDss2eS2Kn0s5eylHaRXiAWIfUL8=; b=LPNpkMyOIdzbu40qsrGXMQRoMuPs3jK4MPjKM92k4BSt0OjZd0zs4W7S6nD/aEiCQzH8oA lD4LH/NrXixYJbYm+UdF2AzM55S7EMBD7bagbTRgvH2Sk4yR3Aox+H2ifeQez9TxulI8/0 rsIkaHSemafO6lsxbq2OHcLleZgCEoxAArFUllu8VrC5DeJJ0Ze+R4AynFqp+CpgXJgE0U DHv/aTXOmP4pDgncoSwrEQDIRqpAg96rzGuDFcczdfp1EXKYUuHvJELkiDD9+dspXetoaP dogNUwz6kUOfsyKorNp4ofcI2Xg4jb94Dl8BPRy+84qyhpxOVMf/PdL9vXwfZQ== Date: Wed, 12 Apr 2023 14:57:15 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412145715.58c2be4a@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_055722_660496_DA2241C0 X-CRM114-Status: GOOD ( 29.39 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDE1OjIyOjI2ICswMzAwOgoKPiBPbiAxMi4wNC4yMDIzIDE1OjE4LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gYXZrcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMTM6MTQ6NTIgKzAzMDA6Cj4gPiAgIAo+ID4+ IE9uIDEyLjA0LjIwMjMgMTI6MzYsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAKPiA+Pj4gSGkgQXJz ZW5peSwKPiA+Pj4KPiA+Pj4gYXZrcmFzbm92QHNiZXJkZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwg MTIgQXByIDIwMjMgMTI6MjA6NTUgKzAzMDA6Cj4gPj4+ICAgICAKPiA+Pj4+IE9uIDEyLjA0LjIw MjMgMTA6NDQsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAgIAo+ID4+Pj4+IEhpIEFyc2VuaXksCj4g Pj4+Pj4KPiA+Pj4+PiBBVktyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBB cHIgMjAyMyAwOToxNjo1OCArMDMwMDoKPiA+Pj4+PiAgICAgICAKPiA+Pj4+Pj4gVGhpcyBOQU5E IHJlYWRzIG9ubHkgZmV3IHVzZXIncyBieXRlcyBpbiBFQ0MgbW9kZSAobm90IGZ1bGwgT09CKSwg c28gICAgICAKPiA+Pj4+Pgo+ID4+Pj4+ICJUaGlzIE5BTkQgcmVhZHMiIGRvZXMgbm90IGxvb2sg cmlnaHQsIGRvIHlvdSBtZWFuICJTdWJwYWdlIHJlYWRzIGRvCj4gPj4+Pj4gbm90IHJldHJpZXZl IGFsbCB0aGUgT09CIGJ5dGVzLCI/Cj4gPj4+Pj4gICAgICAgCj4gPj4+Pj4+IGZpbGwgT09CIGJ1 ZmZlciB3aXRoIHplcm9lcyB0byBub3QgcmV0dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFk cwo+ID4+Pj4+PiB0byB1c2VyLgo+ID4+Pj4+PiBPdGhlcndpc2UgJ25hbmRkdW1wJyB1dGlsaXR5 IHByaW50cyBzb21ldGhpbmcgbGlrZSB0aGlzIGZvciBqdXN0IGVyYXNlZAo+ID4+Pj4+PiBwYWdl Ogo+ID4+Pj4+Pgo+ID4+Pj4+PiAuLi4KPiA+Pj4+Pj4gMHgwMDAwMDdmMDogZmYgZmYgZmYgZmYg ZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYKPiA+Pj4+Pj4gICBPT0IgRGF0YTog ZmYgZmYgZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiA+Pj4+Pj4g ICBPT0IgRGF0YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODgg NmUKPiA+Pj4+Pj4gICBPT0IgRGF0YTogMzggYTEgMmQgZTYgNzcgZDQgMDUgMDYgZjIgYTUgN2Ug MjUgZWIgMzQgN2MgZmYKPiA+Pj4+Pj4gICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIg NDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pj4+Pj4KPiA+Pj4+Pj4gU2lnbmVkLW9mZi1i eTogQXJzZW5peSBLcmFzbm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+Cj4gPj4+Pj4+IC0t LQo+ID4+Pj4+PiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgNSArKysrKwo+ ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pgo+ID4+Pj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIGIvZHJpdmVy cy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gPj4+Pj4+IGluZGV4IGY4NGExMDIzOGU0ZC4u ZjJmMjQ3MmNiNTExIDEwMDY0NAo+ID4+Pj4+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9t ZXNvbl9uYW5kLmMKPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFu ZC5jCj4gPj4+Pj4+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3Jl YWRfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+Pj4+Pj4gIHN0YXRpYyBpbnQg bWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1ZiwK PiA+Pj4+Pj4gIAkJCQkgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+Pj4+Pj4gIHsK PiA+Pj4+Pj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+ Pj4+PiAgCXU4ICpvb2JfYnVmID0gbmFuZC0+b29iX3BvaTsKPiA+Pj4+Pj4gIAlpbnQgcmV0Owo+ ID4+Pj4+PiAgCj4gPj4+Pj4+ICsJbWVtc2V0KG9vYl9idWYsIDAsIG10ZC0+b29ic2l6ZSk7ICAg ICAgCj4gPj4+Pj4KPiA+Pj4+PiBJJ20gc3VycHJpc2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0 aGUgZW50aXJlIE9PQj8gICAgICAKPiA+Pj4+Cj4gPj4+PiBZZXMhIFNlZW1zIGluIGNhc2Ugb2Yg cmF3IGFjY2VzcyAod2hhdCBpIHNlZSBpbiB0aGlzIGRyaXZlcikgbnVtYmVyIG9mIE9PQiBieXRl cyByZWFkCj4gPj4+PiBzdGlsbCBkZXBlbmRzIG9uIEVDQyBwYXJhbWV0ZXJzOiBmb3IgZWFjaCBw b3J0aW9uIG9mIGRhdGEgY292ZXJlZCB3aXRoIEVDQyBjb2RlIHdlIGNhbgo+ID4+Pj4gcmVhZCBp dCdzIEVDQyBjb2RlIGFuZCAidXNlciBieXRlcyIgZnJvbSBPT0IgLSBpdCBpcyB3aGF0IGkgc2Vl IGJ5IGR1bXBpbmcgRE1BIGJ1ZmZlciBieQo+ID4+Pj4gcHJpbnRrKCkuIEZvciBleGFtcGxlIEkn bSB3b3JraW5nIHdpdGggMksgTkFORCBwYWdlcywgZWFjaCBwYWdlIGhhcyAyIHggMUsgRUNDIGJs b2Nrcy4KPiA+Pj4+IEZvciBlYWNoIEVDQyBibG9jayBJIGhhdmUgMTYgT09CIGJ5dGVzIHdoaWNo IEkgY2FuIGFjY2VzcyBieSByZWFkL3dyaXRlLiBFYWNoIDE2IGJ5dGVzCj4gPj4+PiBjb250YWlu cyAyIGJ5dGVzIG9mIHVzZXIncyBkYXRhIGFuZCAxNCBieXRlcyBFQ0MgY29kZXMuIFNvIHdoZW4g SSByZWFkIHBhZ2UgaW4gcmF3IG1vZGUKPiA+Pj4+IGNvbnRyb2xsZXIgcmV0dXJucyAzMiBieXRl cyAoMiB4ICgyICsgMTQpKSBvZiBPT0IuIFdoaWxlIE9PQiBpcyByZXBvcnRlZCBhcyA2NCBieXRl cy4gICAgCj4gPj4+Cj4gPj4+IEluIGFsbCBtb2Rlcywgd2hlbiB5b3UgcmVhZCBPT0IsIHlvdSBz aG91bGQgZ2V0IHRoZSBmdWxsIE9PQi4gVGhlIGZhY3QKPiA+Pj4gdGhhdCBFQ0MgY29ycmVjdGlv biBpcyBlbmFibGVkIG9yIGRpc2FibGVkIGRvZXMgbm90IG1hdHRlci4gSWYgdGhlIE5BTkQKPiA+ Pj4gZmVhdHVyZXMgT09CIHNlY3Rpb25zIG9mIDY0IGJ5dGVzLCB5b3Ugc2hvdWxkIGdldCB0aGUg NjQgYnl0ZXMuCj4gPj4+Cj4gPj4+IFdoYXQgaGFwcGVucyBzb21ldGltZXMsIGlzIHRoYXQgc29t ZSBvZiB0aGUgYnl0ZXMgYXJlIG5vdCBwcm90ZWN0ZWQKPiA+Pj4gYWdhaW5zdCBiaXRmbGlwcywg YnV0IHRoZSBwb2xpY3kgaXMgdG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4gICAgCj4gPj4KPiA+ PiBPaywgc28gdG8gY2xhcmlmeSBjYXNlIGZvciB0aGlzIE5BTkQgY29udHJvbGxlcjoKPiA+PiAx KSBJbiBib3RoIEVDQyBhbmQgcmF3IG1vZGVzIGkgbmVlZCB0byByZXR1cm4gdGhlIHNhbWUgcmF3 IE9PQiBkYXRhIChlLmcuIHVzZXIgYnl0ZXMKPiA+PiAgICArIEVDQyBjb2Rlcyk/ICAKPiA+IAo+ ID4gV2VsbCwgeW91IG5lZWQgdG8gY292ZXIgdGhlIHNhbWUgYW1vdW50IG9mIGRhdGEsIHllcy4g QnV0IGluIHRoZSBFQ0MKPiA+IGNhc2UgdGhlIGRhdGEgd29uJ3QgYmUgcmF3IChhdCBsZWFzdCBu b3QgYWxsIG9mIGl0KS4gIAo+IAo+IFNvICJzYW1lIGFtb3VudCBvZiBkYXRhIiwgaW4gRUNDIG1v ZGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiByZXR1cm5zIG9ubHkgdXNlciBPT0IgYnl0ZXMgKGUu Zy4KPiBPT0IgZGF0YSBleGNsdWRpbmcgRUNDIGNvZGVzKSwgaW4gcmF3IGl0IHJldHVybnMgdXNl ciBieXRlcyArIEVDQyBjb2Rlcy4gSUlVQyBjb3JyZWN0Cj4gYmVoYXZpb3VyIGlzIHRvIGFsd2F5 cyByZXR1cm4gdXNlciBieXRlcyArIEVDQyBjb2RlcyBhcyBPT0IgZGF0YSBldmVuIGluIEVDQyBt b2RlID8KCklmIHRoZSBwYWdlIGFyZSAyays2NEIgeW91IHNob3VsZCByZWFkIDJrKzY0QiB3aGVu IE9PQiBhcmUgcmVxdWVzdGVkLgoKSWYgdGhlIGNvbnRyb2xsZXIgb25seSByZXR1cm5zIDJrKzMy QiwgdGhlbiBwZXJmb3JtIGEgcmFuZG9tIHJlYWQgdG8KanVzdCBtb3ZlIHRoZSByZWFkIHBvaW50 ZXIgdG8gbXRkLT5zaXplICsgbXRkLT5vb2JzaXplIC0gMzIgYW5kCnJldHJpZXZlIHRoZSBtaXNz aW5nIDMyIGJ5dGVzPwoKVGhpcyBhcHBsaWVzIHRvIHRoZSB0d28gbW9kZXMsIHRoZSBvbmx5IGRp ZmZlcmVuY2UgaXM6Ci0gd2l0aCBjb3JyZWN0aW9uIChjb21tb25seSBuYW1lZCAiRUNDIG1vZGUi KTogdGhlIHVzZXIgYnl0ZXMgYW5kIEVDQwogIGJ5dGVzIHNob3VsZCBiZSBmaXhlZCBpZiB0aGVy ZSBhcmUgYW55IGJpdGZsaXBzCi0gd2l0aG91dCBjb3JyZWN0aW9uIChjb21tb25seSByZWZlcnJl ZCBhcyAicmF3IG1vZGUiKTogbm8gY29ycmVjdGlvbgogIGFwcGxpZXMsIGlmIHRoZXJlIGFyZSBi aXRmbGlwcywgZ2l2ZSB0aGVtCgpQbGVhc2UgbWluZCB0aGUgcmF3IG1vZGUgY2FuIGJlIHNsb3cs IGl0J3MgbWVhbnQgZm9yIGRlYnVnZ2luZyBhbmQKdGVzdGluZywgbWFpbmx5LiBQYWdlIHJlYWRz IGhvd2V2ZXIgc2hvdWxkIGJlIGZhc3QsIHNvIGlmIGp1c3QgbW92aW5nCnRoZSBjb2x1bW4gcG9p bnRlciB3b3JrcywgdGhlbiBkbyBpdCwgb3RoZXJ3aXNlIHdlJ2xsIGNvbnNpZGVyCnJldHVybmlu ZyBGRnMuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 685EFC7619A for ; Wed, 12 Apr 2023 12:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lcg1ZGiMVGbUbG4LpKbAWCaF5XGC5uSNw4lwR0oVBXA=; b=juloQvanjD8tJ2 QwS6aLNnY0hKKXK7AgWvOFGBcQUE3tkcLToz+cuU6ukfh/P1aPYzXXg7mCNxxyW2xQ4An71zMv45u 6erbcVf2/4J6PFgSNc+qXj1VgEeBAVNu5A5ZlJdvNeopQFWj7MC3gOW8Esnbxvlp85NbXZEFvHX8o XYlVeI9VjJJup47o4jgC0R7S3qZD/xzNkIr9cMjLbcsYvBPhuU0nlfFZ1cO+H0HFHOYSvpOoe2x23 ROntqGFKE0DsOTzUqs6GTQHd7r64dNHVwfHr11yTj8rDziPd9NoX2Y7mHKRjXI4XZ3LlVgKs7jXwo DaVCFf059mgtlXUiB95g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pma2Q-003EdG-2A; Wed, 12 Apr 2023 12:57:26 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pma2M-003Ebm-0T; Wed, 12 Apr 2023 12:57:24 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1BB20100012; Wed, 12 Apr 2023 12:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681304237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9OeBGkyxviQ45xtIDss2eS2Kn0s5eylHaRXiAWIfUL8=; b=LPNpkMyOIdzbu40qsrGXMQRoMuPs3jK4MPjKM92k4BSt0OjZd0zs4W7S6nD/aEiCQzH8oA lD4LH/NrXixYJbYm+UdF2AzM55S7EMBD7bagbTRgvH2Sk4yR3Aox+H2ifeQez9TxulI8/0 rsIkaHSemafO6lsxbq2OHcLleZgCEoxAArFUllu8VrC5DeJJ0Ze+R4AynFqp+CpgXJgE0U DHv/aTXOmP4pDgncoSwrEQDIRqpAg96rzGuDFcczdfp1EXKYUuHvJELkiDD9+dspXetoaP dogNUwz6kUOfsyKorNp4ofcI2Xg4jb94Dl8BPRy+84qyhpxOVMf/PdL9vXwfZQ== Date: Wed, 12 Apr 2023 14:57:15 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412145715.58c2be4a@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_055722_660496_DA2241C0 X-CRM114-Status: GOOD ( 29.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFw ciAyMDIzIDE1OjIyOjI2ICswMzAwOgoKPiBPbiAxMi4wNC4yMDIzIDE1OjE4LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gYXZrcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMTM6MTQ6NTIgKzAzMDA6Cj4gPiAgIAo+ID4+ IE9uIDEyLjA0LjIwMjMgMTI6MzYsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAKPiA+Pj4gSGkgQXJz ZW5peSwKPiA+Pj4KPiA+Pj4gYXZrcmFzbm92QHNiZXJkZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwg MTIgQXByIDIwMjMgMTI6MjA6NTUgKzAzMDA6Cj4gPj4+ICAgICAKPiA+Pj4+IE9uIDEyLjA0LjIw MjMgMTA6NDQsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAgIAo+ID4+Pj4+IEhpIEFyc2VuaXksCj4g Pj4+Pj4KPiA+Pj4+PiBBVktyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBB cHIgMjAyMyAwOToxNjo1OCArMDMwMDoKPiA+Pj4+PiAgICAgICAKPiA+Pj4+Pj4gVGhpcyBOQU5E IHJlYWRzIG9ubHkgZmV3IHVzZXIncyBieXRlcyBpbiBFQ0MgbW9kZSAobm90IGZ1bGwgT09CKSwg c28gICAgICAKPiA+Pj4+Pgo+ID4+Pj4+ICJUaGlzIE5BTkQgcmVhZHMiIGRvZXMgbm90IGxvb2sg cmlnaHQsIGRvIHlvdSBtZWFuICJTdWJwYWdlIHJlYWRzIGRvCj4gPj4+Pj4gbm90IHJldHJpZXZl IGFsbCB0aGUgT09CIGJ5dGVzLCI/Cj4gPj4+Pj4gICAgICAgCj4gPj4+Pj4+IGZpbGwgT09CIGJ1 ZmZlciB3aXRoIHplcm9lcyB0byBub3QgcmV0dXJuIGdhcmJhZ2UgZnJvbSBwcmV2aW91cyByZWFk cwo+ID4+Pj4+PiB0byB1c2VyLgo+ID4+Pj4+PiBPdGhlcndpc2UgJ25hbmRkdW1wJyB1dGlsaXR5 IHByaW50cyBzb21ldGhpbmcgbGlrZSB0aGlzIGZvciBqdXN0IGVyYXNlZAo+ID4+Pj4+PiBwYWdl Ogo+ID4+Pj4+Pgo+ID4+Pj4+PiAuLi4KPiA+Pj4+Pj4gMHgwMDAwMDdmMDogZmYgZmYgZmYgZmYg ZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYKPiA+Pj4+Pj4gICBPT0IgRGF0YTog ZmYgZmYgZmYgZmYgMDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiA+Pj4+Pj4g ICBPT0IgRGF0YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODgg NmUKPiA+Pj4+Pj4gICBPT0IgRGF0YTogMzggYTEgMmQgZTYgNzcgZDQgMDUgMDYgZjIgYTUgN2Ug MjUgZWIgMzQgN2MgZmYKPiA+Pj4+Pj4gICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAgZGUgOWIg NDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pj4+Pj4KPiA+Pj4+Pj4gU2lnbmVkLW9mZi1i eTogQXJzZW5peSBLcmFzbm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+Cj4gPj4+Pj4+IC0t LQo+ID4+Pj4+PiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgNSArKysrKwo+ ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pgo+ID4+Pj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIGIvZHJpdmVy cy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gPj4+Pj4+IGluZGV4IGY4NGExMDIzOGU0ZC4u ZjJmMjQ3MmNiNTExIDEwMDY0NAo+ID4+Pj4+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9t ZXNvbl9uYW5kLmMKPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFu ZC5jCj4gPj4+Pj4+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3Jl YWRfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+Pj4+Pj4gIHN0YXRpYyBpbnQg bWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1ZiwK PiA+Pj4+Pj4gIAkJCQkgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+Pj4+Pj4gIHsK PiA+Pj4+Pj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+ Pj4+PiAgCXU4ICpvb2JfYnVmID0gbmFuZC0+b29iX3BvaTsKPiA+Pj4+Pj4gIAlpbnQgcmV0Owo+ ID4+Pj4+PiAgCj4gPj4+Pj4+ICsJbWVtc2V0KG9vYl9idWYsIDAsIG10ZC0+b29ic2l6ZSk7ICAg ICAgCj4gPj4+Pj4KPiA+Pj4+PiBJJ20gc3VycHJpc2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0 aGUgZW50aXJlIE9PQj8gICAgICAKPiA+Pj4+Cj4gPj4+PiBZZXMhIFNlZW1zIGluIGNhc2Ugb2Yg cmF3IGFjY2VzcyAod2hhdCBpIHNlZSBpbiB0aGlzIGRyaXZlcikgbnVtYmVyIG9mIE9PQiBieXRl cyByZWFkCj4gPj4+PiBzdGlsbCBkZXBlbmRzIG9uIEVDQyBwYXJhbWV0ZXJzOiBmb3IgZWFjaCBw b3J0aW9uIG9mIGRhdGEgY292ZXJlZCB3aXRoIEVDQyBjb2RlIHdlIGNhbgo+ID4+Pj4gcmVhZCBp dCdzIEVDQyBjb2RlIGFuZCAidXNlciBieXRlcyIgZnJvbSBPT0IgLSBpdCBpcyB3aGF0IGkgc2Vl IGJ5IGR1bXBpbmcgRE1BIGJ1ZmZlciBieQo+ID4+Pj4gcHJpbnRrKCkuIEZvciBleGFtcGxlIEkn bSB3b3JraW5nIHdpdGggMksgTkFORCBwYWdlcywgZWFjaCBwYWdlIGhhcyAyIHggMUsgRUNDIGJs b2Nrcy4KPiA+Pj4+IEZvciBlYWNoIEVDQyBibG9jayBJIGhhdmUgMTYgT09CIGJ5dGVzIHdoaWNo IEkgY2FuIGFjY2VzcyBieSByZWFkL3dyaXRlLiBFYWNoIDE2IGJ5dGVzCj4gPj4+PiBjb250YWlu cyAyIGJ5dGVzIG9mIHVzZXIncyBkYXRhIGFuZCAxNCBieXRlcyBFQ0MgY29kZXMuIFNvIHdoZW4g SSByZWFkIHBhZ2UgaW4gcmF3IG1vZGUKPiA+Pj4+IGNvbnRyb2xsZXIgcmV0dXJucyAzMiBieXRl cyAoMiB4ICgyICsgMTQpKSBvZiBPT0IuIFdoaWxlIE9PQiBpcyByZXBvcnRlZCBhcyA2NCBieXRl cy4gICAgCj4gPj4+Cj4gPj4+IEluIGFsbCBtb2Rlcywgd2hlbiB5b3UgcmVhZCBPT0IsIHlvdSBz aG91bGQgZ2V0IHRoZSBmdWxsIE9PQi4gVGhlIGZhY3QKPiA+Pj4gdGhhdCBFQ0MgY29ycmVjdGlv biBpcyBlbmFibGVkIG9yIGRpc2FibGVkIGRvZXMgbm90IG1hdHRlci4gSWYgdGhlIE5BTkQKPiA+ Pj4gZmVhdHVyZXMgT09CIHNlY3Rpb25zIG9mIDY0IGJ5dGVzLCB5b3Ugc2hvdWxkIGdldCB0aGUg NjQgYnl0ZXMuCj4gPj4+Cj4gPj4+IFdoYXQgaGFwcGVucyBzb21ldGltZXMsIGlzIHRoYXQgc29t ZSBvZiB0aGUgYnl0ZXMgYXJlIG5vdCBwcm90ZWN0ZWQKPiA+Pj4gYWdhaW5zdCBiaXRmbGlwcywg YnV0IHRoZSBwb2xpY3kgaXMgdG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4gICAgCj4gPj4KPiA+ PiBPaywgc28gdG8gY2xhcmlmeSBjYXNlIGZvciB0aGlzIE5BTkQgY29udHJvbGxlcjoKPiA+PiAx KSBJbiBib3RoIEVDQyBhbmQgcmF3IG1vZGVzIGkgbmVlZCB0byByZXR1cm4gdGhlIHNhbWUgcmF3 IE9PQiBkYXRhIChlLmcuIHVzZXIgYnl0ZXMKPiA+PiAgICArIEVDQyBjb2Rlcyk/ICAKPiA+IAo+ ID4gV2VsbCwgeW91IG5lZWQgdG8gY292ZXIgdGhlIHNhbWUgYW1vdW50IG9mIGRhdGEsIHllcy4g QnV0IGluIHRoZSBFQ0MKPiA+IGNhc2UgdGhlIGRhdGEgd29uJ3QgYmUgcmF3IChhdCBsZWFzdCBu b3QgYWxsIG9mIGl0KS4gIAo+IAo+IFNvICJzYW1lIGFtb3VudCBvZiBkYXRhIiwgaW4gRUNDIG1v ZGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiByZXR1cm5zIG9ubHkgdXNlciBPT0IgYnl0ZXMgKGUu Zy4KPiBPT0IgZGF0YSBleGNsdWRpbmcgRUNDIGNvZGVzKSwgaW4gcmF3IGl0IHJldHVybnMgdXNl ciBieXRlcyArIEVDQyBjb2Rlcy4gSUlVQyBjb3JyZWN0Cj4gYmVoYXZpb3VyIGlzIHRvIGFsd2F5 cyByZXR1cm4gdXNlciBieXRlcyArIEVDQyBjb2RlcyBhcyBPT0IgZGF0YSBldmVuIGluIEVDQyBt b2RlID8KCklmIHRoZSBwYWdlIGFyZSAyays2NEIgeW91IHNob3VsZCByZWFkIDJrKzY0QiB3aGVu IE9PQiBhcmUgcmVxdWVzdGVkLgoKSWYgdGhlIGNvbnRyb2xsZXIgb25seSByZXR1cm5zIDJrKzMy QiwgdGhlbiBwZXJmb3JtIGEgcmFuZG9tIHJlYWQgdG8KanVzdCBtb3ZlIHRoZSByZWFkIHBvaW50 ZXIgdG8gbXRkLT5zaXplICsgbXRkLT5vb2JzaXplIC0gMzIgYW5kCnJldHJpZXZlIHRoZSBtaXNz aW5nIDMyIGJ5dGVzPwoKVGhpcyBhcHBsaWVzIHRvIHRoZSB0d28gbW9kZXMsIHRoZSBvbmx5IGRp ZmZlcmVuY2UgaXM6Ci0gd2l0aCBjb3JyZWN0aW9uIChjb21tb25seSBuYW1lZCAiRUNDIG1vZGUi KTogdGhlIHVzZXIgYnl0ZXMgYW5kIEVDQwogIGJ5dGVzIHNob3VsZCBiZSBmaXhlZCBpZiB0aGVy ZSBhcmUgYW55IGJpdGZsaXBzCi0gd2l0aG91dCBjb3JyZWN0aW9uIChjb21tb25seSByZWZlcnJl ZCBhcyAicmF3IG1vZGUiKTogbm8gY29ycmVjdGlvbgogIGFwcGxpZXMsIGlmIHRoZXJlIGFyZSBi aXRmbGlwcywgZ2l2ZSB0aGVtCgpQbGVhc2UgbWluZCB0aGUgcmF3IG1vZGUgY2FuIGJlIHNsb3cs IGl0J3MgbWVhbnQgZm9yIGRlYnVnZ2luZyBhbmQKdGVzdGluZywgbWFpbmx5LiBQYWdlIHJlYWRz IGhvd2V2ZXIgc2hvdWxkIGJlIGZhc3QsIHNvIGlmIGp1c3QgbW92aW5nCnRoZSBjb2x1bW4gcG9p bnRlciB3b3JrcywgdGhlbiBkbyBpdCwgb3RoZXJ3aXNlIHdlJ2xsIGNvbnNpZGVyCnJldHVybmlu ZyBGRnMuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A100C77B72 for ; Wed, 12 Apr 2023 12:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231560AbjDLM6F (ORCPT ); Wed, 12 Apr 2023 08:58:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbjDLM6C (ORCPT ); Wed, 12 Apr 2023 08:58:02 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 641D983FA for ; Wed, 12 Apr 2023 05:57:41 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1BB20100012; Wed, 12 Apr 2023 12:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681304237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9OeBGkyxviQ45xtIDss2eS2Kn0s5eylHaRXiAWIfUL8=; b=LPNpkMyOIdzbu40qsrGXMQRoMuPs3jK4MPjKM92k4BSt0OjZd0zs4W7S6nD/aEiCQzH8oA lD4LH/NrXixYJbYm+UdF2AzM55S7EMBD7bagbTRgvH2Sk4yR3Aox+H2ifeQez9TxulI8/0 rsIkaHSemafO6lsxbq2OHcLleZgCEoxAArFUllu8VrC5DeJJ0Ze+R4AynFqp+CpgXJgE0U DHv/aTXOmP4pDgncoSwrEQDIRqpAg96rzGuDFcczdfp1EXKYUuHvJELkiDD9+dspXetoaP dogNUwz6kUOfsyKorNp4ofcI2Xg4jb94Dl8BPRy+84qyhpxOVMf/PdL9vXwfZQ== Date: Wed, 12 Apr 2023 14:57:15 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230412145715.58c2be4a@xps-13> In-Reply-To: References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 15:22:26 +0300: > On 12.04.2023 15:18, Miquel Raynal wrote: > > Hi Arseniy, > >=20 > > avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 13:14:52 +0300: > > =20 > >> On 12.04.2023 12:36, Miquel Raynal wrote: =20 > >>> Hi Arseniy, > >>> > >>> avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 12:20:55 +0300: > >>> =20 > >>>> On 12.04.2023 10:44, Miquel Raynal wrote: =20 > >>>>> Hi Arseniy, > >>>>> > >>>>> AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:58 +0300: > >>>>> =20 > >>>>>> This NAND reads only few user's bytes in ECC mode (not full OOB), = so =20 > >>>>> > >>>>> "This NAND reads" does not look right, do you mean "Subpage reads do > >>>>> not retrieve all the OOB bytes,"? > >>>>> =20 > >>>>>> fill OOB buffer with zeroes to not return garbage from previous re= ads > >>>>>> to user. > >>>>>> Otherwise 'nanddump' utility prints something like this for just e= rased > >>>>>> page: > >>>>>> > >>>>>> ... > >>>>>> 0x000007f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > >>>>>> OOB Data: ff ff ff ff 00 00 ff ff 80 cf 22 99 cb ad d3 be > >>>>>> OOB Data: 63 27 ae 06 16 0a 2f eb bb dd 46 74 41 8e 88 6e > >>>>>> OOB Data: 38 a1 2d e6 77 d4 05 06 f2 a5 7e 25 eb 34 7c ff > >>>>>> OOB Data: 38 ea de 14 10 de 9b 40 33 16 6a cc 9d aa 2f 5e > >>>>>> > >>>>>> Signed-off-by: Arseniy Krasnov > >>>>>> --- > >>>>>> drivers/mtd/nand/raw/meson_nand.c | 5 +++++ > >>>>>> 1 file changed, 5 insertions(+) > >>>>>> > >>>>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/= raw/meson_nand.c > >>>>>> index f84a10238e4d..f2f2472cb511 100644 > >>>>>> --- a/drivers/mtd/nand/raw/meson_nand.c > >>>>>> +++ b/drivers/mtd/nand/raw/meson_nand.c > >>>>>> @@ -858,9 +858,12 @@ static int meson_nfc_read_page_sub(struct nan= d_chip *nand, > >>>>>> static int meson_nfc_read_page_raw(struct nand_chip *nand, u8 *bu= f, > >>>>>> int oob_required, int page) > >>>>>> { > >>>>>> + struct mtd_info *mtd =3D nand_to_mtd(nand); > >>>>>> u8 *oob_buf =3D nand->oob_poi; > >>>>>> int ret; > >>>>>> =20 > >>>>>> + memset(oob_buf, 0, mtd->oobsize); =20 > >>>>> > >>>>> I'm surprised raw reads do not read the entire OOB? =20 > >>>> > >>>> Yes! Seems in case of raw access (what i see in this driver) number = of OOB bytes read > >>>> still depends on ECC parameters: for each portion of data covered wi= th ECC code we can > >>>> read it's ECC code and "user bytes" from OOB - it is what i see by d= umping DMA buffer by > >>>> printk(). For example I'm working with 2K NAND pages, each page has = 2 x 1K ECC blocks. > >>>> For each ECC block I have 16 OOB bytes which I can access by read/wr= ite. Each 16 bytes > >>>> contains 2 bytes of user's data and 14 bytes ECC codes. So when I re= ad page in raw mode > >>>> controller returns 32 bytes (2 x (2 + 14)) of OOB. While OOB is repo= rted as 64 bytes. =20 > >>> > >>> In all modes, when you read OOB, you should get the full OOB. The fact > >>> that ECC correction is enabled or disabled does not matter. If the NA= ND > >>> features OOB sections of 64 bytes, you should get the 64 bytes. > >>> > >>> What happens sometimes, is that some of the bytes are not protected > >>> against bitflips, but the policy is to return the full buffer. =20 > >> > >> Ok, so to clarify case for this NAND controller: > >> 1) In both ECC and raw modes i need to return the same raw OOB data (e= .g. user bytes > >> + ECC codes)? =20 > >=20 > > Well, you need to cover the same amount of data, yes. But in the ECC > > case the data won't be raw (at least not all of it). =20 >=20 > So "same amount of data", in ECC mode current implementation returns only= user OOB bytes (e.g. > OOB data excluding ECC codes), in raw it returns user bytes + ECC codes. = IIUC correct > behaviour is to always return user bytes + ECC codes as OOB data even in = ECC mode ? If the page are 2k+64B you should read 2k+64B when OOB are requested. If the controller only returns 2k+32B, then perform a random read to just move the read pointer to mtd->size + mtd->oobsize - 32 and retrieve the missing 32 bytes? This applies to the two modes, the only difference is: - with correction (commonly named "ECC mode"): the user bytes and ECC bytes should be fixed if there are any bitflips - without correction (commonly referred as "raw mode"): no correction applies, if there are bitflips, give them Please mind the raw mode can be slow, it's meant for debugging and testing, mainly. Page reads however should be fast, so if just moving the column pointer works, then do it, otherwise we'll consider returning FFs. Thanks, Miqu=C3=A8l