From: SeongJae Park <sj@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: sj@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCHv2] selftests: damon: add config file
Date: Wed, 12 Apr 2023 16:58:06 +0000 [thread overview]
Message-ID: <20230412165806.80672-1-sj@kernel.org> (raw)
In-Reply-To: <20230412092854.3306197-1-anders.roxell@linaro.org>
Hi Anders,
On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@linaro.org> wrote:
> Building and running the subsuite 'damon' of kselftest, shows the
> following issues:
> selftests: damon: debugfs_attrs.sh
> /sys/kernel/debug/damon not found
>
> By creating a config file enabling DAMON fragments in the
> selftests/damon/ directory the tests pass.
>
> Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
checkpatch.pl is warning as below:
WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
#20:
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
warn when Reported-by: is not followed by Link:")'s commit message. Do you
have a link to put here? I guess the report was made inside Linaro, so might
have no publicly available link. Maybe better to add some notes or some funny
tag like "Link: N/A # no publicly-available link of the report" for convincing
the tool, but I don't think this should be a blocker for this patch.
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> tools/testing/selftests/damon/config | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 tools/testing/selftests/damon/config
>
> diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config
> new file mode 100644
> index 000000000000..0daf38974eb0
> --- /dev/null
> +++ b/tools/testing/selftests/damon/config
> @@ -0,0 +1,7 @@
> +CONFIG_DAMON=y
> +CONFIG_DAMON_SYSFS=y
> +CONFIG_DAMON_DBGFS=y
> +CONFIG_DAMON_PADDR=y
> +CONFIG_DAMON_VADDR=y
> +CONFIG_DAMON_RECLAIM=y
> +CONFIG_DAMON_LRU_SORT=y
> --
> 2.39.2
next prev parent reply other threads:[~2023-04-12 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 9:28 [PATCHv2] selftests: damon: add config file Anders Roxell
2023-04-12 16:58 ` SeongJae Park [this message]
2023-06-09 19:16 ` SeongJae Park
2023-06-12 22:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412165806.80672-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naresh.kamboju@linaro.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.