From: Jakub Kicinski <kuba@kernel.org>
To: "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enabling/disabling
Date: Wed, 12 Apr 2023 20:44:14 -0700 [thread overview]
Message-ID: <20230412204414.72e89e5b@kernel.org> (raw)
In-Reply-To: <20230410124856.287753-1-radu-nicolae.pirea@oss.nxp.com>
On Mon, 10 Apr 2023 15:48:56 +0300 Radu Pirea (OSS) wrote:
> - if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
> + if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
> + phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, PTP_IRQS, PTP_IRQS);
Isn't the third argument supposed to be the address?
Am I missing something or this patch was no tested properly?
Also why ignore the return value?
> return phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
> VEND1_PHY_IRQ_EN, PHY_IRQ_LINK_EVENT);
> - else
> + } else {
> + phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, PTP_IRQS, PTP_IRQS);
> return phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
> VEND1_PHY_IRQ_EN, PHY_IRQ_LINK_EVENT);
> + }
next prev parent reply other threads:[~2023-04-13 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 12:48 [PATCH net] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enabling/disabling Radu Pirea (OSS)
2023-04-13 3:44 ` Jakub Kicinski [this message]
2023-04-24 9:08 ` Radu Pirea (OSS)
2023-04-24 11:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412204414.72e89e5b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.