From: Stefan Ott via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Stefan Ott <stefan@ott.net>
Subject: [Buildroot] [PATCH 1/1] package/libgtk3: Remove atk-bridge from .pc file
Date: Thu, 13 Apr 2023 00:26:40 +0200 [thread overview]
Message-ID: <20230412222640.109345-1-stefan@ott.net> (raw)
The dependency is supposed to be optional but it always ends up in the
.pc file. This leads to issues when building packages that depend on
libgtk3 and are unable to find atk-bridge:
> output/build/gcr-3.40.0/meson.build:57:2: ERROR: Dependency lookup for gtk+-3.0 with method 'pkgconfig' failed: Could not generate cargs for gtk+-3.0:
> Package atk-bridge-2.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `atk-bridge-2.0.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'atk-bridge-2.0', required by 'gtk+-3.0', not found
This change modifies the original patch so that the dependency is only
added to the .pc file if atk-bridge is present.
Signed-off-by: Stefan Ott <stefan@ott.net>
---
package/libgtk3/0001-disable-atk-bridge.patch | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/package/libgtk3/0001-disable-atk-bridge.patch b/package/libgtk3/0001-disable-atk-bridge.patch
index f3e9bff2ba..8127b97253 100644
--- a/package/libgtk3/0001-disable-atk-bridge.patch
+++ b/package/libgtk3/0001-disable-atk-bridge.patch
@@ -39,3 +39,14 @@ Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
backend_immodules += ['xim']
+@@ -588,7 +588,9 @@
+ x11_pkgs += ['xdamage']
+ endif
+
+- atk_pkgs += ['atk-bridge-2.0']
++ if atkbridge_dep.found()
++ atk_pkgs += ['atk-bridge-2.0']
++ endif
+
+ cdata.set('HAVE_XDAMAGE', xdamage_dep.found() ? 1 : false)
+ cdata.set('HAVE_XCURSOR', xcursor_dep.found() ? 1 : false)
--
2.40.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2023-04-12 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 22:26 Stefan Ott via buildroot [this message]
2023-04-13 14:13 ` [Buildroot] [PATCH 1/1] package/libgtk3: Remove atk-bridge from .pc file Adrian Perez de Castro
2023-04-15 15:16 ` Yann E. MORIN
2023-04-15 15:27 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412222640.109345-1-stefan@ott.net \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=stefan@ott.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.