All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Tina Zhang <tina.zhang@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 10/17] iommu/vt-d: Remove PASID supervisor request support
Date: Thu, 13 Apr 2023 12:06:38 +0800	[thread overview]
Message-ID: <20230413040645.46157-11-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20230413040645.46157-1-baolu.lu@linux.intel.com>

From: Jacob Pan <jacob.jun.pan@linux.intel.com>

There's no more usage, remove PASID supervisor support.

Suggested-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Link: https://lore.kernel.org/r/20230331231137.1947675-3-jacob.jun.pan@linux.intel.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/pasid.h |  7 ------
 drivers/iommu/intel/pasid.c | 43 -------------------------------------
 2 files changed, 50 deletions(-)

diff --git a/drivers/iommu/intel/pasid.h b/drivers/iommu/intel/pasid.h
index 20c54e50f533..d6b7d21244b1 100644
--- a/drivers/iommu/intel/pasid.h
+++ b/drivers/iommu/intel/pasid.h
@@ -41,13 +41,6 @@
 #define FLPT_DEFAULT_DID		1
 #define NUM_RESERVED_DID		2
 
-/*
- * The SUPERVISOR_MODE flag indicates a first level translation which
- * can be used for access to kernel addresses. It is valid only for
- * access to the kernel's static 1:1 mapping of physical memory — not
- * to vmalloc or even module mappings.
- */
-#define PASID_FLAG_SUPERVISOR_MODE	BIT(0)
 #define PASID_FLAG_NESTED		BIT(1)
 #define PASID_FLAG_PAGE_SNOOP		BIT(2)
 
diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
index 633e0a4a01e7..c5d479770e12 100644
--- a/drivers/iommu/intel/pasid.c
+++ b/drivers/iommu/intel/pasid.c
@@ -335,15 +335,6 @@ static inline void pasid_set_fault_enable(struct pasid_entry *pe)
 	pasid_set_bits(&pe->val[0], 1 << 1, 0);
 }
 
-/*
- * Setup the SRE(Supervisor Request Enable) field (Bit 128) of a
- * scalable mode PASID entry.
- */
-static inline void pasid_set_sre(struct pasid_entry *pe)
-{
-	pasid_set_bits(&pe->val[2], 1 << 0, 1);
-}
-
 /*
  * Setup the WPE(Write Protect Enable) field (Bit 132) of a
  * scalable mode PASID entry.
@@ -521,23 +512,6 @@ int intel_pasid_setup_first_level(struct intel_iommu *iommu,
 		return -EINVAL;
 	}
 
-	if (flags & PASID_FLAG_SUPERVISOR_MODE) {
-#ifdef CONFIG_X86
-		unsigned long cr0 = read_cr0();
-
-		/* CR0.WP is normally set but just to be sure */
-		if (unlikely(!(cr0 & X86_CR0_WP))) {
-			pr_err("No CPU write protect!\n");
-			return -EINVAL;
-		}
-#endif
-		if (!ecap_srs(iommu->ecap)) {
-			pr_err("No supervisor request support on %s\n",
-			       iommu->name);
-			return -EINVAL;
-		}
-	}
-
 	if ((flags & PASID_FLAG_FL5LP) && !cap_fl5lp_support(iommu->cap)) {
 		pr_err("No 5-level paging support for first-level on %s\n",
 		       iommu->name);
@@ -560,10 +534,6 @@ int intel_pasid_setup_first_level(struct intel_iommu *iommu,
 
 	/* Setup the first level page table pointer: */
 	pasid_set_flptr(pte, (u64)__pa(pgd));
-	if (flags & PASID_FLAG_SUPERVISOR_MODE) {
-		pasid_set_sre(pte);
-		pasid_set_wpe(pte);
-	}
 
 	if (flags & PASID_FLAG_FL5LP)
 		pasid_set_flpm(pte, 1);
@@ -658,12 +628,6 @@ int intel_pasid_setup_second_level(struct intel_iommu *iommu,
 	pasid_set_fault_enable(pte);
 	pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap));
 
-	/*
-	 * Since it is a second level only translation setup, we should
-	 * set SRE bit as well (addresses are expected to be GPAs).
-	 */
-	if (pasid != PASID_RID2PASID && ecap_srs(iommu->ecap))
-		pasid_set_sre(pte);
 	pasid_set_present(pte);
 	spin_unlock(&iommu->lock);
 
@@ -700,13 +664,6 @@ int intel_pasid_setup_pass_through(struct intel_iommu *iommu,
 	pasid_set_translation_type(pte, PASID_ENTRY_PGTT_PT);
 	pasid_set_fault_enable(pte);
 	pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap));
-
-	/*
-	 * We should set SRE bit as well since the addresses are expected
-	 * to be GPAs.
-	 */
-	if (ecap_srs(iommu->ecap))
-		pasid_set_sre(pte);
 	pasid_set_present(pte);
 	spin_unlock(&iommu->lock);
 
-- 
2.34.1


  parent reply	other threads:[~2023-04-13  4:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  4:06 [PATCH v2 00/17] [PULL REQUEST] Intel IOMMU updates for Linux v6.4 Lu Baolu
2023-04-13  4:06 ` [PATCH v2 01/17] dmaengine: idxd: Add enable/disable device IOPF feature Lu Baolu
2023-04-13  4:06 ` [PATCH v2 02/17] iommu/vt-d: Allow SVA with device-specific IOPF Lu Baolu
2023-04-13  4:06 ` [PATCH v2 03/17] iommu/vt-d: Move iopf code from SVA to IOPF enabling path Lu Baolu
2023-04-13  4:06 ` [PATCH v2 04/17] iommu/vt-d: Move pfsid and ats_qdep calculation to device probe path Lu Baolu
2023-04-13  4:06 ` [PATCH v2 05/17] iommu/vt-d: Move PRI handling to IOPF feature path Lu Baolu
2023-04-13  4:06 ` [PATCH v2 06/17] iommu/vt-d: Remove unnecessary checks in iopf disabling path Lu Baolu
2023-04-13  4:06 ` [PATCH v2 07/17] iommu/vt-d: Do not use GFP_ATOMIC when not needed Lu Baolu
2023-04-13  4:06 ` [PATCH v2 08/17] iommu/vt-d: Remove extern from function prototypes Lu Baolu
2023-04-13  4:06 ` [PATCH v2 09/17] iommu/vt-d: Use non-privileged mode for all PASIDs Lu Baolu
2023-04-13  4:06 ` Lu Baolu [this message]
2023-04-13  4:06 ` [PATCH v2 11/17] iommu/vt-d: Make size of operands same in bitwise operations Lu Baolu
2023-04-13  4:06 ` [PATCH v2 12/17] iommu/vt-d: Remove BUG_ON on checking valid pfn range Lu Baolu
2023-04-13  4:06 ` [PATCH v2 13/17] iommu/vt-d: Remove BUG_ON in handling iotlb cache invalidation Lu Baolu
2023-04-13  4:06 ` [PATCH v2 14/17] iommu/vt-d: Remove BUG_ON when domain->pgd is NULL Lu Baolu
2023-04-13  4:06 ` [PATCH v2 15/17] iommu/vt-d: Remove BUG_ON in map/unmap() Lu Baolu
2023-04-13  4:06 ` [PATCH v2 16/17] iommu/vt-d: Remove a useless BUG_ON(dev->is_virtfn) Lu Baolu
2023-04-13  4:06 ` [PATCH v2 17/17] iommu/vt-d: Remove BUG_ON in dmar_insert_dev_scope() Lu Baolu
2023-04-13 10:06 ` [PATCH v2 00/17] [PULL REQUEST] Intel IOMMU updates for Linux v6.4 Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413040645.46157-11-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=iommu@lists.linux.dev \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tina.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.