From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47B5C77B61 for ; Thu, 13 Apr 2023 05:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbjDMF3q convert rfc822-to-8bit (ORCPT ); Thu, 13 Apr 2023 01:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjDMF3q (ORCPT ); Thu, 13 Apr 2023 01:29:46 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DF544E69 for ; Wed, 12 Apr 2023 22:29:44 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2ED5E80FC; Thu, 13 Apr 2023 05:29:44 +0000 (UTC) Date: Thu, 13 Apr 2023 08:29:42 +0300 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Nishanth Menon , Santosh Shilimkar , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer Message-ID: <20230413052942.GC9837@atomide.com> References: <20221012140032.113363-1-u.kleine-koenig@pengutronix.de> <20230412142539.brqexyi5kpac5ltr@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20230412142539.brqexyi5kpac5ltr@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org * Uwe Kleine-König [230412 14:26]: > Hello, > > [Cc += Tony Lindgren + Arnd Bergmann who did care about the last change > to this driver] > > On Wed, Oct 12, 2022 at 04:00:32PM +0200, Uwe Kleine-König wrote: > > The probe function stores the sr_info pointer using > > platform_set_drvdata(). Use the corresponding platform_get_drvdata() to > > retrieve that pointer in the remove and shutdown functions. > > > > This simplifies these functions and makes error handling unnecessary. > > This is a good thing as at least for .remove() returning an error code > > doesn't have the desired effect. > > > > This is a preparation for making platform remove callbacks return void. > > > > Signed-off-by: Uwe Kleine-König > > This patch still applies to v6.3-rc1, but I didn't get any feedback > since 6 months now. I need this change to eventually make > platform_driver's remove callback return void. > > Best regards > Uwe > > [Keeping a full quote below for Tony and Arnd] Looks good to me, maybe Arnd is still picking patches for the upcoming merge window: Reviewed-by: Tony Lindgren > > --- > > drivers/soc/ti/smartreflex.c | 30 ++---------------------------- > > 1 file changed, 2 insertions(+), 28 deletions(-) > > > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > > index ad2bb72e640c..1d0b50feae44 100644 > > --- a/drivers/soc/ti/smartreflex.c > > +++ b/drivers/soc/ti/smartreflex.c > > @@ -940,21 +940,8 @@ static int omap_sr_probe(struct platform_device *pdev) > > > > static int omap_sr_remove(struct platform_device *pdev) > > { > > - struct omap_sr_data *pdata = pdev->dev.platform_data; > > struct device *dev = &pdev->dev; > > - struct omap_sr *sr_info; > > - > > - if (!pdata) { > > - dev_err(&pdev->dev, "%s: platform data missing\n", __func__); > > - return -EINVAL; > > - } > > - > > - sr_info = _sr_lookup(pdata->voltdm); > > - if (IS_ERR(sr_info)) { > > - dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", > > - __func__); > > - return PTR_ERR(sr_info); > > - } > > + struct omap_sr *sr_info = platform_get_drvdata(pdev); > > > > if (sr_info->autocomp_active) > > sr_stop_vddautocomp(sr_info); > > @@ -968,20 +955,7 @@ static int omap_sr_remove(struct platform_device *pdev) > > > > static void omap_sr_shutdown(struct platform_device *pdev) > > { > > - struct omap_sr_data *pdata = pdev->dev.platform_data; > > - struct omap_sr *sr_info; > > - > > - if (!pdata) { > > - dev_err(&pdev->dev, "%s: platform data missing\n", __func__); > > - return; > > - } > > - > > - sr_info = _sr_lookup(pdata->voltdm); > > - if (IS_ERR(sr_info)) { > > - dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", > > - __func__); > > - return; > > - } > > + struct omap_sr *sr_info = platform_get_drvdata(pdev); > > > > if (sr_info->autocomp_active) > > sr_stop_vddautocomp(sr_info); > > > > base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | https://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FB11C77B6C for ; Thu, 13 Apr 2023 05:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jWq/ZgVFptnZz7LBKk1ac/LGe0pjOrF/lTmE2VN6WpU=; b=JvWfaWWaO5Lk/B wTfPf1ibBCjrmL0K2Nah0VzwwDQ01IowXckUrs9377kycBr6K6cU60HBTvvKPwlgncc8TvMOh+Z7J mZCn2emYb5vPFLjCHZJ2IJRghU14EXPBLJo2tvb/MY8pSMy3oUeNcG92PGzGfDUNX0XLEGWGoKfm5 rE3EkWZYsTmydGMSpC/1FrI2Gf+FIrp0JZ4SNCGE1xSW88ficanZTEEpbHoFmMMeLZzlobCQ4nyzI S6rOtvLSKJ+pgZtZM0BVhydZMDDlZclcI7CavHj36zoFP0/CS0Hj9kbNubS0URFWQeyJ5v/jsBctv yvyV29Wime7w9fs+UYQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmpWl-0054Eq-38; Thu, 13 Apr 2023 05:29:47 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmpWj-0054EI-0f for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 05:29:46 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2ED5E80FC; Thu, 13 Apr 2023 05:29:44 +0000 (UTC) Date: Thu, 13 Apr 2023 08:29:42 +0300 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Nishanth Menon , Santosh Shilimkar , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer Message-ID: <20230413052942.GC9837@atomide.com> References: <20221012140032.113363-1-u.kleine-koenig@pengutronix.de> <20230412142539.brqexyi5kpac5ltr@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230412142539.brqexyi5kpac5ltr@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_222945_283619_0091AE22 X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiBbMjMw NDEyIDE0OjI2XToKPiBIZWxsbywKPiAKPiBbQ2MgKz0gVG9ueSBMaW5kZ3JlbiArIEFybmQgQmVy Z21hbm4gd2hvIGRpZCBjYXJlIGFib3V0IHRoZSBsYXN0IGNoYW5nZQo+IHRvIHRoaXMgZHJpdmVy XQo+IAo+IE9uIFdlZCwgT2N0IDEyLCAyMDIyIGF0IDA0OjAwOjMyUE0gKzAyMDAsIFV3ZSBLbGVp bmUtS8O2bmlnIHdyb3RlOgo+ID4gVGhlIHByb2JlIGZ1bmN0aW9uIHN0b3JlcyB0aGUgc3JfaW5m byBwb2ludGVyIHVzaW5nCj4gPiBwbGF0Zm9ybV9zZXRfZHJ2ZGF0YSgpLiBVc2UgdGhlIGNvcnJl c3BvbmRpbmcgcGxhdGZvcm1fZ2V0X2RydmRhdGEoKSB0bwo+ID4gcmV0cmlldmUgdGhhdCBwb2lu dGVyIGluIHRoZSByZW1vdmUgYW5kIHNodXRkb3duIGZ1bmN0aW9ucy4KPiA+IAo+ID4gVGhpcyBz aW1wbGlmaWVzIHRoZXNlIGZ1bmN0aW9ucyBhbmQgbWFrZXMgZXJyb3IgaGFuZGxpbmcgdW5uZWNl c3NhcnkuCj4gPiBUaGlzIGlzIGEgZ29vZCB0aGluZyBhcyBhdCBsZWFzdCBmb3IgLnJlbW92ZSgp IHJldHVybmluZyBhbiBlcnJvciBjb2RlCj4gPiBkb2Vzbid0IGhhdmUgdGhlIGRlc2lyZWQgZWZm ZWN0Lgo+ID4gCj4gPiBUaGlzIGlzIGEgcHJlcGFyYXRpb24gZm9yIG1ha2luZyBwbGF0Zm9ybSBy ZW1vdmUgY2FsbGJhY2tzIHJldHVybiB2b2lkLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBVd2Ug S2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IAo+IFRoaXMg cGF0Y2ggc3RpbGwgYXBwbGllcyB0byB2Ni4zLXJjMSwgYnV0IEkgZGlkbid0IGdldCBhbnkgZmVl ZGJhY2sKPiBzaW5jZSA2IG1vbnRocyBub3cuIEkgbmVlZCB0aGlzIGNoYW5nZSB0byBldmVudHVh bGx5IG1ha2UKPiBwbGF0Zm9ybV9kcml2ZXIncyByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQu Cj4gCj4gQmVzdCByZWdhcmRzCj4gVXdlCj4gCj4gW0tlZXBpbmcgYSBmdWxsIHF1b3RlIGJlbG93 IGZvciBUb255IGFuZCBBcm5kXQoKTG9va3MgZ29vZCB0byBtZSwgbWF5YmUgQXJuZCBpcyBzdGls bCBwaWNraW5nIHBhdGNoZXMgZm9yIHRoZSB1cGNvbWluZwptZXJnZSB3aW5kb3c6CgpSZXZpZXdl ZC1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4KCgo+ID4gLS0tCj4gPiAgZHJp dmVycy9zb2MvdGkvc21hcnRyZWZsZXguYyB8IDMwICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDI4IGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvdGkvc21hcnRyZWZsZXguYyBiL2Ry aXZlcnMvc29jL3RpL3NtYXJ0cmVmbGV4LmMKPiA+IGluZGV4IGFkMmJiNzJlNjQwYy4uMWQwYjUw ZmVhZTQ0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9zb2MvdGkvc21hcnRyZWZsZXguYwo+ID4g KysrIGIvZHJpdmVycy9zb2MvdGkvc21hcnRyZWZsZXguYwo+ID4gQEAgLTk0MCwyMSArOTQwLDgg QEAgc3RhdGljIGludCBvbWFwX3NyX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp Cj4gPiAgCj4gPiAgc3RhdGljIGludCBvbWFwX3NyX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ID4gIHsKPiA+IC0Jc3RydWN0IG9tYXBfc3JfZGF0YSAqcGRhdGEgPSBwZGV2 LT5kZXYucGxhdGZvcm1fZGF0YTsKPiA+ICAJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRl djsKPiA+IC0Jc3RydWN0IG9tYXBfc3IgKnNyX2luZm87Cj4gPiAtCj4gPiAtCWlmICghcGRhdGEp IHsKPiA+IC0JCWRldl9lcnIoJnBkZXYtPmRldiwgIiVzOiBwbGF0Zm9ybSBkYXRhIG1pc3Npbmdc biIsIF9fZnVuY19fKTsKPiA+IC0JCXJldHVybiAtRUlOVkFMOwo+ID4gLQl9Cj4gPiAtCj4gPiAt CXNyX2luZm8gPSBfc3JfbG9va3VwKHBkYXRhLT52b2x0ZG0pOwo+ID4gLQlpZiAoSVNfRVJSKHNy X2luZm8pKSB7Cj4gPiAtCQlkZXZfd2FybigmcGRldi0+ZGV2LCAiJXM6IG9tYXBfc3Igc3RydWN0 IG5vdCBmb3VuZFxuIiwKPiA+IC0JCQlfX2Z1bmNfXyk7Cj4gPiAtCQlyZXR1cm4gUFRSX0VSUihz cl9pbmZvKTsKPiA+IC0JfQo+ID4gKwlzdHJ1Y3Qgb21hcF9zciAqc3JfaW5mbyA9IHBsYXRmb3Jt X2dldF9kcnZkYXRhKHBkZXYpOwo+ID4gIAo+ID4gIAlpZiAoc3JfaW5mby0+YXV0b2NvbXBfYWN0 aXZlKQo+ID4gIAkJc3Jfc3RvcF92ZGRhdXRvY29tcChzcl9pbmZvKTsKPiA+IEBAIC05NjgsMjAg Kzk1NSw3IEBAIHN0YXRpYyBpbnQgb21hcF9zcl9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBvbWFwX3NyX3NodXRkb3duKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiAgewo+ID4gLQlzdHJ1Y3Qgb21hcF9zcl9kYXRhICpw ZGF0YSA9IHBkZXYtPmRldi5wbGF0Zm9ybV9kYXRhOwo+ID4gLQlzdHJ1Y3Qgb21hcF9zciAqc3Jf aW5mbzsKPiA+IC0KPiA+IC0JaWYgKCFwZGF0YSkgewo+ID4gLQkJZGV2X2VycigmcGRldi0+ZGV2 LCAiJXM6IHBsYXRmb3JtIGRhdGEgbWlzc2luZ1xuIiwgX19mdW5jX18pOwo+ID4gLQkJcmV0dXJu Owo+ID4gLQl9Cj4gPiAtCj4gPiAtCXNyX2luZm8gPSBfc3JfbG9va3VwKHBkYXRhLT52b2x0ZG0p Owo+ID4gLQlpZiAoSVNfRVJSKHNyX2luZm8pKSB7Cj4gPiAtCQlkZXZfd2FybigmcGRldi0+ZGV2 LCAiJXM6IG9tYXBfc3Igc3RydWN0IG5vdCBmb3VuZFxuIiwKPiA+IC0JCQlfX2Z1bmNfXyk7Cj4g PiAtCQlyZXR1cm47Cj4gPiAtCX0KPiA+ICsJc3RydWN0IG9tYXBfc3IgKnNyX2luZm8gPSBwbGF0 Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiA+ICAKPiA+ICAJaWYgKHNyX2luZm8tPmF1dG9jb21w X2FjdGl2ZSkKPiA+ICAJCXNyX3N0b3BfdmRkYXV0b2NvbXAoc3JfaW5mbyk7Cj4gPiAKPiA+IGJh c2UtY29tbWl0OiA0ZmU4OWQwN2RjYzI4MDRjOGI1NjJmNmM3ODk2YTQ1NjQzZDM0YjJmCj4gCj4g LS0gCj4gUGVuZ3V0cm9uaXggZS5LLiAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgVXdlIEts ZWluZS1Lw7ZuaWcgICAgICAgICAgICB8Cj4gSW5kdXN0cmlhbCBMaW51eCBTb2x1dGlvbnMgICAg ICAgICAgICAgICAgIHwgaHR0cHM6Ly93d3cucGVuZ3V0cm9uaXguZGUvIHwKCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=