From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 488DDC77B73 for ; Thu, 13 Apr 2023 15:04:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C527083F89; Thu, 13 Apr 2023 15:04:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C527083F89 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1681398251; bh=Ua69HTFRBCH4pB7/2heZ5OOZoxWwJ9Fof2BzHJRz8mw=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=MaFcf0SVrjCf8viV85KqZId1OYMN1czm5UuabB+dZFpG+KBbOJEvXNFLJvIBJAvsZ X7v7Zgx4N/pR8OPhCT5WVCmgTb5QdGlhdOjdXU7kqJrAwPJQfXVVF4TQtjmmeEh8dQ u6PA8WXA+YxerV7CjiyTUzV2wTl7wGXnHd90O9JRx6UIFya037Vt7Ic+tck5MdGomL 8elB72EET6cB5Pw4s4ysNu0G/CSNr/TJ0p1i8OZ1Pa7keClVmAF8H8DcydZN6k5oA7 9RofoFSE0bPhc7x+WXGWKJezmiytNOz77JRTiqIX37Z3+1MxLEiu7bO4d9dDkgJ/Sb Qn9RToCzFowuw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hFmZ0i5xRzrr; Thu, 13 Apr 2023 15:04:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id C8DA884089; Thu, 13 Apr 2023 15:04:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C8DA884089 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 663FD1C3DB3 for ; Thu, 13 Apr 2023 15:04:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3E9278408A for ; Thu, 13 Apr 2023 15:04:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3E9278408A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A6xZQJ0GV6SJ for ; Thu, 13 Apr 2023 15:04:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9FA4284093 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9FA4284093 for ; Thu, 13 Apr 2023 15:04:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9EC963D2A; Thu, 13 Apr 2023 15:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC5A7C433EF; Thu, 13 Apr 2023 15:04:06 +0000 (UTC) Date: Thu, 13 Apr 2023 08:04:05 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Message-ID: <20230413080405.30bbe3bd@kernel.org> In-Reply-To: References: <20230412133811.2518336-1-arkadiusz.kubalewski@intel.com> <20230412203500.36fb7c36@kernel.org> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681398247; bh=JdbgbeQTK4oXXpvwy/OkbrBX79V7CMl8I2rByssnbK8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YPGDH/bbVb36/Vi0t11lP6f2sRR4SOLUf7fIxJRUtI28miO5mrqAWIL/3j1+kYij5 Znu5MBMUAZ+ABRUL93fKTMB8SrOPqtCDWAWceK9xh6JuqFmfUN0jdOLKeXXtxaZjlk Mji3Ymgy4JBemOYnGu9wR+RTKyZ/BPk926GVY3BLbrJozJPXSyT4kwpnvRSM1BGqMQ lDdzkfb6wkR/K9+ZE7ddssGuJ4sacrzsSzrfTlCIV7dOuOB08yFa6iiLh6ZIpQyFy4 pQXosljbJNj3i7pKtYMvmQu2Iu5JzdM+4DG/oqhlS/RRYM3agdlvngB1MvkVuACpU7 GLBtV7XMPP1Sw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YPGDH/bb Subject: Re: [Intel-wired-lan] [RFC PATCH v1] ice: add CGU info to devlink info callback X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jiri@resnulli.us" , "corbet@lwn.net" , "netdev@vger.kernel.org" , "richardcochran@gmail.com" , "linux-doc@vger.kernel.org" , "Brandeburg, Jesse" , "linux-kernel@vger.kernel.org" , "edumazet@google.com" , "Nguyen, Anthony L" , "intel-wired-lan@lists.osuosl.org" , "pabeni@redhat.com" , "davem@davemloft.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 13 Apr 2023 13:43:52 +0000 Kubalewski, Arkadiusz wrote: > >Is it flashed together with the rest of the FW components of the NIC? > >Or the update method is different? > > Right now there is no mechanics for CGU firmware update at all, this is why I > mention that this is for now mostly for debugging purposes. > There are already some works ongoing to have CGU FW update possible, first with > Intel's nvmupdate packages and tools. But, for Linux we probably also gonna > need to support update through devlink, at least this seems right thing to do, > as there is already possibility to update NIC firmware with devlink. Only FW versions which are updated with a single flashing operation / are part of a single FW image should be reported under the device instance. If the flash is separate you need to create a separate devlink (sub)instance or something along those lines. Differently put - the components in the API are components of the FW image, not components of a board. We had a similar discussion about "line cards" before. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 550C0C77B6E for ; Thu, 13 Apr 2023 15:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjDMPEJ (ORCPT ); Thu, 13 Apr 2023 11:04:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjDMPEJ (ORCPT ); Thu, 13 Apr 2023 11:04:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5631783E2; Thu, 13 Apr 2023 08:04:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E73A263BBE; Thu, 13 Apr 2023 15:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC5A7C433EF; Thu, 13 Apr 2023 15:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681398247; bh=JdbgbeQTK4oXXpvwy/OkbrBX79V7CMl8I2rByssnbK8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YPGDH/bbVb36/Vi0t11lP6f2sRR4SOLUf7fIxJRUtI28miO5mrqAWIL/3j1+kYij5 Znu5MBMUAZ+ABRUL93fKTMB8SrOPqtCDWAWceK9xh6JuqFmfUN0jdOLKeXXtxaZjlk Mji3Ymgy4JBemOYnGu9wR+RTKyZ/BPk926GVY3BLbrJozJPXSyT4kwpnvRSM1BGqMQ lDdzkfb6wkR/K9+ZE7ddssGuJ4sacrzsSzrfTlCIV7dOuOB08yFa6iiLh6ZIpQyFy4 pQXosljbJNj3i7pKtYMvmQu2Iu5JzdM+4DG/oqhlS/RRYM3agdlvngB1MvkVuACpU7 GLBtV7XMPP1Sw== Date: Thu, 13 Apr 2023 08:04:05 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: "jiri@resnulli.us" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "richardcochran@gmail.com" , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Subject: Re: [RFC PATCH v1] ice: add CGU info to devlink info callback Message-ID: <20230413080405.30bbe3bd@kernel.org> In-Reply-To: References: <20230412133811.2518336-1-arkadiusz.kubalewski@intel.com> <20230412203500.36fb7c36@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, 13 Apr 2023 13:43:52 +0000 Kubalewski, Arkadiusz wrote: > >Is it flashed together with the rest of the FW components of the NIC? > >Or the update method is different? > > Right now there is no mechanics for CGU firmware update at all, this is why I > mention that this is for now mostly for debugging purposes. > There are already some works ongoing to have CGU FW update possible, first with > Intel's nvmupdate packages and tools. But, for Linux we probably also gonna > need to support update through devlink, at least this seems right thing to do, > as there is already possibility to update NIC firmware with devlink. Only FW versions which are updated with a single flashing operation / are part of a single FW image should be reported under the device instance. If the flash is separate you need to create a separate devlink (sub)instance or something along those lines. Differently put - the components in the API are components of the FW image, not components of a board. We had a similar discussion about "line cards" before.