From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E82FDC77B61 for ; Thu, 13 Apr 2023 16:03:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 63EA742108; Thu, 13 Apr 2023 16:03:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 63EA742108 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1681401831; bh=MqMDxD22XVU09vmh4tH4LrSCX+uMEv8/9dYAzrsuj5Y=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=fa2sE6UkqFA5WtJ837wbMU6OkRY6fp7IuAIiRpWcUikLvRdyxFikaNFj4kfgcCBjh 7o+BcLr1/ObxuIsHRfdPvuv0hUnutN7x5cBpRHTJyqVZYHLLlNFqgpCoYhBF1vaINu H2wNK4g+fg/eYeU77GFSA6ncVrHCKnKoRVqJJiNykjeSRpvTCB/mKwjlO+ir/ht/xz z+9b41eI1FabGGhqwArChwthqsRFWK9IUstXiQWXDXxK60I4GxWAs6zkpElhJ5k8gv FlaJoutDk33rCLfsAM4F0dEOlP9YP1EshP7SO0C1iQsZsqpjXJi/51+R2Dyz2ugdhI B5+SZF6/tKxww== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KB-ccgAI3qWY; Thu, 13 Apr 2023 16:03:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 59CBD4210A; Thu, 13 Apr 2023 16:03:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 59CBD4210A Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id D61931C3CAC for ; Thu, 13 Apr 2023 16:03:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id AE648429AE for ; Thu, 13 Apr 2023 16:03:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AE648429AE X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3-NUlC3LNN-O for ; Thu, 13 Apr 2023 16:03:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2177F429A7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2177F429A7 for ; Thu, 13 Apr 2023 16:03:48 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E165D601D6; Thu, 13 Apr 2023 16:03:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA76EC433D2; Thu, 13 Apr 2023 16:03:45 +0000 (UTC) Date: Thu, 13 Apr 2023 09:03:44 -0700 From: Jakub Kicinski To: Jacob Keller Message-ID: <20230413090344.20796001@kernel.org> In-Reply-To: <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com> References: <20230412073611.62942-1-kurt@linutronix.de> <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681401826; bh=Rc5ZK0hEjJCUPLbarklfttD8GZ7zgofLPT8Ny5BT6ac=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FDEagfpji6+VQ7vc82LIuUWvzZ3mHINa2z7GCkahDSUnFzV1BxkQlMxxwUQdB7UVH kCVWlOTqGx0ZQTBuKuRy0Z6C6gqBL+jFf41fQ3mg6XDYa2EfYdPMw3+p8jTFEgOGvH j8d5J3ufTegt+/5v2miE03fQ323wwQJCW4Y1snt23mefUV/QK7ImUL1pSac5U7Dt8O lRbHsyp0mN5NWAGASCFxT8ZQEeNUX0CIjdxDF1P/biOyfFEREzexdeYi3wgfbrkMnT KpGl+7aNj4rv463i1A5a8xNyD4LX+XyTCe1A8sbJhW6zhkrAhl44ksQiNRvQCvNoJW cON6yvABNcAUA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FDEagfpj Subject: Re: [Intel-wired-lan] [PATCH net-next] igc: Avoid transmit queue timeout for XDP X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Kurt Kanzenbach , Jesse Brandeburg , Eric Dumazet , Tony Nguyen , Ong Boon Leong , intel-wired-lan@lists.osuosl.org, Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 12 Apr 2023 15:30:38 -0700 Jacob Keller wrote: > Is most driver's XDP implementation broken? There's also > netif_trans_update but this is called out as a legacy only function. Far > more drivers call this but I don't see either call or a direct update to > trans_start in many XDP implementations... > > Am I missing something or are a bunch of other XDP implementations also > wrong? Only drivers which use the same Tx queues for the stack and XDP need this. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C8AEC77B6E for ; Thu, 13 Apr 2023 16:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbjDMQDt (ORCPT ); Thu, 13 Apr 2023 12:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjDMQDs (ORCPT ); Thu, 13 Apr 2023 12:03:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5686B4EF2 for ; Thu, 13 Apr 2023 09:03:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2FFB6227F for ; Thu, 13 Apr 2023 16:03:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA76EC433D2; Thu, 13 Apr 2023 16:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681401826; bh=Rc5ZK0hEjJCUPLbarklfttD8GZ7zgofLPT8Ny5BT6ac=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FDEagfpji6+VQ7vc82LIuUWvzZ3mHINa2z7GCkahDSUnFzV1BxkQlMxxwUQdB7UVH kCVWlOTqGx0ZQTBuKuRy0Z6C6gqBL+jFf41fQ3mg6XDYa2EfYdPMw3+p8jTFEgOGvH j8d5J3ufTegt+/5v2miE03fQ323wwQJCW4Y1snt23mefUV/QK7ImUL1pSac5U7Dt8O lRbHsyp0mN5NWAGASCFxT8ZQEeNUX0CIjdxDF1P/biOyfFEREzexdeYi3wgfbrkMnT KpGl+7aNj4rv463i1A5a8xNyD4LX+XyTCe1A8sbJhW6zhkrAhl44ksQiNRvQCvNoJW cON6yvABNcAUA== Date: Thu, 13 Apr 2023 09:03:44 -0700 From: Jakub Kicinski To: Jacob Keller Cc: Kurt Kanzenbach , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Paolo Abeni , Vinicius Costa Gomes , "Ong Boon Leong" , , Subject: Re: [PATCH net-next] igc: Avoid transmit queue timeout for XDP Message-ID: <20230413090344.20796001@kernel.org> In-Reply-To: <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com> References: <20230412073611.62942-1-kurt@linutronix.de> <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 12 Apr 2023 15:30:38 -0700 Jacob Keller wrote: > Is most driver's XDP implementation broken? There's also > netif_trans_update but this is called out as a legacy only function. Far > more drivers call this but I don't see either call or a direct update to > trans_start in many XDP implementations... > > Am I missing something or are a bunch of other XDP implementations also > wrong? Only drivers which use the same Tx queues for the stack and XDP need this.