From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49A87C77B6E for ; Thu, 13 Apr 2023 08:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VIRI9Tvkd1WVO0dzYzlI+6PRiECBKyC/VvdMn26lQGo=; b=jBEii31XL7Yoq0 eujhPkEyph7pivs/4oNbHPYxHF1E/71/FD70z9cfWY73+2NplqPUeJsF4laUjw8vlGLzZ55MR5+bs o7mGC5oQf7LnF/R4uJtNThVHRhH+TpGT2UDrs2PS4jDx2IU4pQxVwwO5/LlTtsuWRER2VQc0+aI5x 29DgwsevAIYY+X0E0vEOqYddZK4/lLMTYycCcRHvLa2ltvYUCjfEilWg0woJ+m77Tnk4ofpyleUJq WDuADLcc8Y2UCd81xn+0ZAxICdsOg2vjXP0h+zVd4DC2mZzVVqpvRawiI1j7XgoXsKIcOWdRtW8YO 0Y+LlhlNwPoWwnBnA8KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmsEQ-005OvU-0n; Thu, 13 Apr 2023 08:23:02 +0000 Received: from relay10.mail.gandi.net ([2001:4b98:dc4:8::230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmsEM-005Otw-30; Thu, 13 Apr 2023 08:23:00 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6464424000A; Thu, 13 Apr 2023 08:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681374176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ciag85mAmF6PS4e2a/+yCh2UQDbtdxy+oAzmgl6ZOwY=; b=XVLz1VEi8sbuAHXlIGv24JjCyZBV7wOiY3rPkDej9VhCaJyjmppyFWq9FrQ4uvDiNAbTsh BomeLjiGd2coZifqVaoEk75tlc7HjTN/sXsMSRdicSglQA3L9ozgoDRH2w7GpvGElJf/wD yWZeD6/mteB3R3fG4M8PfioM2PASX86g7aAiutruu4+v7zH43e/7K3AKzmJMJvUuvjkpiN +RqkKT7PFpqBCs1zrqEt422Pj8hdyNBFSpN3WGRi8vM7kIs8QkhpMS49jK0yOUln7gOodd 8/aJ7aKZvdtqgnmMgtTLGsWVogZgkpUikiUEzlTkzAy3PU2u8/RRUH2nVmoykw== Date: Thu, 13 Apr 2023 10:22:53 +0200 From: Miquel Raynal To: Liang Yang Cc: Arseniy Krasnov , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , oxffffaa@gmail.com, kernel@sberdevices.ru, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, "yonghui.yu" Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230413102253.2ee6bae4@xps-13> In-Reply-To: <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> <20230412145715.58c2be4a@xps-13> <7c996832-258f-001c-56bd-87bbdf23eeaa@amlogic.com> <20230412163214.0c764bb3@xps-13> <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_012259_266363_5808E21E X-CRM114-Status: GOOD ( 34.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgTGlhbmcsCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIFRodSwgMTMgQXByIDIw MjMgMTM6MzI6MDMgKzA4MDA6Cgo+IEhpIE1pcXVlbCwKPiAKPiBPbiAyMDIzLzQvMTIgMjI6MzIs IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBbIEVYVEVSTkFMIEVNQUlMIF0KPiA+IAo+ID4gSGVs bG8sCj4gPiAKPiA+IGxpYW5nLnlhbmdAYW1sb2dpYy5jb20gd3JvdGUgb24gV2VkLCAxMiBBcHIg MjAyMyAyMjowNDoyOCArMDgwMDoKPiA+ICAgCj4gPj4gSGkgTWlxdWVsIGFuZCBBcnNlbml5LAo+ ID4+Cj4gPj4gT24gMjAyMy80LzEyIDIwOjU3LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4+ IFsgRVhURVJOQUwgRU1BSUwgXQo+ID4+Pgo+ID4+PiBIaSBBcnNlbml5LAo+ID4+Pgo+ID4+PiBh dmtyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBBcHIgMjAyMyAxNToyMjoy NiArMDMwMDogIAo+ID4+PiAgICA+Pj4+IE9uIDEyLjA0LjIwMjMgMTU6MTgsIE1pcXVlbCBSYXlu YWwgd3JvdGU6ICAKPiA+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Cj4gPj4+Pj4gYXZrcmFzbm92 QHNiZXJkZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMTM6MTQ6NTIgKzAzMDA6 ICAKPiA+Pj4+PiAgICAgPj4+PiBPbiAxMi4wNC4yMDIzIDEyOjM2LCBNaXF1ZWwgUmF5bmFsIHdy b3RlOiAgCj4gPj4+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGF2a3Jhc25v dkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFwciAyMDIzIDEyOjIwOjU1ICswMzAw OiAgCj4gPj4+Pj4+PiAgICAgICA+Pj4+Pj4gT24gMTIuMDQuMjAyMyAxMDo0NCwgTWlxdWVsIFJh eW5hbCB3cm90ZTogIAo+ID4+Pj4+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Pj4+Pgo+ID4+Pj4+ Pj4+PiBBVktyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBBcHIgMjAyMyAw OToxNjo1OCArMDMwMDogIAo+ID4+Pj4+Pj4+PiAgICAgICAgID4+Pj4+Pj4+IFRoaXMgTkFORCBy ZWFkcyBvbmx5IGZldyB1c2VyJ3MgYnl0ZXMgaW4gRUNDIG1vZGUgKG5vdCBmdWxsIE9PQiksIHNv ICAKPiA+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9v ayByaWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiA+Pj4+Pj4+Pj4gbm90IHJl dHJpZXZlIGFsbCB0aGUgT09CIGJ5dGVzLCI/ICAKPiA+Pj4+Pj4+Pj4gICAgICAgICA+Pj4+Pj4+ PiBmaWxsIE9PQiBidWZmZXIgd2l0aCB6ZXJvZXMgdG8gbm90IHJldHVybiBnYXJiYWdlIGZyb20g cHJldmlvdXMgcmVhZHMgIAo+ID4+Pj4+Pj4+Pj4gdG8gdXNlci4KPiA+Pj4+Pj4+Pj4+IE90aGVy d2lzZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRoaXMgZm9yIGp1 c3QgZXJhc2VkCj4gPj4+Pj4+Pj4+PiBwYWdlOgo+ID4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4+IC4u Lgo+ID4+Pj4+Pj4+Pj4gMHgwMDAwMDdmMDogZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYg ZmYgZmYgZmYgZmYgZmYgZmYKPiA+Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogZmYgZmYgZmYgZmYg MDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiA+Pj4+Pj4+Pj4+ICAgICBPT0Ig RGF0YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODggNmUKPiA+ Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogMzggYTEgMmQgZTYgNzcgZDQgMDUgMDYgZjIgYTUgN2Ug MjUgZWIgMzQgN2MgZmYKPiA+Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAg ZGUgOWIgNDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pj4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5y dT4KPiA+Pj4+Pj4+Pj4+IC0tLQo+ID4+Pj4+Pj4+Pj4gICAgZHJpdmVycy9tdGQvbmFuZC9yYXcv bWVzb25fbmFuZC5jIHwgNSArKysrKwo+ID4+Pj4+Pj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDUg aW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNv bl9uYW5kLmMKPiA+Pj4+Pj4+Pj4+IGluZGV4IGY4NGExMDIzOGU0ZC4uZjJmMjQ3MmNiNTExIDEw MDY0NAo+ID4+Pj4+Pj4+Pj4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5j Cj4gPj4+Pj4+Pj4+PiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+ Pj4+Pj4+Pj4+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRf cGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+Pj4+Pj4+Pj4+ICAgIHN0YXRpYyBp bnQgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1 ZiwKPiA+Pj4+Pj4+Pj4+ICAgIAkJCQkgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+ Pj4+Pj4+Pj4+ICAgIHsKPiA+Pj4+Pj4+Pj4+ICsJc3RydWN0IG10ZF9pbmZvICptdGQgPSBuYW5k X3RvX210ZChuYW5kKTsKPiA+Pj4+Pj4+Pj4+ICAgIAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9w b2k7Cj4gPj4+Pj4+Pj4+PiAgICAJaW50IHJldDsgIAo+ID4+Pj4+Pj4+Pj4gICAgPj4+Pj4+Pj4g KwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsgIAo+ID4+Pj4+Pj4+Pgo+ID4+Pj4+ Pj4+PiBJJ20gc3VycHJpc2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0aGUgZW50aXJlIE9PQj8g IAo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gWWVzISBTZWVtcyBpbiBjYXNlIG9mIHJhdyBhY2Nlc3Mg KHdoYXQgaSBzZWUgaW4gdGhpcyBkcml2ZXIpIG51bWJlciBvZiBPT0IgYnl0ZXMgcmVhZAo+ID4+ Pj4+Pj4+IHN0aWxsIGRlcGVuZHMgb24gRUNDIHBhcmFtZXRlcnM6IGZvciBlYWNoIHBvcnRpb24g b2YgZGF0YSBjb3ZlcmVkIHdpdGggRUNDIGNvZGUgd2UgY2FuCj4gPj4+Pj4+Pj4gcmVhZCBpdCdz IEVDQyBjb2RlIGFuZCAidXNlciBieXRlcyIgZnJvbSBPT0IgLSBpdCBpcyB3aGF0IGkgc2VlIGJ5 IGR1bXBpbmcgRE1BIGJ1ZmZlciBieQo+ID4+Pj4+Pj4+IHByaW50aygpLiBGb3IgZXhhbXBsZSBJ J20gd29ya2luZyB3aXRoIDJLIE5BTkQgcGFnZXMsIGVhY2ggcGFnZSBoYXMgMiB4IDFLIEVDQyBi bG9ja3MuCj4gPj4+Pj4+Pj4gRm9yIGVhY2ggRUNDIGJsb2NrIEkgaGF2ZSAxNiBPT0IgYnl0ZXMg d2hpY2ggSSBjYW4gYWNjZXNzIGJ5IHJlYWQvd3JpdGUuIEVhY2ggMTYgYnl0ZXMKPiA+Pj4+Pj4+ PiBjb250YWlucyAyIGJ5dGVzIG9mIHVzZXIncyBkYXRhIGFuZCAxNCBieXRlcyBFQ0MgY29kZXMu IFNvIHdoZW4gSSByZWFkIHBhZ2UgaW4gcmF3IG1vZGUKPiA+Pj4+Pj4+PiBjb250cm9sbGVyIHJl dHVybnMgMzIgYnl0ZXMgKDIgeCAoMiArIDE0KSkgb2YgT09CLiBXaGlsZSBPT0IgaXMgcmVwb3J0 ZWQgYXMgNjQgYnl0ZXMuICAKPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBJbiBhbGwgbW9kZXMsIHdoZW4g eW91IHJlYWQgT09CLCB5b3Ugc2hvdWxkIGdldCB0aGUgZnVsbCBPT0IuIFRoZSBmYWN0Cj4gPj4+ Pj4+PiB0aGF0IEVDQyBjb3JyZWN0aW9uIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQgZG9lcyBub3Qg bWF0dGVyLiBJZiB0aGUgTkFORAo+ID4+Pj4+Pj4gZmVhdHVyZXMgT09CIHNlY3Rpb25zIG9mIDY0 IGJ5dGVzLCB5b3Ugc2hvdWxkIGdldCB0aGUgNjQgYnl0ZXMuCj4gPj4+Pj4+Pgo+ID4+Pj4+Pj4g V2hhdCBoYXBwZW5zIHNvbWV0aW1lcywgaXMgdGhhdCBzb21lIG9mIHRoZSBieXRlcyBhcmUgbm90 IHByb3RlY3RlZAo+ID4+Pj4+Pj4gYWdhaW5zdCBiaXRmbGlwcywgYnV0IHRoZSBwb2xpY3kgaXMg dG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4gIAo+ID4+Pj4+Pgo+ID4+Pj4+PiBPaywgc28gdG8g Y2xhcmlmeSBjYXNlIGZvciB0aGlzIE5BTkQgY29udHJvbGxlcjoKPiA+Pj4+Pj4gMSkgSW4gYm90 aCBFQ0MgYW5kIHJhdyBtb2RlcyBpIG5lZWQgdG8gcmV0dXJuIHRoZSBzYW1lIHJhdyBPT0IgZGF0 YSAoZS5nLiB1c2VyIGJ5dGVzCj4gPj4+Pj4+ICAgICAgKyBFQ0MgY29kZXMpPyAgCj4gPj4+Pj4K PiA+Pj4+PiBXZWxsLCB5b3UgbmVlZCB0byBjb3ZlciB0aGUgc2FtZSBhbW91bnQgb2YgZGF0YSwg eWVzLiBCdXQgaW4gdGhlIEVDQwo+ID4+Pj4+IGNhc2UgdGhlIGRhdGEgd29uJ3QgYmUgcmF3IChh dCBsZWFzdCBub3QgYWxsIG9mIGl0KS4gIAo+ID4+Pj4KPiA+Pj4+IFNvICJzYW1lIGFtb3VudCBv ZiBkYXRhIiwgaW4gRUNDIG1vZGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiByZXR1cm5zIG9ubHkg dXNlciBPT0IgYnl0ZXMgKGUuZy4KPiA+Pj4+IE9PQiBkYXRhIGV4Y2x1ZGluZyBFQ0MgY29kZXMp LCBpbiByYXcgaXQgcmV0dXJucyB1c2VyIGJ5dGVzICsgRUNDIGNvZGVzLiBJSVVDIGNvcnJlY3QK PiA+Pj4+IGJlaGF2aW91ciBpcyB0byBhbHdheXMgcmV0dXJuIHVzZXIgYnl0ZXMgKyBFQ0MgY29k ZXMgYXMgT09CIGRhdGEgZXZlbiBpbiBFQ0MgbW9kZSA/ICAKPiA+Pj4KPiA+Pj4gSWYgdGhlIHBh Z2UgYXJlIDJrKzY0QiB5b3Ugc2hvdWxkIHJlYWQgMmsrNjRCIHdoZW4gT09CIGFyZSByZXF1ZXN0 ZWQuCj4gPj4+Cj4gPj4+IElmIHRoZSBjb250cm9sbGVyIG9ubHkgcmV0dXJucyAyayszMkIsIHRo ZW4gcGVyZm9ybSBhIHJhbmRvbSByZWFkIHRvCj4gPj4+IGp1c3QgbW92ZSB0aGUgcmVhZCBwb2lu dGVyIHRvIG10ZC0+c2l6ZSArIG10ZC0+b29ic2l6ZSAtIDMyIGFuZAo+ID4+PiByZXRyaWV2ZSB0 aGUgbWlzc2luZyAzMiBieXRlcz8gIAo+ID4+Cj4gPj4gMSkgcmF3IHJlYWQgY2FuIHJlYWQgb3V0 IHRoZSB3aG9sZSBwYWdlIGRhdGEgMmsrNjRCLCBkZWNpZGVkIGJ5IHRoZSBsZW4gaW4gdGhlIGNv bnRyb2xsZXIgcmF3IHJlYWQgY29tbWFuZDoKPiA+PiAJY21kID0gKGxlbiAmIEdFTk1BU0soNSwg MCkpIHwgc2NyYW1ibGVyIHwgRE1BX0RJUihkaXIpOwo+ID4+IGFmdGVyIHRoYXQsIHRoZSBtaXNz aW5nIG9vYiBieXRlcyhub3QgdXNlZCkgY2FuIGJlIGNvcGllZCBmcm9tIG1lc29uX2NoaXAtPmRh dGFfYnVmLiBzbyB0aGUgaW1wbGVtZW50YXRpb24gb2YgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXco KSBpcyBsaWtlIHRoaXMgaWYgbmVlZC4KPiA+PiAJewo+ID4+IAkJLi4uLi4uCj4gPj4gCQltZXNv bl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAxKTsKPiA+PiAJCW1lc29uX25mY19nZXRf ZGF0YV9vb2IobmFuZCwgYnVmLCBvb2JfYnVmKTsKPiA+PiAJCW9vYl9sZW4gPSAobmFuZC0+ZWNj LmJ5dGVzICsgMikgKiBuYW5kLT5lY2Muc3RlcHM7Cj4gPj4gCQltZW1jcHkob29iX2J1ZiArIG9v Yl9sZW4sIG1lc29uX2NoaXAtPmRhdGFfYnVmICsgb29iX2xlbiwgbXRkLT5vb2JzaXplIC0gb29i X2xlbik7Cj4gPj4KPiA+PiAJfQo+ID4+IDIpIEluIEVDQyBtb2RlLCB0aGUgY29udHJvbGxlciBj YW4ndCBicmluZyBiYWNrIHRoZSBtaXNzaW5nIE9PQiBieXRlcy4gaXQgY2FuIHJlYWQgb3V0IHRo ZSB1c2VyIGJ5dGVzIGFuZCBlY2MgYnl0ZXMgcGVyIG1lc29uX29vYmxheW91dF9vcHMgZGVmaW5l LiAgCj4gPiAKPiA+IEFuZCB0aGVuIChpZiBvb2JfcmVxdWlyZWQpIHlvdSBjYW4gYnJpbmcgdGhl IG1pc3NpbmcgYnl0ZXMgd2l0aAo+ID4gc29tZXRoaW5nIGFsb25nOgo+ID4gbmFuZF9jaGFuZ2Vf cmVhZF9jb2x1bW5fb3AoY2hpcCwgbXRkLT53cml0ZXNpemUgKyBvb2JfbGVuLAo+ID4gCQkJICAg b29iX2J1ZiArIG9vYl9sZW4sCj4gPiAJCQkgICBtdGQtPm9vYnNpemUgLSBvb2JfbGVuLAo+ID4g CQkJICAgZmFsc2UpOwo+ID4gU2hvdWxkIG5vdCBiZSBhIGh1Z2UgcGVyZm9ybWFuY2UgaGl0LiAg Cj4gCj4gQWZ0ZXIgZmluaXNoaW5nIEVDQyBtb2RlIHJlYWRpbmcsIHRoZSBjb2x1bW4gYWRkcmVz cyBpbnRlcm5hbCBpbiBOQU5EIGRldmljZSBzaG91bGQgYmUgdGhlIHJpZ2h0IHBvczsgaXQgZG9l c24ndCBuZWVkIHRvIGNoYW5nZSB0aGUgY29sdW1uIGFnYWluLiBzbyBhZGRpbmcgY29udHJvbGxl ciByYXcgcmVhZCBmb3IgdGhlIG1pc3NpbmcgYnl0ZXMgYWZ0ZXIgRUNDIHJlYWRpbmcgbWF5IHdv cmtzLgoKWWVzLCBpZiB0aGUgbGFzdCBieXRlIHJlYWQgaXMgdGhlIG9uZSByaWdodCBiZWZvcmUg dGhlICJtaXNzaW5nIiBieXRlcywKdGhlbiB0aGF0IHdpbGwgd29yay4KClRoYW5rcywKTWlxdcOo bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECB14C77B61 for ; Thu, 13 Apr 2023 08:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nVOB2tdN80b0yYCRG6TOt+YhSnrwSbUUhxYBOA2ZlI4=; b=R3Wp2HQON4SLn1 Nyf6FTgxdpvSmvZEz3vxM1kP5VuBwE0tgAZcKcAxxqkZP8Y+YI3A+/sTxBSdKaMcnxAe70x9HhY9Y TwITSiMAqV/BfJYn15JiV98XFxb/uv5InsAJa64wcABZxaDAmUJ6yfPNBllRh4bBjVyZjji+mz59E V6p9fWwMGWbrudLuq8XgX2UL46NVE3fag3rcOltgADF0li5IddROLzBvCEC2NAQqDC+f4XXBO8qZ+ Yy8YswhnCKYZLAZZms27HzbBGgJgaCx/HTnZ6eEjKWJJpgH40FFoW/NcOV03qR21neyL37SlfPo4r mlIQcpnYw9vJyfg3JTjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmsER-005OwB-2J; Thu, 13 Apr 2023 08:23:03 +0000 Received: from relay10.mail.gandi.net ([2001:4b98:dc4:8::230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmsEM-005Otw-30; Thu, 13 Apr 2023 08:23:00 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6464424000A; Thu, 13 Apr 2023 08:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681374176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ciag85mAmF6PS4e2a/+yCh2UQDbtdxy+oAzmgl6ZOwY=; b=XVLz1VEi8sbuAHXlIGv24JjCyZBV7wOiY3rPkDej9VhCaJyjmppyFWq9FrQ4uvDiNAbTsh BomeLjiGd2coZifqVaoEk75tlc7HjTN/sXsMSRdicSglQA3L9ozgoDRH2w7GpvGElJf/wD yWZeD6/mteB3R3fG4M8PfioM2PASX86g7aAiutruu4+v7zH43e/7K3AKzmJMJvUuvjkpiN +RqkKT7PFpqBCs1zrqEt422Pj8hdyNBFSpN3WGRi8vM7kIs8QkhpMS49jK0yOUln7gOodd 8/aJ7aKZvdtqgnmMgtTLGsWVogZgkpUikiUEzlTkzAy3PU2u8/RRUH2nVmoykw== Date: Thu, 13 Apr 2023 10:22:53 +0200 From: Miquel Raynal To: Liang Yang Cc: Arseniy Krasnov , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , oxffffaa@gmail.com, kernel@sberdevices.ru, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, "yonghui.yu" Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230413102253.2ee6bae4@xps-13> In-Reply-To: <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> <20230412145715.58c2be4a@xps-13> <7c996832-258f-001c-56bd-87bbdf23eeaa@amlogic.com> <20230412163214.0c764bb3@xps-13> <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_012259_266363_5808E21E X-CRM114-Status: GOOD ( 34.91 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTGlhbmcsCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIFRodSwgMTMgQXByIDIw MjMgMTM6MzI6MDMgKzA4MDA6Cgo+IEhpIE1pcXVlbCwKPiAKPiBPbiAyMDIzLzQvMTIgMjI6MzIs IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBbIEVYVEVSTkFMIEVNQUlMIF0KPiA+IAo+ID4gSGVs bG8sCj4gPiAKPiA+IGxpYW5nLnlhbmdAYW1sb2dpYy5jb20gd3JvdGUgb24gV2VkLCAxMiBBcHIg MjAyMyAyMjowNDoyOCArMDgwMDoKPiA+ICAgCj4gPj4gSGkgTWlxdWVsIGFuZCBBcnNlbml5LAo+ ID4+Cj4gPj4gT24gMjAyMy80LzEyIDIwOjU3LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4+ IFsgRVhURVJOQUwgRU1BSUwgXQo+ID4+Pgo+ID4+PiBIaSBBcnNlbml5LAo+ID4+Pgo+ID4+PiBh dmtyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBBcHIgMjAyMyAxNToyMjoy NiArMDMwMDogIAo+ID4+PiAgICA+Pj4+IE9uIDEyLjA0LjIwMjMgMTU6MTgsIE1pcXVlbCBSYXlu YWwgd3JvdGU6ICAKPiA+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Cj4gPj4+Pj4gYXZrcmFzbm92 QHNiZXJkZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMTM6MTQ6NTIgKzAzMDA6 ICAKPiA+Pj4+PiAgICAgPj4+PiBPbiAxMi4wNC4yMDIzIDEyOjM2LCBNaXF1ZWwgUmF5bmFsIHdy b3RlOiAgCj4gPj4+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGF2a3Jhc25v dkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFwciAyMDIzIDEyOjIwOjU1ICswMzAw OiAgCj4gPj4+Pj4+PiAgICAgICA+Pj4+Pj4gT24gMTIuMDQuMjAyMyAxMDo0NCwgTWlxdWVsIFJh eW5hbCB3cm90ZTogIAo+ID4+Pj4+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Pj4+Pgo+ID4+Pj4+ Pj4+PiBBVktyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBBcHIgMjAyMyAw OToxNjo1OCArMDMwMDogIAo+ID4+Pj4+Pj4+PiAgICAgICAgID4+Pj4+Pj4+IFRoaXMgTkFORCBy ZWFkcyBvbmx5IGZldyB1c2VyJ3MgYnl0ZXMgaW4gRUNDIG1vZGUgKG5vdCBmdWxsIE9PQiksIHNv ICAKPiA+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9v ayByaWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiA+Pj4+Pj4+Pj4gbm90IHJl dHJpZXZlIGFsbCB0aGUgT09CIGJ5dGVzLCI/ICAKPiA+Pj4+Pj4+Pj4gICAgICAgICA+Pj4+Pj4+ PiBmaWxsIE9PQiBidWZmZXIgd2l0aCB6ZXJvZXMgdG8gbm90IHJldHVybiBnYXJiYWdlIGZyb20g cHJldmlvdXMgcmVhZHMgIAo+ID4+Pj4+Pj4+Pj4gdG8gdXNlci4KPiA+Pj4+Pj4+Pj4+IE90aGVy d2lzZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRoaXMgZm9yIGp1 c3QgZXJhc2VkCj4gPj4+Pj4+Pj4+PiBwYWdlOgo+ID4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4+IC4u Lgo+ID4+Pj4+Pj4+Pj4gMHgwMDAwMDdmMDogZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYg ZmYgZmYgZmYgZmYgZmYgZmYKPiA+Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogZmYgZmYgZmYgZmYg MDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiA+Pj4+Pj4+Pj4+ICAgICBPT0Ig RGF0YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODggNmUKPiA+ Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogMzggYTEgMmQgZTYgNzcgZDQgMDUgMDYgZjIgYTUgN2Ug MjUgZWIgMzQgN2MgZmYKPiA+Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAg ZGUgOWIgNDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pj4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5y dT4KPiA+Pj4+Pj4+Pj4+IC0tLQo+ID4+Pj4+Pj4+Pj4gICAgZHJpdmVycy9tdGQvbmFuZC9yYXcv bWVzb25fbmFuZC5jIHwgNSArKysrKwo+ID4+Pj4+Pj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDUg aW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNv bl9uYW5kLmMKPiA+Pj4+Pj4+Pj4+IGluZGV4IGY4NGExMDIzOGU0ZC4uZjJmMjQ3MmNiNTExIDEw MDY0NAo+ID4+Pj4+Pj4+Pj4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5j Cj4gPj4+Pj4+Pj4+PiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+ Pj4+Pj4+Pj4+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRf cGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+Pj4+Pj4+Pj4+ICAgIHN0YXRpYyBp bnQgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1 ZiwKPiA+Pj4+Pj4+Pj4+ICAgIAkJCQkgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+ Pj4+Pj4+Pj4+ICAgIHsKPiA+Pj4+Pj4+Pj4+ICsJc3RydWN0IG10ZF9pbmZvICptdGQgPSBuYW5k X3RvX210ZChuYW5kKTsKPiA+Pj4+Pj4+Pj4+ICAgIAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9w b2k7Cj4gPj4+Pj4+Pj4+PiAgICAJaW50IHJldDsgIAo+ID4+Pj4+Pj4+Pj4gICAgPj4+Pj4+Pj4g KwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsgIAo+ID4+Pj4+Pj4+Pgo+ID4+Pj4+ Pj4+PiBJJ20gc3VycHJpc2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0aGUgZW50aXJlIE9PQj8g IAo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gWWVzISBTZWVtcyBpbiBjYXNlIG9mIHJhdyBhY2Nlc3Mg KHdoYXQgaSBzZWUgaW4gdGhpcyBkcml2ZXIpIG51bWJlciBvZiBPT0IgYnl0ZXMgcmVhZAo+ID4+ Pj4+Pj4+IHN0aWxsIGRlcGVuZHMgb24gRUNDIHBhcmFtZXRlcnM6IGZvciBlYWNoIHBvcnRpb24g b2YgZGF0YSBjb3ZlcmVkIHdpdGggRUNDIGNvZGUgd2UgY2FuCj4gPj4+Pj4+Pj4gcmVhZCBpdCdz IEVDQyBjb2RlIGFuZCAidXNlciBieXRlcyIgZnJvbSBPT0IgLSBpdCBpcyB3aGF0IGkgc2VlIGJ5 IGR1bXBpbmcgRE1BIGJ1ZmZlciBieQo+ID4+Pj4+Pj4+IHByaW50aygpLiBGb3IgZXhhbXBsZSBJ J20gd29ya2luZyB3aXRoIDJLIE5BTkQgcGFnZXMsIGVhY2ggcGFnZSBoYXMgMiB4IDFLIEVDQyBi bG9ja3MuCj4gPj4+Pj4+Pj4gRm9yIGVhY2ggRUNDIGJsb2NrIEkgaGF2ZSAxNiBPT0IgYnl0ZXMg d2hpY2ggSSBjYW4gYWNjZXNzIGJ5IHJlYWQvd3JpdGUuIEVhY2ggMTYgYnl0ZXMKPiA+Pj4+Pj4+ PiBjb250YWlucyAyIGJ5dGVzIG9mIHVzZXIncyBkYXRhIGFuZCAxNCBieXRlcyBFQ0MgY29kZXMu IFNvIHdoZW4gSSByZWFkIHBhZ2UgaW4gcmF3IG1vZGUKPiA+Pj4+Pj4+PiBjb250cm9sbGVyIHJl dHVybnMgMzIgYnl0ZXMgKDIgeCAoMiArIDE0KSkgb2YgT09CLiBXaGlsZSBPT0IgaXMgcmVwb3J0 ZWQgYXMgNjQgYnl0ZXMuICAKPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBJbiBhbGwgbW9kZXMsIHdoZW4g eW91IHJlYWQgT09CLCB5b3Ugc2hvdWxkIGdldCB0aGUgZnVsbCBPT0IuIFRoZSBmYWN0Cj4gPj4+ Pj4+PiB0aGF0IEVDQyBjb3JyZWN0aW9uIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQgZG9lcyBub3Qg bWF0dGVyLiBJZiB0aGUgTkFORAo+ID4+Pj4+Pj4gZmVhdHVyZXMgT09CIHNlY3Rpb25zIG9mIDY0 IGJ5dGVzLCB5b3Ugc2hvdWxkIGdldCB0aGUgNjQgYnl0ZXMuCj4gPj4+Pj4+Pgo+ID4+Pj4+Pj4g V2hhdCBoYXBwZW5zIHNvbWV0aW1lcywgaXMgdGhhdCBzb21lIG9mIHRoZSBieXRlcyBhcmUgbm90 IHByb3RlY3RlZAo+ID4+Pj4+Pj4gYWdhaW5zdCBiaXRmbGlwcywgYnV0IHRoZSBwb2xpY3kgaXMg dG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4gIAo+ID4+Pj4+Pgo+ID4+Pj4+PiBPaywgc28gdG8g Y2xhcmlmeSBjYXNlIGZvciB0aGlzIE5BTkQgY29udHJvbGxlcjoKPiA+Pj4+Pj4gMSkgSW4gYm90 aCBFQ0MgYW5kIHJhdyBtb2RlcyBpIG5lZWQgdG8gcmV0dXJuIHRoZSBzYW1lIHJhdyBPT0IgZGF0 YSAoZS5nLiB1c2VyIGJ5dGVzCj4gPj4+Pj4+ICAgICAgKyBFQ0MgY29kZXMpPyAgCj4gPj4+Pj4K PiA+Pj4+PiBXZWxsLCB5b3UgbmVlZCB0byBjb3ZlciB0aGUgc2FtZSBhbW91bnQgb2YgZGF0YSwg eWVzLiBCdXQgaW4gdGhlIEVDQwo+ID4+Pj4+IGNhc2UgdGhlIGRhdGEgd29uJ3QgYmUgcmF3IChh dCBsZWFzdCBub3QgYWxsIG9mIGl0KS4gIAo+ID4+Pj4KPiA+Pj4+IFNvICJzYW1lIGFtb3VudCBv ZiBkYXRhIiwgaW4gRUNDIG1vZGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiByZXR1cm5zIG9ubHkg dXNlciBPT0IgYnl0ZXMgKGUuZy4KPiA+Pj4+IE9PQiBkYXRhIGV4Y2x1ZGluZyBFQ0MgY29kZXMp LCBpbiByYXcgaXQgcmV0dXJucyB1c2VyIGJ5dGVzICsgRUNDIGNvZGVzLiBJSVVDIGNvcnJlY3QK PiA+Pj4+IGJlaGF2aW91ciBpcyB0byBhbHdheXMgcmV0dXJuIHVzZXIgYnl0ZXMgKyBFQ0MgY29k ZXMgYXMgT09CIGRhdGEgZXZlbiBpbiBFQ0MgbW9kZSA/ICAKPiA+Pj4KPiA+Pj4gSWYgdGhlIHBh Z2UgYXJlIDJrKzY0QiB5b3Ugc2hvdWxkIHJlYWQgMmsrNjRCIHdoZW4gT09CIGFyZSByZXF1ZXN0 ZWQuCj4gPj4+Cj4gPj4+IElmIHRoZSBjb250cm9sbGVyIG9ubHkgcmV0dXJucyAyayszMkIsIHRo ZW4gcGVyZm9ybSBhIHJhbmRvbSByZWFkIHRvCj4gPj4+IGp1c3QgbW92ZSB0aGUgcmVhZCBwb2lu dGVyIHRvIG10ZC0+c2l6ZSArIG10ZC0+b29ic2l6ZSAtIDMyIGFuZAo+ID4+PiByZXRyaWV2ZSB0 aGUgbWlzc2luZyAzMiBieXRlcz8gIAo+ID4+Cj4gPj4gMSkgcmF3IHJlYWQgY2FuIHJlYWQgb3V0 IHRoZSB3aG9sZSBwYWdlIGRhdGEgMmsrNjRCLCBkZWNpZGVkIGJ5IHRoZSBsZW4gaW4gdGhlIGNv bnRyb2xsZXIgcmF3IHJlYWQgY29tbWFuZDoKPiA+PiAJY21kID0gKGxlbiAmIEdFTk1BU0soNSwg MCkpIHwgc2NyYW1ibGVyIHwgRE1BX0RJUihkaXIpOwo+ID4+IGFmdGVyIHRoYXQsIHRoZSBtaXNz aW5nIG9vYiBieXRlcyhub3QgdXNlZCkgY2FuIGJlIGNvcGllZCBmcm9tIG1lc29uX2NoaXAtPmRh dGFfYnVmLiBzbyB0aGUgaW1wbGVtZW50YXRpb24gb2YgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXco KSBpcyBsaWtlIHRoaXMgaWYgbmVlZC4KPiA+PiAJewo+ID4+IAkJLi4uLi4uCj4gPj4gCQltZXNv bl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAxKTsKPiA+PiAJCW1lc29uX25mY19nZXRf ZGF0YV9vb2IobmFuZCwgYnVmLCBvb2JfYnVmKTsKPiA+PiAJCW9vYl9sZW4gPSAobmFuZC0+ZWNj LmJ5dGVzICsgMikgKiBuYW5kLT5lY2Muc3RlcHM7Cj4gPj4gCQltZW1jcHkob29iX2J1ZiArIG9v Yl9sZW4sIG1lc29uX2NoaXAtPmRhdGFfYnVmICsgb29iX2xlbiwgbXRkLT5vb2JzaXplIC0gb29i X2xlbik7Cj4gPj4KPiA+PiAJfQo+ID4+IDIpIEluIEVDQyBtb2RlLCB0aGUgY29udHJvbGxlciBj YW4ndCBicmluZyBiYWNrIHRoZSBtaXNzaW5nIE9PQiBieXRlcy4gaXQgY2FuIHJlYWQgb3V0IHRo ZSB1c2VyIGJ5dGVzIGFuZCBlY2MgYnl0ZXMgcGVyIG1lc29uX29vYmxheW91dF9vcHMgZGVmaW5l LiAgCj4gPiAKPiA+IEFuZCB0aGVuIChpZiBvb2JfcmVxdWlyZWQpIHlvdSBjYW4gYnJpbmcgdGhl IG1pc3NpbmcgYnl0ZXMgd2l0aAo+ID4gc29tZXRoaW5nIGFsb25nOgo+ID4gbmFuZF9jaGFuZ2Vf cmVhZF9jb2x1bW5fb3AoY2hpcCwgbXRkLT53cml0ZXNpemUgKyBvb2JfbGVuLAo+ID4gCQkJICAg b29iX2J1ZiArIG9vYl9sZW4sCj4gPiAJCQkgICBtdGQtPm9vYnNpemUgLSBvb2JfbGVuLAo+ID4g CQkJICAgZmFsc2UpOwo+ID4gU2hvdWxkIG5vdCBiZSBhIGh1Z2UgcGVyZm9ybWFuY2UgaGl0LiAg Cj4gCj4gQWZ0ZXIgZmluaXNoaW5nIEVDQyBtb2RlIHJlYWRpbmcsIHRoZSBjb2x1bW4gYWRkcmVz cyBpbnRlcm5hbCBpbiBOQU5EIGRldmljZSBzaG91bGQgYmUgdGhlIHJpZ2h0IHBvczsgaXQgZG9l c24ndCBuZWVkIHRvIGNoYW5nZSB0aGUgY29sdW1uIGFnYWluLiBzbyBhZGRpbmcgY29udHJvbGxl ciByYXcgcmVhZCBmb3IgdGhlIG1pc3NpbmcgYnl0ZXMgYWZ0ZXIgRUNDIHJlYWRpbmcgbWF5IHdv cmtzLgoKWWVzLCBpZiB0aGUgbGFzdCBieXRlIHJlYWQgaXMgdGhlIG9uZSByaWdodCBiZWZvcmUg dGhlICJtaXNzaW5nIiBieXRlcywKdGhlbiB0aGF0IHdpbGwgd29yay4KClRoYW5rcywKTWlxdcOo bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68856C77B6C for ; Thu, 13 Apr 2023 08:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BkhLLvkvVO2dVwsmJh5/NfTg0rxjJvvbH2xUQJwJMQ0=; b=yRGR1qTYdhkcL2 jxPzkoog4tIRYHJZIwYd31P+RExFIPCyijh4zLaU7IvW6eB3c42UKz+O6LDFtFwjJukJ9bChpUaOm wBXtKnMnmd9iv+uUzbUO9OjY79I7ba/ojiwW4zG7irq0muoLHyel/T7auetLyDJP70rF65cRp7UO+ RRBNHerR2LD6KzT0zI6Jue/A4kh1U1/4f8qZH7YirYDmTTFEXm4OjYqBnanMJNscikJV/FdLP1jGu 32ygefvcTDn7k6SvpNj1ysxrD0zLkBf+R/PxqmGMXCYiSrn+zqkEN9D5W0z26cVmrVYKKGyOaNUtS ORoRreTHo5TOSiIT45Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmsEQ-005Ovf-2L; Thu, 13 Apr 2023 08:23:02 +0000 Received: from relay10.mail.gandi.net ([2001:4b98:dc4:8::230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmsEM-005Otw-30; Thu, 13 Apr 2023 08:23:00 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6464424000A; Thu, 13 Apr 2023 08:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681374176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ciag85mAmF6PS4e2a/+yCh2UQDbtdxy+oAzmgl6ZOwY=; b=XVLz1VEi8sbuAHXlIGv24JjCyZBV7wOiY3rPkDej9VhCaJyjmppyFWq9FrQ4uvDiNAbTsh BomeLjiGd2coZifqVaoEk75tlc7HjTN/sXsMSRdicSglQA3L9ozgoDRH2w7GpvGElJf/wD yWZeD6/mteB3R3fG4M8PfioM2PASX86g7aAiutruu4+v7zH43e/7K3AKzmJMJvUuvjkpiN +RqkKT7PFpqBCs1zrqEt422Pj8hdyNBFSpN3WGRi8vM7kIs8QkhpMS49jK0yOUln7gOodd 8/aJ7aKZvdtqgnmMgtTLGsWVogZgkpUikiUEzlTkzAy3PU2u8/RRUH2nVmoykw== Date: Thu, 13 Apr 2023 10:22:53 +0200 From: Miquel Raynal To: Liang Yang Cc: Arseniy Krasnov , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , oxffffaa@gmail.com, kernel@sberdevices.ru, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, "yonghui.yu" Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230413102253.2ee6bae4@xps-13> In-Reply-To: <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> <20230412145715.58c2be4a@xps-13> <7c996832-258f-001c-56bd-87bbdf23eeaa@amlogic.com> <20230412163214.0c764bb3@xps-13> <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_012259_266363_5808E21E X-CRM114-Status: GOOD ( 34.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGlhbmcsCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIFRodSwgMTMgQXByIDIw MjMgMTM6MzI6MDMgKzA4MDA6Cgo+IEhpIE1pcXVlbCwKPiAKPiBPbiAyMDIzLzQvMTIgMjI6MzIs IE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBbIEVYVEVSTkFMIEVNQUlMIF0KPiA+IAo+ID4gSGVs bG8sCj4gPiAKPiA+IGxpYW5nLnlhbmdAYW1sb2dpYy5jb20gd3JvdGUgb24gV2VkLCAxMiBBcHIg MjAyMyAyMjowNDoyOCArMDgwMDoKPiA+ICAgCj4gPj4gSGkgTWlxdWVsIGFuZCBBcnNlbml5LAo+ ID4+Cj4gPj4gT24gMjAyMy80LzEyIDIwOjU3LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4+ IFsgRVhURVJOQUwgRU1BSUwgXQo+ID4+Pgo+ID4+PiBIaSBBcnNlbml5LAo+ID4+Pgo+ID4+PiBh dmtyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBBcHIgMjAyMyAxNToyMjoy NiArMDMwMDogIAo+ID4+PiAgICA+Pj4+IE9uIDEyLjA0LjIwMjMgMTU6MTgsIE1pcXVlbCBSYXlu YWwgd3JvdGU6ICAKPiA+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Cj4gPj4+Pj4gYXZrcmFzbm92 QHNiZXJkZXZpY2VzLnJ1IHdyb3RlIG9uIFdlZCwgMTIgQXByIDIwMjMgMTM6MTQ6NTIgKzAzMDA6 ICAKPiA+Pj4+PiAgICAgPj4+PiBPbiAxMi4wNC4yMDIzIDEyOjM2LCBNaXF1ZWwgUmF5bmFsIHdy b3RlOiAgCj4gPj4+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGF2a3Jhc25v dkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDEyIEFwciAyMDIzIDEyOjIwOjU1ICswMzAw OiAgCj4gPj4+Pj4+PiAgICAgICA+Pj4+Pj4gT24gMTIuMDQuMjAyMyAxMDo0NCwgTWlxdWVsIFJh eW5hbCB3cm90ZTogIAo+ID4+Pj4+Pj4+PiBIaSBBcnNlbml5LAo+ID4+Pj4+Pj4+Pgo+ID4+Pj4+ Pj4+PiBBVktyYXNub3ZAc2JlcmRldmljZXMucnUgd3JvdGUgb24gV2VkLCAxMiBBcHIgMjAyMyAw OToxNjo1OCArMDMwMDogIAo+ID4+Pj4+Pj4+PiAgICAgICAgID4+Pj4+Pj4+IFRoaXMgTkFORCBy ZWFkcyBvbmx5IGZldyB1c2VyJ3MgYnl0ZXMgaW4gRUNDIG1vZGUgKG5vdCBmdWxsIE9PQiksIHNv ICAKPiA+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4gIlRoaXMgTkFORCByZWFkcyIgZG9lcyBub3QgbG9v ayByaWdodCwgZG8geW91IG1lYW4gIlN1YnBhZ2UgcmVhZHMgZG8KPiA+Pj4+Pj4+Pj4gbm90IHJl dHJpZXZlIGFsbCB0aGUgT09CIGJ5dGVzLCI/ICAKPiA+Pj4+Pj4+Pj4gICAgICAgICA+Pj4+Pj4+ PiBmaWxsIE9PQiBidWZmZXIgd2l0aCB6ZXJvZXMgdG8gbm90IHJldHVybiBnYXJiYWdlIGZyb20g cHJldmlvdXMgcmVhZHMgIAo+ID4+Pj4+Pj4+Pj4gdG8gdXNlci4KPiA+Pj4+Pj4+Pj4+IE90aGVy d2lzZSAnbmFuZGR1bXAnIHV0aWxpdHkgcHJpbnRzIHNvbWV0aGluZyBsaWtlIHRoaXMgZm9yIGp1 c3QgZXJhc2VkCj4gPj4+Pj4+Pj4+PiBwYWdlOgo+ID4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4+IC4u Lgo+ID4+Pj4+Pj4+Pj4gMHgwMDAwMDdmMDogZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYgZmYg ZmYgZmYgZmYgZmYgZmYgZmYKPiA+Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogZmYgZmYgZmYgZmYg MDAgMDAgZmYgZmYgODAgY2YgMjIgOTkgY2IgYWQgZDMgYmUKPiA+Pj4+Pj4+Pj4+ICAgICBPT0Ig RGF0YTogNjMgMjcgYWUgMDYgMTYgMGEgMmYgZWIgYmIgZGQgNDYgNzQgNDEgOGUgODggNmUKPiA+ Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogMzggYTEgMmQgZTYgNzcgZDQgMDUgMDYgZjIgYTUgN2Ug MjUgZWIgMzQgN2MgZmYKPiA+Pj4+Pj4+Pj4+ICAgICBPT0IgRGF0YTogMzggZWEgZGUgMTQgMTAg ZGUgOWIgNDAgMzMgMTYgNmEgY2MgOWQgYWEgMmYgNWUKPiA+Pj4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5y dT4KPiA+Pj4+Pj4+Pj4+IC0tLQo+ID4+Pj4+Pj4+Pj4gICAgZHJpdmVycy9tdGQvbmFuZC9yYXcv bWVzb25fbmFuZC5jIHwgNSArKysrKwo+ID4+Pj4+Pj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDUg aW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNv bl9uYW5kLmMKPiA+Pj4+Pj4+Pj4+IGluZGV4IGY4NGExMDIzOGU0ZC4uZjJmMjQ3MmNiNTExIDEw MDY0NAo+ID4+Pj4+Pj4+Pj4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5j Cj4gPj4+Pj4+Pj4+PiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+ Pj4+Pj4+Pj4+IEBAIC04NTgsOSArODU4LDEyIEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3JlYWRf cGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiA+Pj4+Pj4+Pj4+ICAgIHN0YXRpYyBp bnQgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwgdTggKmJ1 ZiwKPiA+Pj4+Pj4+Pj4+ICAgIAkJCQkgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+ Pj4+Pj4+Pj4+ICAgIHsKPiA+Pj4+Pj4+Pj4+ICsJc3RydWN0IG10ZF9pbmZvICptdGQgPSBuYW5k X3RvX210ZChuYW5kKTsKPiA+Pj4+Pj4+Pj4+ICAgIAl1OCAqb29iX2J1ZiA9IG5hbmQtPm9vYl9w b2k7Cj4gPj4+Pj4+Pj4+PiAgICAJaW50IHJldDsgIAo+ID4+Pj4+Pj4+Pj4gICAgPj4+Pj4+Pj4g KwltZW1zZXQob29iX2J1ZiwgMCwgbXRkLT5vb2JzaXplKTsgIAo+ID4+Pj4+Pj4+Pgo+ID4+Pj4+ Pj4+PiBJJ20gc3VycHJpc2VkIHJhdyByZWFkcyBkbyBub3QgcmVhZCB0aGUgZW50aXJlIE9PQj8g IAo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gWWVzISBTZWVtcyBpbiBjYXNlIG9mIHJhdyBhY2Nlc3Mg KHdoYXQgaSBzZWUgaW4gdGhpcyBkcml2ZXIpIG51bWJlciBvZiBPT0IgYnl0ZXMgcmVhZAo+ID4+ Pj4+Pj4+IHN0aWxsIGRlcGVuZHMgb24gRUNDIHBhcmFtZXRlcnM6IGZvciBlYWNoIHBvcnRpb24g b2YgZGF0YSBjb3ZlcmVkIHdpdGggRUNDIGNvZGUgd2UgY2FuCj4gPj4+Pj4+Pj4gcmVhZCBpdCdz IEVDQyBjb2RlIGFuZCAidXNlciBieXRlcyIgZnJvbSBPT0IgLSBpdCBpcyB3aGF0IGkgc2VlIGJ5 IGR1bXBpbmcgRE1BIGJ1ZmZlciBieQo+ID4+Pj4+Pj4+IHByaW50aygpLiBGb3IgZXhhbXBsZSBJ J20gd29ya2luZyB3aXRoIDJLIE5BTkQgcGFnZXMsIGVhY2ggcGFnZSBoYXMgMiB4IDFLIEVDQyBi bG9ja3MuCj4gPj4+Pj4+Pj4gRm9yIGVhY2ggRUNDIGJsb2NrIEkgaGF2ZSAxNiBPT0IgYnl0ZXMg d2hpY2ggSSBjYW4gYWNjZXNzIGJ5IHJlYWQvd3JpdGUuIEVhY2ggMTYgYnl0ZXMKPiA+Pj4+Pj4+ PiBjb250YWlucyAyIGJ5dGVzIG9mIHVzZXIncyBkYXRhIGFuZCAxNCBieXRlcyBFQ0MgY29kZXMu IFNvIHdoZW4gSSByZWFkIHBhZ2UgaW4gcmF3IG1vZGUKPiA+Pj4+Pj4+PiBjb250cm9sbGVyIHJl dHVybnMgMzIgYnl0ZXMgKDIgeCAoMiArIDE0KSkgb2YgT09CLiBXaGlsZSBPT0IgaXMgcmVwb3J0 ZWQgYXMgNjQgYnl0ZXMuICAKPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBJbiBhbGwgbW9kZXMsIHdoZW4g eW91IHJlYWQgT09CLCB5b3Ugc2hvdWxkIGdldCB0aGUgZnVsbCBPT0IuIFRoZSBmYWN0Cj4gPj4+ Pj4+PiB0aGF0IEVDQyBjb3JyZWN0aW9uIGlzIGVuYWJsZWQgb3IgZGlzYWJsZWQgZG9lcyBub3Qg bWF0dGVyLiBJZiB0aGUgTkFORAo+ID4+Pj4+Pj4gZmVhdHVyZXMgT09CIHNlY3Rpb25zIG9mIDY0 IGJ5dGVzLCB5b3Ugc2hvdWxkIGdldCB0aGUgNjQgYnl0ZXMuCj4gPj4+Pj4+Pgo+ID4+Pj4+Pj4g V2hhdCBoYXBwZW5zIHNvbWV0aW1lcywgaXMgdGhhdCBzb21lIG9mIHRoZSBieXRlcyBhcmUgbm90 IHByb3RlY3RlZAo+ID4+Pj4+Pj4gYWdhaW5zdCBiaXRmbGlwcywgYnV0IHRoZSBwb2xpY3kgaXMg dG8gcmV0dXJuIHRoZSBmdWxsIGJ1ZmZlci4gIAo+ID4+Pj4+Pgo+ID4+Pj4+PiBPaywgc28gdG8g Y2xhcmlmeSBjYXNlIGZvciB0aGlzIE5BTkQgY29udHJvbGxlcjoKPiA+Pj4+Pj4gMSkgSW4gYm90 aCBFQ0MgYW5kIHJhdyBtb2RlcyBpIG5lZWQgdG8gcmV0dXJuIHRoZSBzYW1lIHJhdyBPT0IgZGF0 YSAoZS5nLiB1c2VyIGJ5dGVzCj4gPj4+Pj4+ICAgICAgKyBFQ0MgY29kZXMpPyAgCj4gPj4+Pj4K PiA+Pj4+PiBXZWxsLCB5b3UgbmVlZCB0byBjb3ZlciB0aGUgc2FtZSBhbW91bnQgb2YgZGF0YSwg eWVzLiBCdXQgaW4gdGhlIEVDQwo+ID4+Pj4+IGNhc2UgdGhlIGRhdGEgd29uJ3QgYmUgcmF3IChh dCBsZWFzdCBub3QgYWxsIG9mIGl0KS4gIAo+ID4+Pj4KPiA+Pj4+IFNvICJzYW1lIGFtb3VudCBv ZiBkYXRhIiwgaW4gRUNDIG1vZGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiByZXR1cm5zIG9ubHkg dXNlciBPT0IgYnl0ZXMgKGUuZy4KPiA+Pj4+IE9PQiBkYXRhIGV4Y2x1ZGluZyBFQ0MgY29kZXMp LCBpbiByYXcgaXQgcmV0dXJucyB1c2VyIGJ5dGVzICsgRUNDIGNvZGVzLiBJSVVDIGNvcnJlY3QK PiA+Pj4+IGJlaGF2aW91ciBpcyB0byBhbHdheXMgcmV0dXJuIHVzZXIgYnl0ZXMgKyBFQ0MgY29k ZXMgYXMgT09CIGRhdGEgZXZlbiBpbiBFQ0MgbW9kZSA/ICAKPiA+Pj4KPiA+Pj4gSWYgdGhlIHBh Z2UgYXJlIDJrKzY0QiB5b3Ugc2hvdWxkIHJlYWQgMmsrNjRCIHdoZW4gT09CIGFyZSByZXF1ZXN0 ZWQuCj4gPj4+Cj4gPj4+IElmIHRoZSBjb250cm9sbGVyIG9ubHkgcmV0dXJucyAyayszMkIsIHRo ZW4gcGVyZm9ybSBhIHJhbmRvbSByZWFkIHRvCj4gPj4+IGp1c3QgbW92ZSB0aGUgcmVhZCBwb2lu dGVyIHRvIG10ZC0+c2l6ZSArIG10ZC0+b29ic2l6ZSAtIDMyIGFuZAo+ID4+PiByZXRyaWV2ZSB0 aGUgbWlzc2luZyAzMiBieXRlcz8gIAo+ID4+Cj4gPj4gMSkgcmF3IHJlYWQgY2FuIHJlYWQgb3V0 IHRoZSB3aG9sZSBwYWdlIGRhdGEgMmsrNjRCLCBkZWNpZGVkIGJ5IHRoZSBsZW4gaW4gdGhlIGNv bnRyb2xsZXIgcmF3IHJlYWQgY29tbWFuZDoKPiA+PiAJY21kID0gKGxlbiAmIEdFTk1BU0soNSwg MCkpIHwgc2NyYW1ibGVyIHwgRE1BX0RJUihkaXIpOwo+ID4+IGFmdGVyIHRoYXQsIHRoZSBtaXNz aW5nIG9vYiBieXRlcyhub3QgdXNlZCkgY2FuIGJlIGNvcGllZCBmcm9tIG1lc29uX2NoaXAtPmRh dGFfYnVmLiBzbyB0aGUgaW1wbGVtZW50YXRpb24gb2YgbWVzb25fbmZjX3JlYWRfcGFnZV9yYXco KSBpcyBsaWtlIHRoaXMgaWYgbmVlZC4KPiA+PiAJewo+ID4+IAkJLi4uLi4uCj4gPj4gCQltZXNv bl9uZmNfcmVhZF9wYWdlX3N1YihuYW5kLCBwYWdlLCAxKTsKPiA+PiAJCW1lc29uX25mY19nZXRf ZGF0YV9vb2IobmFuZCwgYnVmLCBvb2JfYnVmKTsKPiA+PiAJCW9vYl9sZW4gPSAobmFuZC0+ZWNj LmJ5dGVzICsgMikgKiBuYW5kLT5lY2Muc3RlcHM7Cj4gPj4gCQltZW1jcHkob29iX2J1ZiArIG9v Yl9sZW4sIG1lc29uX2NoaXAtPmRhdGFfYnVmICsgb29iX2xlbiwgbXRkLT5vb2JzaXplIC0gb29i X2xlbik7Cj4gPj4KPiA+PiAJfQo+ID4+IDIpIEluIEVDQyBtb2RlLCB0aGUgY29udHJvbGxlciBj YW4ndCBicmluZyBiYWNrIHRoZSBtaXNzaW5nIE9PQiBieXRlcy4gaXQgY2FuIHJlYWQgb3V0IHRo ZSB1c2VyIGJ5dGVzIGFuZCBlY2MgYnl0ZXMgcGVyIG1lc29uX29vYmxheW91dF9vcHMgZGVmaW5l LiAgCj4gPiAKPiA+IEFuZCB0aGVuIChpZiBvb2JfcmVxdWlyZWQpIHlvdSBjYW4gYnJpbmcgdGhl IG1pc3NpbmcgYnl0ZXMgd2l0aAo+ID4gc29tZXRoaW5nIGFsb25nOgo+ID4gbmFuZF9jaGFuZ2Vf cmVhZF9jb2x1bW5fb3AoY2hpcCwgbXRkLT53cml0ZXNpemUgKyBvb2JfbGVuLAo+ID4gCQkJICAg b29iX2J1ZiArIG9vYl9sZW4sCj4gPiAJCQkgICBtdGQtPm9vYnNpemUgLSBvb2JfbGVuLAo+ID4g CQkJICAgZmFsc2UpOwo+ID4gU2hvdWxkIG5vdCBiZSBhIGh1Z2UgcGVyZm9ybWFuY2UgaGl0LiAg Cj4gCj4gQWZ0ZXIgZmluaXNoaW5nIEVDQyBtb2RlIHJlYWRpbmcsIHRoZSBjb2x1bW4gYWRkcmVz cyBpbnRlcm5hbCBpbiBOQU5EIGRldmljZSBzaG91bGQgYmUgdGhlIHJpZ2h0IHBvczsgaXQgZG9l c24ndCBuZWVkIHRvIGNoYW5nZSB0aGUgY29sdW1uIGFnYWluLiBzbyBhZGRpbmcgY29udHJvbGxl ciByYXcgcmVhZCBmb3IgdGhlIG1pc3NpbmcgYnl0ZXMgYWZ0ZXIgRUNDIHJlYWRpbmcgbWF5IHdv cmtzLgoKWWVzLCBpZiB0aGUgbGFzdCBieXRlIHJlYWQgaXMgdGhlIG9uZSByaWdodCBiZWZvcmUg dGhlICJtaXNzaW5nIiBieXRlcywKdGhlbiB0aGF0IHdpbGwgd29yay4KClRoYW5rcywKTWlxdcOo bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0363FC77B6C for ; Thu, 13 Apr 2023 08:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbjDMIXH (ORCPT ); Thu, 13 Apr 2023 04:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbjDMIXE (ORCPT ); Thu, 13 Apr 2023 04:23:04 -0400 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 247F7E2 for ; Thu, 13 Apr 2023 01:22:57 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6464424000A; Thu, 13 Apr 2023 08:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681374176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ciag85mAmF6PS4e2a/+yCh2UQDbtdxy+oAzmgl6ZOwY=; b=XVLz1VEi8sbuAHXlIGv24JjCyZBV7wOiY3rPkDej9VhCaJyjmppyFWq9FrQ4uvDiNAbTsh BomeLjiGd2coZifqVaoEk75tlc7HjTN/sXsMSRdicSglQA3L9ozgoDRH2w7GpvGElJf/wD yWZeD6/mteB3R3fG4M8PfioM2PASX86g7aAiutruu4+v7zH43e/7K3AKzmJMJvUuvjkpiN +RqkKT7PFpqBCs1zrqEt422Pj8hdyNBFSpN3WGRi8vM7kIs8QkhpMS49jK0yOUln7gOodd 8/aJ7aKZvdtqgnmMgtTLGsWVogZgkpUikiUEzlTkzAy3PU2u8/RRUH2nVmoykw== Date: Thu, 13 Apr 2023 10:22:53 +0200 From: Miquel Raynal To: Liang Yang Cc: Arseniy Krasnov , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , oxffffaa@gmail.com, kernel@sberdevices.ru, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, "yonghui.yu" Subject: Re: [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Message-ID: <20230413102253.2ee6bae4@xps-13> In-Reply-To: <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> References: <20230412061700.1492474-1-AVKrasnov@sberdevices.ru> <20230412061700.1492474-5-AVKrasnov@sberdevices.ru> <20230412094400.3c82f631@xps-13> <20230412113654.183350d0@xps-13> <4eace0a0-f6af-7d99-a52f-7913a2139330@sberdevices.ru> <20230412141824.755b2bca@xps-13> <20230412145715.58c2be4a@xps-13> <7c996832-258f-001c-56bd-87bbdf23eeaa@amlogic.com> <20230412163214.0c764bb3@xps-13> <0c61eaae-053e-5768-a533-70b2ff0cc95d@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liang, liang.yang@amlogic.com wrote on Thu, 13 Apr 2023 13:32:03 +0800: > Hi Miquel, >=20 > On 2023/4/12 22:32, Miquel Raynal wrote: > > [ EXTERNAL EMAIL ] > >=20 > > Hello, > >=20 > > liang.yang@amlogic.com wrote on Wed, 12 Apr 2023 22:04:28 +0800: > > =20 > >> Hi Miquel and Arseniy, > >> > >> On 2023/4/12 20:57, Miquel Raynal wrote: =20 > >>> [ EXTERNAL EMAIL ] > >>> > >>> Hi Arseniy, > >>> > >>> avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 15:22:26 +0300: =20 > >>> >>>> On 12.04.2023 15:18, Miquel Raynal wrote: =20 > >>>>> Hi Arseniy, > >>>>> > >>>>> avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 13:14:52 +0300: = =20 > >>>>> >>>> On 12.04.2023 12:36, Miquel Raynal wrote: =20 > >>>>>>> Hi Arseniy, > >>>>>>> > >>>>>>> avkrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 12:20:55 +0300= : =20 > >>>>>>> >>>>>> On 12.04.2023 10:44, Miquel Raynal wrote: =20 > >>>>>>>>> Hi Arseniy, > >>>>>>>>> > >>>>>>>>> AVKrasnov@sberdevices.ru wrote on Wed, 12 Apr 2023 09:16:58 +03= 00: =20 > >>>>>>>>> >>>>>>>> This NAND reads only few user's bytes in ECC m= ode (not full OOB), so =20 > >>>>>>>>> > >>>>>>>>> "This NAND reads" does not look right, do you mean "Subpage rea= ds do > >>>>>>>>> not retrieve all the OOB bytes,"? =20 > >>>>>>>>> >>>>>>>> fill OOB buffer with zeroes to not return garb= age from previous reads =20 > >>>>>>>>>> to user. > >>>>>>>>>> Otherwise 'nanddump' utility prints something like this for ju= st erased > >>>>>>>>>> page: > >>>>>>>>>> > >>>>>>>>>> ... > >>>>>>>>>> 0x000007f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > >>>>>>>>>> OOB Data: ff ff ff ff 00 00 ff ff 80 cf 22 99 cb ad d3 be > >>>>>>>>>> OOB Data: 63 27 ae 06 16 0a 2f eb bb dd 46 74 41 8e 88 6e > >>>>>>>>>> OOB Data: 38 a1 2d e6 77 d4 05 06 f2 a5 7e 25 eb 34 7c ff > >>>>>>>>>> OOB Data: 38 ea de 14 10 de 9b 40 33 16 6a cc 9d aa 2f 5e > >>>>>>>>>> > >>>>>>>>>> Signed-off-by: Arseniy Krasnov > >>>>>>>>>> --- > >>>>>>>>>> drivers/mtd/nand/raw/meson_nand.c | 5 +++++ > >>>>>>>>>> 1 file changed, 5 insertions(+) > >>>>>>>>>> > >>>>>>>>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/n= and/raw/meson_nand.c > >>>>>>>>>> index f84a10238e4d..f2f2472cb511 100644 > >>>>>>>>>> --- a/drivers/mtd/nand/raw/meson_nand.c > >>>>>>>>>> +++ b/drivers/mtd/nand/raw/meson_nand.c > >>>>>>>>>> @@ -858,9 +858,12 @@ static int meson_nfc_read_page_sub(struct= nand_chip *nand, > >>>>>>>>>> static int meson_nfc_read_page_raw(struct nand_chip *nand, = u8 *buf, > >>>>>>>>>> int oob_required, int page) > >>>>>>>>>> { > >>>>>>>>>> + struct mtd_info *mtd =3D nand_to_mtd(nand); > >>>>>>>>>> u8 *oob_buf =3D nand->oob_poi; > >>>>>>>>>> int ret; =20 > >>>>>>>>>> >>>>>>>> + memset(oob_buf, 0, mtd->oobsize); =20 > >>>>>>>>> > >>>>>>>>> I'm surprised raw reads do not read the entire OOB? =20 > >>>>>>>> > >>>>>>>> Yes! Seems in case of raw access (what i see in this driver) num= ber of OOB bytes read > >>>>>>>> still depends on ECC parameters: for each portion of data covere= d with ECC code we can > >>>>>>>> read it's ECC code and "user bytes" from OOB - it is what i see = by dumping DMA buffer by > >>>>>>>> printk(). For example I'm working with 2K NAND pages, each page = has 2 x 1K ECC blocks. > >>>>>>>> For each ECC block I have 16 OOB bytes which I can access by rea= d/write. Each 16 bytes > >>>>>>>> contains 2 bytes of user's data and 14 bytes ECC codes. So when = I read page in raw mode > >>>>>>>> controller returns 32 bytes (2 x (2 + 14)) of OOB. While OOB is = reported as 64 bytes. =20 > >>>>>>> > >>>>>>> In all modes, when you read OOB, you should get the full OOB. The= fact > >>>>>>> that ECC correction is enabled or disabled does not matter. If th= e NAND > >>>>>>> features OOB sections of 64 bytes, you should get the 64 bytes. > >>>>>>> > >>>>>>> What happens sometimes, is that some of the bytes are not protect= ed > >>>>>>> against bitflips, but the policy is to return the full buffer. =20 > >>>>>> > >>>>>> Ok, so to clarify case for this NAND controller: > >>>>>> 1) In both ECC and raw modes i need to return the same raw OOB dat= a (e.g. user bytes > >>>>>> + ECC codes)? =20 > >>>>> > >>>>> Well, you need to cover the same amount of data, yes. But in the ECC > >>>>> case the data won't be raw (at least not all of it). =20 > >>>> > >>>> So "same amount of data", in ECC mode current implementation returns= only user OOB bytes (e.g. > >>>> OOB data excluding ECC codes), in raw it returns user bytes + ECC co= des. IIUC correct > >>>> behaviour is to always return user bytes + ECC codes as OOB data eve= n in ECC mode ? =20 > >>> > >>> If the page are 2k+64B you should read 2k+64B when OOB are requested. > >>> > >>> If the controller only returns 2k+32B, then perform a random read to > >>> just move the read pointer to mtd->size + mtd->oobsize - 32 and > >>> retrieve the missing 32 bytes? =20 > >> > >> 1) raw read can read out the whole page data 2k+64B, decided by the le= n in the controller raw read command: > >> cmd =3D (len & GENMASK(5, 0)) | scrambler | DMA_DIR(dir); > >> after that, the missing oob bytes(not used) can be copied from meson_c= hip->data_buf. so the implementation of meson_nfc_read_page_raw() is like t= his if need. > >> { > >> ...... > >> meson_nfc_read_page_sub(nand, page, 1); > >> meson_nfc_get_data_oob(nand, buf, oob_buf); > >> oob_len =3D (nand->ecc.bytes + 2) * nand->ecc.steps; > >> memcpy(oob_buf + oob_len, meson_chip->data_buf + oob_len, mtd->oobsi= ze - oob_len); > >> > >> } > >> 2) In ECC mode, the controller can't bring back the missing OOB bytes.= it can read out the user bytes and ecc bytes per meson_ooblayout_ops defin= e. =20 > >=20 > > And then (if oob_required) you can bring the missing bytes with > > something along: > > nand_change_read_column_op(chip, mtd->writesize + oob_len, > > oob_buf + oob_len, > > mtd->oobsize - oob_len, > > false); > > Should not be a huge performance hit. =20 >=20 > After finishing ECC mode reading, the column address internal in NAND dev= ice should be the right pos; it doesn't need to change the column again. so= adding controller raw read for the missing bytes after ECC reading may wor= ks. Yes, if the last byte read is the one right before the "missing" bytes, then that will work. Thanks, Miqu=C3=A8l