From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Jamin Lin" <jamin_lin@aspeedtech.com>
Cc: <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/2] kernel-fitimage: support 64 bits address
Date: Thu, 13 Apr 2023 18:04:52 +0200 [thread overview]
Message-ID: <20230413180452.53f9eb8f@booty> (raw)
In-Reply-To: <20230413103109.5604-2-jamin_lin@aspeedtech.com>
Hello Jamin,
thank you for your contribution!
On Thu, 13 Apr 2023 18:31:08 +0800
"Jamin Lin" <jamin_lin@aspeedtech.com> wrote:
> The default value of address-cells is "1", so the generated "its" file
> only supports 32bits address for kernel FIT image.
> However, some platforms may want to support 64bits address
> of UBOOT_LOADADDRESS and UBOOT_ENTRYPOINT.
> Therefore, adds a variable to support both 64bits and 32bits address cells.
>
> By default, the address-cell is "1" which is used for 32bits load address.
> If users would like to use 64bits load address, users are able to
> set as following for "0x400000000" 64bits load address.
> 1. FIT_ADDRESS_CELLS = "2"
> 2. UBOOT_LOADADDRESS= "0x04 0x00000000"
>
> (From OE-Core rev: f79046d082f3a7752e6780b2990470dcd36cbba4)
This line should not be there. It looks like you generated your patches
from a poky repository where this patch landed via combo-layers, but it
just doesn't make sense as an oe-core patch. Also, that SHA-1 does not
exist in the public oe-core repository.
I removed that line while applying the patch for testing, so you
don't need to resend for this time, but please make sure you generate
your patches from an oe-core repository in the future.
The same applies to patch 2/2.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-13 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 10:31 [PATCH 0/2] kernel-fitimage/uboot-sign: support 64bits address Jamin Lin
2023-04-13 10:31 ` [PATCH 1/2] kernel-fitimage: support 64 bits address Jamin Lin
2023-04-13 16:04 ` Luca Ceresoli [this message]
2023-04-14 2:06 ` Jamin Lin
2023-04-13 10:31 ` [PATCH 2/2] uboot-sign: support 64bits address Jamin Lin
2023-05-04 11:45 ` [OE-core] [PATCH 0/2] kernel-fitimage/uboot-sign: " Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413180452.53f9eb8f@booty \
--to=luca.ceresoli@bootlin.com \
--cc=jamin_lin@aspeedtech.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.