All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Heiko Schocher <hs@denx.de>
Cc: u-boot@lists.denx.de
Subject: [PATCH u-boot 2/3] pci: mpc85xx: Allow 8/16-bit access to PCI config space
Date: Thu, 13 Apr 2023 22:41:45 +0200	[thread overview]
Message-ID: <20230413204146.9318-3-pali@kernel.org> (raw)
In-Reply-To: <20230413204146.9318-1-pali@kernel.org>

This Freescale mpc85xx PCI controller should support 8-bit and 16-bit read
and write access to PCI config space as described in more Freescale
reference manuals.

This change fixes issue that 8-bit and 16-bit write to PCI config space
caused to clear adjacent bits of 32-bit PCI register.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 drivers/pci/pci_mpc85xx.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci_mpc85xx.c b/drivers/pci/pci_mpc85xx.c
index 23f14db83018..d144f2b791b8 100644
--- a/drivers/pci/pci_mpc85xx.c
+++ b/drivers/pci/pci_mpc85xx.c
@@ -25,7 +25,18 @@ static int mpc85xx_pci_dm_read_config(const struct udevice *dev, pci_dev_t bdf,
 	addr = PCI_CONF1_EXT_ADDRESS(PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf), offset);
 	out_be32(priv->cfg_addr, addr);
 	sync();
-	*value = pci_conv_32_to_size(in_le32(priv->cfg_data), offset, size);
+
+	switch (size) {
+	case PCI_SIZE_8:
+		*value = in_8(priv->cfg_data + (offset & 3));
+		break;
+	case PCI_SIZE_16:
+		*value = in_le16(priv->cfg_data + (offset & 2));
+		break;
+	case PCI_SIZE_32:
+		*value = in_le32(priv->cfg_data);
+		break;
+	}
 
 	return 0;
 }
@@ -40,7 +51,18 @@ static int mpc85xx_pci_dm_write_config(struct udevice *dev, pci_dev_t bdf,
 	addr = PCI_CONF1_EXT_ADDRESS(PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf), offset);
 	out_be32(priv->cfg_addr, addr);
 	sync();
-	out_le32(priv->cfg_data, pci_conv_size_to_32(0, value, offset, size));
+
+	switch (size) {
+	case PCI_SIZE_8:
+		out_8(priv->cfg_data + (offset & 3), value);
+		break;
+	case PCI_SIZE_16:
+		out_le16(priv->cfg_data + (offset & 2), value);
+		break;
+	case PCI_SIZE_32:
+		out_le32(priv->cfg_data, value);
+		break;
+	}
 	sync();
 
 	return 0;
-- 
2.20.1


  parent reply	other threads:[~2023-04-13 20:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 20:41 [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space Pali Rohár
2023-04-13 20:41 ` [PATCH u-boot 1/3] pci: mpc85xx: Add missing sync() after writing to " Pali Rohár
2023-04-17  5:13   ` Heiko Schocher
2023-05-02 16:51   ` Tom Rini
2023-04-13 20:41 ` Pali Rohár [this message]
2023-04-17  5:13   ` [PATCH u-boot 2/3] pci: mpc85xx: Allow 8/16-bit access " Heiko Schocher
2023-05-02 16:51   ` Tom Rini
2023-04-13 20:41 ` [PATCH u-boot 3/3] pci: mpc85xx: Do not try to access extended PCIe registers Pali Rohár
2023-04-17  5:13   ` Heiko Schocher
2023-05-02 16:51   ` Tom Rini
2023-04-14  4:01 ` [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space Heiko Schocher
2023-04-17  5:12 ` Heiko Schocher
2023-04-17  7:03   ` Pali Rohár
2023-04-29 11:10 ` Pali Rohár
2023-05-02  4:20   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413204146.9318-3-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.