From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: Eric Dumazet <edumazet@google.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>, <hawk@kernel.org>,
<ilias.apalodimas@linaro.org>, <alexander.duyck@gmail.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next v2 1/3] net: skb: plumb napi state thru skb freeing paths
Date: Thu, 13 Apr 2023 22:20:01 -0700 [thread overview]
Message-ID: <20230413222001.78fdc9a4@kernel.org> (raw)
In-Reply-To: <dd743d1e-d8a1-58d5-5b1f-8583d0f23b9f@huawei.com>
On Fri, 14 Apr 2023 08:57:03 +0800 Yunsheng Lin wrote:
> >> Does it break the single-producer single-consumer assumption of tx queue?
> >
> > We do not think so.
>
> Then I guess it is ok to do direct recycling for page pool case as it is
> per napi?
We're talking about the tx queue or the pp cache?
Those have different producers and consumers.
> It is per cpu cache case we are using !!bugget to protect it from preemption
> while netpoll_poll_dev() is running?
This is the scenario - We are feeding the page pool cache from the
deferred pages. An IRQ comes and interrupts us half way thru.
netpoll then tries to also feed the page pool cache. Unhappiness.
Note that netpoll is activated extremely rarely (only when something
writes to the console), and even more rarely does it actually poll
for space in the Tx queue.
next prev parent reply other threads:[~2023-04-14 5:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 4:26 [PATCH net-next v2 0/3] page_pool: allow caching from safely localized NAPI Jakub Kicinski
2023-04-13 4:26 ` [PATCH net-next v2 1/3] net: skb: plumb napi state thru skb freeing paths Jakub Kicinski
2023-04-13 7:49 ` Yunsheng Lin
2023-04-13 8:51 ` Eric Dumazet
2023-04-14 0:57 ` Yunsheng Lin
2023-04-14 5:20 ` Jakub Kicinski [this message]
2023-04-14 9:40 ` Yunsheng Lin
2023-04-13 4:26 ` [PATCH net-next v2 2/3] page_pool: allow caching from safely localized NAPI Jakub Kicinski
2023-04-14 8:45 ` Jesper Dangaard Brouer
2023-04-14 14:50 ` Jakub Kicinski
2023-04-13 4:26 ` [PATCH net-next v2 3/3] bnxt: hook NAPIs to page pools Jakub Kicinski
2023-04-14 13:09 ` [PATCH net-next v2 0/3] page_pool: allow caching from safely localized NAPI Dragos Tatulea
2023-04-15 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413222001.78fdc9a4@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.