All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [bvanassche:retain-zoned-write-order 7/13] drivers/block/ublk_drv.c:1210:9: error: too few arguments to function 'blk_mq_run_hw_queues'
Date: Fri, 14 Apr 2023 05:10:32 +0800	[thread overview]
Message-ID: <202304140542.PW2UCC5d-lkp@intel.com> (raw)

tree:   https://github.com/bvanassche/linux retain-zoned-write-order
head:   aa091476612b6bd24c4dc89253c89035392e3bf8
commit: 65e6a2884b5812c630f5dcf3807e0853b9260a88 [7/13] block: Remove blk_mq_kick_requeue_list() and blk_mq_delay_kick_requeue_list()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230414/202304140542.PW2UCC5d-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/bvanassche/linux/commit/65e6a2884b5812c630f5dcf3807e0853b9260a88
        git remote add bvanassche https://github.com/bvanassche/linux
        git fetch --no-tags bvanassche retain-zoned-write-order
        git checkout 65e6a2884b5812c630f5dcf3807e0853b9260a88
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304140542.PW2UCC5d-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/block/ublk_drv.c: In function 'ublk_unquiesce_dev':
>> drivers/block/ublk_drv.c:1210:9: error: too few arguments to function 'blk_mq_run_hw_queues'
    1210 |         blk_mq_run_hw_queues(ub->ub_disk->queue);
         |         ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/block/ublk_drv.c:40:
   include/linux/blk-mq.h:888:6: note: declared here
     888 | void blk_mq_run_hw_queues(struct request_queue *q, bool async);
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/block/ublk_drv.c: In function 'ublk_ctrl_end_recovery':
   drivers/block/ublk_drv.c:2050:9: error: too few arguments to function 'blk_mq_run_hw_queues'
    2050 |         blk_mq_run_hw_queues(ub->ub_disk->queue);
         |         ^~~~~~~~~~~~~~~~~~~~
   include/linux/blk-mq.h:888:6: note: declared here
     888 | void blk_mq_run_hw_queues(struct request_queue *q, bool async);
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/blk_mq_run_hw_queues +1210 drivers/block/ublk_drv.c

  1191	
  1192	static void ublk_unquiesce_dev(struct ublk_device *ub)
  1193	{
  1194		int i;
  1195	
  1196		pr_devel("%s: unquiesce ub: dev_id %d state %s\n",
  1197				__func__, ub->dev_info.dev_id,
  1198				ub->dev_info.state == UBLK_S_DEV_LIVE ?
  1199				"LIVE" : "QUIESCED");
  1200		/* quiesce_work has run. We let requeued rqs be aborted
  1201		 * before running fallback_wq. "force_abort" must be seen
  1202		 * after request queue is unqiuesced. Then del_gendisk()
  1203		 * can move on.
  1204		 */
  1205		for (i = 0; i < ub->dev_info.nr_hw_queues; i++)
  1206			ublk_get_queue(ub, i)->force_abort = true;
  1207	
  1208		blk_mq_unquiesce_queue(ub->ub_disk->queue);
  1209		/* We may have requeued some rqs in ublk_quiesce_queue() */
> 1210		blk_mq_run_hw_queues(ub->ub_disk->queue);
  1211	}
  1212	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-04-13 21:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202304140542.PW2UCC5d-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bvanassche@acm.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.