From: Bjorn Helgaas <helgaas@kernel.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>, '@bhelgaas
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
"Rick Wertenbroek" <rick.wertenbroek@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 08/17] PCI: epf-test: Simplify IRQ test commands execution
Date: Fri, 14 Apr 2023 11:09:22 -0500 [thread overview]
Message-ID: <20230414160922.GA197844@bhelgaas> (raw)
In-Reply-To: <20230330085357.2653599-9-damien.lemoal@opensource.wdc.com>
On Thu, Mar 30, 2023 at 05:53:48PM +0900, Damien Le Moal wrote:
> For the commands COMMAND_RAISE_LEGACY_IRQ, COMMAND_RAISE_MSI_IRQ and
> COMMAND_RAISE_MSIX_IRQ, the function pci_epf_test_cmd_handler()
> sets the STATUS_IRQ_RAISED status flag and calls the epc function
> pci_epc_raise_irq() directly. However, this is also exactly what the
> pci_epf_test_raise_irq() function does. Avoid duplicating these
> operations by directly using pci_epf_test_raise_irq() for the IRQ test
> commands. It is OK to do so as the host side endpoint test driver always
> set the correct irq type for the IRQ test commands.
>
> At the same time, the irq number check done for the
> COMMAND_RAISE_MSI_IRQ and COMMAND_RAISE_MSIX_IRQ commands can also be
> moved to pci_epf_test_raise_irq() to also check the IRQ number requested
> by the host for other test commands.
>
> Overall, this significantly simplifies the pci_epf_test_cmd_handler()
> function.
s/irq/IRQ/ several times above to be consistent.
next prev parent reply other threads:[~2023-04-14 16:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:53 [PATCH v4 00/17] PCI endpoint fixes and improvements Damien Le Moal
2023-03-30 8:53 ` [PATCH v4 01/17] PCI: endpoint: Automatically create a function specific attributes group Damien Le Moal
2023-03-31 5:22 ` Manivannan Sadhasivam
2023-03-31 7:16 ` Damien Le Moal
2023-04-14 15:58 ` Bjorn Helgaas
2023-04-15 0:55 ` Damien Le Moal
2023-03-30 8:53 ` [PATCH v4 02/17] PCI: endpoint: Move pci_epf_type_add_cfs() code Damien Le Moal
2023-03-30 8:53 ` [PATCH v4 03/17] PCI: epf-test: Fix DMA transfer completion initialization Damien Le Moal
2023-03-30 8:53 ` [PATCH v4 04/17] PCI: epf-test: Fix DMA transfer completion detection Damien Le Moal
2023-03-31 5:25 ` Manivannan Sadhasivam
2023-04-04 9:47 ` Shunsuke Mie
2023-04-04 10:16 ` Damien Le Moal
2023-04-04 10:30 ` Shunsuke Mie
2023-04-13 1:50 ` Damien Le Moal
2023-04-14 15:41 ` Bjorn Helgaas
2023-04-14 15:45 ` Bjorn Helgaas
2023-04-14 16:00 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 05/17] PCI: epf-test: Use dmaengine_submit() to initiate DMA transfer Damien Le Moal
2023-03-30 8:53 ` [PATCH v4 06/17] PCI: epf-test: Simplify read/write/copy test functions Damien Le Moal
2023-04-14 16:06 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 07/17] PCI: epf-test: Simplify pci_epf_test_raise_irq() Damien Le Moal
2023-04-14 16:08 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 08/17] PCI: epf-test: Simplify IRQ test commands execution Damien Le Moal
2023-04-14 16:09 ` Bjorn Helgaas [this message]
2023-03-30 8:53 ` [PATCH v4 09/17] PCI: epf-test: Improve handling of command and status registers Damien Le Moal
2023-04-14 16:11 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 10/17] PCI: epf-test: Cleanup pci_epf_test_cmd_handler() Damien Le Moal
2023-04-14 16:12 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 11/17] PCI: epf-test: Cleanup request result handling Damien Le Moal
2023-03-31 5:28 ` Manivannan Sadhasivam
2023-03-30 8:53 ` [PATCH v4 12/17] PCI: epf-test: Simplify DMA support checks Damien Le Moal
2023-04-14 16:14 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 13/17] PCI: epf-test: Simplify transfers result print Damien Le Moal
2023-04-14 16:17 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 14/17] misc: pci_endpoint_test: Free IRQs before removing the device Damien Le Moal
2023-04-14 16:17 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 15/17] misc: pci_endpoint_test: Re-init completion for every test Damien Le Moal
2023-03-31 5:29 ` Manivannan Sadhasivam
2023-03-30 8:53 ` [PATCH v4 16/17] misc: pci_endpoint_test: Do not write status in IRQ handler Damien Le Moal
2023-04-14 16:18 ` Bjorn Helgaas
2023-03-30 8:53 ` [PATCH v4 17/17] misc: pci_endpoint_test: Simplify pci_endpoint_test_msi_irq() Damien Le Moal
2023-04-14 16:19 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414160922.GA197844@bhelgaas \
--to=helgaas@kernel.org \
--cc='@bhelgaas \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=rick.wertenbroek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.