From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B31D9C77B72 for ; Fri, 14 Apr 2023 14:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NNbw1+YgkfjX/aOgzfAXPI6tKPddPrA84+dLsVoCKrQ=; b=2UJQHIASvFkYW7 jjqm8GqP2e+CcY2ZjvmJOWNCZB77FKNicByTZZO9qIg/MOh+5sJuCRZiRFhnvTva2dB+BxjZ95TBk Fv0KmT/0AMxATV3/3SXLobGEqLl5XbQM3pCn5K1rlsT8T82Uk0w90xnQr++RoJ5sS0QNCL8BI6/6q pLDj1FYZ6okqEU4scc8a8/02ebgboEPgAkgWHOqIfJo/BAuuWxqj5MDR3eMIPbGVPOKelxmIaQTPh hC7weNSopwaDxxU3vgWlgLd+nL9pjuEp6i/kz9A4csB9OTxIVBYnKYZEGB5wZy8uBqXxZQf2ZYlWR 9rTDf3MmL6iQp+Uy+n2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnKpd-009t5b-0C; Fri, 14 Apr 2023 14:55:21 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnKpZ-009t4D-0b for linux-phy@lists.infradead.org; Fri, 14 Apr 2023 14:55:19 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 14271240002; Fri, 14 Apr 2023 14:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681484110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qYy47sl74TgDHd1JkFN/WszmVyDzzzCSFWb60vPYy+0=; b=S8uYckW7R+GfvkffcwP4D4MY1ukU9yz+ZPzKL+N3hwVDwDtAEe7tj5uKF58Q2y1BtBS0EZ YULYeii9S4yLhFQRedV0sLv3CbhMQGcqwEzKlVqDoWTnV+jnHloHa7YejLyIPHk+G8fu6D D6GVwBkKndJ1yckKs/xip2ON356TsIUCx88umFwgmFkrx05Cvd9P/W/OBv0zlb/zxj/fwb /Re15kObG7sv6pephz1IW0xLrr3KdG5nSuwV/O7iGayX4UDGBi9pvU68d6CJtQBPBs9+j+ 9MvE7kIOxNoVXDdxGF8oVhwXindJhPQXWRN/I9bhmM+6n6Zwyv6m+k/glh0nMQ== Date: Fri, 14 Apr 2023 16:55:04 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [RFC PATCH 0/4] Add support for QMC HDLC and PHY Message-ID: <20230414165504.7da4116f@bootlin.com> In-Reply-To: <885e4f20-614a-4b8e-827e-eb978480af87@lunn.ch> References: <20230323103154.264546-1-herve.codina@bootlin.com> <885e4f20-614a-4b8e-827e-eb978480af87@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_075517_665380_0CFB0CA0 X-CRM114-Status: GOOD ( 35.40 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org SGkgQW5kcmV3LAoKT24gVGh1LCAxMyBBcHIgMjAyMyAxNDo0ODozMCArMDIwMApBbmRyZXcgTHVu biA8YW5kcmV3QGx1bm4uY2g+IHdyb3RlOgoKPiBPbiBUaHUsIE1hciAyMywgMjAyMyBhdCAxMToz MTo1MEFNICswMTAwLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBIaSwKPiA+IAo+ID4gSSBoYXZl IGEgc3lzdGVtIHdoZXJlIEkgbmVlZCB0byBoYW5kbGUgYW4gSERMQyBpbnRlcmZhY2UuCj4gPiAK PiA+IFRoZSBIRExDIGRhdGEgYXJlIHRyYW5zZmVycmVkIHVzaW5nIGEgVERNIGJ1cyBvbiB3aGlj aCBhIFBFRjIyNTYgaXMKPiA+IHByZXNlbnQuIFRoZSBQRUYyMjU2IHRyYW5zZmVycyBkYXRhIGZy b20vdG8gdGhlIFRETSBidXMgdG8vZnJvbSBFMSBsaW5lLgo+ID4gVGhpcyBQRUYyMjU2IGlzIGFs c28gY29ubmVjdGVkIHRvIGEgUG93ZXJRVUlDQyBTb0MgZm9yIHRoZSBjb250cm9sIHBhdGgKPiA+ IGFuZCB0aGUgVERNIGlzIGNvbm5lY3RlZCB0byB0aGUgU29DIChRTUMgY29tcG9uZW50KSBmb3Ig dGhlIGRhdGEgcGF0aC4KPiA+IAo+ID4gRnJvbSB0aGUgSERMQyBkcml2ZXIsIEkgbmVlZCB0byBo YW5kbGUgZGF0YSB1c2luZyB0aGUgUU1DIGFuZCBjYXJyaWVyCj4gPiBkZXRlY3Rpb24gdXNpbmcg dGhlIFBFRjIyNTYgKEUxIGxpbmUgY2FycmllcikuCj4gPiAKPiA+IFRoZSBIRExDIGRyaXZlciBj b25zaWRlciB0aGUgUEVGMjI1NiBhcyBhIGdlbmVyaWMgUEhZLgo+ID4gU28sIHRoZSBkZXNpZ24g aXMgdGhlIGZvbGxvd2luZzoKPiA+IAo+ID4gKy0tLS0tLS0tLS0rICAgICAgICAgICstLS0tLS0t LS0tLS0tKyAgICAgICAgICAgICAgKy0tLS0tLS0tLSsKPiA+IHwgSERMQyBkcnYgfCA8LWRhdGEt PiB8IFFNQyBjaGFubmVsIHwgPC0tIFRETSAtLT4gIHwgUEVGMjI1NiB8Cj4gPiArLS0tLS0tLS0t LSsgICAgICAgICAgKy0tLS0tLS0tLS0tLS0rICAgICAgICAgICAgICB8ICAgICAgICAgfCA8LS0+ IEUxCj4gPiAgICBeICAgKy0tLS0tLS0tLSsgICAgICstLS0tLS0tLS0rICAgICAgICAgICAgICAg ICB8ICAgICAgICAgfAo+ID4gICAgKy0+IHwgR2VuIFBIWSB8IDwtPiB8IFBFRjIyNTYgfCA8LSBs b2NhbCBidXMgLT4gfCAgICAgICAgIHwKPiA+ICAgICAgICArLS0tLS0tLS0tKyAgICAgfCBQSFkg ZHJ2IHwgICAgICAgICAgICAgICAgICstLS0tLS0tLS0rCj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICstLS0tLS0tLS0rICAKPiAKPiBIaSBIZXJ2ZXIKPiAKPiBTb3JyeSwgaSdtIGxhdGUgdG8g dGhlIGNvbnZlcnNhdGlvbi4gSSdtIGxvb2tpbmcgYXQgdGhpcyBmcm9tIHR3bwo+IGRpZmZlcmVu dCBwZXJzcGVjdGl2ZXMuIEkgaGVscCBtYWludGFpbiBFdGhlcm5ldCBQSFlzLiBBbmQgaSBoYXZl Cj4gaGFja2VkIG9uIHRoZSBJRFQgODJQMjI4OCBFMS9UMS9KMSBmcmFtZXIuCj4gCj4gSSB0aGlu ayB0aGVyZSBpcyBhIGJsb2NrIG1pc3NpbmcgZnJvbSB0aGlzIGRpYWdyYW0uIFRoZXJlIGFwcGVh cnMgdG8KPiBiZSBhbiBNRkQgZHJpdmVyIGZvciB0aGUgUEVGMjI1Nj8gQXQgbGVhc3QsIGkgc2Vl IGFuIGluY2x1ZGUgZm9yCj4gbGludXgvbWZkL3BlZjIyNTYuaC4KCkluZGVlZCwgdGhlcmUgaXMg dGhlIE1GRCBkcml2ZXIgYW5kIHRoaXMgTUZEIGRyaXZlciBkb2VzIHRoZSBQRUYyMjU2CnNldHVw IChsaW5lIGNvbmZpZ3VyYXRpb24sIHNwZWVkLCAuLi4pLgoKPiAKPiBXaGVuIGkgbG9vayBhdCB0 aGUgJ3BoeScgZHJpdmVyLCBpIGRvbid0IHNlZSBhbnl0aGluZyBhIHR5cGljYWwgUEhZCj4gZHJp dmVyIHVzZWQgZm9yIG5ldHdvcmtpbmcgd291bGQgaGF2ZS4gQSBuZXR3b3JraW5nIFBIWSBkcml2 ZXIgb2Z0ZW4KPiBoYXMgdGhlIGFiaWxpdHkgdG8gY2hhbmdlIGJldHdlZW4gbW9kZXMsIGxpa2Ug U0dNSUksIFFTR01JSSwgMTBHQkFTRVIuCj4gVGhlIGVxdWl2YWxlbnQgaGVyZSB3b3VsZCBiZSBj aGFuZ2luZyBiZXR3ZWVuIEUxLCBUMSBhbmQgSjEuIEl0IGhhcwo+IHRoZSBhYmlsaXR5IHRvIGNo YW5nZSB0aGUgc3BlZWQsIDFHLCAyLjVHLCAxMEcgZXRjLiBUaGlzIGNvdWxkIGJlCj4gaW1wbGll ZCB2aWEgdGhlIG1vZGUsIEUxIGlzIDIuMDQ4TWJwcywgVDEgMS41NDRNYnBzLCBhbmQgaSBmb3Jn ZXQgd2hhdAo+IEoxIGlzLiBUaGUgUEVGMjI1NiBhbHNvIHNlZW1zIHRvIHN1cHBvcnQgRTEvVDEv SjEuIEhvdyBpcyBpdHMgbW9kZXMKPiBjb25maWd1cmVkPwoKQWxsIG9mIHRoZXNlIGFyZSBzZXQg YnkgdGhlIE1GRCBkcml2ZXIgZHVyaW5nIGl0cyBwcm9iZSgpLgpUaGUgZXhwZWN0ZWQgc2V0dGlu ZyBjb21lIGZyb20gc2V2ZXJhbCBwcm9wZXJ0aWVzIHByZXNlbnQgaW4gdGhlIHBlZjIyNTYKRFQg bm9kZS4gVGhlIGJpbmRpbmcgY2FuIGJlIGZvdW5kIGhlcmU6CiAgaHR0cHM6Ly9sb3JlLmtlcm5l bC5vcmcvYWxsLzIwMjMwMzI4MDkyNjQ1LjYzNDM3NS0yLWhlcnZlLmNvZGluYUBib290bGluLmNv bS8KCkZ1cnRoZXIgbW9yZSwgdGhlIFFNQyBIRExDIGlzIG5vdCB0aGUgb25seSBQRUYyMjU2IGNv bnN1bWVyLgpUaGUgUEVGMjI1NiBpcyBhbHNvIHVzZWQgZm9yIGF1ZGlvIHBhdGggKGllIGF1ZGlv IG92ZXIgRTEpIGFuZCBzbyB0aGUKY29uZmlndXJhdGlvbiBpcyBzaGFyZWQgYmV0d2VlbiBuZXR3 b3JrIGFuZCBhdWRpby4gVGhlIHNldHRpbmcgY2Fubm90IGJlCmhhbmRsZSBieSB0aGUgbmV0d29y ayBwYXJ0IGFzIHRoZSBQRUYyMjU2IG11c3QgYmUgYXZhaWxhYmxlIGFuZCBjb3JyZWN0bHkKY29u ZmlndXJlZCBldmVuIGlmIHRoZSBuZXR3b3JrIHBhcnQgaXMgbm90IHByZXNlbnQuCgo+IAo+IElu IGZhY3QsIHRoaXMgUEhZIGRyaXZlciBkb2VzIG5vdCBzZWVtIHRvIGRvIGFueSBjb25maWd1cmF0 aW9uIG9mIGFueQo+IHNvcnQgb24gdGhlIGZyYW1lci4gQWxsIGl0IHNlZW1zIHRvIGJlIGRvaW5n IGlzIHRha2Ugbm90aWZpY2F0aW9uIGZyb20KPiBvbmUgY2hhaW4gYW5kIHNlbmQgdGhlbSBvdXQg YW5vdGhlciBjaGFpbiEKCkNvbmZpZ3VyYXRpb24gaXMgZG9uZSBieSB0aGUgcGFyZW50IE1GRCBk cml2ZXIuClRoZSBQSFkgZHJpdmVyIGhhcyBub3RoaW5nIG1vcmUgdG8gZG8uCgo+IAo+IEkgYWxz byB3b3VuZGVyIGlmIHRoaXMgZ2V0X3N0YXR1cygpIGNhbGwgaXMgc3VmZmljaWVudC4gRG9uJ3Qg eW91IGFsc28KPiB3YW50IFJlZCwgWWVsbG93IGFuZCBCbHVlIGFsYXJtcz8gSXQgaXMgbm90IGp1 c3QgdGhlIGNhcnJpZXIgaXMgZG93biwKPiBidXQgd2h5IGl0IGlzIGRvd24uCgpJIGRvbid0IG5l ZWQgdGhlbSBpbiBteSB1c2UgY2FzZSBidXQgaWYgbmVlZGVkIGNhbid0IHRoZXkgYmUgYWRkZWQg bGF0ZXI/CkFsc28sIGZyb20gdGhlIEhETEMgZGV2aWNlIHBvaW50IG9mIHZpZXcgd2hhdCBjYW4g YmUgZG9uZSB3aXRoIHRoZXNlIGFsYXJtcz8KCj4gCj4gT3ZlcmFsbCwgaSBkb24ndCBzZWUgd2h5 IHlvdSB3YW50IGEgUEhZLiBXaGF0IHZhbHVlIGRvZXMgaXQgYWRkPwoKSSBuZWVkIHRvIGRldGVj dCBjYXJyaWVyIG9uL29mZiBhY2NvcmRpbmcgdG8gdGhlIEUxIGxpbmsgc3RhdGUuClRoZSBIRExD IGRyaXZlciBpcyBhIGRyaXZlciBmb3IgYSBRTUMgZGV2aWNlLgpUaGUgUU1DIGRldmljZSBwcmVz ZW50IGluIHNvbWUgUG93ZXJQQyBTT0Mgb2ZmZXJzIHRoZSBwb3NzaWJpbGl0eSB0byBzZW5kCmRh dGEgb3ZlciBhIFRETSBidXMuCkZyb20gdGhlIFFNQyBIRExDIGRyaXZlciBJIGRvbid0IHdhbnQg dG8gcmVmZXIgdGhlIFBFRjIyNTYgYXMgdGhlIGRyaXZlciBoYXMKbm90aGluZyB0byBkbyB3aXRo IHRoZSBQRUYyMjU2IGRpcmVjdGx5LgpUaGUgUU1DIEhETEMgZHJpdmVyIHNlbmQgZGF0YSB0byBh IFRETSBidXMgdXNpbmcgdGhlIFFNQyBkZXZpY2UuCgpUaGUgUEVGMjI1NiBpcyBhbiBpbnRlcmZh Y2UgaW4gdGhlIGRhdGEgcGF0aCBiZXR3ZWVuIHRoZSBRTUMgb3V0cHV0IChURE0gYnVzKSBhbmQK dGhlIEUxIGxpbmUuCgpXZSBzZW5kIEhETEMgb3ZlciBFMSBiZWNhdXNlIHRoZXJlIGlzIHRoaXMg a2luZCBvZiBpbnRlcmZhY2UgYnV0IHdlIHdvdWxkCmhhdmUgc2VudCBIRExDIG92ZXIgYW55dGhp bmcgZWxzZSBpZiB0aGlzIGludGVyZmFjZSB3YXMgZGlmZmVyZW50LgoKVXNpbmcgYSBQSFkgdG8g cmVwcmVzZW50IHRoaXMgaW50ZXJmYWNlIHdhcyBjb2hlcmVudCBmb3IgbWUuClVzaW5nIHRoZSBn ZW5lcmljIFBIWSBzdWJzeXN0ZW0gYWxsb3dzIHRvIGFic3RyYWN0IHRoZSBzcGVjaWZpYyBwcm92 aWRlciAoUEVGMjI1NikKZnJvbSB0aGUgY29uc3VtZXIgKFFNQyBIRExDKS4KCkJlc3QgcmVnYXJk cywKSGVydsOpCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D6FC77B76 for ; Fri, 14 Apr 2023 14:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230081AbjDNOzQ (ORCPT ); Fri, 14 Apr 2023 10:55:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjDNOzO (ORCPT ); Fri, 14 Apr 2023 10:55:14 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2336865A8; Fri, 14 Apr 2023 07:55:11 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 14271240002; Fri, 14 Apr 2023 14:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681484110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qYy47sl74TgDHd1JkFN/WszmVyDzzzCSFWb60vPYy+0=; b=S8uYckW7R+GfvkffcwP4D4MY1ukU9yz+ZPzKL+N3hwVDwDtAEe7tj5uKF58Q2y1BtBS0EZ YULYeii9S4yLhFQRedV0sLv3CbhMQGcqwEzKlVqDoWTnV+jnHloHa7YejLyIPHk+G8fu6D D6GVwBkKndJ1yckKs/xip2ON356TsIUCx88umFwgmFkrx05Cvd9P/W/OBv0zlb/zxj/fwb /Re15kObG7sv6pephz1IW0xLrr3KdG5nSuwV/O7iGayX4UDGBi9pvU68d6CJtQBPBs9+j+ 9MvE7kIOxNoVXDdxGF8oVhwXindJhPQXWRN/I9bhmM+6n6Zwyv6m+k/glh0nMQ== Date: Fri, 14 Apr 2023 16:55:04 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [RFC PATCH 0/4] Add support for QMC HDLC and PHY Message-ID: <20230414165504.7da4116f@bootlin.com> In-Reply-To: <885e4f20-614a-4b8e-827e-eb978480af87@lunn.ch> References: <20230323103154.264546-1-herve.codina@bootlin.com> <885e4f20-614a-4b8e-827e-eb978480af87@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Thu, 13 Apr 2023 14:48:30 +0200 Andrew Lunn wrote: > On Thu, Mar 23, 2023 at 11:31:50AM +0100, Herve Codina wrote: > > Hi, > >=20 > > I have a system where I need to handle an HDLC interface. > >=20 > > The HDLC data are transferred using a TDM bus on which a PEF2256 is > > present. The PEF2256 transfers data from/to the TDM bus to/from E1 line. > > This PEF2256 is also connected to a PowerQUICC SoC for the control path > > and the TDM is connected to the SoC (QMC component) for the data path. > >=20 > > From the HDLC driver, I need to handle data using the QMC and carrier > > detection using the PEF2256 (E1 line carrier). > >=20 > > The HDLC driver consider the PEF2256 as a generic PHY. > > So, the design is the following: > >=20 > > +----------+ +-------------+ +---------+ > > | HDLC drv | <-data-> | QMC channel | <-- TDM --> | PEF2256 | > > +----------+ +-------------+ | | <--> E1 > > ^ +---------+ +---------+ | | > > +-> | Gen PHY | <-> | PEF2256 | <- local bus -> | | > > +---------+ | PHY drv | +---------+ > > +---------+ =20 >=20 > Hi Herver >=20 > Sorry, i'm late to the conversation. I'm looking at this from two > different perspectives. I help maintain Ethernet PHYs. And i have > hacked on the IDT 82P2288 E1/T1/J1 framer. >=20 > I think there is a block missing from this diagram. There appears to > be an MFD driver for the PEF2256? At least, i see an include for > linux/mfd/pef2256.h. Indeed, there is the MFD driver and this MFD driver does the PEF2256 setup (line configuration, speed, ...). >=20 > When i look at the 'phy' driver, i don't see anything a typical PHY > driver used for networking would have. A networking PHY driver often > has the ability to change between modes, like SGMII, QSGMII, 10GBASER. > The equivalent here would be changing between E1, T1 and J1. It has > the ability to change the speed, 1G, 2.5G, 10G etc. This could be > implied via the mode, E1 is 2.048Mbps, T1 1.544Mbps, and i forget what > J1 is. The PEF2256 also seems to support E1/T1/J1. How is its modes > configured? All of these are set by the MFD driver during its probe(). The expected setting come from several properties present in the pef2256 DT node. The binding can be found here: https://lore.kernel.org/all/20230328092645.634375-2-herve.codina@bootlin.= com/ Further more, the QMC HDLC is not the only PEF2256 consumer. The PEF2256 is also used for audio path (ie audio over E1) and so the configuration is shared between network and audio. The setting cannot be handle by the network part as the PEF2256 must be available and correctly configured even if the network part is not present. >=20 > In fact, this PHY driver does not seem to do any configuration of any > sort on the framer. All it seems to be doing is take notification from > one chain and send them out another chain! Configuration is done by the parent MFD driver. The PHY driver has nothing more to do. >=20 > I also wounder if this get_status() call is sufficient. Don't you also > want Red, Yellow and Blue alarms? It is not just the carrier is down, > but why it is down. I don't need them in my use case but if needed can't they be added later? Also, from the HDLC device point of view what can be done with these alarms? >=20 > Overall, i don't see why you want a PHY. What value does it add? I need to detect carrier on/off according to the E1 link state. The HDLC driver is a driver for a QMC device. The QMC device present in some PowerPC SOC offers the possibility to send data over a TDM bus. =46rom the QMC HDLC driver I don't want to refer the PEF2256 as the driver has nothing to do with the PEF2256 directly. The QMC HDLC driver send data to a TDM bus using the QMC device. The PEF2256 is an interface in the data path between the QMC output (TDM bu= s) and the E1 line. We send HDLC over E1 because there is this kind of interface but we would have sent HDLC over anything else if this interface was different. Using a PHY to represent this interface was coherent for me. Using the generic PHY subsystem allows to abstract the specific provider (P= EF2256) from the consumer (QMC HDLC). Best regards, Herv=C3=A9