From: Jakub Kicinski <kuba@kernel.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
decui@microsoft.com, kys@microsoft.com, paulros@microsoft.com,
olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net,
wei.liu@kernel.org, edumazet@google.com, pabeni@redhat.com,
leon@kernel.org, longli@microsoft.com,
ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org,
daniel@iogearbox.net, john.fastabend@gmail.com,
bpf@vger.kernel.org, ast@kernel.org, sharmaajay@microsoft.com,
hawk@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3,net-next, 3/4] net: mana: Enable RX path to handle various MTU sizes
Date: Fri, 14 Apr 2023 19:06:08 -0700 [thread overview]
Message-ID: <20230414190608.3c21f44f@kernel.org> (raw)
In-Reply-To: <1681334163-31084-4-git-send-email-haiyangz@microsoft.com>
On Wed, 12 Apr 2023 14:16:02 -0700 Haiyang Zhang wrote:
> + } else if (rxq->alloc_size > PAGE_SIZE) {
> + if (is_napi)
> + va = napi_alloc_frag(rxq->alloc_size);
Allocating frag larger than a page is not safe.
Frag allocator falls back to allocating single pages, doesn't it?
next prev parent reply other threads:[~2023-04-15 2:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 21:15 [PATCH V3,net-next, 0/4] net: mana: Add support for jumbo frame Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 1/4] net: mana: Use napi_build_skb in RX path Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU Haiyang Zhang
2023-04-13 13:04 ` Leon Romanovsky
2023-04-13 14:03 ` Haiyang Zhang
2023-04-13 16:30 ` Leon Romanovsky
2023-04-13 16:40 ` Jakub Kicinski
2023-04-13 16:59 ` Leon Romanovsky
2023-04-13 17:01 ` Jakub Kicinski
2023-04-15 2:04 ` Jakub Kicinski
2023-04-15 14:09 ` Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 3/4] net: mana: Enable RX path to handle various MTU sizes Haiyang Zhang
2023-04-15 2:06 ` Jakub Kicinski [this message]
2023-04-15 14:25 ` Haiyang Zhang
2023-04-17 17:52 ` Jakub Kicinski
2023-04-17 19:52 ` Haiyang Zhang
2023-04-12 21:16 ` [PATCH V3,net-next, 4/4] net: mana: Add support for jumbo frame Haiyang Zhang
2023-04-15 2:08 ` [PATCH V3,net-next, 0/4] " Jakub Kicinski
2023-04-15 14:11 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414190608.3c21f44f@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=pabeni@redhat.com \
--cc=paulros@microsoft.com \
--cc=sharmaajay@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.