All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Witold Lipieta <witold.lipieta@thaumatec.com>
Cc: Asaf Kahlon <asafka7@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-evdev: new package
Date: Fri, 14 Apr 2023 22:32:09 +0200	[thread overview]
Message-ID: <20230414203209.GA2819@scaer> (raw)
In-Reply-To: <20230413092055.3438333-1-witold.lipieta@thaumatec.com>

Witold, All,

On 2023-04-13 11:20 +0200, Witold Lipieta spake thusly:
> evdev 1.6.1 https://pypi.org/project/evdev/
> 
> Signed-off-by: Witold Lipieta <witold.lipieta@thaumatec.com>
> ---
[--SNIP--]
> diff --git a/package/python-evdev/Config.in b/package/python-evdev/Config.in
> new file mode 100644
> index 0000000000..f6c021e694
> --- /dev/null
> +++ b/package/python-evdev/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_EVDEV
> +	bool "python-evdev"
> +	select BR2_PACKAGE_LIBEVDEV # runtime

I could not find where that dependency is used in the code. Can you
double check, please?

However, it uses input-event-codes.h, which was only included in linux
4.4, so it should depend on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4.

[--SNIP--]
> diff --git a/package/python-evdev/python-evdev.mk b/package/python-evdev/python-evdev.mk
> new file mode 100644
> index 0000000000..33fe071916
> --- /dev/null
> +++ b/package/python-evdev/python-evdev.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# python-evdev
> +#
> +################################################################################
> +
> +PYTHON_EVDEV_VERSION = 1.6.1
> +PYTHON_EVDEV_SOURCE = evdev-$(PYTHON_EVDEV_VERSION).tar.gz
> +PYTHON_EVDEV_SITE = https://files.pythonhosted.org/packages/05/50/629b011a7f61cb2fca754ea8631575784bf8605a1ec4d6970a010bc54e2b
> +PYTHON_EVDEV_SETUP_TYPE = setuptools
> +PYTHON_EVDEV_LICENSE = Revised BSD License
> +PYTHON_EVDEV_LICENSE_FILES = LICENSE
> +
> +PYTHON_EVDEV_BUILD_OPTS = \
> +	build_ecodes \
> +	--evdev-headers $(STAGING_DIR)/usr/include/linux/input.h:$(STAGING_DIR)/usr/include/linux/input-event-codes.h

setup.py also lists /usr/include/linux/uinput.h, so maybe we want to
also include that?

Regards,
Yann E. MORIN.

> +$(eval $(python-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-04-14 20:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  9:20 [Buildroot] [PATCH 1/1] package/python-evdev: new package Witold Lipieta
2023-04-14 20:32 ` Yann E. MORIN [this message]
2023-04-17 13:02   ` Witold Lipieta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414203209.GA2819@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=witold.lipieta@thaumatec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.