From: SeongJae Park <sj@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
Date: Sat, 15 Apr 2023 03:04:52 +0000 [thread overview]
Message-ID: <20230415030452.3223-1-sj@kernel.org> (raw)
In-Reply-To: <ZDoRSlHiyIvAz+pR@casper.infradead.org>
On Sat, 15 Apr 2023 03:51:54 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> On Sat, Apr 15, 2023 at 12:37:53AM +0000, SeongJae Park wrote:
> > *
> > + * begin:
> > * rcu_read_lock();
> > - * again:
> > * obj = lockless_lookup(key);
> > * if (obj) {
> > * if (!try_get_ref(obj)) // might fail for free objects
> > - * goto again;
> > + * goto begin;
> > *
> > * if (obj->key != key) { // not the object we expected
> > * put_ref(obj);
> > + * rcu_read_unlock();
> > * goto again;
>
> - * goto again;
> + * goto begin;
Oops, thank you for catching, Matthew!
Thanks,
SJ
next prev parent reply other threads:[~2023-04-15 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 0:37 [PATCH 0/2] mm/slab: trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet SeongJae Park
2023-04-15 0:37 ` [PATCH 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code SeongJae Park
2023-04-15 0:37 ` [PATCH 2/2] mm/slab: break up RCU readers " SeongJae Park
2023-04-15 2:51 ` Matthew Wilcox
2023-04-15 3:04 ` SeongJae Park [this message]
2023-04-15 3:23 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230415030452.3223-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.