All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/3] r8169: use new macro netif_subqueue_maybe_stop in rtl8169_start_xmit
Date: Sun, 16 Apr 2023 16:24:01 +0300	[thread overview]
Message-ID: <20230416132401.GE15386@unreal> (raw)
In-Reply-To: <1ea8c541-2f96-9a01-4355-fb0c98ddcdac@gmail.com>

On Sun, Apr 16, 2023 at 01:33:11PM +0200, Heiner Kallweit wrote:
> On 16.04.2023 12:20, Leon Romanovsky wrote:
> > On Sat, Apr 15, 2023 at 09:22:11AM +0200, Heiner Kallweit wrote:
> >> Use new net core macro netif_subqueue_maybe_stop in the start_xmit path
> >> to simplify the code. Whilst at it, set the tx queue start threshold to
> >> twice the stop threshold. Before values were the same, resulting in
> >> stopping/starting the queue more often than needed.
> >>
> >> v2:
> >> - ring doorbell if queue was stopped
> > 
> > Please put changelog under "---" markup, below tags section.
> > 
> I know that this would be the standard. IIRC Dave once requested to
> make the change log part of the commit message.

I can imagine how it was useful before lore.kernel.org appeared.

Thanks

> 
> > Thanks
> > 
> 

  reply	other threads:[~2023-04-16 13:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-15  7:18 [PATCH net-next v2 0/3] r8169: use new macros from netdev_queues.h Heiner Kallweit
2023-04-15  7:20 ` [PATCH net-next v2 1/3] net: add macro netif_subqueue_completed_wake Heiner Kallweit
2023-04-15  7:22 ` [PATCH net-next v2 2/3] r8169: use new macro netif_subqueue_maybe_stop in rtl8169_start_xmit Heiner Kallweit
2023-04-16 10:20   ` Leon Romanovsky
2023-04-16 11:33     ` Heiner Kallweit
2023-04-16 13:24       ` Leon Romanovsky [this message]
2023-04-15  7:23 ` [PATCH net-next v2 3/3] r8169: use new macro netif_subqueue_completed_wake in the tx cleanup path Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230416132401.GE15386@unreal \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.