From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A5E4C77B70 for ; Mon, 17 Apr 2023 06:20:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5037A60F45; Mon, 17 Apr 2023 06:20:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5037A60F45 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HnFmpt8n X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VjJNs7JDU10Y; Mon, 17 Apr 2023 06:20:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id E932A60F44; Mon, 17 Apr 2023 06:20:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E932A60F44 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C215FC0037; Mon, 17 Apr 2023 06:20:29 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 11093C002A for ; Mon, 17 Apr 2023 06:20:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C92C340273 for ; Mon, 17 Apr 2023 06:20:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C92C340273 Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HnFmpt8n X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zuW3DPdmppZR for ; Mon, 17 Apr 2023 06:20:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 55F694026E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 55F694026E for ; Mon, 17 Apr 2023 06:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681712426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePbMyRA1sPZRgCUtm4jF6vrpMcXUEcAn5cv4sWSGRdg=; b=HnFmpt8n9LNrWigutZzu/ISfmmZSYwMzT6SUZb7MXFtmZbVE2nQex6bi8ZRf+9dLGXkk7b FLZ+lapY69suM5oCVameST1+WBGAxG99+w3V+p8b/JijXDDH9uzBf72vLvN6jSXFH29pY+ 8Y32TVqQrVwxTJa0usvG/cvWtmBAepk= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-yX5crIKUM3ynOS134bMTig-1; Mon, 17 Apr 2023 02:20:24 -0400 X-MC-Unique: yX5crIKUM3ynOS134bMTig-1 Received: by mail-qt1-f199.google.com with SMTP id y5-20020a05622a004500b003e3979be6abso17088821qtw.12 for ; Sun, 16 Apr 2023 23:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681712424; x=1684304424; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePbMyRA1sPZRgCUtm4jF6vrpMcXUEcAn5cv4sWSGRdg=; b=bmqsFeKeXkgN7OQH+L045qPOcjj6xNmxaOmrOdcnmMtcvav1Og7wcukLkB1DNZxTEC 75I/q+9Z8XfiDsyN3NPQcZfaqMTxDxgyKRXviN+8UZxBNeZ8o1grOfaCDGbvBCEjNRsf mG+ti2KELJuz4a2dwzFJsMAsNAY5TOdGnPrdkL4rxt49UHjnoJIE35f9YfrCcpCo32SS J85z9f/hiYwIu7UZNBCqoqvItGK8AnWZCZbHrXJ3tRPi0X6H/eMuiYKrp8+ph/DoTk1Q 1T8LwSTbQMg/+GTvfuZsRrLaSI92e46w8XLwUNXLJFjKPeXVLbaemff93ixzxg1Fsoco DRaw== X-Gm-Message-State: AAQBX9cQF7YarYT1ByVBso3IJgKiGhPUPUkAkfi95hpZp9yn5nemGS5b 6bPAeo8TqvFMpvSDiXjmPNcBvynBOl/K1yREXu398Jfi2/Ptnq2il5iIKJZXoU4ODDHj/2WagQr YypWt8YrNH/63znDsAN+4cK/+vvsvSTBX0mfvaw55ug== X-Received: by 2002:a05:6214:400e:b0:5ef:5503:d41c with SMTP id kd14-20020a056214400e00b005ef5503d41cmr13070233qvb.15.1681712424104; Sun, 16 Apr 2023 23:20:24 -0700 (PDT) X-Google-Smtp-Source: AKy350YGBvzLQl8TSywlbRHoWsuwzUmdZAtbC2GsJy/SU9rWuxjFVNqOx/mP7CdWEeGgZjqG0Nm5bg== X-Received: by 2002:a05:6214:400e:b0:5ef:5503:d41c with SMTP id kd14-20020a056214400e00b005ef5503d41cmr13070223qvb.15.1681712423865; Sun, 16 Apr 2023 23:20:23 -0700 (PDT) Received: from redhat.com ([185.199.103.251]) by smtp.gmail.com with ESMTPSA id lx4-20020a0562145f0400b005ef42af7eb7sm2870554qvb.25.2023.04.16.23.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 23:20:23 -0700 (PDT) Date: Mon, 17 Apr 2023 02:20:16 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH net] virtio-net: reject small vring sizes Message-ID: <20230417021725-mutt-send-email-mst@kernel.org> References: <20230416074607.292616-1-alvaro.karsz@solid-run.com> <20230416164453-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "davem@davemloft.net" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gTW9uLCBBcHIgMTcsIDIwMjMgYXQgMTE6MjQ6MTZBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBNb24sIEFwciAxNywgMjAyMyBhdCA0OjQ14oCvQU0gTWljaGFlbCBTLiBUc2lya2lu IDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gU3VuLCBBcHIgMTYsIDIwMjMgYXQg MDQ6NTQ6NTdQTSArMDAwMCwgQWx2YXJvIEthcnN6IHdyb3RlOgo+ID4gPiBBZnRlciBmdXJ0aGVy IGNvbnNpZGVyYXRpb24sIG90aGVyIHZpcnRpbyBkcml2ZXJzIG5lZWQgYSBtaW5pbXVtIGxpbWl0 IHRvIHRoZSB2cmluZyBzaXplIHRvby4KPiA+ID4KPiA+ID4gTWF5YmUgdGhpcyBjYW4gYmUgbW9y ZSBnZW5lcmFsLCBmb3IgZXhhbXBsZSBhIG5ldyB2aXJ0aW9fZHJpdmVyIGNhbGxiYWNrIHRoYXQg aXMgY2FsbGVkIChpZiBpbXBsZW1lbnRlZCkgZHVyaW5nIHZpcnRpb19kZXZfcHJvYmUsIGJlZm9y ZSBkcnYtPnByb2JlLgo+ID4gPgo+ID4gPiBXaGF0IGRvIHlvdSB0aGluaz8KPiA+ID4KPiA+ID4g VGhhbmtzLAo+ID4gPiBBbHZhcm8KPiA+Cj4gPiBMZXQncyBzdGFydCB3aXRoIHdoYXQgeW91IGRp ZCBoZXJlLCB3aGVuIG1vcmUgdGhhbiAyIGRyaXZlcnMgZG8gaXQgd2UnbGwKPiA+IG1vdmUgaXQg dG8gY29yZS4KPiAKPiBJIHdvbmRlciBob3cgaGFyZCBpdCBpcyB0byBsZXQgdmlydGlvIHN1cHBv cnQgc21hbGwgdnJpbmcgc2l6ZT8KPiAKPiBUaGFua3MKCkFjdHVhbGx5LCBJIHRoaW5rIHRoYXQg YWxsIHlvdSBuZWVkIHRvIGRvIGlzIGRpc2FibGUgTkVUSUZfRl9TRywKYW5kIHRoaW5ncyB3aWxs IHdvcmssIG5vPwpBbHZhcm8sIGNhbiB5b3UgdHJ5PwoKCj4gPgo+ID4gLS0KPiA+IE1TVAo+ID4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxp emF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9u Lm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92 aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65561C77B72 for ; Mon, 17 Apr 2023 06:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjDQGVR (ORCPT ); Mon, 17 Apr 2023 02:21:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjDQGVO (ORCPT ); Mon, 17 Apr 2023 02:21:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D1153A80 for ; Sun, 16 Apr 2023 23:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681712425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePbMyRA1sPZRgCUtm4jF6vrpMcXUEcAn5cv4sWSGRdg=; b=HU61dzEjIQnANKsvWxGQlo6ir/zpRY2bcJxc5TTk24/IpWiksNa113SzycV01+hfS4ssai QBbqmqiLwkDrXXK3xJRYFR4zO/Bg29b1HU/R8uf48F3yzEVXDlrgvfi3bpPZTALxFcJw6R RLd8m8OIN4zZLvx3fz+TamlNoRx+1AM= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-iCkF-W6MMFWl72Npizquzw-1; Mon, 17 Apr 2023 02:20:24 -0400 X-MC-Unique: iCkF-W6MMFWl72Npizquzw-1 Received: by mail-qt1-f200.google.com with SMTP id e8-20020a05622a110800b003e4e915a164so12917853qty.4 for ; Sun, 16 Apr 2023 23:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681712424; x=1684304424; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePbMyRA1sPZRgCUtm4jF6vrpMcXUEcAn5cv4sWSGRdg=; b=hEbOM2ZjpA0yBKMVAv9ekfhzRR1QtifdG6wD7/2slVGFbHRLWLzknatX2dV4lmpqgE fG7IwcQhF28fd0Yd8GMHsKghm779Zi4nJTifG2kWT2GZCEFoBB69IFEktTdaZpyfuGDX WB8arWrEQj0m892GOPKOuY3PbXPLEeeDKY5g3TYW0+/Ft9BvgijI1sQmFsJcfwoKvzC8 KkBTP3cy/NdCO5OK3lkU/E4mT0Nghn2cRzEa/R0j5YkJdsONisQPrtor/enBTLD4Y+Iz qXedHNZpkCv8G6QsKlFj3sIC3P9Ju141tpPQOreTHR/pho7PBmqPctFV4AmoB6Dv0OPv j5IQ== X-Gm-Message-State: AAQBX9d+1dSi5U5/7IVX6QMKzi1tTDp9oA8gmQ9/+Pw5Tf57JkTP9GmJ yY9yfi89GLFc2M7oOIxH++Zd/DtaSSORvhC3d77dTXmro1Y/YaKCbeRqMrx/FPDbaJPPoQFO5U3 +8vS+Rnei5PssjhLmAcdNSp4u X-Received: by 2002:a05:6214:400e:b0:5ef:5503:d41c with SMTP id kd14-20020a056214400e00b005ef5503d41cmr13070238qvb.15.1681712424105; Sun, 16 Apr 2023 23:20:24 -0700 (PDT) X-Google-Smtp-Source: AKy350YGBvzLQl8TSywlbRHoWsuwzUmdZAtbC2GsJy/SU9rWuxjFVNqOx/mP7CdWEeGgZjqG0Nm5bg== X-Received: by 2002:a05:6214:400e:b0:5ef:5503:d41c with SMTP id kd14-20020a056214400e00b005ef5503d41cmr13070223qvb.15.1681712423865; Sun, 16 Apr 2023 23:20:23 -0700 (PDT) Received: from redhat.com ([185.199.103.251]) by smtp.gmail.com with ESMTPSA id lx4-20020a0562145f0400b005ef42af7eb7sm2870554qvb.25.2023.04.16.23.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 23:20:23 -0700 (PDT) Date: Mon, 17 Apr 2023 02:20:16 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Alvaro Karsz , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net] virtio-net: reject small vring sizes Message-ID: <20230417021725-mutt-send-email-mst@kernel.org> References: <20230416074607.292616-1-alvaro.karsz@solid-run.com> <20230416164453-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 11:24:16AM +0800, Jason Wang wrote: > On Mon, Apr 17, 2023 at 4:45 AM Michael S. Tsirkin wrote: > > > > On Sun, Apr 16, 2023 at 04:54:57PM +0000, Alvaro Karsz wrote: > > > After further consideration, other virtio drivers need a minimum limit to the vring size too. > > > > > > Maybe this can be more general, for example a new virtio_driver callback that is called (if implemented) during virtio_dev_probe, before drv->probe. > > > > > > What do you think? > > > > > > Thanks, > > > Alvaro > > > > Let's start with what you did here, when more than 2 drivers do it we'll > > move it to core. > > I wonder how hard it is to let virtio support small vring size? > > Thanks Actually, I think that all you need to do is disable NETIF_F_SG, and things will work, no? Alvaro, can you try? > > > > -- > > MST > >